Rex Zhang

This commit **migrates** the `f14_intrinsics_availability` build target in `folly/container/detail/BUCK` to utilize the modern `fb_dirsync_cpp_library` macro. This **build system refactoring** involved updating `select()` keys for proper cross-cell resolution and modifying the `_cpp_library_wrapper` to correctly absorb `exported_preprocessor_flags`. The change ensures that `folly/container/detail/BUCK` is now **fully migrated**, eliminating all remaining legacy build loads and streamlining the build configuration for `folly`'s container components.

This commit **refactors** the build configuration within `folly/detail/BUCK` by **migrating** the remaining six dual build targets to exclusively use the `fb_dirsync_cpp_library` rule. This completes the **full migration** of the `detail/BUCK` file, eliminating legacy `fbcode_target`/`non_fbcode_target` patterns and associated load statements. The change ensures that specific build attributes like `compiler_flags`, `undefined_symbols`, and `force_static` are correctly preserved or absorbed by the new unified macro, maintaining functional equivalence while streamlining the **build system**.

This commit **refactors the build configuration** for **six targets within the `folly/debugging/exception_tracer` module**. It migrates `compatibility`, `exception_tracer_base`, `stacktrace`, `smart_exception_tracer_singleton`, `smart_exception_stack_trace_hooks`, and `exception_tracer` from separate `non_fbcode_target` and `fbcode_target` definitions to a unified `fb_dirsync_cpp_library` target. This **build system migration** simplifies the `BUCK` file by consolidating dual-cell targets into a single, synchronized definition, improving maintainability for these core exception tracing components. The remaining three targets in the module will be addressed separately due to their unique structural differences.

This commit performs a **build system refactoring** by converting the `folly/detail/traponavx512` target from a dual `non_fbcode_target`/`fbcode_target` setup to a unified `fb_dirsync_cpp_library` configuration. This **maintenance** effort unifies the compiler flag approach for AVX512 enablement within `traponavx512`, adopting a platform-agnostic `ovr_config//cpu:x86_64` selection that works consistently across both xplat and fbcode build environments. It also streamlines the build by removing redundant clang warning flags, which are now managed by a per-directory system in fbcode, and replaces a specific toolchain constraint with a more general CPU constraint. This change simplifies the **build configuration** for `folly/detail` and ensures robust and consistent compilation for this **performance-critical component**.

This commit performs a **build system refactoring** by converting the `malloc`, `jemalloc_huge_page_allocator`, and `jemalloc_nodump_allocator` targets within `folly/memory/BUCK` to utilize the `fb_dirsync_cpp_library` build rule. This **maintenance** effort updates their `compiler_flags` and dependency declarations, including `cxx_exported_deps` and `fbandroid_exported_deps`, to ensure proper cross-platform (`xplat`) and platform-specific dependency handling. The change streamlines the build definitions for these **memory allocator components**, aligning them with the new build system paradigm without altering their runtime functionality.

This commit **refactors** the build configuration for the **`folly/concurrency`** module by converting the `deadlock_detector` and `cache_locality` libraries to use the standardized `fb_dirsync_cpp_library` macro. This **build system migration** fully completes the transition of `folly/concurrency/BUCK`, eliminating all legacy build target definitions and load statements. Notably, `cache_locality` is the first target to leverage the new macro's ability to absorb `cxx_deps` and `fbandroid_deps`, streamlining dependency management. This change simplifies the build process and ensures consistency across the project.

This commit **fixes a critical build error** in **C++20 modular builds** affecting the **`folly/logging`** module. It restores the `export_header_unit = "preload"` attribute in `folly/logging/BUCK`, which was inadvertently removed and is essential for correctness. Without this attribute, the `ERROR` severity macro from `glog` was not correctly exposed through `folly`'s headers, leading to 'use of undeclared identifier ERROR' during modular compilation. This **bug fix** ensures **correctness** and allows `folly/logging` to be used properly in C++20 modular environments, preventing compilation failures for downstream users.

This commit **migrates** the **core logging library** located at `folly/logging` to utilize the `fb_dirsync_cpp_library` build target. This **build system refactoring** consolidates its definition, ensuring consistent configuration by carrying over essential flags like `force_static` and `FOLLY_XLOG_SUPPORT_BUCK2`. It also **corrects dependencies** by incorporating `//folly/portability:fcntl` and removes all legacy build definitions, streamlining the **build process** for the `folly/logging` module. This change improves the **maintainability** and **cross-platform compatibility** of the logging infrastructure.

This commit **refactors** the build definitions for the **`folly/cli/program_options`** and **`folly/testing/test_util`** libraries. It **migrates** these targets to use `fb_dirsync_cpp_library`, consolidating their build rules and dependency management within the build system. This **maintenance** change resolves previous blocking issues related to `fbandroid_deps` and platform-specific attributes, streamlining the build process for these core `folly` components. The migration ensures consistent dependency handling, including `apple_sdks`, `platforms`, and `external_deps`, improving overall build system maintainability and consistency.

This commit **refactors** the build system by converting four C++ library targets within the `folly` project to utilize the unified `fb_dirsync_cpp_library` macro. Specifically, the **`concurrency/deadlock_detector`**, **`experimental/observer/detail/observer_manager`**, **`json/bser/bser`**, and **`container/detail/f14_mask`** build targets are updated. This **build system refactoring** standardizes library definitions, ensuring that platform-specific attributes like `apple_sdks` and `fbandroid_exported_preprocessor_flags` are correctly carried over. The change removes legacy non-unified target definitions and cleans up unused build file loads, significantly improving **build system consistency and maintainability** across these modules.

This commit **refactors** the **Folly build system** by migrating three critical test and benchmark targets to use the standardized `fb_dirsync_cpp_unittest` and `fb_dirsync_cpp_benchmark` macros. Specifically, the `folly/io/async/fdsock/test/async_fd_socket_test` and `folly/system/arch/test/x86_test` targets are converted to unittest macros, while `folly/stats/test/tdigest_benchmark` is converted to a benchmark macro. This **build system maintenance** ensures consistent target definitions across different build environments, preserving essential metadata like contacts, emails, labels, and platforms. The change also includes cleanup of unused `BUCK` file loads, improving build file clarity without altering the functional behavior of the tests or benchmarks.

This commit performs a **build system refactoring** within the **`folly/portability`** module by converting four `non_fbcode_target` definitions to `fb_dirsync_cpp_library` in `folly/portability/BUCK`. Specifically, it updates the `openssl`, `source_location`, `sys_types`, and `windows` targets to align with the new build paradigm. The changes include adjusting compiler flags to suppress specific warnings on Clang and macOS, setting `apple_sdks` for `sys_types`, and correctly specifying external dependencies like `ws2_32.lib` for Windows. This migration ensures better consistency and maintainability of the build configuration across different platforms while handling platform-specific compiler and dependency requirements.

This commit **refactors** the build definitions for four targets within the **`folly/portability`** library: `sys_resource`, `unistd`, `config`, and `stdlib`. It **migrates** these targets from `non_fbcode_target` to `fb_dirsync_cpp_library`, streamlining their build configuration. The changes involve adjusting redundant dependencies, handling conditional sources, and ensuring proper preprocessor flags are applied for cross-platform compatibility, particularly for Windows builds. This **build system migration** improves consistency and maintainability for Folly's portability layers, ensuring correct compilation and dependency resolution.

This commit **refactors** the build configuration for **8 test targets** within the `folly/io/async` module by converting them from `non_fbcode_target` to `fb_dirsync_cpp_unittest` in `folly/io/async/test/BUCK`. This **build system migration** ensures consistency with `fb_dirsync` standards, preserving critical oncall information and correctly mapping external dependencies like `glibc` for `async_socket_test`. The change streamlines the build process for these **asynchronous I/O tests**, improving maintainability and synchronization between different development environments.

This commit **refactors** the build definitions for three targets within the **`folly/io/async/test`** module: `event_base_benchmark`, `event_base_local_test`, and `event_base_test`. It migrates these targets from using xplat wrappers to directly employing `fb_dirsync_cpp_unittest` and `fb_dirsync_cpp_binary`. A key part of this **build system migration** involves updating `fb_dirsync_cpp_binary.bzl` to correctly absorb the `allocator` attribute, ensuring that `allocator = "malloc"` is preserved for these targets without leaking to underlying `cxx_binary` rules. This streamlines the build process and maintains consistent allocator configurations for these **`folly`** test and benchmark executables.

This commit performs a **build system refactoring** by converting 11 specific targets within the **`folly/portability`** module from a non-FBCode build type to `fb_dirsync_cpp_library`. This change primarily affects targets like `builtins`, `sockets`, `string`, and various `sys_` components, ensuring their build configurations are aligned with the internal FBCode system. The existing `compiler_flags = ["-fno-omit-frame-pointer"]` are preserved, and `exported_external_deps` for `sys_mman` and `time` are correctly migrated. This migration streamlines the build process for these **cross-platform portability components** within the unified build environment.

This commit **migrates 8 test targets** within the **`folly/io/async/test`** module from the `folly_xplat_cxx_test` build rule to `fb_dirsync_cpp_unittest`. This **maintenance** effort updates the build system definitions for tests such as `async_timeout_test`, `async_udp_socket_test`, and `hhwheel_timer_test`. The change ensures that source files, dependencies, and metadata are correctly configured under the new rule, preserving critical oncall information (emails and contacts) by adjusting how these attributes are absorbed by the build macros. This refactoring streamlines the build process for these asynchronous I/O tests by aligning them with the `fb_dirsync` system, improving consistency across different build environments.

This commit **refactors** the build system for several **Folly concurrency components**, migrating three dual-defined targets to a unified `fb_dirsync_cpp_library` definition. Specifically, the build configurations for `folly/concurrency/concurrent_hash_map`, `folly/concurrency/memory/read_mostly_shared_ptr`, and `folly/concurrency/memory/tl_ref_count` are updated. This **maintenance** work streamlines the build process by consolidating `folly_xplat_library` and `cpp_library` targets, ensuring consistent handling of compiler flags such as `-fno-omit-frame-pointer`. The change completes the conversion of `folly/concurrency/memory/BUCK`, simplifying its overall build structure.

This commit performs a **build system refactoring** by migrating several Folly C++ library targets to use the `fb_dirsync_cpp_library` rule. Specifically, the `global_executor` target within **`folly/executors`**, the `base` target in **`folly/gen`**, and the `observer_manager` and `graph_cycle_detector` targets in **`folly/observer/detail`** are updated. This change **simplifies the build configuration** for these Folly components by removing old dual-target definitions, fully converting `observer/detail/BUCK` and `gen/BUCK` to the new standard. Existing build properties, such as `force_static = False` and `apple_sdks = DEFAULT_APPLE_SDKS`, are preserved during this conversion.

This commit **refactors** the build definition for the `f14_hash` component in `folly/container/BUCK`. It converts `f14_hash` from a dual `fbcode_target`/`non_fbcode_target` setup to a unified **`fb_dirsync_cpp_library`** rule. This **build system improvement** ensures that **Android-specific preprocessor flags** (`fbandroid_exported_preprocessor_flags`) are correctly intercepted within the `fbcode` cell. By preventing these flags from leaking to the generic `cpp_library`, the change guarantees consistent and correct build behavior for `f14_hash` across different environments.