xusd320

This commit implements a significant **performance optimization** by introducing **zero-copy `Buffer` transfer** from Node.js to Rust within the **Turbopack Node.js worker pool**. It leverages `bytes::Bytes::from_owner` to directly wrap `napi::Buffer` instances, eliminating the `Buffer` to `Vec<u8>` memcpy on the JS→Rust path. This involves **refactoring** the `Operation` trait and associated data transfer mechanisms across the `turbopack-node` crate to consistently use `bytes::Bytes` for both sending and receiving. The primary impact is a **reduction in memory consumption** and improved efficiency, as data returned by the loader no longer incurs temporary memory doubling.

This commit provides a **bug fix** for the **Turbopack NAPI bindings** by ensuring that `ThreadsafeFunction`s created within `NapiNextTurbopackCallbacks::from_js` are properly unreferenced. Previously, these functions would keep the Node.js event loop alive indefinitely, preventing the process from exiting after a Turbopack build completed. By calling `unref()` on `throw_turbopack_internal_error` and `on_before_deferred_entries`, this change resolves a potential **Node.js process hang** issue, particularly when Turbopack is not run within a worker thread. This improves the robustness of the **Turbopack shutdown mechanism** and prevents indefinite hangs in scenarios like child processes or direct main process execution.

This commit introduces a significant **refactoring** within the **`turbopack-node`** module, transitioning the execution of **webpack loaders** from Node.js `child_process` to more efficient `worker_threads`. This change involves implementing a new **`WorkerThreadPool`** and adapting the evaluation logic to leverage `napi` for inter-thread communication, aiming to improve performance and resource utilization. While `worker_threads` are now the default, the previous `child_process` (`process_pool`) mechanism is retained as a configurable feature for specific use cases like `turbopack-cli` and `turbopack-tests`. A notable downstream impact is that debugging with Chrome DevTools Protocol (CDP) for these loader executions will no longer function, requiring developers to use IDE-based breakpoint debugging instead.

This commit delivers a **performance optimization** for **Turbopack's core resolver**, specifically enhancing its plugin handling mechanisms. It **refactors** the `turbopack-core/src/resolve/mod.rs` module by introducing techniques such as pre-fetching options, implementing early exit conditions, and pre-resolving plugin conditions. These changes primarily affect the `handle_before_resolve_plugins` and `handle_after_resolve_plugins` functions, making their execution more efficient. The overall impact is **faster module resolution** within Turbopack, contributing to improved build performance.

This commit **refactors Turbopack's resolution plugin conditions** by introducing `Always` and `Never` enum variants to `AfterResolvePluginCondition` and `BeforeResolvePluginCondition`. This **new capability** allows plugins, such as the `ExternalsPlugin`, to explicitly declare if they always or never match a condition, thereby **optimizing performance** by entirely skipping expensive `matches()` task calls. The change primarily affects the **`turbopack-core` resolution system** and its integration within `next-core`, leading to a notable reduction in `resolve_call` tasks and overall improved resolution efficiency.

This commit introduces a **new feature** to the **`turbo-tasks-fs`** crate, enabling the `DiskFileSystem` to support **multiple denied paths** instead of a single one. This is achieved by **refactoring** the `DiskFileSystem`'s internal `denied_path` field into a vector and updating methods like `is_path_denied` and `read_dir` to handle the collection. The **`next-api`** and **`turbopack-cli`** modules are updated to utilize the new `DiskFileSystem::new_with_denied_paths` API. This enhancement is crucial for **reducing redundant task invalidation** within `Turbopack`, leading to improved performance and more efficient file system operations.

This commit **refactors the memory allocator dependency** within the **`turbo-tasks-malloc` crate** of **Turbopack**. It replaces the `mimalloc-rspack` wrapper with the official `mimalloc` library, as `mimalloc` now natively supports the `v3` features previously requiring the `rspack` fork. This **maintenance chore** involves updating the `Cargo.toml` to remove the intermediary dependencies and modifying allocator calls in `src/lib.rs` from `mimalloc_rspack::MiMalloc` to `mimalloc::MiMalloc`. The change streamlines the dependency management for memory allocation, ensuring `turbo-tasks-malloc` leverages the direct and latest `mimalloc` features.

This commit performs a **refactoring** within the **`turbo-tasks-fs`** crate, specifically targeting the `FileSystemPath` type. It modifies the `to_string` method to delegate its implementation to the existing `value_to_string` function. This change eliminates duplicated string formatting logic, thereby improving code maintainability and reducing redundancy within the file system abstraction layer. The work is a **maintenance** task that cleans up internal implementation without altering external behavior or functionality.

This commit performs a **maintenance cleanup** within the **`turbopack-node` crate**, specifically targeting **outdated and unused code**. It removes the `get_renderer_pool_operation` and `get_intermediate_asset` functions, along with the `ResponseHeaders` struct, from the main `lib.rs` file. Additionally, the `trace_stack` and `trace_stack_with_source_mapping_assets` functions are removed from the `source_map` module. This **refactoring** reduces the overall codebase complexity and improves maintainability of the `turbopack-node` module without affecting its current functionality.

This commit **updates the `twox-hash` dependency** across the **Turbopack workspace**, specifically in `turbo-tasks-hash` and `turbo-persistence`, to consolidate its version and improve consistency. The **`turbo-tasks-hash` crate** undergoes a **refactoring** where its `Xxh3Hash64Hasher` now directly utilizes `twox_hash::XxHash3_64` for its internal hashing logic, and an unused 128-bit hash function is removed. This **dependency update and refactoring** of the core hashing mechanism directly impacts **asset hashing**, leading to changes in generated URLs for images and CSS. Consequently, several **end-to-end and integration test snapshots** related to `next-image` and basic global CSS support have been updated to reflect these new asset hashes.

This commit introduces a **significant enhancement** to **Turbopack's compile-time define mechanism**, allowing it to support a wider range of data types and expression evaluation. The `CompileTimeDefineValue` enum in `turbopack-core` is extended to include `Null`, `Number`, `Array`, `Object`, and `Evaluate` variants, enabling more complex compile-time configurations. This **new capability** impacts the `next-core` parsing logic and the `turbopack-ecmascript` analyzer and constant value reference modules, which now convert these advanced define values into SWC expressions for evaluation. Specifically, `define_env_to_expr` and `eval_single_expr_lit` functions are added to handle the conversion and evaluation of these new types. As a result, developers can leverage richer static analysis and optimization by defining more sophisticated environment variables or constants during the build process.

This commit performs a **refactoring** within the **TurboTasks filesystem (turbo-tasks-fs)** crate, changing the `to_sys_path` method from an asynchronous to a **synchronous operation**. This update simplifies calls to `to_sys_path` by eliminating the need for `await` in consuming modules such as `napi/src/next_api/project.rs` and `turbopack/crates/turbo-tasks-fs/src/util.rs`. The change streamlines **filesystem path resolution** logic, reducing complexity and potentially improving performance for core TurboTasks operations that rely on this utility.

This commit introduces a **performance optimization** within the **Turbopack** engine, specifically targeting the `next-core` crate's import mapping logic. It **refactors** the `insert_alias_option` and `export_value_to_import_mapping` functions in `crates/next-core/src/next_import_map.rs`. By passing `project_path` by reference instead of by value, the change avoids unnecessary cloning, performing a clone only when explicitly required. This enhancement aims to reduce memory allocations and CPU overhead, leading to more efficient processing of import aliases within Turbopack builds.

This commit performs a comprehensive **typo correction and refactoring** across numerous Rust crates within the Next.js and Turbopack ecosystems. It addresses misspellings in comments, renames variables like `strat` to `strategy` and `indicies` to `indices`, and updates enum variants such as `Unparseable` to `Unparsable` for improved clarity and consistency. The work spans **Next.js core components**, **NAPI bindings**, **build testing utilities**, and a wide array of **Turbopack modules**, including `turbo-persistence`, `turbo-tasks-backend`, `turbopack-core`, `turbopack-css`, and `turbopack-ecmascript`. This **maintenance effort** also introduces a new `.typos.toml` configuration file, establishing a linter to prevent future typographical errors and enhance overall code quality.

This commit performs a **refactoring** to remove the deprecated `lazy_static` dependency across the **Turbopack** and **Next.js** ecosystems. It systematically replaces all instances of `lazy_static!` macros with the standard library's `std::sync::LazyLock` for lazy initialization of static variables. This change primarily impacts **Turbopack's core resolution**, **ECMAScript analysis**, and **Node.js native binding resolution**, as well as **Next.js core resolution logic** and **custom transforms**. The **maintenance** effort modernizes the codebase by leveraging a standard library feature, thereby reducing external dependencies. This internal improvement enhances maintainability and aligns with current Rust best practices, with no expected functional changes.

This commit **fixes a bug** in **Turbopack's CSS processing pipeline** where the **original sourcemap of style files was lost** after transformations. Specifically, the `turbopack-css` crate now correctly **extends the sourcemap generated by `lightningcss` with the original sourcemap** from the asset's source within the `finalize_css` and `to_css` functions. This ensures that debugging tools can accurately map transformed CSS back to its **initial source files (e.g., SASS/SCSS)**, significantly improving the debugging experience for styles. End-to-end tests were updated to reflect the correct sourcemap content.

This commit introduces a **fix** to the display formatting within **Turbopack's core `AssetIdent`** module. It ensures that a question mark (`?`) is prepended to the query string when an `AssetIdent` is formatted for display, specifically within the `fmt` implementation in `turbopack/crates/turbopack-core/src/ident.rs`. This change makes the displayed identifiers accurately resemble standard URL query parameters. This **fix** improves the consistency and readability of `AssetIdent` output, particularly in debugging and logging scenarios within the **Turbopack core**.