Vitali Zaidman

This commit **improves error reporting** within the **Buck worker runner** by including the specific worker's arguments in failure messages. Previously, only `stderr` was displayed, making it difficult to identify which worker had failed, hindering debugging efforts. This **enhancement to developer experience** within the `prelude/js/worker_runner/worker_tool_runner.py` module, specifically around the `_receive_command_reply` function, provides crucial context for **debugging worker failures**. The change directly addresses a pain point in diagnosing issues, making the **Buck build system more robust and easier to maintain**.

This commit introduces a **new asynchronous capability** for **iOS bundle URL provisioning** by adding `isPackagerRunningAsync` to `RCTBundleURLProvider`. This **enhancement** allows the application to check if the React Native packager (DevServer) is running without blocking the UI thread, addressing previous issues where network delays caused unresponsiveness. The change significantly improves the **user experience** on iOS by ensuring the UI remains fluid during packager status checks. Additionally, a null check was incorporated into the existing synchronous `isPackagerRunning` method for improved robustness.

This commit introduces a **defensive URL validation check** within the **`RCTWebSocketModule`** to prevent application crashes. It **fixes a bug** where providing an invalid or nil URL to the WebSocket connection method could lead to XPC serialization failures deep in the network stack. By validating the URL before attempting to connect, this change ensures the **WebSocket module** handles malformed input gracefully, significantly improving the stability of network communication in **React Native**.

This commit introduces **defensive validation checks** within the **WebSocket module** to prevent crashes. Specifically, it ensures that custom header keys are valid `NSString` instances and that header values can be successfully converted before being processed by the native `RCTWebSocketModule.mm`. This **bug fix** addresses potential runtime errors when invalid or malformed header data is passed from JavaScript during WebSocket connection attempts, significantly improving the **stability and robustness** of the WebSocket client.

This commit introduces a **defensive null check** within the **WebSocket module** (`RCTWebSocketModule.mm`) to enhance application stability. It specifically validates the `NSURLComponents` and its `URL` property before attempting to load cookies for a WebSocket connection. This **bug fix** prevents potential crashes in the **network stack** by ensuring that `cookiesForURL` is never called with an invalid or `nil` URL, which could occur if `NSURLComponents` fails to parse a malformed URL. The change improves the **robustness** of WebSocket connections by safeguarding against invalid URL inputs.

This commit **fixes a critical crash** in the **iOS bundle loading mechanism** by introducing robust timeout handling for Dev Server connectivity checks. Previously, applications could crash due to prolonged semaphore waits when the Dev Server was unreachable or experiencing network issues during the `isPackagerRunning` method's execution. To prevent this, the `/status` request timeout has been reduced to 6 seconds, and the semaphore wait time is now capped at 8 seconds. This **stability improvement** ensures that the app gracefully handles Dev Server connectivity problems, preventing crashes and enhancing the developer experience on **iOS**.

This commit introduces a **new feature** that enables the **Metro bundler** to operate as an **HTTPS server**. Developers can now configure Metro using the `config.server.tls` option to serve assets over secure connections. This enhancement provides greater flexibility for development environments that require HTTPS, such as those integrating with secure APIs or more closely mimicking production setups. A test utility in `packages/dev-middleware/src/__tests__/ServerUtils.js` was updated to correctly handle asynchronous certificate generation, ensuring proper testing of this new TLS capability.

This commit **enhances** the **Android DevSupport system** by **fixing** the synchronization of **Metro bundling progress** with the in-app loading view. It introduces a new `percent` parameter across the `DevBundleDownloadListener` and `DevLoadingViewManager` interfaces, allowing the `BundleDownloader` to extract and pass precise percentage values from the Metro CLI. The `DevSupportManagerBase` now orchestrates passing this new parameter during bundle download and reload, while the `DefaultDevLoadingViewImplementation` updates its display to prioritize this accurate percentage. This **improvement** ensures developers receive more accurate and real-time feedback on bundle download progress directly within their **React Native Android applications**, enhancing the development experience.

This commit **fixes** an issue by **synchronizing bundling progress** more accurately between the Metro CLI and **iOS app hints**. It introduces a new `percent` property to the `RCTLoadingProgress` class in `RCTJavaScriptLoader.h`, allowing for direct, percentage-based reporting of the bundling status. The `RCTJavaScriptLoader.mm` implementation is updated to prioritize this new `percent` value in progress descriptions and to parse it from incoming data via `progressEventFromData`. This **enhances the user experience** by providing more consistent and real-time progress updates within **iOS applications** during development.

This commit **fixes** a limitation in the **React Native Metro dev-middleware** that previously restricted WebSocket debugger connections to only `localhost:8081` or `127.0.0.1:8081`. It **enhances** the `InspectorProxy` to correctly validate and allow debugger connections from their actual origin URL, improving flexibility for various development setups. Additionally, the system now provides user notifications within Metro when a debugger connection is rejected, offering clearer feedback. This change significantly improves the **developer experience** by making the debugger more robust and adaptable to different network configurations.

This commit **fixes a critical bug** affecting the **debugger shell** launch process on **Windows**, specifically within the `unstable_spawnDebuggerShellWithArgs` function in `packages/debugger-shell`. It addresses a Node.js issue where `detached` processes with `unref` failed to inherit `stdio` streams, preventing output from being visible. The **bug fix** manually pipes `stdout` and `stderr` to ensure proper inheritance, significantly improving the debugging experience for developers on **Windows**. This work also **relands** previous changes by incorporating additional **debug logging** and **improved error handling** for the spawned debugger shell.

This commit performs **maintenance** by **removing** a set of **unstable functions** previously introduced for **tracking the existence of connected devices**. These functions, part of a briefly exposed API, are no longer necessary as an alternative, more robust method for obtaining device connection information has been identified. This **cleanup** prevents the exposure of an unnecessary and unstable API, streamlining the **device management subsystem**. The change ensures the project relies on more stable and integrated solutions for device connectivity status.

This commit implements a **bug fix** for the **debugger shell's Node.js spawning logic**, specifically within `packages/debugger-shell/src/node/index.flow.js`. It addresses a Node.js bug on Windows where child processes launched with `detached` mode and `unref` fail to inherit stdio, preventing output from being visible. The change explicitly pipes `stdout` and `stderr` for these processes, ensuring proper output display. Additionally, it introduces **debug logging** and **improved error reporting** around child process events, enhancing the overall stability and diagnostic capabilities of the **debugger shell** on **Windows**.

This commit **refactors** the handling of the `ELECTRON_RUN_AS_NODE` environment variable within the **debugger-shell** package. Specifically, the `unstable_spawnDebuggerShellWithArgs` function now **removes** this environment variable entirely from the child process's environment, rather than merely setting it to an empty string. This **maintenance** change ensures a cleaner environment for spawned debugger processes, preventing potential misinterpretations or unintended behaviors that might arise from an empty but present `ELECTRON_RUN_AS_NODE` variable in **Electron-based debugging scenarios**. The change improves the robustness of how child processes are launched by explicitly omitting this variable when it's not needed.

This commit implements a **bug fix** for the **debugger-shell** package, specifically addressing an issue with process environment inheritance. It modifies the default spawn command for the debugger shell to explicitly **unset the `ELECTRON_RUN_AS_NODE` environment variable**. This prevents the debugger shell from incorrectly inheriting this variable from a parent Electron process, which could lead to unexpected behavior or runtime errors. The change, located in `packages/debugger-shell/src/node/index.flow.js` and affecting `unstable_spawnDebuggerShellWithArgs`, ensures the debugger operates correctly regardless of its parent process's environment.

This commit provides a **bug fix** by correcting a typo within the **Flow type definitions** for Node.js utilities. Specifically, it updates the `flow-typed/environment/node.js` file to change the incorrect `validStream` property to the accurate `validateStream` within the options for `util.styleText`. This **maintenance update** ensures proper type checking and alignment with the official Node.js API for the `validateStream` option, improving the reliability of static analysis for Node.js environments.

This commit introduces a **new capability** to the **`dev-middleware`** package, enabling external consumers to programmatically monitor the connection status of development devices. It exposes two new unstable APIs, `unstable_hasConnectedDevices` and `unstable_addHasConnectedDevicesListener`, through the `DevMiddlewareAPI` in `createDevMiddleware.js`. These methods, implemented within the `InspectorProxy` in `InspectorProxy.js`, allow checking if any devices are currently connected to the middleware and subscribing to real-time updates when this state changes. This enhancement provides greater visibility and programmatic control over the development server's device connections, facilitating more dynamic tooling and integration.

This commit **refactors** the **React Native DevTools launching mechanism** by moving default configuration parameters for the debugger shell downstream. Specifically, the `packages/debugger-shell` now defines default `flavor` and `prebuiltBinaryPath` values within its `unstable_spawnDebuggerShellWithArgs` and `unstable_prepareDebuggerShell` functions. Consequently, `packages/dev-middleware/src/utils/DefaultBrowserLauncher.js` no longer explicitly passes these common arguments, simplifying its logic and relying on the newly established defaults. This **maintenance** change centralizes debugger shell launch configurations, improving modularity and ease of future updates for the **debugger shell integration**.

This commit **fixes a critical crash** occurring in **iOS** non-debug builds when the `RCT_DEV_MENU=1` flag was enabled, specifically due to **FastRefresh** not being properly initialized. It **re-introduces and implements** the `addNotificationHandler` and `addRequestHandler` methods within the **`RCTDevSettings` module**, which were previously backed out. This change **restores the API** for registering packager event handlers, ensuring development tools can correctly integrate without causing application instability. The fix prevents unexpected application termination and improves the reliability of the **developer experience** on iOS.

This commit **enhances error reporting** for the **`AccessibilityInfo` module** in React Native. Specifically, methods like `isReduceMotionEnabled` and `isGrayscaleEnabled` will now **reject with specific `Error` objects** when their underlying native modules are unavailable, rather than returning `null` or failing silently. This **improves the developer experience** by providing more meaningful and actionable feedback, making it easier to diagnose issues related to accessibility feature availability and enhancing the overall **robustness** of the API.