Vasant Patil

This commit **adds comprehensive unit tests** for the **named next-hop group management** functionality within the `NextHopIDManager`. These new tests validate the correct behavior of `allocateNamedNextHopGroup`, `updateNamedNextHopGroup`, and `deallocateNamedNextHopGroup` operations. Furthermore, they specifically verify `namedNextHopGroupWarmBoot` behavior and the critical **ID sharing via reference counting** between routes and named groups. This **quality assurance** effort significantly improves the reliability and robustness of the **`fboss/agent/rib`** subsystem's handling of named next-hop resources.

This commit introduces **named next-hop group management** within the **`NextHopIDManager`** module, enabling the system to track and manage sets of next-hops using symbolic names. This **new capability** provides functions like `allocateNamedNextHopGroup()`, `updateNamedNextHopGroup()`, and `deallocateNamedNextHopGroup()` for lifecycle management, along with lookup methods such as `getNextHopSetIDForName()`. It ensures proper restoration of these named groups during **warm boot** by updating `reconstructFromFib()` and efficiently reuses existing `NextHopSetIDs` through reference counting. This significantly enhances the flexibility and organization of next-hop configurations by allowing named references to common next-hop sets.

This commit **enhances the `AggregatePort` configuration** by introducing a new `i32` field, `extendedKey`, to support larger Link Aggregation Group (LAG) identifiers. Previously, LAG IDs were constrained by an `i16` `key` field, which was insufficient for some use cases. The new `extendedKey` field in the `AggregatePort` struct, defined in `fboss/agent/switch_config.thrift`, provides an expanded range for LAG keys and takes precedence over the existing `i16` field when set, ensuring **backward compatibility**. This **new capability** impacts the **`AggregatePort` configuration** within the FBOSS agent and requires an update to the **FSDB data model** to include the new field.

This commit **introduces new accessor methods** to the **`FibInfo`** class, enabling comprehensive management of **named next-hop groups**. It provides functionalities to `getNextHopSetIdForName`, `setNextHopSetIdForName`, `removeNextHopSetForName`, and `resolveNextHopSetFromName`, allowing other components to interact with these named groups programmatically. This **new feature** enhances the flexibility and manageability of routing information within the `fboss/agent/state` subsystem by providing a clear interface for named next-hop set operations.

This commit **introduces the foundational Thrift schema** for **named next-hop groups**, enabling future support for clients to define, update, and query reusable next-hop sets by name. Specifically, it **modifies the `SwitchState` Thrift definition** within the **`fboss/agent`** module by adding a `nameToNextHopSetId` map field to the `FibInfoFields` struct. This **new capability** is a critical **infrastructure change**, laying the groundwork for a more flexible and manageable network forwarding information model. It represents the initial step in a larger effort to integrate named next-hop group functionality into the system.

This commit **fixes a warmboot test** by ensuring the **PHY loopback mode** is correctly preserved across warmboots. It **refactors the test setup** within `fboss/agent/test/agent_hw_tests/AgentPrbsTests.cpp` to configure the PHY loopback mode as part of the `initialConfig` for **Yuba ASICs**. This change addresses an issue where the loopback state was not maintained after a warmboot, thereby improving the reliability of **PRBS warmboot testing**. The now-unused helper function `setAllTestPortsLoopbackPhy` is also removed, streamlining the test code.

This commit performs **code cleanup** by identifying and removing header files that are no longer utilized within the project. This **maintenance** and **refactoring** effort aims to streamline the codebase by eliminating unnecessary dependencies. While functionally a no-op, this change contributes to improved compilation times and a reduced build footprint across various components.

This commit performs **maintenance** by **removing the `aoi_override` flag** from the **QSFP service**. The flag was identified as unused, making its removal a **code cleanup** effort. This change streamlines the codebase by eliminating dead code within the **QSFP module**. As the flag was not actively used, its removal has **no functional impact** on the operation or behavior of the QSFP service.

This commit **adds a new unit test** to the **SAI switch agent's FDB manager**, specifically within `fboss/agent/hw/sai/switch/tests/FdbManagerTest.cpp`. The new `getL2EntriesTest` case is designed to **verify the functionality of retrieving L2 entries** from the **Forwarding Database (FDB)**. This **enhances test coverage** for the **FDB management subsystem**, ensuring the reliability and correctness of L2 entry retrieval operations. This **maintenance improvement** helps validate a critical component of the network agent's hardware abstraction layer.

This commit **updates the `getL2Entries` function** within the **SAI FDB manager** (`SaiFdbManager.cpp`) to introduce conditional logic for L2 entry retrieval. This **feature enhancement** allows the function to semantically fetch L2 entries either directly from the SDK or from the FDB's internally managed entries. Specifically, if a new `sdk` parameter is true, entries are sourced from the SDK; otherwise, the existing managed entries are returned. This change **enhances the flexibility** of the **L2 entry retrieval mechanism**, enabling callers to explicitly choose the desired source for L2 data.

This commit **refactors** the **FBOSS agent hardware tests** by modifying how the L2 table is retrieved within test utilities. Specifically, the test utility function in `AgentMacLearningTests.cpp` now calls a **common utility method** to obtain the L2 table, centralizing this logic. This **improves test code consistency and maintainability** by leveraging a shared utility for L2 table access within the test infrastructure. The change is purely a **test refactoring** and has no impact on the production agent's functionality or behavior.

This commit introduces a new **test utility function**, `getL2Table`, within `fboss/agent/test/utils/MacTestUtils.cpp` and `MacTestUtils.h`. This function provides a standardized and abstracted mechanism for **L2 Tests** to fetch L2 entries directly from the switch, utilizing either the FBB manager or SDK instead of direct Thrift API calls. This **test utility enhancement** centralizes L2 table data retrieval, improving the maintainability and robustness of **FBOSS agent L2 testing**. It simplifies future test development by offering a consistent interface for verifying L2 table contents.

This commit introduces a **new command-line argument** to the `fboss/oss/scripts/run_scripts/run_test.py` script, allowing users to provide a `platform_mapping.json` file. This **enhances the SAI test infrastructure** by enabling the **SaiTestRunner** and **SaiAgentTestRunner** to utilize custom platform configurations during test execution. The change integrates this new argument into the test execution logic via functions like `add_subcommand_arguments` and `_get_test_run_args`. This **new capability** provides greater flexibility and configurability for running **SAI tests**, particularly when dealing with diverse hardware platforms.

This commit introduces a new boolean parameter, `sdk`, to the **L2 table fetching mechanism** across the `fboss/agent` component. This **feature enhancement** modifies the `fetchL2Table` virtual function in `HwSwitch.h` and its implementations in `BcmSwitch`, `SaiSwitch`, `SimSwitch`, and `MockHwSwitch`. The `sdk` parameter dictates whether L2 entries are read directly from the hardware SDK or from FDB-managed entries, also impacting `getL2Entries` in `SaiFdbManager`. This change provides greater control over the source of L2 data, enabling more flexible and potentially optimized retrieval strategies across various hardware platforms.

This commit performs a **platform identifier rename**, changing all internal references from `WEDGE800CA` to `WEDGE800C_ACT`. This **refactoring** ensures consistency across the **platform identification**, **SAI platform initialization**, and **Thrift definitions** within the system. Specifically, it updates the `PlatformType` enum in `fboss_common.thrift`, string representations in `PlatformMode.h`, and platform type initializations in `PlatformMappingUtils.cpp`, `SaiPlatform.cpp`, and `SaiPlatformInit.cpp`. The change aligns the internal platform naming with external documentation, impacting how the system recognizes and configures the `WEDGE800C_ACT` hardware platform.

This commit **enhances hardware tests** by addressing a specific prerequisite for configuring **Port Random Bit Sequence (PRBS)**. It introduces a helper function within `AgentPrbsTests.cpp` to place test ports into **PHY loopback mode**, a necessary step on **YUBA ASICs** before setting the `SAI_PORT_ATTR_PRBS_CONFIG` attribute. This **maintenance and test enhancement** ensures the reliability of PRBS enable/disable tests by correctly handling ASIC-specific configuration requirements, preventing potential test failures.

This commit performs a **refactoring** and **maintenance** task by **removing unused header includes** from the `fboss/agent/NeighborUpdater.cpp` file. Specifically, it cleans up the implementation of the **NeighborUpdater** component by eliminating unnecessary dependencies. This change improves code hygiene, potentially reduces compilation times, and enhances the clarity of the `NeighborUpdater` module without introducing any functional modifications or behavioral changes to the system.

This commit **improves observability** within the **SAI switch agent** by adding a crucial log message to aid in **debugging FDB learn notifications**. Specifically, it now logs when **FDB learn notifications** are ignored because the `l2LearningMode` is not `SOFTWARE`, which is vital for diagnosing issues in mixed hardware/software L2 learning mode environments. This **maintenance** change, affecting `fdbEventCallback` and `fdbEventCallbackLockedBottomHalf` in `SaiSwitch.cpp`, helps engineers understand why certain FDB events are not processed. It also includes a minor adjustment to existing FDB event log levels.

This commit **improves the reliability of L3 stats testing** by modifying the `AgentHwResourceStatsTests.cpp` file. Specifically, the test now adds **10 IPv6 prefixes** instead of just one when verifying hardware resource usage. This change addresses a nuance in how **LPM (Longest Prefix Match)** algorithms on certain ASICs calculate available hardware entries, ensuring that the test accurately reflects the decrement in resource statistics. This **test improvement** guarantees that hardware resource usage stats are reliably updated and reported, providing more accurate insights into ASIC capacity.

This commit provides a **bug fix** to prevent **FBOSS agent crashes** on **SSWs** related to **IPv6 multicast neighbor solicitation**. It addresses a regression by reintroducing a previously reverted change, ensuring the `MultiSwitchInterfaceMap` is not prematurely destroyed during `stateUpdate`. The fix involves storing a shared pointer to the map within `fboss/agent/IPv6Handler.cpp`, specifically in the `sendMulticastNeighborSolicitation` function, to prevent dangling interface pointers. This change significantly improves the **agent's stability** in multi-switch environments by correctly managing interface lifetimes.