Travis Brown

This commit **enhances** the **PXE boot** process by increasing the statically-sized btrfs image for the installer. Specifically, it **updates** the `config.xml` for **CentOS 09.0** to expand the disk image size from 16GB to 64GB. This **feature enhancement** is crucial for supporting larger **Distro Images**, enabling the inclusion of **debug FBOSS binaries** during image construction. The change prevents `ESPACE` errors that previously occurred when building the PXE installer with more extensive content.

This commit **enables btrfs boot support** for **CentOS distro images** by activating the `editbootinstall.sh` script within the image configuration file `fboss-image/image_builder/templates/centos-09.0/config.xml`. This **enhancement** modifies the upstream Grub installer, allowing systems to **boot directly from btrfs partitions** without requiring a separate non-btrfs `/boot` partition. The change primarily affects the **distro image generation process** and the resulting **boot functionality**, providing greater flexibility for btrfs filesystem users.

This commit introduces a **performance optimization** to the **kernel build process** within `fboss-image`. It modifies the `build_kernel.sh` script to implement a conditional check, preventing the redundant re-downloading of vanilla kernel sources if they already exist locally. This change significantly **improves build times** for subsequent image rebuilds by leveraging the immutability of the kernel source content. The primary impact is faster development cycles and more efficient CI/CD pipelines, as the system avoids unnecessary network operations.

This commit **enhances UART console compatibility** for FBOSS systems, particularly those without legacy UARTs like Minipack3. It **modifies the kernel boot configuration** within `fboss-image/image_builder/templates/centos-09.0/config.xml` to consistently assign the console to `ttyS0`. By adding `8250.nr_uarts=1` to the kernel command line, it disables the legacy UART reservation, ensuring `ttyS0` is always the first available UART. This **resolves an incompatibility** where the console might otherwise be assigned to `ttyS4`, providing a unified and reliable console experience across diverse hardware platforms.

This commit **introduces a default `netops` user** for **FBOSS Distro systems**, specifically impacting the **CentOS image build process**. This **new capability** aims to **enhance security and usability** by providing a non-root user with passwordless sudo access, thereby avoiding common friction points and reducing the blast radius associated with direct root user operations. The changes involve modifying the `fboss-image/image_builder/templates/centos-09.0/config.xml` to add the user and updating the `fboss-image/image_builder/templates/centos-09.0/root_files/etc/sudoers.d/passwordless_wheel` configuration to grant necessary privileges. This establishes a safer and more convenient default environment for **FBOSS deployments**.

This commit **enhances the CentOS distribution image** by **adding three essential system packages** to its build configuration. Specifically, `epel-release` is included for a wider package universe, `ipmitool` for BMC access and testing scenarios, and `git` to support the `fboss2-dev` config CLI's new backend. This **maintenance** update ensures the **Distro Image** provides necessary tools out-of-the-box, improving its utility for development and testing environments. The change primarily affects the `fboss-image/image_builder/templates/centos-09.0/config.xml` file, impacting all future CentOS image builds.

This commit **refactors** the **Distro image** to transition from the monolithic `wedge_agent` to a split agent architecture, utilizing `fboss_sw_agent` and multiple `fboss_hw_agent` instances. This **architectural change** enables support for multi-ASIC platforms by introducing new **systemd service units** for `fboss_sw_agent` and templated `fboss_hw_agent`s, grouped under `fboss_hw_agents.target`. A new `num_hw_agents` configuration file is added to statically define the number of hardware agents to be started, ensuring proper detection and management of ASICs. This work lays the groundwork for deprecating the mono-mode agent and improving the modularity and scalability of the FBOSS agent deployment.

This commit **removes** the deprecated script `image_builder/bin/build_image.sh` from the **FBOSS image building process**. This script was development scaffolding and is no longer necessary as the `fboss-image build` command now handles image creation. This **maintenance** change streamlines the build workflow, requiring users to utilize a manifest file with new component names like `fboss-platform-stack` and `fboss-forwarding-stack` instead of the old 'FBOSS tarball' concept. This **cleanup** simplifies the `image_builder` component by removing redundant tooling.

This commit addresses minor **code style issues** across the **Distro Image builder** and **OSS packaging scripts**, primarily driven by an expanded Python `ruff` scope. It corrects indentation within the `fboss-image/image_builder/templates/onie` directory for `default_platform.conf` and `install.sh.tmpl`, ensuring consistent formatting for ONIE-related configurations. Additionally, the commit **modernizes Python type hints** in `fboss/oss/scripts/package.py`, updating `typing.Dict` and `typing.List` to their built-in equivalents in functions like `write_tar` and `package_fboss`. This **maintenance** work is entirely non-functional, enhancing code readability and adherence to current linting standards without altering any system behavior.

This commit **fixes a critical issue** in the **`distro_infra`** module's **iPXE boot process** that occurred on CPU boards with multiple network interfaces. Previously, the `autoexec.ipxe` script incorrectly assumed `net0` was always the external management port for retrieving the installer, leading to boot failures when the external port was `net1` or another `netX`. The change modifies `fboss-image/distro_infra/parts/autoexec.ipxe` to use `netX` for MAC address retrieval, which dynamically selects the last successfully opened and IP-assigned interface. This **enhances the robustness of PXE booting**, ensuring that the correct external interface is used regardless of its enumeration, and preventing boot failures on affected hardware.

This commit introduces a **new capability** to improve the accessibility and robustness of **FBOSS command-line tools**. It addresses challenges with managing the system `PATH` for commands like `fboss2` by creating wrapper scripts in `/usr/local/bin`. These wrappers, leveraging the new `fboss_cmd_find.sh` script, will dynamically locate and execute the appropriate FBOSS binary, even if its installation path changes due to updates. This **infrastructure improvement** ensures that critical **FBOSS CLI commands** are reliably available in the user's `PATH`, enhancing the **developer experience** and simplifying future component updates.

This commit introduces **support for PXE booting in environments with authoritative DHCPv6 servers**, preventing conflicts with the `Distro Infra`'s own DHCPv6 service. It adds a **new capability** via the `--nodhcpv6` argument to `distro_infra.sh`, allowing the system to disable its internal DHCPv6 server and rely on an external one for `bootfile-url` information. Furthermore, it **enhances the PXE boot flow** by removing first-stage PXE boot files (`ipxev?.efi`) after a successful boot, ensuring that subsequent reboots fall back to other options instead of re-executing the installer, which is crucial when external DHCPv6 servers persist PXE advertisements. This change primarily affects the **PXE boot and network provisioning subsystems** of the `Distro Infra`, along with its **documentation**, to facilitate seamless integration into existing IPv6 networks.

Add other_dependency RPM build example (#992)

This commit introduces a crucial **build improvement** to the **FBOSS build process** by preventing **out-of-memory (OOM) errors** during compilation. It modifies the `build_fboss_stack.sh` script to dynamically calculate and limit the number of parallel build jobs for the **platform stack** and **forwarding stack** based on available memory and CPU cores. This **maintenance** change ensures that memory-intensive compilation and linking tasks, which can require significant RAM, do not exhaust system resources. The primary impact is improved build reliability, especially for large components, preventing build failures in resource-constrained environments like Distro.

This commit provides crucial **build fixes** for the **Distro Image** by resolving issues related to the clang migration and proper SAI API integration. It modifies `fboss/oss/scripts/build_fboss_stack.sh` to include additional CMake definitions required for clang and ensures that `sai_build.env` values are correctly exported for the `getdeps` invocation. This **maintenance** work prevents the FBOSS build from defaulting to an incorrect SAI API version, thereby eliminating mismatched SAI API enum values and avoiding confusing runtime crash errors. The changes ensure the **Distro Image build process** correctly utilizes the specified SAI library version.

This commit **significantly enhances the FBOSS distro image build process** by enabling the comprehensive installation of all necessary components. It introduces new configuration files (`after_pkgs_install_input.json`, `after_pkgs_execute_input.json`) and **refactors the image configuration script** (`config.sh`) within the `fboss-image` module. This **new capability** allows for the proper inclusion of various component types, such as kernel, SAI, BSPs, and FBOSS stacks, along with post-installation execution hooks. The change ensures the **final distro image is complete and fully functional**, addressing previously missing components crucial for consolidated builds.

This commit performs **repository cleanup** by **deleting the redundant file** `distro_cli/lib/builder.py`. This file was previously renamed to `distro_cli/builder/image_build.py`, but due to a merge error, the original file was not correctly removed from the codebase. This **maintenance** task ensures the `distro_cli` module's build-related components are consistent and free of stale artifacts, with no impact on the successful execution of the Omnibus build process.

Add a Distro Image demo container example (#911)

This commit **enhances the build system** by configuring **component build containers** to run in **privileged mode**. This change, implemented in `fboss-image/distro_cli/lib/execute.py` by modifying the `execute_build_in_container` function to always set the `privileged` flag, is crucial for builds that need to perform operations requiring elevated permissions, such as running containers within themselves. Additionally, the `fboss/oss/docker/Dockerfile` is updated to adjust `/etc/shadow` permissions, ensuring `sudo` functionality within these privileged containers, particularly on CentOS. This **feature enhancement** enables more complex and flexible build environments by providing necessary elevated permissions.

This commit **adds the `fboss2-dev` CLI tool** to the **FBOSS distribution image**, making it available for direct use. It achieves this by updating the `fboss/oss/scripts/package.py` script to include `fboss2-dev` in the list of binaries packaged. This **feature addition** ensures that users of the FBOSS distribution image can now leverage the `fboss2-dev` command-line interface for configuring and managing FBOSS.