Thibault Sottiaux

This commit introduces a **new capability** by adding 'Jason' to the **predefined subagent nickname pool** within the `codex-core` module. This enhancement ensures that **spawned agents** can now automatically adopt 'Jason' as a name, eliminating the need for manual or custom role configurations. The change specifically updates the `codex-rs/core/src/agent/agent_names.txt` file, expanding the available default names for subagents. This simplifies the agent creation process and improves user convenience for the **agent management** subsystem.

This commit **fixes a critical account state synchronization bug** in the **Codex app** by **including the user's `planType`** in `AccountUpdatedNotification` messages. Previously, the `account/updated` notification lacked subscription tier information, causing client applications to display incorrect upgrade messaging for paid users. The change involves **updating the `codex-rs/app-server-protocol` schema** and **modifying `codex-rs/app-server/src/codex_message_processor.rs`** to consistently populate `planType` during login and refresh events. This **enhances data consistency** for the **account management subsystem**, ensuring clients accurately reflect user subscription tiers and **preventing misleading upgrade prompts**.

This commit introduces a **bug fix** to the **MCP resource handler** within `codex-rs/core/src/tools/handlers/mcp_resource.rs`. It modifies the `parse_arguments` function to correctly interpret `null` JSON strings as `None` when processing tool arguments. This change ensures that optional resource tools can gracefully accept `null` values without causing failures, thereby improving the **robustness** of the system. The fix prevents spurious argument parsing errors for `list` and `read` MCP resource calls, particularly when models emit `null` for optional parameters.

This commit **fixes** a bug in the **core execution environment handling** for Windows systems. It updates the environment variable filtering logic in `codex-rs/core/src/exec_env.rs` to correctly account for **case-insensitive variable names**, preventing essential system variables like `Path` and `TEMP` from being dropped when `inherit=core`. A **new Windows-specific regression test** has been added to validate this behavior. This ensures proper inheritance of core environment variables on **Windows systems**, preventing unexpected execution environment issues.

This commit **fixes** a contextual discrepancy within the **`/review` sub-agent** by ensuring it now **includes project-level `AGENTS.md` instructions and associated skills**. This enhancement guarantees that the **review sub-agent** processes information through the same comprehensive instruction pipeline as standard runs. The change **aligns reviewer context** with normal session execution, leading to more consistent and accurate feedback during code reviews.

This commit **updates documentation** within the **`codex-rs/core`** module's error handling component. It **corrects a comment** for the `ERROR_MESSAGE_UI_MAX_BYTES` constant, accurately stating its size as 2 KiB instead of the previously incorrect 4 KiB. This is a **maintenance chore** to improve code clarity and ensure the documentation precisely reflects the constant's actual value. There are no functional changes to the error handling logic, only an improvement in code readability and accuracy for developers.

This commit introduces a **bug fix** to the **`list_dir` functionality** within `codex-rs/core/src/tools/handlers/list_dir.rs`. It modifies the `list_dir_slice` function to **sort directory entries** *before* applying offset and limit for pagination. This change ensures that pagination results are **stable and predictable**, preventing inconsistencies in directory page ordering. The update also includes new test cases to cover sorted pagination and truncation expectations, improving the robustness of the `list_dir` feature.

This commit **fixes a bug** in the **TypeScript SDK's `CodexExec` utility** that could lead to missed early process exits, causing potential hangs or incorrect state. The `run` method in `sdk/typescript/src/exec.ts` is now modified to **register the process exit handler upfront** and **defer error handling** until after `stdout` has been fully drained, ensuring reliable capture of exit statuses. This **enhances the robustness** of process execution within the SDK, particularly for fast-exiting child processes that still produce output. A **new regression test** in `sdk/typescript/tests/exec.test.ts` has been added to prevent future regressions of this specific issue.

This commit **fixes** an issue where the `/review` command with arguments in the **TUI** and **TUI2** interfaces did not correctly initiate a code review. Previously, typing `/review <instructions>` would be treated as a plain message or an unrecognized command, failing to trigger the intended review flow. Now, the **chat composer** and **chat widget** components in both TUI versions are updated to properly **recognize and dispatch `/review` with arguments as a custom review command**, ensuring it directly starts a review with the provided instructions. This enhancement significantly improves the user experience by enabling direct review initiation from the command line.

This commit provides a **bug fix** for path parsing within the **`codex-rs/utils/git/src/apply.rs`** module. It refines how `git apply` paths are processed by correctly tokenizing quoted diff headers, ignoring `/dev/null` headers before prefix stripping, and unescaping C-style quoted paths from `git apply` output. This ensures accurate path classification and prevents potentially missed staging or misclassified paths, especially for filenames containing spaces or escaped characters. The fix primarily impacts the **cloud tasks support** and `codex apply <task_id>` functionality.

This commit **stabilizes a core tool parallelism test** within the `codex-rs/core` test suite. It's a **maintenance chore** that modifies the timing-based test in `tool_parallelism.rs` by setting `login=false` for the shell tool. This adjustment prevents test flakiness caused by slow user login shells, making the test more deterministic. The change ensures more reliable local and CI/CD runs by **preventing occasional test failures** without affecting any user-facing functionality.

This commit introduces a **bug fix** and **UI improvement** to the **Terminal User Interface (TUI)** approval modals. It **truncates long approval prefixes** and **prevents the "don't ask again" option from being displayed** when a command has a multiline prefix, which previously led to inscrutable approval requests. This change affects the `approval_overlay.rs` and `chatwidget` components in both `tui` and `tui2` modules, ensuring a clearer and more manageable user experience for command approvals. New test cases and snapshots were added to verify this behavior.

This commit **fixes a critical bug** within the **`codex-rs/utils/readiness`** module, specifically addressing issues in the `ReadinessFlag::subscribe` method. Previously, `i32` wrap-around could lead to the generation of token `0` or duplicate tokens, causing readiness gates to become stuck or misauthorized. The **refactoring** ensures that `subscribe` consistently issues non-zero and unique tokens, thereby preventing these wrap-around issues and improving the **reliability of readiness signaling**. New **regression tests** have been added to validate the fix and prevent future regressions.

This commit **fixes a bug** in the **`codex-apply-patch`** module, enabling it to correctly parse patch markers (`*** Begin Patch` / `*** End Patch`) that are padded with whitespace. Previously, such markers would cause `apply_patch` failures, particularly when generated by models or other sources with varied formatting. The fix involves **trimming whitespace** from these marker lines within the `check_start_and_end_lines_strict` function in `codex-rs/apply-patch/src/parser.rs`. This change significantly improves the robustness of the patch application process and is validated by new unit and fixture **regression tests**.

This commit **fixes a bug** in the **`/review` command's base-branch resolution logic** within the `codex-rs/core` module. Previously, `/review` might not have correctly respected the **session's current working directory (CWD)**, including runtime overrides, when computing merge-base guidance. Now, the command accurately uses the intended CWD from the turn context, ensuring that **code review guidance** is computed from the correct repository context. This **bug fix** improves the reliability of the `/review` feature, especially in environments with CWD overrides, and includes a **regression test** to prevent future regressions.

This commit performs a significant **documentation update and improvement** across several core project guides. It **updates outdated links and descriptions** within the `codex-rs/README.md` for getting started, advanced configuration, and MCP client usage. Additionally, **new documentation sections** are introduced in `docs/config.md` for connecting to MCP servers and configuring notification settings, while `docs/install.md` receives **clarified instructions** for installing `nextest` and executing tests with `just test` or `cargo test --all-features`. This **maintenance** work enhances the overall user experience by providing more accurate, comprehensive, and up-to-date guides for installation, configuration, and development workflows.

This commit performs **maintenance** by **correcting typos** and **rephrasing tooltip messages** within the **TUI** and **TUI2** components. Specifically, it updates the `tooltips.txt` files for both user interface versions to improve **clarity, conciseness, and tone**. These changes ensure a more professional and consistent user experience by providing accurate and well-articulated **in-application guidance**.

This commit introduces **experimental support for Skills** within the `codex-rs` CLI, enabling the system to load and integrate custom skill definitions from `skills.md` files. It adds a new `skills` module to the **core library** for skill discovery, parsing, and rendering, and integrates this functionality into the **user instruction generation** process via `project_doc.rs`. The **TUI application** is updated to handle skill loading and display any related errors, while new documentation (`docs/skills.md`) outlines its usage. This **new capability** allows for dynamic extension of the CLI's understanding through user-defined skills, though it is currently for internal testing.

This commit **fixes a minor UI inconsistency** within the **TUI (Text User Interface)** component by **correcting a display label**. Specifically, it updates the `reasoning_effort_label` in `codex-rs/tui/src/history_cell.rs` to change the 'XHigh' reasoning effort configuration's display from 'extra high' to the more accurate and concise 'xhigh'. This **label correction** ensures consistency and improves clarity for users interacting with the history display in the TUI.

This commit **refines the operational instructions** for the **`gpt-5-codex` agent** by updating its core prompt documentation. A new instruction has been added to `codex-rs/core/gpt_5_codex_prompt.md`, explicitly clarifying that the agent should **not amend commits automatically** unless specifically requested by the user. This **behavioral clarification** aims to prevent unintended modifications to the commit history, thereby enhancing user control and ensuring the agent's actions align precisely with explicit commands.