Tianyu Du

This commit **fixes a bug** in the **hardware production invariant tests** (`HwProdInvariantTests`) by updating their configuration helpers to use `masterLogicalInterfacePortIds`. This change ensures that management ports are correctly skipped during test setup, preventing false failures and improving test accuracy. Concurrently, the `ProdConfigFactory` is **extended to support** the new **PLATFORM_WEDGE800CACT** and **PLATFORM_WEDGE800BACT** platforms, enabling comprehensive testing for these hardware types. This work enhances the **reliability of hardware tests** and expands the **test infrastructure's platform compatibility**.

This commit provides a **critical data correction** for the **Wedge800CACT platform**, specifically addressing the **port type classification** for `eth1/33/1` and `eth1/33/2`. It **fixes** an issue where these ports were incorrectly identified, by updating their `portType` from a generic value to the correct **management port type** (4). This change is propagated across the **platform mapping configuration** in `fboss/agent/platforms/common/wedge800cact/Wedge800CACTPlatformMapping.cpp` and `fboss/lib/platform_mapping_v2/generated_platform_mappings/wedge800cact_platform_mapping.json`. Additionally, the **port profile mapping data** in `fboss/lib/platform_mapping_v2/platforms/wedge800cact/wedge800cact_port_profile_mapping.csv` is updated to reflect this change. The correction ensures the **FBOSS agent** accurately recognizes and manages these specific ports as intended management interfaces.

This commit delivers a **bug fix** for **PFC (Priority Flow Control) test cases** that were failing specifically on the **G200 ASIC** when using a new SDK. It addresses these failures within the `fboss/agent/test/agent_hw_tests/AgentTrafficPfcTests.cpp` module by introducing a new helper function. This helper is designed to correctly identify the highest priority strict-priority queue ID, which is then utilized by the `pumpTraffic` function to ensure accurate traffic simulation. The fix enables reliable validation of network traffic prioritization and flow control behavior on the **G200 ASIC**.

This commit **enables Pseudo-Random Binary Sequence (PRBS) configuration** for the **wedge400c platform**, extending a capability previously available on morgan800cc. It introduces a **new capability** by adding the `getSupportedPrbsPolynomials` method to the `EbroAsic` class, allowing the system to query available PRBS polynomials for diagnostic purposes. Concurrently, a **refactoring** in `EbroAsic.cpp` updates the `isSupportedNonFabric` method to explicitly exclude `SAI_PRBS`, indicating its specialized handling outside of general non-fabric features. This change, which requires Leaba SDK version 24.8.3001 or newer, provides crucial link testing and diagnostic features for the **wedge400c platform**.

This commit **adds support for a new SDK version**, `TAJO_SDK_VERSION_26_2_5210`, within the **FBOSS agent's SAI API layer**. Specifically, it updates the `fboss/agent/hw/sai/api/SaiVersion.h` file by including the new version in relevant preprocessor macros. This **feature enhancement** ensures that the FBOSS agent can correctly recognize and utilize the capabilities provided by this updated SDK. The change is crucial for maintaining compatibility with newer hardware platforms and their associated software development kits.

This commit introduces a **new capability** to the **FBOSS Agent's platform identification logic** by adding the `isTajoWedge800cPlatform` virtual function to the `AgentNetWhoAmI` interface. This enables the system to specifically detect the **Tajo Wedge800c platform**, which is essential for correctly setting the `ASIC` environment variable to `G2LL` for `wedge800cact`. This **feature addition** ensures the **Leaba debug shell** functions properly on the target hardware by providing the necessary environment configuration. The `AgentNetWhoAmI` interface and its associated **test infrastructure** in `MockAgentNetWhoAmI.h` and `AgentPreStartExecTests.cpp` are updated to support this new detection method.

This commit **resolves a build failure** in the **FBOSS FSDB OSS interface** by **regenerating** the `fboss/fsdb/if/oss/fsdb_model_thriftpath.h` file. The previous version of this generated header contained **duplicated class definitions**, introduced through source control merges, which prevented OSS builds from completing successfully. By re-running the `sync_model_thriftpath` script, this **maintenance fix** removes the redundant specializations and updates the **Thrift path definitions** to include new fields and rename existing ones, ensuring the **correctness and consistency of the FSDB model paths** for open-source consumption.

This commit **resyncs** the **OSS FSDB model Thrift path definitions** by updating the generated file `fboss/fsdb/if/oss/fsdb_model_thriftpath.h`. This **maintenance fix** addresses an oversight where a new field, `nameToNextHopSetId`, was added to the `FibInfo` struct in `switch_state.thrift` but the corresponding OSS Thrift path file was not regenerated. The update also incorporates other new fields and structures, such as `TransceiverI2cLogging` and `Srv6TunnelFields`, ensuring the **FSDB model** accurately reflects the latest **Fboss agent state Thrift definitions**. This **synchronization** is crucial for the **OSS build** to prevent compilation or runtime issues related to out-of-date schema definitions.

This commit **resyncs** the generated **FSDB model Thrift path definition** in `fboss/fsdb/if/oss/fsdb_model_thriftpath.h`. This **maintenance update** resolves a build error caused by an inconsistency between the generated file and the underlying FSDB Thrift model. Specifically, it incorporates new fields, `maxArsVirtualGroupWidth` and `maxArsVirtualGroups`, into the **FBOSS data model's Thrift interface**. This ensures the **FSDB component** builds correctly and accurately reflects the latest schema, preventing compilation failures due to out-of-sync definitions.

This commit introduces a **test infrastructure improvement** by configuring **global buffer pool reserved bytes** for **SAI tests** involving **Olympic port queues**. Specifically, it adds logic within `fboss/agent/test/utils/OlympicTestUtils.cpp` to set pool-level reserved bytes via a SAI extension for **ASIC types G200/G202X (Yuba)**. This **optimization** prevents the SDK from performing an inefficient O(n^2) recalculation of reserved bytes during queue attach/detach operations, thereby **avoiding test case timeouts** and improving the stability of the **Olympic test suite**. The change ensures a constant pool reserve is used, enhancing the reliability of **buffer management** in these specific test environments.

This commit introduces a **new SAI extension attribute**, `SAI_BUFFER_POOL_ATTR_RESERVED_BUFFER_SIZE`, to the **FBOSS SAI buffer management** subsystem. This **new capability** allows FBOSS to explicitly pass the configured `reservedBytes` for a buffer pool to the underlying SDK, specifically for **Tajo platforms** running SDK 25.5 and above. By providing both total pool size and reserved bytes, this change resolves a **critical bug** where the SDK was double-reducing the shared buffer pool size and avoids an O(n²) performance degradation during buffer pool updates. This ensures more **accurate buffer resource allocation** and **improves agent bootup performance** by preventing unnecessary recalculations.

This commit **fixes** incorrect `controllingPort` values within the **platform mapping JSON string** for the `Wedge800CACTPlatformMapping.cpp` file. Specifically, it corrects the `controllingPort` assignments for several Ethernet interfaces on the **Wedge800CACT** platform. This **maintenance** update ensures proper port control logic for these devices, preventing potential operational issues related to port management and configuration.

This commit performs **code cleanup** and **maintenance refactoring** by **removing an unused reference** to the `24.8.3001_yuba` SDK version. The obsolete SDK reference was eliminated from the **FBOSS agent's SAI implementation** for the Tajo NPU, specifically within `fboss/agent/hw/sai/switch/npu/tajo/SaiSwitch.cpp`. This change improves code hygiene by removing dead code and also includes a minor comment update to generalize SDK version references, ensuring no functional impact on the system.

This commit introduces a **new capability** for the **Yuba ASIC** to utilize **IP-in-IP tunnel PIPE mode** for DSCP handling. It dynamically configures the tunnel DSCP mode to `PIPE` or `UNIFORM` within the `YubaAsic` class based on the detected Leaba SDK version, specifically enabling `PIPE` mode for SDK versions greater than 24.8.3001. This change involves **platform integration** in `SaiMorgan800ccPlatform.cpp` to pass the SDK version during ASIC setup, and a minor **refactoring** in `G202xAsic.h` to remove the now-obsolete `getTunnelDscpMode` function. The update ensures optimal DSCP preservation for IP-in-IP tunnels on Yuba ASIC hardware when supported by the underlying SDK.

This commit **enhances the platform mapping generation** by allowing controlling ports to be read directly from a CSV file, serving as an interim solution until dynamic generation is fully implemented. It **refactors** the `_populate_subsumed_ports` logic within `fboss/lib/platform_mapping_v2/platform_mapping_v2.py` to accommodate this new input method. Specifically, new `Parent_Port` and `Controlling_Port` columns are **added to `wedge800cact_port_profile_mapping.csv`**, enabling explicit definition of these relationships. Consequently, the generated `wedge800cact_platform_mapping.json` and `wedge800bact_platform_mapping.json` now correctly incorporate these CSV-defined controlling ports and their associated `subsumedPorts` arrays. This ensures the continued generation of accurate subsumed port lists for each port profile.

This commit **deprecates Python REPL support** within the **`diag_shell`** for **TAJO ASICs** running SDK versions **24.8 and above**. This **maintenance** change is necessary because the `diag_shell`'s Python runtime conflicts with the `S1 CLI`'s Python environment, thus encouraging a full transition to the `S1 CLI`. The `makeRepl` function in `fboss/agent/hw/sai/diag/DiagShell.cpp` is updated to disable this functionality, and error handling is improved around `tryConnect`. Consequently, users on affected platforms will need to utilize the `S1 CLI` for Python-based diagnostics.

This commit performs a **maintenance update** to the **FBOSS agent's SAI API layer**, specifically updating the **TAJO SDK version** definition. It changes the SDK version from `25.5.5210` to `25.5.4210` within the `SaiVersion.h` file, aligning the codebase with the designated General Availability (GA) release for the `25.5` SDK series. This ensures the FBOSS agent correctly identifies and interacts with the intended hardware abstraction layer, maintaining compatibility and proper functionality.

This commit implements a **bug fix** to prevent the **FBOSS agent** from crashing when attempting to send **ARP requests** during the switch's exit or shutdown process. It modifies the `sendArpRequest` function in `fboss/agent/ArpHandler.cpp` to add a crucial check, ensuring that ARP transmissions are aborted if the switch is in an uninitialized or exiting state. This change significantly enhances the **stability** and **robustness** of the **ARP handling subsystem**, mitigating a rare but critical crash scenario observed during stress testing. A new test case has also been added to `fboss/agent/test/ArpTest.cpp` to verify that ARP requests are correctly dropped when the switch is in an exiting state.

This commit **fixes a warmboot inconsistency** in the **FBOSS SAI API layer** by adjusting how the `SAI_PORT_SERDES_ATTR_CUSTOM_COLLECTION` attribute is handled. Previously, FBOSS used an empty string as the default, but the underlying SAI SDK (v25.11.5210+) returns a specific empty JSON structure (`"{\"attributes\":[]}"`) when the collection is not set. To ensure **state consistency during warmboot**, the default getter for this attribute in `PortApi.h` now uses `StdNullOptDefault`. Furthermore, the `getSaiAttribute` function in `SaiApi.h` is updated to interpret empty `SaiJsonString` values (including the SDK's specific empty JSON) as `nullopt`. This **maintenance change** prevents mismatches in the warmboot state for port serdes custom collections, improving the robustness of the SAI attribute handling.

This commit introduces a **new capability** to the **`SaiTracer`** module, enabling it to properly handle and trace **`sai_json_t` attributes**. It adds a dedicated attribute handler within `SaiTracer.h` and implements the `jsonAttr` utility function in `Utils.cpp` to process these JSON attributes. This enhancement allows the tracer to accurately log both the raw byte values and a readable JSON string for **custom collection attributes**, significantly improving the debugging and monitoring of SAI interactions involving complex, serialized data types.