Tommy Brosman

This commit **fixes a bug** in the **Shared Tree**'s `checkCompatibility` function within `snapshotCompatibilityChecker.ts`, which previously mishandled view schemas containing staged upgrades by incorrectly filtering allowed types. The fix now correctly utilizes `toInitialSchema` to ensure proper schema conversion and filtering, resolving issues where the `viewWhichCreatedStoredSchema` contained staged upgrades. Furthermore, **new tests** are added to validate complex schema compatibility scenarios, such as `allowUnknownOptionalFields` for forward compatibility and staged schema upgrades, while also correcting an existing roundtrip snapshot test. This work significantly improves the robustness of **Shared Tree**'s **schema evolution** and compatibility checks.

This commit introduces a **new capability** to the `Shared Tree`'s `simple-tree` module by adding **alpha APIs** for schema snapshot compatibility testing. It provides `checkCompatibility`, `importCompatibilitySchemaSnapshot`, and `exportCompatibilitySchemaSnapshot` functions, primarily within `packages/dds/tree/src/simple-tree/api/snapshotCompatibilityChecker.ts`. This **feature addition** enables developers to encode schemas as snapshots and programmatically verify their compatibility, which is crucial for maintaining data integrity and stability during schema evolution. The new APIs are exported for general use and are documented in the `tree.alpha.api.md` and `fluid-framework.alpha.api.md` API reports, along with dedicated unit tests.

This commit introduces a **new capability** to the **Shared Tree**'s schema generation, enabling `generateSchemaFromSimpleSchema` to build schemas that incorporate "staging information" for allowed types. The core change updates the `generateAllowedTypes` function within `packages/dds/tree/src/simple-tree/api/schemaFromSimple.ts` to correctly process the `isStaged` attribute from `SimpleAllowedTypeAttributes` and utilize `AllowedTypesFull`. This enhancement provides greater flexibility in defining schemas by supporting staged types. **New tests** were added to validate the `allowUnknownOptionalFields` property and the correct handling of staged allowed types, alongside type tests addressing issues with allowed types parameters in schema factories.

This commit introduces **new alpha APIs** for the **Shared Tree**'s **Simple Tree schema system**, specifically `encodeSimpleSchema` and `decodeSimpleSchema`, which enable serializing and deserializing `SimpleTreeSchema` objects to and from a JSON-compatible format. This **new capability** facilitates external storage, transmission, and comparison of schemas. Additionally, the `SimpleTreeSchema` definition is **enhanced** with new fields like `isStaged` and `allowUnknownOptionalTypes` to support future schema compatibility checking scenarios. These changes primarily affect the `packages/dds/tree/src/simple-tree/api` module and lay the groundwork for more robust schema evolution.

This commit **refactors** the **Shared Tree's Simple Schema** by replacing the `allowedTypesIdentifiers` Set with a new `simpleAllowedTypes` Map, which now includes `isStaged` information for each allowed type. This **feature enhancement** provides richer metadata for schema management, particularly for staged schema upgrades. The change impacts core schema definition, conversion, and API exposure within the `dds/tree` package, and introduces **breaking changes** to several alpha APIs such as `SimpleFieldSchema.allowedTypesIdentifiers`. Downstream consumers like `ai-collab` and `devtools-core` are updated to use the new structure, ensuring consistent schema handling across the project.

This commit performs a **refactoring** by **removing the deprecated re-export** of `MinimumVersionForCollab` from the **`@fluidframework/container-runtime`** package. Consequently, all internal usages within **`@fluidframework/aqueduct`**, **`@fluidframework/fluid-static`**, and various **test utilities** have been updated to import `MinimumVersionForCollab` directly from its canonical source, **`@fluidframework/runtime-definitions`**. This **maintenance** task cleans up the API surface and constitutes a **breaking change** for any external consumers who were relying on the deprecated re-export.

This commit **enhances error reporting** within the **runtime-utils package** by providing more detailed messages for invalid `minVersionForCollab` values. It introduces a new helper function, `checkValidMinVersionForCollabVerbose`, which performs granular validation checks and is now utilized by existing compatibility methods like `isValidMinVersionForCollab`. This **refactoring** improves the clarity of error messages, making it easier for developers to diagnose and correct compatibility configuration issues. New tests were also added to ensure the correctness of the verbose validation logic for `minVersionForCollab`.

This commit **refactors** the **Shared Tree** DDS to standardize how the minimum compatible client version is specified. It replaces the `oldestCompatibleClient` option with `minVersionForCollab` across various **Shared Tree APIs** and **codec** implementations, including `SharedTreeOptions` and `CodecWriteOptions`. This change also introduces a fallback mechanism where `Shared Tree` will now use the `minVersionForCollab` from the `ContainerRuntime` if not explicitly set, and redefines `FluidClientVersion` as a const object. This is a **breaking change** for several alpha APIs, requiring consumers to update their version specification to align with the new `minVersionForCollab` parameter.

Added React linting to inventory-app and fixed existing violations (#25465)

This commit performs a **minor refactoring** by **removing a redundant declaration** of the `minVersionForCollab` property from the `IFluidDataStoreContext` interface. Since `IFluidDataStoreContext` already extends `IFluidParentContext`, which defines `minVersionForCollab`, the explicit declaration in the derived interface was unnecessary. This change **cleans up the core Fluid Framework interface definitions**, specifically within the **data store context module**, improving code clarity and maintainability. There is **no functional impact** or behavioral change to the system, as the property remains accessible via inheritance.

This commit **introduces a new capability** by plumbing the `minVersionForCollab` property through the Fluid Framework runtime stack. This architectural **refactoring** ensures that the versioning information, originating from the `ContainerRuntime`, is propagated through `FluidDataStoreContext` and `FluidDataStoreRuntime` to the `SharedObjectKernel`. The primary goal is to make `minVersionForCollab` directly accessible for consumption by **Distributed Data Structures (DDSes)**, enabling them to implement version-aware logic. This work involves **API surface expansion** across several core runtime interfaces and classes, along with corresponding updates to test mocks and API documentation.

This commit performs a **refactoring** and **maintenance** task by relocating the `MinimumVersionForCollab` constant. It moves the definition of this crucial compatibility version from the **`runtime-utils`** package to the **`runtime-definitions`** package, specifically within a new `compatibilityDefinitions.ts` file. This change enables the `runtime-definitions` package to properly access and utilize this constant, while the **`container-runtime`** package is updated to reflect the new import paths. The **API report** for `runtime-definitions` is also updated, and deprecation messages are adjusted to reflect the new canonical location, improving dependency management and logical organization across runtime components.

This commit delivers a **bug fix** for the `flub` **Dockerfile policy check** that was failing specifically on **Windows environments**. The issue arose because the policy check expected forward slashes in Dockerfile paths, while paths generated from the Windows filesystem used backslashes. To resolve this, the `handler` function within `build-tools/packages/build-cli/src/library/repoPolicyCheck/dockerfilePackages.ts` now explicitly normalizes path separators to use forward slashes. This ensures consistent path representation, allowing the **Dockerfile policy check** to execute correctly on Windows.

This commit **refactors** the **compatibility tooling** within the Fluid Framework, moving shared utilities from the `container-runtime` package to the more general-purpose **`runtime-utils`** package. Specifically, the former `compatUtils.ts` was split into `runtime-utils/src/compatibilityBase.ts` (containing shared logic like `SemanticVersion`) and `container-runtime/src/containerCompatibility.ts` (for container-specific versioning, including new validation functions). This **reorganization** improves modularity, exposes these tools to more layers, and introduces **new capabilities** for managing `minVersionForCollab` and other versioning aspects. As a significant downstream impact, the `MinimumVersionForCollab` type has been **relocated and deprecated** in `container-runtime`, though it is currently re-exported for backward compatibility. This work lays the groundwork for plumbing `minVersionForCollab` down to the DDS layer.

This commit **updates the Shared Tree documentation** by adding a new example section to `packages/dds/tree/docs/main/compatibility.md`. This new content details the introduction of a new schema format and codec, providing a practical illustration of how such changes are handled within the system. This **documentation enhancement** improves developer understanding of **compatibility** considerations for the **Shared Tree** module, offering a concrete example and linking to a relevant pull request for further context on schema evolution.

This commit introduces a **new capability** to the **Shared Tree's `simple-tree` schema factory APIs**, enabling the annotation of recursive array and map schemas with **persisted metadata**. It updates the `arrayRecursive` and `mapRecursive` methods in `packages/dds/tree/src/simple-tree/api/schemaFactoryAlpha.ts` to accept `NodeSchemaOptionsAlpha`, thereby allowing custom metadata to be associated with these schema definitions. This enhancement exclusively affects **alpha APIs** and is validated by new test cases in `schemaFactoryRecursive.spec.ts`, with corresponding updates to the `tree.alpha.api.md` and `fluid-framework.alpha.api.md` API reports.

This commit introduces a **new capability** to the **Shared Tree** by adding support for **persisted schema metadata** within its in-memory format and API. It modifies core `Tree*StoredSchema` types to include a `persistedMetadata` field, allowing arbitrary, JSON-compatible data to be associated with **node and field schemas**. This involves significant **API changes** within the **Simple Tree**'s `SchemaFactoryAlpha`, introducing new **alpha types** such as `NodeSchemaOptionsAlpha`, `FieldPropsAlpha`, and `FieldSchemaMetadataAlpha` to facilitate passing this metadata. The work also includes **refactoring** various schema conversion, export, and internal utility functions to correctly handle and propagate this new metadata. This enhancement provides developers with the ability to store custom, persistent information directly within their schema definitions, impacting how schemas are defined, stored, and managed.

This commit performs a significant **refactoring** of the **Shared Tree**'s schema versioning mechanism to improve clarity and consistency. It renames the internal `CodecFormatVersion` concept to a more explicit `SchemaVersion` enum, which now consistently defines and manages the format version for stored schemas. This change impacts various **schema-related codecs and components** within the `dds/tree` package, including `schema-edits`, `schema-index` codecs, `SharedTree` initialization, and the `simple-tree` API. The update ensures that all relevant parts of the system, including tests, correctly reference the new `SchemaVersion` enum for schema codec operations, standardizing how schema formats are identified and processed.

This commit **refactors** the **Shared Tree schema codec** to support multiple write formats, introducing a robust versioning system. It renames the original `Format` to `FormatV1` and implements a `makeCodecFamily` pattern for both schema and schema change codecs, enabling dispatch based on the format version. This significant **architectural enhancement** impacts the **schema summarization** (`SchemaSummarizer`), **SharedTreeKernel**, and **Simple Tree API**, which now instantiate and utilize the new versioned codec. The change ensures future compatibility and extensibility for schema serialization within the `dds/tree` package by allowing new schema formats to be introduced without breaking existing functionality.

This commit performs a significant **refactoring** by **removing the `IsomorphicPerformance` API** from the `client-utils` package, replacing its `now()` method with a direct `performanceNow()` function. This change simplifies performance timing measurements across various modules, as components in **driver and loader packages** (e.g., `odsp-driver`, `routerlicious-driver`, `container-loader`) and **telemetry utilities** now directly utilize `performanceNow()`. The work streamlines the codebase, **reduces abstraction overhead** within `client-utils`, and improves maintainability by eliminating a partially unused internal utility. This internal cleanup has no external impact on functionality but makes performance measurement calls more direct and efficient.