Takashi Tamura

This commit provides a **bug fix** within the **Markdown language features extension** to improve document link navigation. It specifically **normalizes the start and end positions** within the `getSelectionFromLocationFragment` utility function. This ensures that selection ranges derived from location fragments are always correctly ordered, preventing potential issues with incorrect text highlighting or cursor placement. The change enhances the reliability and accuracy of text selection when opening document links in Markdown files.

This commit introduces a **bug fix** to the **Markdown language features extension**, specifically addressing potential crashes during link navigation. It **adds robust error handling** to the `decodeURIComponent` function within `getLocationFragmentFromLinkText` in `extensions/markdown-language-features/src/util/openDocumentLink.ts`. This change **prevents application crashes** when processing malformed URI components found in link fragments, significantly improving the stability and reliability of Markdown document link handling.

This commit delivers a **bug fix** to the **Markdown language features extension**, specifically within the `openDocumentLink.ts` utility. It enhances the `getSelectionFromLocationFragment` function by adding validation to ensure that parsed line numbers (start and end) are strictly greater than zero. This prevents errors and improves the robustness of **document link navigation** when handling location fragments, ensuring accurate and reliable selection parsing within Markdown files.

This commit **enhances document link handling** within the **Markdown language features extension**. It introduces new capabilities to **parse URI fragments** in document links, allowing users to specify and automatically select a particular text range or location when opening a linked file. This **feature enhancement** improves navigation by enabling more precise linking directly to specific content within documents. The change involves new parsing logic and helper functions, such as `getSelectionFromLocationFragment` and `getLocationFragmentFromLinkText`, primarily within `openDocumentLink.ts`.

This commit **enhances the Chat UI rendering** by implementing **pinning logic and repositioning** specifically for final AI responses. It modifies the `chatListRenderer.ts` file to improve how these completed answers are displayed, ensuring they are more prominent and correctly positioned within the chat interface. A new utility function, `isRenderedPartInsideThinking`, was introduced to manage rendering context, particularly when parts of a response are still being generated. This **enhancement** significantly refines the presentation of AI outputs, improving the overall user experience within the **Chat feature**.

This commit provides a **bug fix** for the **Chat UI's markdown rendering logic**, specifically addressing the detection of the final answer part. It adjusts the `isFinalAnswerPart` logic within `src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts` to ensure accurate identification during `renderMarkdown`. This correction prevents incorrect display or truncation of chat responses, thereby improving the reliability and user experience of the **Chat feature**.

This commit introduces a **bug fix** to the **Chat UI rendering** logic, specifically within the `chatListRenderer.ts` file. It addresses an issue where the "thinking" indicator was incorrectly displayed for final answers in the **chat list widget**. By modifying the `renderElement` function, this change prevents the rendering of the "thinking part" when a chat response is complete, ensuring the UI accurately reflects the state of chat interactions. This improves the user experience by eliminating misleading visual cues in the **chat panel**.

This commit **optimizes rendering performance** within the editor's **`NativeEditContext`** and **`TextAreaEditContext`** components by **refactoring** how DOM updates are handled. It introduces a mechanism to **schedule expensive DOM manipulations**, such as updating selection and control bounds, to the **next animation frame** using `requestAnimationFrame`. This **maintenance** change, specifically impacting `src/vs/editor/browser/controller/editContext/native/nativeEditContext.ts` and `src/vs/editor/browser/controller/editContext/textArea/textAreaEditContext.ts`, effectively **reduces layout thrashing and reflow pressure**. The overall impact is a smoother and more responsive user interface during editor interactions.

This commit introduces a **bug fix** to the **Chat** feature's user interface, specifically targeting the rendering of final responses. It **enhances the final response rendering logic** within the `ChatListItemRenderer` in `src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts`. The change likely refines how markdown content is processed via the `renderMarkdown` symbol, ensuring that the last message in a chat conversation is displayed correctly and completely. This improvement directly impacts the visual presentation and user experience of completed chat interactions.

This commit **updates the documentation** for file linkification instructions within the **Copilot extension's agent prompts**. It **clarifies valid URI formats** by removing one previously listed format from `extensions/copilot/src/extension/prompts/node/agent/fileLinkificationInstructions.tsx`. This **maintenance** change ensures that the agent's understanding and generation of file links adhere to a more precise set of rules. Consequently, numerous **snapshot tests** across various agent prompt configurations were updated to reflect this refined definition of valid file link formats, ensuring consistency with the clarified instructions.

This commit performs a **maintenance refactoring** within the **WorkbenchKeybindingService** to standardize the usage of the `isComposing` context key. It updates `src/vs/workbench/services/keybinding/browser/keybindingService.ts` to align with the global `EditorContextKeys.isComposing` constant, ensuring consistent interpretation of input composition state across the workbench. This change improves code consistency and maintainability by centralizing the definition of this critical context key, affecting how keybindings are processed during IME input. The refactoring has no functional impact but enhances the robustness of the **keybinding system**.

This commit implements a **bug fix** to improve **context handling** within the **ChatWidget** during message re-editing. It introduces a new helper function, `addToContext`, which employs conditional logic to correctly manage chat context variables in `src/vs/workbench/contrib/chat/browser/chatWidget.ts`. This replaces a less robust filtering mechanism, ensuring chat context variables are accurately preserved when users modify their messages. Ultimately, this **enhances the reliability** of the chat experience by preventing context loss during user modifications.

This commit introduces a **bug fix** to the **ChatWidget** component within the **workbench contrib chat** subsystem. It ensures that the `finishedEditing()` method is consistently invoked within the `updateModel` function by adding conditional calls. This change addresses an oversight where the editing state was not always properly finalized, preventing potential issues with the chat input's state management. The fix improves the reliability and correctness of the chat experience by ensuring timely cleanup or state transitions after user input.

Isolated change to test utilities for the `runInTerminalTool`; no production impact.

This commit introduces a **fix** to the **terminal chat agent tools** to improve the detection of `sed`'s in-place editing option. Specifically, it updates the regex in `src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalChatAgentToolsConfiguration.ts` to correctly recognize both lowercase `-i` and uppercase `-I` flags. This **bug fix** ensures that the **chat agent** can accurately parse `sed` commands regardless of the case used for the in-place option, preventing potential misinterpretations and enhancing the reliability of automated command execution.

This commit **fixes** an issue within the **Markdown KaTeX extension** by updating the `mathInlineRegExp` regular expression. The modification ensures that **inline LaTeX math syntax** is correctly parsed even when it includes additional, previously mishandled characters. This **bug fix** improves the robustness and accuracy of **math rendering in Markdown previews**, preventing parsing errors for complex or edge-case LaTeX expressions.

This commit **fixes** an issue in the **markdown rendering** subsystem by correcting the DOM API usage within the `renderMarkdown` function in `src/vs/base/browser/markdownRenderer.ts`. Previously, the `children` property was used to reset DOM elements, which only includes element nodes. By switching to `childNodes`, the renderer now correctly clears all child nodes, including text nodes and comments, ensuring a complete and proper reset of the rendered markdown content. This **improves the robustness and accuracy of markdown display**, resolving potential issues where markdown might not have been fully updated or cleared as intended.

This commit introduces a **bug fix** to the **Chat UI**'s markdown rendering, specifically addressing the timing of the `onDidChangeHeight` event. Previously, this event could fire prematurely before a **code block editor** had fully rendered, leading to incorrect layout or sizing within chat responses. The change modifies `src/vs/workbench/contrib/chat/browser/chatContentParts/chatMarkdownContentPart.ts` to ensure the event is now triggered *after* the asynchronous `renderCodeBlock` operation completes. This guarantees accurate height reporting for **chat code blocks**, improving the stability and responsiveness of the chat display.

This commit **fixes a bug** in the **quick input component** that caused the `accept` action to fire prematurely during Input Method Editor (IME) composition. Specifically, it modifies `src/vs/platform/quickinput/browser/quickInputActions.ts` to incorporate an `isComposing` context key check. This change **prevents unintended quick input acceptance** while users are actively typing with an IME. The **bug fix** significantly **improves the user experience for international users** by ensuring stable and predictable input behavior within quick input fields.

This commit introduces a **new capability** to the **editor's context key system** by adding `EditorContextKeys.isComposing`, which accurately reflects when an Input Method Editor (IME) is actively composing text. This new context key is then immediately leveraged to refine the behavior of the **Find/Replace feature**. Specifically, the Enter keybinding within the `replace` functionality in `findController.ts` is updated to only trigger a replacement action when `isComposing` is false. This enhancement significantly improves the **editor's input handling** for users of IMEs, preventing unintended replacements while text is being composed.