Kevin Yakar

This commit introduces a **revamped FBOSS OSS on-diff job system** and a new capability to **test local changes in OSS via Sandcastle**. This **major enhancement** to the **FBOSS OSS CI/CD pipeline** consolidates five on-diff jobs into one, drastically reducing execution time from approximately 100 minutes to 20-30 minutes, while improving build parity with the vendor experience through the use of Docker and Clang. Developers can now easily validate local code changes against the OSS build process, streamlining the **developer workflow** and enabling proactive build health monitoring. Supporting changes include a **refactor** in `fboss/oss/docker/Dockerfile` and a **fix** in `fboss/oss/scripts/run-getdeps.py` to ensure proper clang environment setup.

Update OSS test results

This commit introduces **new capabilities** and **CI/CD enhancements** across the project's build and test infrastructure. It **integrates dedicated unit test steps** into the **Agent** and **QSFP** GitHub Actions workflows, improving automated testing coverage for these services. Concurrently, the `docker-build.py` script is enhanced to support building **multiple CMake targets**, providing greater flexibility in Docker image creation. Furthermore, the `docker-unittest.py` script now allows for the **exclusion of specific test binaries**, enabling more granular control over test execution within the CI environment.

This commit introduces a **new capability** to the **`docker-unittest.py` script**, enabling it to **reuse existing Docker containers or images** for testing instead of rebuilding them every time. This optimization significantly **reduces test execution time and resource usage** by detecting if the script is running inside a container or if a suitable image already exists. To support this, several **GitHub Actions CI/CD workflows** are updated to save and load Docker images as artifacts, further streamlining the build process. This enhancement improves the efficiency and flexibility of the testing infrastructure by avoiding redundant Docker image builds.

This **refactoring** commit **unifies docker image and container naming conventions** across the **FBOSS OSS codebase** and its **documentation**. It updates image tags from `fboss_docker` to `fboss_image` and container names from `FBOSS_DOCKER_CONTAINER` to `FBOSS_BUILD_CONTAINER` within various `docs/static/code_snips` scripts. The change also ensures consistency in `fboss/oss/docker/prefetch` Dockerfiles and build scripts by adopting the `fboss_image` base name. This **maintenance** effort improves clarity and reduces potential confusion for developers interacting with the FBOSS OSS Docker environment.

This commit provides a crucial **build fix** for the **OSS build system**, resolving several linker errors and compilation issues. It addresses an undefined symbol error in the core agent by adding `thrift_service_utils` to its library dependencies in `cmake/Agent.cmake`. For the **SAI hardware agent tests**, specifically the `switch_test` target, missing library dependencies like `nexthop_id_test_utils` are added, and gtest discovery is configured to fix linker errors related to route and next-hop ID management. Additionally, `fboss/agent/hw/sai/switch/tests/Srv6ManagerTest.cpp` is updated to unconditionally include required SAI headers, ensuring its successful compilation. These changes collectively enable the **`switch_test` target** and related components to build correctly in the open-source environment.

This commit introduces **validation** within the **FBOSS build script** `run-getdeps.py` to enforce mutual exclusivity among SAI implementation arguments. It ensures that users cannot simultaneously specify `--npu-sai-impl`, `--phy-sai-impl`, or enable the fake SAI build option, preventing conflicting configurations. This **enhancement to the build system** improves the robustness of dependency management by clarifying and constraining the available SAI build choices. The changes primarily affect the argument parsing (`parse_args`) and environment variable setup (`_set_build_env_vars`) within the script, leading to more predictable and error-free builds for **FBOSS components**.

Update Stable Commits

This commit provides a **bug fix** to the **build script** `fboss/oss/scripts/run-getdeps.py`, addressing two issues related to `libsai` manifest patching. It ensures that the `SAI_VERSION` is correctly updated regardless of whether an NPU implementation argument is provided, preventing unexpected version discrepancies. Additionally, the commit **corrects the patching logic** within `_edit_libsai_manifest` to properly include the `experimental` keyword. This resolves **build failures** caused by missing header files, such as `saiexperimentaldashtrustedvni.h`, by ensuring the correct `libsai` headers are found during the compilation process.

This commit **updates the project documentation and associated build scripts** to reflect a recent change in how `run-getdeps.py` handles environment variables. It **migrates configuration for NPU SAI implementations and benchmarks** from direct environment variable assignments to dedicated command-line flags. Specifically, the `run_agent_benchmarks.md` manual and `build_forwarding_stack.sh` script now use `--npu-sai-impl` and `--npu-sai-sdk-version` flags, and a new `build_benchmark_binaries.sh` script demonstrates `--benchmark-install`. This **documentation and maintenance update** ensures users follow the correct, simplified procedure for **building NPU-related components and running benchmarks**.

This commit introduces a **new feature** to the **`run-getdeps.py` script**, enabling users to **preserve pre-existing environment variables** during execution. A new command-line argument, `--preserve-env`, has been added to control this behavior, allowing the script to optionally maintain current environment values instead of overwriting them. This enhancement primarily affects the **environment variable management** logic within `run-getdeps.py`, specifically modifying how functions like `parse_args` and `_set_build_env_vars` handle environment setup. This provides greater flexibility for users who need to integrate `run-getdeps.py` into diverse build environments without losing custom configurations.

This commit introduces a **new feature** to the **FBOSS build system** by enhancing the `fboss/oss/scripts/run-getdeps.py` script. It now allows users to configure critical environment variables for **SAI (Switch Abstraction Interface) builds** directly via command-line flags, specifically for NPU and PHY implementations and SDK versions. This **improves developer experience** by simplifying the build process and preventing common configuration errors. The script also incorporates an automated mechanism, leveraging a "Claude skill," to keep these options updated from the `impl.bzl` source of truth, ensuring the script remains current with the codebase.

This commit **updates the Fboss Dockerfile** to incorporate essential static libraries, specifically enabling **SDK builds**. It introduces static versions of `glibc` and `libstdc++`, and builds and installs `libyaml.a` directly within the `Dockerfile`. This **build system maintenance** ensures that the Fboss development environment can successfully generate **SDK artifacts** by providing all necessary static dependencies.

This commit **standardizes the build process** within **GitHub Actions (GHA) workflows** by configuring them to utilize **system-installed dependencies**. It specifically modifies how the `docker-build.py` script is invoked to ensure consistency with dependency management strategies used in other build environments. This **maintenance improvement** aims to align the CI/CD pipeline's build environment, promoting greater predictability and reducing discrepancies between local development and automated builds. The change primarily affects the project's **build infrastructure** and **developer experience**.

Fix compiler flag to ignore nullability completeness warnings (#954)

This commit provides a **bug fix** to resolve **undefined reference errors** encountered during **OSS builds** of the `fbthrift` library. It addresses linker issues related to `apache::thrift::ThriftParametersServerExtension::negotiate` in `Cpp2Worker.cpp` and `apache::thrift::type::AnyStruct::readNoXfer` during `dynamic::Any` deserialization within `Any.cpp`. These errors, introduced by recent changes, were preventing successful compilation of core `fbthrift` components in open-source environments. The **maintenance** work ensures that the necessary symbols are correctly linked, allowing downstream projects to build `fbthrift` without compilation failures.

This commit **updates documentation** across several manuals and code snippets to reflect the deprecation of `build-helper.py`. It removes instructions for the old build helper and instead guides users to utilize the newer `run-getdeps.py` command with its updated flags for various build scenarios. This **documentation update** is a **maintenance** task that ensures the project's build instructions remain accurate and align with the latest recommended practices. Users following the **build guides for agent benchmarks, forwarding stack, and other targets** will now be directed to the correct and supported build processes.

This commit **refactors the FBOSS OSS build process** by integrating NPU SAI SDK artifact preparation and manifest management directly into `run-getdeps.py`, effectively **deprecating `build-helper.py`**. It introduces new command-line arguments and functions like `_edit_libsai_manifest` and `_conditionally_prepare_sdk_artifacts` within `run-getdeps.py` to handle SDK staging more efficiently, eliminating the need for a local HTTP server. This **enhancement** streamlines the build workflow, making it faster and smarter, while maintaining backward compatibility to allow for future updates to documentation and build instructions. The changes also lay the groundwork for simplifying FBOSS builds by transitioning to flag-based configurations.

This commit **enables Clang as the default compiler** for **FBOSS Open Source Software (OSS) builds**, marking a significant **build system enhancement**. It updates the `Dockerfile` and `docker-build.py` script to default to Clang, impacting **GitHub Actions workflows** and **vendor build instructions**. This change streamlines the OSS build process for most users, who can still opt for GCC using a `--build-arg USE_CLANG=false` flag if needed. Additionally, several documentation snippets related to build flags were updated.

Update zlib source url to use GitHub