Ravi Vantipalli

This commit **updates a hardcoded configuration value** for the **Ladakh platform** within the **SAI Broadcom BCM88800-based platform agent**. Specifically, it adjusts the `numCellsAvailable` constant in `fboss/agent/platforms/sai/SaiBcmLadakh800bclsPlatform.h` to `610000`. This **maintenance fix** ensures the platform accurately reflects the current number of available buffer cells, addressing a known issue until a more permanent resolution is implemented. The change is crucial for correct resource management and capacity reporting on the **Ladakh platform**.

This commit **introduces a new capability** by adding official support for the **AIFM controller ethertype**, defining `0x88B6` in `switch_config.thrift` and integrating it into the packet processing pipeline. The `PacketStreamHandler.h` module now utilizes this specific ethertype, and `SaiAclTableManager.cpp` is updated to recognize `AIFM` for ACL configurations, enabling proper identification and handling of AIFM control plane traffic. Additionally, the commit includes several **maintenance fixes**, such as adding explicit `uint16_t` casts for VLAN IDs in `TxPacket.h` and `ICMPHdr.cpp` for improved type safety. Template types are also explicitly specified in `HwCpuLatencyBenchmarkHelper.h`, and `asic_utils` is added as a dependency for benchmarks.

This commit **corrects the reported number of available cells** for the **SAI Broadcom Tahansb800bc platform**. It **updates the `numCellsAvailable` function** in `fboss/agent/platforms/sai/SaiBcmTahansb800bcPlatform.h` to provide a more accurate value for the **TH6 platform**, replacing an outdated value inherited from TH5. This **platform-specific configuration update** addresses a data inaccuracy, though the value is currently capped at 610,000 due to a known issue, with an eventual target of 630,000 cells. This improves the precision of resource reporting for the specified hardware.

This commit **introduces a new capability** by adding `ether_type` as a supported qualifier for **Access Control List (ACL) tables**. This enhancement is implemented within the **SAI ACL table manager** (`SaiAclTableManager.cpp`), specifically targeting **Tomahawk6 ASICs**. The primary purpose of this addition is to enable the **punting of Aifm control packets to the agent**, allowing for more granular control and processing of these critical packets. This expands the flexibility of **network traffic classification** and handling for specific control plane interactions on supported hardware.

This commit **fixes a warm-boot failure** encountered in the **`VerifySinkToStreamLoopback`** hardware test within `AgentPacketStreamHandlerTests.cpp`. The **refactoring** addresses this by moving the client's `connect` call from the test's setup phase to its verification phase. This ensures the test correctly initializes and validates connections after a warm-boot, improving the reliability of **agent hardware testing** and preventing erroneous test failures during system restarts.

This commit introduces **new unit tests** for the **`PacketStreamClient`** within the `thrift_packet_stream` module. These tests specifically validate the `send` functionality, ensuring correct behavior across various scenarios including sink readiness, single and multiple packet transmissions, concurrent sends, and sending to multiple ports. This **enhances test coverage** and improves the reliability of the packet streaming client by verifying its core sending capabilities under diverse conditions.

This commit introduces a **new capability** to the **`PacketStreamClient`** within the **`thrift_packet_stream` library**, enabling it to act as a simplified sink client. It adds a new `send()` method, along with `createSink` and `isSinkReady`, which abstracts the complexity of sending packets via a Thrift `packetSink` coroutine. This **API simplification** manages an internal lock-free queue and a background `sinkLoop` for asynchronous packet transmission, improving usability for callers. Test cases in `AgentPacketStreamHandlerTests.cpp` are updated to leverage this new, streamlined interface, removing direct Thrift sink client usage. The change significantly enhances the `PacketStreamClient` by providing a high-level, asynchronous mechanism for packet streaming.

This commit introduces a **new agent-level hardware test**, `AgentPacketStreamHandlerTest`, designed to verify the **full round-trip packet loopback path** for the `PacketStreamHandler`. The test simulates sending AIFM control packets out a port in loopback mode, ensuring they are correctly dispatched by `handlePacketImpl()` and forwarded back to a `PacketStreamClient` by `PacketStreamHandler.handlePacket()`. This **new test capability** significantly **enhances the test coverage** for the **agent's packet streaming subsystem**, ensuring reliable control plane communication. It involves updates to the agent's build configurations and adds `AIFM_PACKET_STREAM_HANDLER` to the `ProductionFeature` enum.

This commit **adds comprehensive unit tests** for the **`PacketStreamHandler`** component within the FBOSS agent. Located in `fboss/agent/test/PacketStreamHandlerTest.cpp`, these new tests validate critical functionalities such as **packet dropping when no clients are connected**, the **Thrift client lifecycle** (connect/disconnect), and the **Tx path for stream delivery** of both single and multiple packets. This work significantly **improves test coverage and reliability** for the agent's packet streaming capabilities, ensuring robust behavior in various client interaction scenarios. The tests are integrated into the existing `ctrl_test` build target, enhancing the overall quality assurance for the `fboss/agent` module.

This commit **refactors** the **FBOSS agent test suite** by migrating the `TrunkPortStats` test case from `HwTrunkTests.cpp` to `AgentTrunkTests.cpp`. This action completes the consolidation of all trunk-related hardware tests, specifically those verifying **trunk port statistics**, into the more appropriate `AgentTrunkTests.cpp` file. Consequently, the now-obsolete `HwTrunkTests.cpp` file is **removed**, streamlining the test infrastructure for **FBOSS agent trunk functionality**. This **test migration** improves the organization and maintainability of the agent's hardware tests.

This commit performs **code cleanup** by **removing unused test files** associated with the **TE flow feature** from the hardware agent's test suite. Specifically, `HwTeFlowTests.cpp` and `HwTeFlowTrafficTests.cpp` are deleted, which previously contained tests for TE flow functionality and traffic. This **maintenance** action is taken because the **TE flow feature** is no longer utilized and will not be migrated to the new `AgentHwTest` framework, thereby simplifying the codebase and reducing unnecessary test overhead.

This commit performs **test infrastructure refactoring** by **removing the deprecated `HwPtpTcTests.cpp` file**. All tests related to **Precision Time Protocol Traffic Class (PTP TC)**, specifically `VerifyPtpTcEnable` and `VerifyPtpTcToggle`, have been fully migrated from the old `HwTest` framework to the new `AgentHwTest` framework, now residing in `AgentHwPtpTcTests.cpp`. This **maintenance** task streamlines the test suite by eliminating redundant test definitions and cleaning up the codebase. The change has no functional impact on the PTP TC feature, only improving the organization of the hardware test framework.

This commit **removes the redundant test file** `HwSwitchStateReplayTest.cpp` from the **old `HwTest` framework**. This is a **maintenance and cleanup** task, as the test's functionality, specifically the **hardware switch state replay tests**, has been fully migrated to the **new `AgentHwTest` framework** within `AgentSwitchStateReplayTest.cpp`. The change streamlines the **testing infrastructure** by eliminating duplicate test code, ensuring that the `HwTest` framework no longer contains obsolete components while preserving full test coverage.

This commit performs **maintenance** by **removing** the obsolete test file `HwPacketSendTests.cpp` from the old `HwTest` framework. All its hardware packet sending tests, including `LacpPacketReceiveSrcPort` and `ArpRequestFloodTest`, have been fully **migrated** to the new `AgentHwTest` framework, now located in `AgentPacketSendTests.cpp`. This **refactoring** streamlines the **testing infrastructure** by eliminating a redundant component, ensuring that all relevant tests are consolidated within the modern framework and even adding 7 new test cases. The change simplifies the codebase without any loss of test coverage, as all functionality is preserved and enhanced in the new test suite.

This commit **enables Cable Length Measurement (CLM) delay retrieval for Tomahawk5 (TH5) ASICs**, introducing a **new capability** to accurately measure cable propagation delays. It **extends support for the `SAI_PORT_ATTR_CABLE_PROPAGATION_DELAY` attribute** within the **SAI Port API** to Broadcom SDKs version 13.0 and greater on XGS platforms. The **`SaiPortManager`** is updated to incorporate this new data into optics delay calculations for NPU switch types, improving the precision of network timing. This change specifically targets **Tomahawk5 ASICs** and represents the final agent-side work required for this feature.

This commit implements **maintenance fixes** and **configuration updates** to the **MMU (Memory Management Unit) values** for **Tomahawk6 ASICs**. It updates the `SaiBufferManager`'s `getMaxEgressPoolBytes` function to correctly calculate the maximum egress buffer pool bytes based on Tomahawk6 specifications, rather than Tomahawk5. Additionally, the `Tomahawk6Asic`'s `getDefaultReservedBytes` is adjusted to allocate 24 cells for CPU ports, aligning with Broadcom's recommendation, and related TODO comments are removed from `getMMUSizeBytes` and `getDefaultScalingFactor`. This ensures more accurate and efficient **buffer management** and **CPU queue handling** on Tomahawk6-based hardware.

This commit **introduces a new capability** by integrating the **`PacketStreamHandler`** into the agent's Thrift server initialization process. It registers this handler with both the **`MonolithicAgentInitializer`** and **`SplitSwAgentInitializer`** to provide **multiplexed Thrift server support** for processing specific control packets. The feature is controlled by the new `enable_aifm_ctrl_handler` gflag, which is `false` by default, making it an opt-in enhancement. This setup ensures the handler is properly owned as a `shared_ptr` by the initializer and wired into `SwSwitch` for ethertype-based dispatch.

This commit **integrates** the `PacketStreamHandler` into the **`SwSwitch`** to enable **ethertype-based packet dispatch**. It introduces a new dispatch case within `handlePacketImpl()` for `ETHERTYPE_AIFM_CTRL` (0x9999) packets, delegating their processing to the `PacketStreamHandler`. This **new capability** involves adding a raw pointer to `PacketStreamHandler` in `SwSwitch.h` and `SwSwitch.cpp`, along with accessor methods like `setPacketStreamHandler()`, and updating build configurations. The `SwSwitch` does not own the handler, which is instead managed by `AgentInitializer`, facilitating its use with the multiplexed Thrift server.

This commit introduces a **new capability** by implementing `PacketStreamHandler`, a concrete service for **bidirectional packet streaming** within the **FBOSS agent**. This handler facilitates communication between the agent and **external controllers**, managing both the reception of network control packets (via `processReceivedPacket`) and their transmission (via `handlePacket` and a `ServerStream`). It also incorporates **statistics tracking** for packet flow and utilizes a new **EtherType `0x9999`** for packet dispatch, significantly enhancing the agent's ability to interact with external control plane applications.

This commit introduces a **new capability** by adding the `packetSink` method to the **`PacketStream` thrift IDL** in `fboss/agent/if/packet_stream.thrift`. This method enables the **Rx path** for **bidirectional packet streaming**, allowing external controllers to push packets to the **FBOSS agent**. This is a foundational step, representing **Phase 1 of the SidebandHandler implementation**, to facilitate more dynamic network control.