Ruinan Hu

This commit introduces a **configuration update** and **logic enhancement** to standardize controlling port assignments within the **platform mapping system**. It modifies `fboss/lib/platform_mapping_v2/platform_mapping_v2.py` to dynamically enforce that the **first port in a group (e.g., `ethx/x/1`) is always designated as the controlling port** for specific platforms, including Tomahawk6. This new logic, primarily within the `_generate_platform_mapping` function, ensures consistency across various hardware configurations. As a result, generated platform mapping files for `icecube800banw`, `icecube800bc`, and `tahansb800bc` are updated to reflect this standardized controlling port definition, improving predictability and uniformity in port control.

This commit introduces a **platform-specific configuration update** within the **FBOSS agent's SAI platform layer**. It **updates the reported number of available cells** for the `SaiBcmIcecube800bcPlatform` by modifying the `numCellsAvailable` value in `fboss/agent/platforms/sai/SaiBcmIcecube800bcPlatform.h`. This ensures the **Broadcom Icecube800bc platform** accurately reflects its MMU resource capabilities, which is critical for correct resource allocation and system operation on this specific hardware.

This commit **fixes an IP address overlap issue** within the **`HwSplitAgentCallbackTest.txPacket`** test case. It **adjusts the source and destination IP addresses** used in `fboss/agent/hw/test/HwSplitAgentTest.cpp` to prevent them from conflicting with existing interface IPs. This **maintenance fix** ensures the test runs reliably and correctly by eliminating an unstable condition caused by the IP address collision. The change specifically targets the **`fboss` agent's hardware test infrastructure**, improving the robustness of its validation suite.

This commit **fixes** an issue within the **TunManager**'s route and rule processing logic. It modifies the `routeProcessor` and `ruleProcessor` in `fboss/agent/TunManager.cpp` to **gracefully skip** entries associated with reserved Linux route table IDs (0, 253, 254, 255) when 1:1 mapping is enabled. Previously, encountering these reserved IDs would lead to an error, potentially causing instability or crashes in the **network agent**. This **maintenance** change now logs the event and continues processing, thereby **improving the robustness** and reliability of network configuration management by preventing disruptions from unexpected system-reserved table entries.

This commit implements a **bug fix** for the **ECMP load balancing tests** within the **FBOSS agent**, resolving an issue where test traffic IP addresses overlapped with actual interface IPs. Specifically, it updates the source and destination IP ranges used by traffic generation utility functions, such as `pumpTraffic` and `pumpMplsTraffic`, in `fboss/agent/test/utils/LoadBalancerTestUtils.cpp` to dedicated `100.10.xx` and `200.20.xx` subnets. This **test maintenance** ensures the **load balancing tests** execute reliably and accurately by preventing unintended IP conflicts, thereby improving the overall robustness of the testing infrastructure.

This commit provides a **build fix** to resolve **linker errors** encountered during the compilation of the **`prod_invariant_tests`** within the **`fboss/agent/test`** module. Specifically, the `BUCK` file at `fboss/agent/test/prod_invariant_tests/BUCK` was updated to apply necessary linker flags for **additional SAI implementations**. This **maintenance** change addresses an "unfound library" issue that was causing the `invariant_test` to fail on the conveyer node, ensuring these critical tests can now build and execute successfully. The fix prevents build system failures related to missing dependencies for specific SAI components.

This commit **adds support for the Tomahawk Ultra 1 ASIC** by integrating `TomahawkUltra1Asic.cpp` into the `switch_asics` library via `cmake/AgentHwSwitchAsics.cmake`. This change is primarily a **bug fix** to resolve a broken Open Source Software (OSS) build, ensuring the project compiles correctly in an open-source environment. It introduces a **new capability** for hardware interaction, specifically enabling the system to recognize and utilize the **Tomahawk Ultra 1** hardware within the `switch_asics` subsystem.

This commit **fixes** an incorrect ASIC type assignment for the **Minipack3BTA platform** within the FBOSS agent's SAI implementation. It **corrects the platform's ASIC instantiation** by updating `fboss/agent/platforms/sai/SaiBcmMinipack3BTAPlatform.cpp` to use `TomahawkUltra1` instead of the placeholder `Tomahawk5` in the `setupAsic` method. Additionally, the `asic_` member variable type in `fboss/agent/platforms/sai/SaiBcmMinipack3BTAPlatform.h` is adjusted to `TomahawkUltra1Asic`. This ensures the FBOSS agent accurately identifies and interacts with the **TomahawkUltra1 ASIC** on Minipack3BTA hardware, enabling correct platform functionality.

This commit introduces **support for the Broadcom Tomahawk Ultra 1 ASIC** by implementing the new `TomahawkUltra1Asic` class, which defines its specific hardware characteristics and capabilities. It integrates the `ASIC_TYPE_TOMAHAWKULTRA1` enum across various **FBOSS core components**, including configuration, ASIC utility functions, and the hardware abstraction layer, particularly within `SaiBufferManager` for buffer pool calculations. This **new capability** allows FBOSS to properly configure and manage switches equipped with the **Tomahawk Ultra 1 ASIC**, ensuring correct operation, resource allocation, and feature enablement for this specific Broadcom variant. The changes also update numerous **test suites** to account for the new ASIC type, ensuring comprehensive validation.

This commit introduces **support for new hardware platforms**, `ICECUBE800BC` and `ICETEA800BC`, into the **FBOSS agent's production configuration factory**. It **extends the `uplinksCountFromSwitch` function** in `fboss/agent/hw/test/ProdConfigFactory.cpp` to correctly identify these platforms and determine their respective uplink counts. This **new capability** is crucial for ensuring the FBOSS agent can properly initialize and manage these specific switch types in a **production environment**. By adding these platforms, the system can now generate accurate hardware configurations for `ICECUBE800BC` and `ICETEA800BC` devices.

This commit provides a **bug fix** for an exception encountered in **`AgentNeighborTest`** on multi-NPU platforms. The `getNeighborInfo` utility function in `fboss/agent/test/agent_hw_tests/AgentNeighborTests.cpp` was incorrectly calling `HwSwitchMatcher::switchId` when `scope()` returned multiple switch IDs, leading to a C++ exception. The fix modifies `getNeighborInfo` to correctly determine the `switchId` based on the `interfaceId` associated with the neighbor entry, ensuring proper state retrieval directly from the ASIC. This resolves test failures and improves the reliability of neighbor state verification in multi-NPU environments.

This commit introduces a **new feature** to the **FBOSS agent's SAI platform implementation** by adding a **custom BDE parameter** to the SAI profile values. This crucial change, implemented within the `initSaiProfileValues` function in `fboss/agent/platforms/sai/SaiPlatform.cpp`, specifically enables **multi-NPU support** for the `LADAKH800BCLS` platform. By providing this parameter, the agent can now correctly initialize and manage hardware configurations featuring multiple Network Processing Units, enhancing platform compatibility and scalability.

This commit implements a **bug fix** for **Agent hardware mirroring, L4 blackholing, and routing test cases** that were failing due to incorrect IP address assumptions, especially when running in **400G mode**. Previously, test traffic was misrouted because its destination IP addresses (e.g., `201.0.0.x`) collided with more specific routes automatically provisioned by the test framework, leading to unresolved neighbors and packet drops. The fix **updates the source and destination IP addresses** in `AgentL4PortBlackholingTests.cpp`, `AgentRouteTests.cpp`, and `MirrorTestUtils.cpp` to ensure traffic follows the intended forwarding paths. This **maintenance** improves the reliability and accuracy of these critical hardware tests.

This commit **enables temperature monitoring support** for the **Jericho3 ASIC** by updating its `isSupported` feature list within `Jericho3Asic.cpp`. This **new capability** allows the hardware agent to read temperature sensor data from J3 devices. A significant benefit of this change is the **reduced cost** associated with performing these temperature readings, improving the efficiency of environmental monitoring. The update directly impacts the **hardware agent's ability to monitor critical environmental conditions** on Jericho3-based network devices.

This commit performs a **refactoring** of the **FBOSS agent's feature flag management** by **relocating** the `fsdbStatsStreamIntervalSeconds` flag. The declaration and definition for this specific configuration setting are now consolidated within `fboss/agent/AgentFeatures.h` and `fboss/agent/AgentFeatures.cpp` respectively. This change improves the **code organization and consistency** for agent-specific feature flags, ensuring `fsdbStatsStreamIntervalSeconds` is properly managed within the designated feature system. The primary impact is on the **internal structure and maintainability** of the agent's codebase.

This commit **optimizes performance** within the **FBOSS agent's hardware abstraction layer** by significantly **reducing the frequency** of hardware switch temperature readings. Specifically, the `getHwSwitchTemperatureStats` function in `SaiSwitchManager.cpp` will now only execute every 5 seconds. This **performance optimization** addresses the issue where frequent temperature readings, each taking 40ms, were unacceptably impacting **DSF stats collection**. The change improves the overall efficiency and responsiveness of **SAI-based hardware switch management**.

This commit implements a **performance optimization** by **refactoring** the **hardware agent's temperature sensor data collection** to eliminate redundant API calls. Specifically, it ensures the expensive `NumTemperatureSensors` API is called only once per agent lifecycle, rather than repeatedly. This change primarily affects the **SAI switch manager** in `SaiSwitchManager.cpp`, optimizing functions like `fillHwSwitchTemperatureStats` and `getHwSwitchTemperatureStats`. By **reducing CPU overhead** from duplicated calls, this work significantly **improves the efficiency of hardware statistics collection**, aligning its cost more accurately with the underlying SAI API operations.

This commit introduces a **new feature** to the `fboss/agent` component, enabling a **1-to-1 mapping from interface ID to route table ID**. A new flag, `enable_1to1_intf_route_table_mapping`, controls this behavior, allowing the system to use a direct mapping when true, or fall back to the existing calculation logic otherwise. This update modifies the **table ID calculation and validation logic** within `TunManager.cpp`, specifically impacting the `getTableIdForNpu` function and the `routeProcessor` and `ruleProcessor` modules. This enhancement provides greater flexibility in network configuration and simplifies table ID management for specific deployment scenarios.

This commit **enables temperature monitoring** for the **Jericho3Asic** (J3) hardware platform. It updates the `Jericho3Asic.cpp` file to include `TEMPERATURE_MONITORING` in the list of features supported by the ASIC, specifically within the `isSupported` method. This **new capability** allows the system to read and report temperature data from J3 devices, enhancing hardware health monitoring and diagnostics. The change is a **feature enablement** that expands the diagnostic capabilities for J3 platforms.

This commit introduces a **new capability** to the **FBOSS agent's `TunManager`** by **expanding the permissible range for route table IDs**. It modifies the `getTableId` function in `fboss/agent/TunManager.cpp` to incorporate new constants, allowing for a larger maximum table ID. Specifically, the system can now support route table IDs up to 4096, which is necessary to cover an interface ID range of 4000. This enhancement is conditionally enabled via a **feature flag**, providing flexibility and controlled rollout for supporting a greater number of routing contexts.