Ramanpreet Nara

This commit introduces a **security fix** by adding robust content validation for module names within the **React Native codegen** for **Android**. It prevents potential **Java code injection** by ensuring that module names passed to `throwIfIncorrectModuleRegistryCallArgument` adhere to a safe identifier pattern (alphanumeric and underscores). A new error class, `IncorrectModuleRegistryCallArgumentValueParserError`, is now thrown when an unsafe module name is detected, improving the **security and reliability** of generated code. This **maintenance improvement** enhances the integrity of generated Android code by catching invalid module names early during parsing.

This commit performs a **refactoring** within the **React Native TurboModule system's JSI binding installation** on **Android**. The external function `installJSIBindings` in `TurboModuleManager.kt` and its native C++ counterpart are renamed to `dispatchJSBindingInstall` to better reflect its role as a dispatcher. Concurrently, a new internal helper function, also named `installJSBindings`, is introduced in `TurboModuleManager.cpp` and `.h` to encapsulate the actual JSI binding logic. This change enhances **code clarity and consistency** by aligning the naming convention with iOS's behavior, where the original name implied JS thread execution, improving the maintainability of the **TurboModule core**.

This commit introduces a **refactoring** to the **TurboModule system's binding mechanism** by modifying `TurboModuleBinding` to accept a new provider function type, `TurboModuleProviderFunctionTypeWithRuntime`, which explicitly includes a `jsi::Runtime` parameter. This **architectural improvement** allows the system to stop capturing the runtime pointer within providers, leading to cleaner memory management and reducing potential for issues. The changes primarily affect the `TurboModuleBinding` and `BridgelessNativeModuleProxy` components, enhancing the robustness of **React Native's native module instantiation**. This **internal optimization** ensures that `jsi::Runtime` is passed directly, improving the overall design of TurboModule providers.

This commit performs a **refactoring** within the **React Native Android JSI layer**, specifically targeting the **TurboModuleManager** to streamline the installation of JSI bindings. It **cleans up parameter passing** by removing the `runtimeExecutor` from the `TurboModuleManager` constructor and the `initHybrid` method. Instead, the `runtimeExecutor` is now passed directly to the `installJSIBindings` function, where it is exclusively utilized. This change improves the internal architecture and **dependency management** for JSI binding installation, enhancing code clarity and maintainability.

This commit performs a **refactoring** within the **React Native native module core** by making the `TurboModuleBinding` class constructor private. This change **restricts direct instantiation** of `TurboModuleBinding` objects, ensuring they are only created through controlled internal mechanisms like `BridgelessTurboModuleProxy` or `TurboModuleBinding::install`. Consequently, the `BridgelessNativeModuleProxy` implementation was updated to correctly handle this new encapsulation, utilizing `std::optional` for its `legacyBinding_` member. This **maintenance** effort improves the **encapsulation and maintainability** of the native module system, preventing unintended external construction and enforcing proper object lifecycle management.

This commit introduces a significant **refactoring** within the **Android TurboModule system** to streamline how the legacy module interop feature flag is handled. It centralizes the reading of the `shouldEnableLegacyModuleInterop` flag directly within the `TurboModuleManager` and its related components, eliminating the need for callers to explicitly pass this boolean. This change simplifies the API of `installJSIBindings` by removing a redundant parameter and removes the `unstable_shouldEnableLegacyModuleInterop` method from `ReactPackageTurboModuleManagerDelegate.kt`. This **breaking change** improves the internal consistency and maintainability of the **TurboModule initialization process** on **Android**.

This commit **refactors** the **TurboModule system** to prevent the storage of raw `jsi::Runtime` pointers within provider functions, which is a discouraged practice. Instead, the `jsi::Runtime` is now passed by reference directly to the `createTurboModuleProvider` and `createLegacyModuleProvider` lambdas, improving memory safety and discouraging stale references. This change **deprecates** `TurboModuleProviderFunctionType` and an overload of the `install` method in `TurboModuleBinding.h`, guiding developers to use the new `TurboModuleProviderFunctionTypeWithRuntime` pattern. The **React Native Android and iOS platforms** are affected, specifically how **TurboModule providers** are created and installed within `TurboModuleManager` and `RCTTurboModuleManager`. This **maintenance** effort promotes a more robust and safer way of interacting with the JavaScript runtime.

This commit provides a **bug fix** for **React Native Android**, preventing **JNI aborts** that occurred when **TurboModule** or **LegacyModule** creation threw an exception. The issue stemmed from `fbjni`'s handling of `std::string` arguments, where temporary `local_ref<JString>` objects were destroyed while a JNI exception was pending, violating JNI rules and causing crashes. The fix involves **pre-converting string arguments to `jstring`** before the JNI method call in `TurboModuleManager.cpp`, specifically for `getTurboJavaModule` and `getLegacyJavaModule`. This ensures the `jstring`'s lifetime extends past the exception check, resolving a critical stability problem in the **Android JNI layer** related to module instantiation.

This commit introduces a **bug fix** to the **Android React Native integration**, specifically within the `ReactDelegate` component. It corrects the behavior of the `onBackPressed` method, ensuring it now returns an accurate boolean status. Previously, the method might have returned an incorrect status when the React Native instance was invalid; this change ensures `onBackPressed` correctly returns `false` in such scenarios, indicating that the back press event was **not handled by React Native**. This improvement prevents potential issues with system-level back press handling and ensures proper event propagation when the React Native context is not active.

This commit **refactors** the **native module lookup logic** within React Native's **TurboModuleRegistry**. It **simplifies** the `requireModule` function in `TurboModuleRegistry.js` by **removing obsolete conditional checks** that were previously used for internal rollout flags. This **maintenance** task cleans up temporary global flags, reducing code complexity and improving readability. The change is purely **internal**, streamlining the core C++ module loading mechanism without impacting external API behavior or developer-facing functionality.

This commit performs **maintenance** by **removing the legacy validation warning infrastructure**, which is no longer needed following the deprecation of associated **legacy architecture classes**. This change streamlines the codebase by eliminating obsolete components, preparing for their complete removal in a future major release. The work contributes to the ongoing **modernization of the core architecture** by cleaning up outdated systems.

This commit performs a significant **refactoring** by **consolidating conditional compilation macros** across the React Native codebase. It replaces various legacy removal flags, such as `RCT_FIT_RM_OLD_COMPONENT` and `RCT_FIT_RM_OLD_RUNTIME`, with a single, unified macro: `RCT_REMOVE_LEGACY_ARCH`. This change impacts numerous core **React Native modules**, including **Image**, **Text**, **Wrapper** components, and the underlying **runtime** and **bridge** implementations on both iOS and Android. The nature of this **maintenance** work is to streamline the process of removing legacy architecture code, ensuring all related components can be compiled out using a single, consistent flag, which simplifies future migration efforts.

This commit **deprecates several legacy JavaScript APIs** within the React Native framework by adding `@deprecated` annotations to their respective files. Specifically, it targets components related to the **BatchedBridge** (e.g., `BatchedBridge.js`, `MessageQueue.js`) and **JSTimers** (`JSTimers.js`, `NativeTiming.js`, `immediateShim.js`). This **maintenance** and **refactoring** effort signals that these APIs are no longer recommended for use, guiding developers away from outdated parts of the architecture. The deprecation marks these interfaces for eventual removal, ensuring a cleaner and more modern codebase in future releases.

This commit **deprecates a substantial set of C++ core classes and functions** across React Native's `ReactAndroid` and `ReactCommon` modules. This **refactoring** effort targets legacy components, such as `CatalystInstanceImpl`, `NativeToJsBridge`, and various `Executor` implementations, that are no longer used by the project's **new architecture** or its interop layer. By marking these components as deprecated, the change aims to **modernize the codebase**, reduce technical debt, and guide future development towards the new architectural paradigms. This prepares the project for the eventual removal of these legacy C++ elements, without introducing immediate functional changes beyond deprecation warnings.

This commit **deprecates a comprehensive set of legacy iOS native components** within React Native, spanning modules such as **Image**, **Text** (including `TextInput`), **Wrapper**, and various core **View** components like `RCTActivityIndicatorView` and `RCTScrollView`. This significant **refactoring** and **maintenance** effort marks these components as obsolete, as they now have modern, equivalent implementations within the **Fabric architecture**. The change is a crucial preparatory step for their eventual removal, guiding developers to transition to Fabric-compatible replacements and thereby advancing the **React Native iOS rendering pipeline**.

This commit **deprecates a substantial set of legacy Objective-C core classes, protocols, and functions** within the **React Native iOS codebase**. This **refactoring** effort aims to signal that these components are no longer recommended for use, particularly as the project transitions towards the **new architecture** and modern interop mechanisms. Key components affected include various initializers and methods in `RCTBridge` and `RCTBridgeDelegate`, core UI components like `RCTRootView` and `RCTSurface`, JavaScript execution interfaces such as `RCTJavaScriptExecutor`, and several C++ bridge utilities like `RCTNativeModule`. By marking these APIs as deprecated, the commit guides developers away from outdated patterns, **streamlining the codebase** and preparing for their eventual removal, which is crucial for the ongoing **modernization of React Native's iOS platform**.

This commit introduces a **bug fix** to the **iOS TurboModule infrastructure**, specifically addressing a critical concurrency issue within native modules. It prevents null pointer exceptions that could occur when `resolve` or `reject` methods are called concurrently on a promise. By implementing mutex-based synchronization within the `createPromise` method in `RCTTurboModule.mm`, this change ensures robust handling of promise resolutions and rejections. This significantly improves the **stability and reliability** of **iOS native modules** by preventing crashes under concurrent execution scenarios.

This commit **enhances error logging** for **native modules** by ensuring that the specific rejection message is displayed in the RedBox when a promise is redundantly rejected or resolved. This **developer experience improvement**, implemented within `RCTTurboModule.mm` for the **iOS platform**, provides critical context for debugging. By surfacing the actual error message from redundant promise operations, particularly those involving `createPromise`, developers can more effectively identify and resolve underlying issues, leading to **improved debugging efficiency** and **production stability**.

This commit performs a significant **refactoring** within the **React Native core** by preparing for the removal of numerous **legacy UI components** and their associated native infrastructure. It wraps a wide array of files related to **Image**, **Text**, **TextInput**, **Wrapper**, and various **core UI components** (e.g., `ActivityIndicator`, `Modal`, `Switch`, `RefreshControl`, `SafeAreaView`, `ScrollView`) in conditional compilation blocks. This change effectively disables these components unless a specific build flag is enabled, serving as a crucial step towards their eventual complete deletion from the framework. The goal is to streamline the codebase and reduce its footprint, which will require consumers to migrate to modern component implementations.

This commit performs a **refactoring** to **decouple** the `RCTBridgeProxy` from the **legacy UI manager** within the React Native framework. It extracts the `paperViewOrCurrentView` logic from a class method in `RCTUIManager` into a new global function, `RCTPaperViewOrCurrentView`. This change updates `RCTBridgeProxy.mm` to call the new global function, thereby removing its direct dependency on the `RCTUIManager` class. This is a crucial step in preparing for the future **removal of the legacy UI manager**, ensuring that the `RCTBridgeProxy` can persist without it.