Roman Choporov

This commit **introduces a critical configuration file**, `fboss/platform/configs/blackwolf800banw/led_manager.json`, for the **LED manager** on the `blackwolf800banw` platform. This new file defines essential system and FRU LED paths, along with presence detection settings. Its addition is a **critical configuration update** that directly **unblocks the bring-up of the `data_corral_service`**, which previously crashed due to the absence of this required configuration. This ensures the stability and proper functioning of LED management and dependent platform services.

This commit performs a **maintenance update** by **bumping the BSP kmods RPM version** for the **Blackwolf800banw platform**. It specifically updates the `platform_manager.json` configuration to reference BSP kernel modules version `0.7.19-1` instead of `0.7.18-1`. This ensures the **platform manager** for Blackwolf800banw utilizes the latest **Board Support Package** components, which may include critical bug fixes, performance improvements, or new hardware support. The change is confined to the **platform configuration** for this specific hardware variant.

This commit **increases the `kMaxSetupTime` constant** within the `PlatformExplorer` module from 45 seconds to 48 seconds. This change is a **bug fix** aimed at **reducing flakiness** in the platform manager's hardware tests, specifically for the **meru800bfa platform**. By extending the maximum allowed setup time, it prevents test failures where platform exploration occasionally exceeds the previous limit, thereby unblocking conveyor runs and improving test stability for this hardware.

This commit **refactors** the **LED name validation logic** within the **BSP testing framework**, specifically in `fboss/platform/bsp_tests/LedTests.cpp`. The change makes the validation more generic by removing specific regex patterns for different LED types, such as port or fan LEDs. Instead, it now **enforces a universal requirement for 1-based integer indexing** in all LED names, aligning with the platform's LED driver development specification. This **maintenance** update improves the robustness and consistency of LED configuration validation across various hardware platforms and ensures compliance for future **LED driver development** and **platform BSPs**.

This commit provides a **bug fix** and **test improvement** for the **GPIO testing framework** in `fboss/platform/bsp_tests`. It modifies the `GpioTest.GpioCreated` test to **dynamically detect new GPIO devices**, removing reliance on hardcoded names for increased robustness. Furthermore, it **corrects the usage of `gpioget`** by ensuring it is only applied to input lines, aligning with its intended functionality. This change improves the accuracy and reliability of GPIO device creation and input line testing, though testing of output lines remains a known limitation due to tool capabilities.

This commit introduces a **temporary workaround** within the **platform manager's error reporting** to classify specific `IDPROM_READ` failures as expected errors. It modifies `fboss/platform/platform_manager/ExplorationSummary.cpp` to use `addError` to mark `IDPROM_READ` issues on **MONTBLANC, JANGA800BIC, and TAHAN800BC platforms** as non-critical. This **maintenance change** prevents these known, platform-specific failures from being flagged as unexpected, streamlining error monitoring. The scope is limited to these specific platforms and error types, providing a temporary adjustment to error classification. This modification is explicitly temporary and will be reverted once the underlying `IDPROM_READ` problem is permanently resolved.

This commit **refactors** the **BSP test framework** to **defer the initialization of the `RuntimeEnvironment`** within `BspTestEnvironment`. Previously, platform-specific configurations were loaded unconditionally, leading to errors when test binaries were invoked on non-platform systems or for operations like `gtest_list_tests`. Now, the initialization is moved to the `SetUp` method, making it optional and configurable via command-line flags, thus **preventing premature execution of platform-specific code**. This change improves the **robustness and portability** of the **BSP test suite** by ensuring platform-dependent logic is only executed during actual test runs.

This commit **reverts** a prior change, effectively **re-adding** the `MCB_IOB_I2C_MASTER_10` configuration to the `platform_manager.json` file for the **morgan800cc platform**. This **maintenance** action is a critical **bug fix** aimed at **unblocking forwarding stack qualification**, which was previously impeded by the removal of this specific I2C master setup. By restoring this essential **platform configuration**, the commit ensures the proper functioning and validation of the forwarding stack.

Add bsp_tests to fboss_platform_services

This commit provides a **bug fix** to the **CMake build configuration** by addressing a missing library linkage for the `bsp_test_environment` target. Specifically, it modifies `cmake/PlatformBspTests.cmake` to explicitly link the `platform_manager_utils` library, which was previously omitted. This **maintenance** change ensures that the `bsp_test_environment` can be built and executed correctly, resolving potential compilation errors or runtime issues caused by the unresolved dependency.

This commit **updates the project documentation** to formally recognize and integrate the **`platform_hw_test`** binary across various guides. Specifically, it adds `platform_hw_test` to the list of commands to run for platform services in `add_initial_support_for_platform_services.md`, includes it in the current hardware tests for platform services in `Testing_Platform_Services.md`, and categorizes it under Platform Services in `test_categories.md`. This **documentation update** ensures users and developers are informed about this tool for **early hardware issue detection** within the **platform services** subsystem. The work is a **documentation maintenance** task to reflect an important testing capability.

This commit **introduces build system support** for the new `platform_hw_test` component, marking a significant step towards its open-sourcing. It **adds CMake configuration** within `cmake/PlatformPlatformHwTest.cmake` to enable the proper compilation and linking of the `platform_hw_test` executable and its dependencies. This **new capability** ensures that the `platform_hw_test` module can be seamlessly integrated and built, facilitating its use for **platform hardware testing** within the project.

This commit **implements a new gtest**, `PCIDevicesPresent`, within the **`platform_hw_test`** suite to enhance hardware validation. This **new test** verifies that all **PCI devices** specified in the `platform_manager` configuration are correctly detected and present on the physical hardware. It ensures consistency between the expected and actual PCI device availability, improving the reliability of platform deployments. The `BUCK` file was updated to include necessary build dependencies for this new test.

This commit **implements a new platform hardware test** within the `fboss/platform/platform_hw_test` module. A **new Google Test**, `PlatformHwTest.CorrectMacX86`, is introduced to specifically verify that the `eth0` MAC address on the system correctly matches the MAC address provisioned in the **EEPROM**. This **new capability** enhances the **platform's hardware validation** by ensuring critical network interface configuration is accurate, improving system reliability and provisioning correctness. The `BUCK` file was updated to include the build target for this new test binary.

This commit **fixes a critical bug** in the **`fboss/platform/fan_service`** by **refactoring the watchdog handling** within the `Bsp` component. Previously, the watchdog file descriptor was repeatedly opened and closed, inadvertently disarming the watchdog and potentially leading to system instability. Now, the file descriptor is persistently kept open for the entire service cycle, ensuring the **watchdog remains active** and properly monitors the system. This **maintenance improvement** introduces a new `closeWatchdog` function and an optional `watchdogFd_` member in `Bsp.h` to manage the persistent file descriptor, preventing unexpected system behavior.

This commit introduces a **new capability** to **publish hardware versions** for **CHASSIS EEPROMs** that are not modeled as IDPROMs. It enhances the **platform management subsystem** by adding an `isEeprom` flag to the `I2cDeviceConfig` schema and updating `PlatformExplorer.cpp` to explore and generate human-readable content for these newly identified I2C EEPROM devices. This **feature** allows for more comprehensive hardware version reporting, improving **hardware inventory and monitoring** across various platforms by explicitly configuring relevant chassis EEPROMs in their respective `platform_manager.json` files.

This commit introduces a **new capability** to the **FbossEepromInterface** within the **weutil** platform utility, enabling direct loading and parsing of EEPROM data. A new constructor, `FbossEepromInterface(eepromPath, offset)`, is implemented to read EEPROM content from a specified file path and offset, populating the interface structure. This functionality is supported by a newly added **ParserUtils** module, which provides static helper functions for loading raw EEPROM data and parsing various data types like UINT, HEX, String, MAC, and Date, along with CRC16 calculation. This enhancement streamlines the process of interpreting EEPROM blobs, making the `FbossEepromInterface` more robust and easier to initialize from raw data sources.

This commit **removes** the `FbossEepromParser` component from the codebase, effectively annihilating its presence. This **maintenance** task streamlines the **FBOSS system's EEPROM parsing functionality** by eliminating a dedicated parsing utility. The removal likely targets an unused or deprecated module, contributing to code simplification and reducing future maintenance overhead for EEPROM-related operations within FBOSS.

This commit **refactors** the **`FbossEepromInterface`** by removing the `getFieldDictionary()` method, which was previously used to return a map of EEPROM field entries. This method is no longer required, and its removal simplifies the codebase by eliminating unused code. The change involves deleting both the declaration of `getFieldDictionary()` from `FbossEepromInterface.h` and its implementation from `FbossEepromInterface.cpp`. This **maintenance** task does not alter any existing functionality, but rather streamlines the interface and reduces code complexity for the `FbossEepromInterface` module.

This commit performs a **refactoring** by **renaming** the `fboss_eeprom_parser` library to `fboss_eeprom_interface` within the **FBOSS CMake build system**. Specifically, it updates the library target definition in `PlatformWeutil.cmake` from `weutil_fboss_eeprom_parser` to `weutil_fboss_eeprom_interface` and adjusts its linking dependencies. The `PlatformPlatformManager.cmake` file is also updated to reflect this new name in its `target_link_libraries` directives, ensuring correct build configurations. This change is purely a **maintenance** rename to improve clarity and does not introduce any functional modifications to the EEPROM parsing or interface logic.