Robert Phillips

This commit introduces **three new Android-specific precompile `PaintOptions`** to the **Graphite rendering backend**, which now explicitly utilize an **SRGB working colorspace**. This **enhancement** addresses a potential bug (b/496028724) by ensuring correct color space handling for precompiled rendering pipelines on Android. The changes involve adding the new options in `tests/graphite/precompile/AndroidPaintOptions.cpp` and updating `tests/graphite/precompile/AndroidPrecompileTest.cpp` with corresponding pipeline labels. This update likely renders the previous non-SRGB Android `PaintOptions` redundant, improving the accuracy and consistency of color rendering for Android-specific precompiled assets.

This commit **reverts** a previous change that aimed to improve the readability and add documentation to the **`SkCpu` module**. Specifically, it undoes the detailed comments, constant definition simplifications, and streamlined CPU feature detection logic for x86 and LOONGARCH architectures within `src/core/SkCpu.cpp`. This **rollback** also restores the minor stylistic change in `src/core/SkCpu.h`. The revert was performed as a **critical maintenance action** to unblock a Chrome roll, temporarily sacrificing the readability improvements for project progression.

This commit **disables two specific tests**, `ThreadedPipelinePrecompileTest` and `ThreadedPipelinePrecompilePurgingTest`, within the **test infrastructure** for the `Graphite_Dawn_GLES` configuration. This **maintenance fix** addresses recent test failures that began occurring after a Dawn roll, preventing continuous integration breaks. By adding skip rules to `infra/bots/gen_tasks_logic/dm_flags.go`, the commit ensures stability in the build system. The immediate impact is that these **threaded pipeline precompilation tests** will no longer execute on this specific graphics backend and platform combination until the underlying issue is resolved.

This commit performs **maintenance cleanup** by **deleting three persistently failing sanitizer jobs**: `DDL3_TSAN`, `ASAN_Vulkan`, and `TSAN_Vulkan`. These jobs, which were intended for **ThreadSanitizer (TSAN)** and **AddressSanitizer (ASAN)** testing, have been consistently failing due to internal errors, driver races, or incomplete execution, providing no useful feedback. The removal of these unreliable tests **streamlines the CI/CD pipeline**, reduces wasted compute cycles, and improves the overall signal-to-noise ratio of the **testing infrastructure**. This change specifically impacts the **graphics testing subsystem**, particularly for **Vulkan**-related sanitizer checks, by removing non-contributing test configurations.

This commit performs **maintenance** by **removing all Vulkan jobs** specifically configured for the `AlphaR2/RadeonR9M470X` platform. These jobs were consistently failing, indicating that the **Vulkan driver is not viable** on this particular hardware setup. The change **streamlines the CI/CD pipeline** by eliminating persistent, unresolvable failures, thereby improving the reliability and signal-to-noise ratio of test results for other configurations. This prevents unnecessary resource consumption and false-positive alerts from a non-functional test configuration.

This commit primarily **fixes an infrastructure configuration issue** by **correcting the name of an Android Graphite Vulkan HWASAN job** within the `infra/bots/jobs.json` file. The previous incomplete naming prevented this critical **testing job** from running, and this update ensures its proper execution within the **Skia build system**. Additionally, a **skip rule** is introduced in `infra/bots/gen_tasks_logic/dm_flags.go` for the `SkSLMatrixToVectorCast_Graphite` test on Adreno618 GPUs under Vulkan and Graphite, likely to prevent failures in the newly enabled job. This **maintenance** work ensures the stability and completeness of the **Android Graphite testing pipeline**.

This commit implements a **maintenance fix** to prevent **failing 'image' tests** on the **Mac15 platform**. It **excludes large BMP images** from being processed by these tests, extending a conditional check in the **testing infrastructure**'s `infra/bots/gen_tasks_logic/dm_flags.go` file. This change ensures test stability on Mac15 by mirroring an existing exclusion previously applied only to Mac14. The update prevents unnecessary test failures and maintains the integrity of the image testing suite.

This commit introduces a **maintenance update** to the Skia infrastructure, specifically modifying the `dm_flags.go` configuration. It **disables two unit tests**, `PersistentPipelineStorageTest` and `NotifyInUseTestLayer`, when executed on **Windows 11** with the **Graphite_Native_Vulkan** backend on **Intel Iris 540 GPUs**. This change acts as a **workaround for known bugs** (b/462240488, b/485241813) that cause these tests to fail on this specific hardware and OS combination. The primary impact is to **improve CI stability** by preventing these failing tests from blocking builds on the affected platform.

This commit introduces a **conditional skip** for **Compute sampling unit tests** within the Skia **infrastructure bot logic**. Specifically, it **disables** these tests when executed on **Windows 11** using the **Graphite_Dawn_Vulkan** backend on **Intel Iris 540 GPUs**. This **bug fix** prevents **access violations** and crashes that were occurring during test runs on this particular hardware and software configuration. The change, implemented in `infra/bots/gen_tasks_logic/dm_flags.go` via the `dmFlags` symbol, ensures the stability of the **CI/CD pipeline** by avoiding known test failures.

This commit **reverts** a prior change that removed bespoke `CLZ` and `CTZ` implementations, as it **broke compilation on some bots**. It **reintroduces** the portable and platform-specific `SkCLZ` and `SkCTZ` functions within `src/base/SkMathPriv.h`, restoring essential **math utility functions**. To ensure the restored functionality is correct and performant, **new benchmarks** (`CLZBench`, `CTZBench`) are added to `bench/MathBench.cpp` and **new test cases** (`test_clz`, `test_ctz`) are introduced in `tests/MathTest.cpp`. This **bug fix** is crucial for maintaining build stability and providing robust math operations across all supported platforms.

This commit introduces initial support for **YCbCr combination methods** within the **Graphite pipeline**, specifically targeting **Android Pixel8 Pipeline labels**. It adds a **new test file**, `AndroidYCbCrPrecompileTest.cpp`, to verify precompile settings for various HDR/SDR image processing cases related to YCbCr. As part of this **maintenance** effort, the **precompile test utilities** in `PrecompileTestUtils.cpp` and `PrecompileTestUtils.h` are **refactored** to enable checking for full label coverage rather than percentage-based coverage. This lays the groundwork for future YCbCr generalization to other Pixel devices and resolves initial Android-specific settings.

This commit **refactors the Graphite precompilation testing framework** by extracting common utilities from `AndroidPrecompileTest.cpp` into new `PrecompileTestUtils.h` and `PrecompileTestUtils.cpp` files. This significantly improves the modularity and extensibility of the **precompilation tests**, enabling easier splitting of tests across multiple files and updating existing tests like `ChromePrecompileTest.cpp` to use the new `RunTest` signature. Additionally, it includes a **bug fix** in the **Mouri tonemap shader** within `AndroidRuntimeEffectManager.cpp`, resolving an issue where a texture access was incorrectly optimized away, leading to improper color mapping selection. This work enhances the maintainability of the testing infrastructure and corrects a specific rendering artifact.

This commit provides a **bug fix** for the **Graphite Vulkan backend**, specifically addressing an issue within the **Ycbcr conversion** logic. It corrects the bit shift assignments for the `kComponentBMask` and `kComponentGMask` constants in `src/gpu/graphite/vk/VulkanYcbcrConversion.cpp`. This ensures that `VulkanYcbcrConversionInfo` objects correctly round-trip when converted to and from `ImmutableSamplerInfo`. The fix resolves a problem observed during debugging of Android external file format handling, which was preventing proper conversion of Ycbcr information.

This commit introduces **three new Android-specific `PaintOptions`** to the **Graphite rendering pipeline**, enabling new rendering configurations for the platform. This **new capability** is supported by adding corresponding **pipeline labels** within the **Graphite precompilation system**, ensuring these options are correctly processed. The changes include new test cases in `tests/graphite/precompile/AndroidPaintOptions.cpp` and updates to `tests/graphite/precompile/AndroidPrecompileTest.cpp` to validate the new labels. Additionally, a minor **refactoring** was performed in `src/gpu/vk/VulkanUtilsPriv.cpp` to adjust a debug assertion.

This commit performs a **maintenance update** to **Skia's Graphite precompile testing framework** by aligning its `LinearEffect` SkSL stub with Android's updated implementation. Specifically, it **removes redundant sRGB conversions** from the generated GLSL code for `LinearEffect` within `AndroidRuntimeEffectManager::getOrCreateLinearRuntimeEffect`. This **bug fix** (b/465255225) ensures consistency between Skia's internal representation and Android's behavior, which had already removed these conversions. The `LinearEffect` test helper in `tests/graphite/precompile/AndroidPaintOptions.cpp` is also updated to support specifying a working color space, and expected pipeline label strings are adjusted in `AndroidPrecompileTest.cpp`. This change is crucial for correctly recreating `Pipeline` labels in subsequent development.

This commit **refactors** the **Graphite Vulkan backend's** YCbCr image handling by making the `vulkan_ycbcr_image_shader` function more explicit in its parameter requirements. The function now directly accepts `VulkanYcbcrConversionInfo` and `SkColorInfo` objects, enhancing the clarity and completeness of YCbCr conversion details within the **shader precompilation** system. A new helper function, `ycbcr_info`, was introduced to facilitate the conversion of existing data into the comprehensive `VulkanYcbcrConversionInfo` structure. This **preparatory work** is essential for supporting **new Android image drawing capabilities** that will require more detailed YCbCr parameter specification.

This commit **refactors** the `LinearEffect` helper within **Android's Graphite precompile shaders** to directly accept `PrecompileShader` objects, moving away from an enum-based selection. This **enhancement** is critical for enabling future **Vulkan YCbCr precompile shaders** to support arbitrary external formats, as a predefined set of child shaders is no longer viable. A new helper, `create_hw_image_precompile_shader`, is also introduced to manage hardware image shaders, primarily impacting the `tests/graphite/precompile/AndroidPaintOptions.cpp` test suite.

This commit implements a **temporary workaround** to improve the stability of **Windows 11 CI jobs**. It **skips specific failing tests** on configurations involving **IntelIrisXe, RadeonVega8, and IntelHD4400 GPUs** by adding new skip rules within the `dmFlags` function in `infra/bots/gen_tasks_logic/dm_flags.go`. This **maintenance change** prevents known test failures from blocking the build, ensuring the continuous integration pipeline remains unblocked while the root causes of the test failures are investigated. The affected tests will no longer execute on these specific Windows 11 hardware setups.

This commit **updates Skia's `AndroidRuntimeEffectManager` shim** within the **Graphite precompile system**, primarily focusing on **feature enhancement and refactoring**. It **updates** the `RuntimeEffectManager` to include **new runtime effect definitions**, **refactors its initialization** using a macro, and **adds support for a new `Dataspace` type**. This streamlines how known runtime effects are declared and accessed, improving the system's adaptability for future effect additions. Concurrently, the `AndroidPrecompileTest.cpp` is updated to **remove references to obsolete Kawase blur effects**, ensuring the tests align with the current effect management.

This commit implements a **bug fix** for a **memory lifetime issue** within the **Graphite GPU backend's Vulkan implementation**. It addresses premature deallocation of `cachedData` during the `createPipelineCache` operation in `src/gpu/graphite/vk/VulkanSharedContext.cpp`. By adjusting the declaration of `cachedData` to extend its lifetime, this change ensures stable and correct **Vulkan pipeline cache creation**. This prevents potential crashes or undefined behavior related to memory management, improving the overall robustness of the graphics pipeline.