Prashasthi Melanta

This commit performs a **cleanup** by **removing the now-empty test file** `HwAclStatTests.cpp` from the codebase. All tests related to **Hardware ACL statistics** were previously migrated to `AgentHwAclStatTests.cpp`, rendering the original file redundant. This **maintenance** task streamlines the **test infrastructure** by eliminating dead code and also updates the **build configuration** by removing the corresponding BUCK reference. The change improves code hygiene and reduces build complexity without impacting any functional aspects of the system.

This commit **enhances** the **FBOSS agent's hardware tests** by adding comprehensive **ACL stat count verification**. It introduces detailed checks to the `AclStatMultipleActions`, `AclStatDelete`, and `AclStatCreatePostWarmBoot` tests, ensuring accurate reporting of ACL statistics. This **test enhancement** improves the reliability and coverage of the **ACL subsystem**, particularly for scenarios involving multiple actions, deletions, and warm boot operations, by verifying expected stat counts in `fboss/agent/test/agent_hw_tests/AgentHwAclStatTests.cpp`.

This commit **migrates** the `StatNumberOfCounters` test case, responsible for verifying ACL statistics, from `HwAclStatTests.cpp` to `AgentHwAclStatTests.cpp`. This **refactoring** consolidates **ACL statistics testing** within the agent hardware test suite, ensuring more robust and accurate validation. The updated test now dynamically resolves `SwitchID` via `scopeResolver()` and maintains full verification parity with `getDefaultAclTableStatCountInfo()` and `isStatProgrammedInDefaultAclTable()`. This change improves the reliability of **agent hardware tests** for ACL stat programming by centralizing relevant test logic and enhancing its adaptability.

This commit **migrates the `AclStatShuffle` hardware test case** from `HwAclStatTests.cpp` to `AgentHwAclStatTests.cpp`, significantly enhancing the **FBOSS agent's hardware test coverage** for **ACL statistics**. The **test migration** ensures that changes in Access Control List (ACL) entry order correctly preserve associated statistics programmed in the hardware. By utilizing dynamic `SwitchID` resolution and verifying full parity with existing stat count and programming checks, this work strengthens the validation of **ACL stat programming** robustness within the agent's dedicated hardware test suite.

This commit **migrates** the `AclStatRenameShared` test case from `HwAclStatTests.cpp` to `AgentHwAclStatTests.cpp`, integrating it into the **Agent hardware test suite**. This **test migration** ensures that the verification of **shared ACL stat renaming** is performed within the correct Agent context. The updated test now leverages a **dynamic `SwitchID`** via `scopeResolver()` and performs a full verification parity using `getDefaultAclTableStatCountInfo()` and `isStatProgrammedInDefaultAclTable()`. This **enhances the robustness** of **ACL stat testing** by confirming that `acl0` correctly retains `stat0` while `acl1` receives `stat1` after a rename operation.

This commit **migrates** the `AclStatRename` test case to `AgentHwAclStatTests.cpp`, significantly enhancing the **agent hardware test suite** for **ACL stat management**. This **test migration** ensures comprehensive verification of **ACL stat renaming functionality** by dynamically resolving `SwitchID` and performing full parity checks with `getDefaultAclTableStatCountInfo()` and `isStatProgrammedInDefaultAclTable()`. The test now explicitly verifies that the new stat is correctly programmed and the old stat is deleted, improving the robustness of **ACL stat management** within the FBOSS agent.

This commit **migrates** the `AclStatDeleteShared` test case to the **agent hardware test** framework by moving it into `AgentHwAclStatTests.cpp`. This **maintenance** effort enhances the testing of **ACL statistics** deletion, specifically for shared ACLs, ensuring robust behavior within the agent's control plane. The updated test leverages dynamic `SwitchID` resolution and performs comprehensive verification of ACL table stat counts and programming status, confirming that deleting one shared ACL correctly leaves others intact.

This commit **migrates** the `AclStatCreateSharedPostWarmBoot` test case to `AgentHwAclStatTests.cpp`, specifically verifying the creation of **shared ACL statistics after a warm boot**. This **test migration and enhancement** for the **FBOSS agent hardware environment** ensures comprehensive validation of ACL stat programming. It achieves full verification parity using methods like `getDefaultAclTableStatCountInfo()` and `isStatProgrammedInDefaultAclTable()`, and dynamically resolves `SwitchID` via `scopeResolver()`. This improves the **reliability and coverage** of warm boot tests for the **ACL statistics subsystem**.

This commit **migrates** the `AclStatDeleteSharedPostWarmBoot` test case from `HwAclStatTests.cpp` to `AgentHwAclStatTests.cpp`, **enhancing** the **agent hardware test suite**. This **test migration** ensures that shared ACL stats are correctly deleted after a warm boot, specifically within the context of the **FBOSS agent's ACL stat management**. The updated test now dynamically resolves `SwitchID` via `scopeResolver()` and performs comprehensive verification using `getDefaultAclTableStatCountInfo()` and `isStatProgrammedInDefaultAclTable()`. This improves the robustness of **ACL stat deletion validation** post-warmboot, ensuring proper resource cleanup.

This commit introduces **new capabilities** to the **AgentHwTestCtrl Thrift API** by adding two methods, `getDefaultAclTableStatCountInfo` and `isAclStatDeleted`. These methods enable querying **ACL entry, stat, and counter counts** directly from hardware and verifying the **deletion of specific ACL stat counters**, respectively. The functionality is implemented for both **BCM** and **SAI** hardware platforms, extending the `HwTestThriftHandler` interface and defining a new `AclStatCountInfo` struct. This enhancement provides **full verification parity** for ACL statistics, which is crucial for migrating existing hardware tests to the `AgentHwTest` framework and improving the robustness of hardware test coverage.

This commit **fixes a heap-use-after-free bug** affecting the **`ArpHandler`** and **`IPv6Handler`** modules. Specifically, the `floodGratuituousArp()` and `floodNeighborAdvertisements()` functions were vulnerable to memory corruption during `gracefulExit()` when iterating over network interfaces, as concurrent state updates could free interface nodes prematurely. The **bug fix** addresses this by ensuring the switch state is captured once at the beginning of these functions, providing a stable reference throughout the iteration. This change **improves system stability** by preventing critical crashes related to neighbor flooding during shutdown or state transitions.

This commit **fixes a crash** in the `AgentRouteCounterOverflowTest` by **adding support for the new `PLATFORM_TAHANSB800BC` platform type** to the `ProdConfigFactory.cpp` utility. Specifically, it updates the `uplinksCountFromSwitch()` and `getPortSpeed()` functions to correctly return configuration values for this platform, which was previously undefined. This **bug fix** prevents "PlatformType not defined" errors in the `sai_agent` conveyer when testing the new hardware variant. The **maintenance update** ensures proper initialization and testing of configurations for `TAHANSB800BC`, enabling its future integration.

This commit **migrates** the `AclStatCreatePostWarmBoot` test case, which validates **ACL stat creation after a warm boot**, to the `AgentHwAclStatTests.cpp` file. This **test refactoring** specifically impacts the **FBOSS agent's hardware test suite**, moving the test from `HwAclStatTests.cpp`. The change is a **test maintenance** effort, ensuring that the validation of **ACL functionality post-warm boot** is properly categorized within the **agent-specific hardware tests**.

This commit **migrates** the `AclStatDelete` test case from `HwAclStatTests.cpp` to `AgentHwAclStatTests.cpp`, aligning it with the new **Agent hardware testing framework**. This **refactoring** effort adapts the test to use `getAgentEnsemble()` and performs verification through **Thrift client calls**, specifically `sync_isStatProgrammedInDefaultAclTable`, instead of direct hardware interaction. The change ensures the **ACL statistics** deletion test is consistent with the evolving **Agent hardware tests** architecture. This improves the maintainability and architectural consistency of the **Agent's hardware test suite**.

This commit **migrates** the `AclStatMultipleActions` test case from `HwAclStatTests.cpp` to `AgentHwAclStatTests.cpp`, aligning it with the **agent hardware test framework**. The test's implementation is updated to verify **ACL statistics** by utilizing **Thrift client calls** like `sync_isStatProgrammedInDefaultAclTable` against the agent, replacing direct hardware verification. This **test migration** and **refactoring** effort enhances the **test infrastructure** for **ACL functionality**, ensuring more consistent and robust validation through the agent's public API.

This commit **fixes a failing test** in the **`HwFlowletSwitchingTests`** suite by **excluding management ports** from next-hop resolution. The `ValidateMaxEcmpIdFlowletUpdate` test previously failed because management ports, such as `PhysicalPort-65`, lack configured interfaces and thus have no next-hop entries in the ECMP helper, leading to "Could not find a nhop" errors. To address this, a `filterManagementPorts` lambda was introduced in `HwFlowletSwitchingTests.cpp` to filter out ports with `cfg::PortType::MANAGEMENT_PORT` before `resolveNextHopsAddRoute()` is invoked. This **test maintenance** ensures the flowlet switching test runs reliably, preventing false negatives caused by unroutable management port configurations.

This commit provides a **bug fix** for the **Tomahawk6Asic** by updating its buffer configuration parameters to resolve `SAI_STATUS_INSUFFICIENT_RESOURCES` errors and allow the `AgentIngressBufferTest.validateConfig` to pass. Specifically, it **updates the MMU cell size** from 254 to 420 bytes to accurately reflect the hardware, and **increases the pool reserved cells** from 200 to 4000. These adjustments ensure sufficient buffer resources are available for ingress priority groups on **TH6** devices, preventing test failures and improving the stability of buffer profile assignments.

This commit **fixes a test failure** in the **mirroring test suite** by updating the receiver IP address used in test parameters within `fboss/agent/test/utils/MirrorTestUtils.cpp`. Previously, the mirror receiver IP `201.0.0.10` could conflict with dynamically generated interface IPs on platforms with a large number of ports, causing test packets to be dropped prematurely. The receiver IP is now changed to `201.201.0.10`, utilizing a **high second octet** to ensure it does not clash with the IP ranges generated by `genInterfaceAddress()`. This **maintenance fix** prevents **test flakiness** and ensures the **mirroring tests** pass reliably on high-port-count devices like Tahan-sb, improving the robustness of the **FBOSS agent testing infrastructure**.

This commit **extends the DSF scale test utilities** to correctly support the **Janga platform** by configuring it for **256 Remote Distributed Switch (RDSW) nodes**. Specifically, it updates `getMaxRdsw()` in `ConfigUtils.cpp` to return 256 for `PLATFORM_JANGA800BIC` and modifies `getDsfInterfaceNodeCount()` in `DsfConfigUtils.cpp` to reflect Janga's unique configuration (256 RDSWs, no EDSWs). The changes also introduce an **optional platform type parameter** across relevant functions like `getMaxRdsw()` and `addRemoteIntfNodeCfg`, improving flexibility in test configurations. Additionally, it incorporates recommended **Thrift API** for null-safety checks and resolves a linter warning by using `is_non_optional_field_set_manually_or_by_serializer()` for non-optional field access. This **feature extension** ensures accurate scale testing for the Janga platform.

This commit introduces a **new capability** to support **platform-specific RDSW cluster sizes** within the **DSF configuration utilities**. It adds a helper function, `getRdswPerCluster()`, which dynamically determines the appropriate RDSW count (256 for `Janga` platforms, 128 otherwise) based on the `platformType`. The `addRemoteIntfNodeCfg()` function in `fboss/agent/test/utils/DsfConfigUtils.cpp` is updated to leverage this, ensuring that **Janga scale tests** correctly provision the required resources. This change improves the accuracy of **scale test configurations** without impacting existing callers.