Thoth

This commit performs a **maintenance update** within the **`pkg/aflow`** module, specifically for its **Gemini API integration**. It switches from using `ThinkingBudget` to `ThinkingLevelHigh` for calls to the Gemini 3+ models, as recommended by Google to avoid "unexpected performance". This **performance improvement** ensures **optimal and dynamic thinking capabilities** for content generation, directly impacting the `generateContentGemini` function. The change aligns the system with the latest API best practices, preventing potential performance issues and enhancing the reliability of AI-driven features.

This commit introduces an **automatic instance deletion mechanism** for **GCE virtual machines**, ensuring that instances are cleaned up even if the managing service crashes. It configures GCE instances to self-terminate after `VMRunningTime + 1 hour`, adding a buffer for manager-side cleanup. This **enhances resource management reliability** within the **GCE provisioning system** by preventing orphaned resources and correctly handles provisioning models to avoid preemption-related errors during instance creation in `pkg/gce/gce.go` and `vm/gce/gce.go`.

This commit **reverts** a previous change that introduced **automatic instance deletion** for **Google Cloud Engine (GCE) virtual machines**. It effectively removes the functionality within `pkg/gce` and `vm/gce` responsible for automatically terminating GCE instances. This **rollback** ensures that the system will no longer automatically delete GCE instances, restoring the prior behavior where instance cleanup requires explicit management. The primary impact is on the **GCE integration's instance lifecycle management**, preventing unintended or premature instance termination.

This commit introduces a **new capability** for **GCE VM instances** to automatically self-terminate after a specified runtime, plus a one-hour buffer. The `pkg/gce` module is updated to include a `VMRunningTime` field in `InstanceConfig`, which the `CreateInstance` function uses to configure this automatic termination. The `vm/gce` module's `Create` function now passes this runtime from the pool environment to the GCE configuration. This **enhances system robustness** by ensuring instances are reliably cleaned up, even if the managing service crashes and fails to perform explicit deletion.

This commit introduces a new `InstanceConfig` struct within the **`pkg/gce`** module to encapsulate parameters for creating GCE instances. The **`CreateInstance` method** in `pkg/gce/gce.go` has been **refactored** to accept this single, consolidated struct, improving API clarity and extensibility. Consequently, the **`vm/gce`** module's `Create` method in `vm/gce/gce.go` is updated to construct and pass this new `InstanceConfig` when provisioning virtual machines. This **refactoring** streamlines the instance creation interface, making it easier to manage and extend instance configuration options in the future.

This commit **updates Linux system constant definitions** by running `make extract`. It **refactors** the **KVM AMD64 device constants**, specifically renaming `TDX_ATTR_` identifiers to `TDX_TD_ATTR_` for improved clarity and consistency within the **TDX attribute definitions**. Additionally, the value of the `NETLINK_MAX_ATTRIBUTES` constant is updated for the **Netlink socket interface**. This **maintenance update** ensures that the project's Linux constant definitions remain synchronized with upstream kernel changes, preventing potential compatibility issues for components interacting with these subsystems.

This commit performs **documentation maintenance** for **Linux system interfaces**, updating descriptions to reflect recent kernel API changes. It specifically renames **TDX attribute constants** from `TDX_ATTR_` to `TDX_TD_ATTR_` within the `dev_kvm_amd64.txt` documentation, aligning with upstream renames. Furthermore, it removes outdated **Landlock network access flags** such as `LANDLOCK_ACCESS_NET_*_UDP` and the `LANDLOCK_SCOPE_PATHNAME_UNIX_SOCKET` scope flag from `landlock.txt`. This ensures the project's internal documentation for **KVM/AMD64 TDX** and the **Landlock security module** remains accurate and consistent with the current Linux kernel interfaces.

This commit **enhances the `syz-cluster/email-reporter`'s command handling** by providing more informative replies to users. Instead of a generic "Unknown command" message, the `IncomingEmail` function now issues **specific feedback for commands that are recognized but not yet supported** by `syzbot-ci`. This **feature improvement** aims to **reduce user confusion** and the frequency of repeated, failed command attempts, thereby streamlining user interaction with the system. The change is validated by an updated `TestInvalidReply` test case to assert the new, more specific error messages.

This commit **fixes a minor typo** within the **GCE (Google Compute Engine) integration package**. It specifically corrects a log message in the `DeleteInstance` function within `pkg/gce/gce.go`, changing the inaccurate "delete image" to the correct "delete instance". This **maintenance improvement** ensures that the logging output accurately reflects the operation being performed, enhancing clarity for monitoring and debugging GCE instance deletion processes. The change improves the reliability of **logging output** for the instance lifecycle management subsystem.

This commit performs a **refactoring** within the **`pkg/debugtracer`** module by renaming the `Log` method to `Logf`. This change aligns the method's name with standard Go conventions for functions that accept format strings and arguments, as the original `Log` method was already used for formatted output. Consequently, numerous call sites across various modules, including `pkg/asset`, `pkg/bisect`, `pkg/kconfig`, `pkg/vcs`, and `syz-cluster` components, have been updated to use the new `debugtracer.Logf` method. Additionally, the `TestTracer` implementation was adjusted to correctly utilize `t.Logf` for formatted test output, ensuring consistency throughout the logging infrastructure.

This commit introduces a **new capability** to the `syz-cluster` **triage workflow**, enabling it to utilize a `base-commit` hint provided by a patch series author. The `syz-cluster/workflow/triage-step/main.go` module now attempts to select a fuzzing target based on this hint, falling back to the default method if applying the series against the specified base commit fails. This enhancement is supported by a **refactoring** in `pkg/vcs/git.go`, which extracts URL retrieval into a helper function `getURL` and adjusts method signatures like `CommitExists` for improved Git operation management. This change aims to improve the accuracy and efficiency of patch series application by respecting author-specified base commits during the triage process.

This commit introduces a **new test case** within the **`pkg/report`** package to validate its parsing capabilities for complex kernel reports. It adds a test data file (`pkg/report/testdata/linux/report/999`) containing a Linux kernel warning report that features both a specific condition string and a **RISC-V stack trace**. This **maintenance** work ensures the report parser correctly identifies and processes these specialized elements, thereby improving the robustness and accuracy of report analysis, especially for the **RISC-V architecture**.

This commit introduces a **new feature** to the **`pkg/report` module** by adding a **regular expression pattern** to `pkg/report/linux.go`. This pattern specifically enables the detection of **Linux kernel warnings** that include a condition string, formatted as "WARNING: [condition] file:line at func...". By enhancing the `linuxOopses` slice, this change improves the **system's ability to accurately identify and report** a broader range of Linux kernel issues. The update ensures more comprehensive monitoring and analysis of system stability on Linux platforms.

This commit **improves stack trace detection** within the **`pkg/report` module** for **RISC-V** architectures. It addresses a specific issue where stack dumps generated by `show_regs()` in kernel space on RISC-V lacked a clear start indicator, leading to incorrect log corruption flags. By adjusting the `isCorrupted` detection logic in `pkg/report/linux.go` and adding a new regex to match the last line of `show_regs()` output as a stack start, this **bug fix** ensures that valid RISC-V stack traces are no longer misidentified as corrupted. This change enhances the accuracy of **kernel crash reporting** and analysis on RISC-V systems by preventing false positives in log corruption detection.

This commit **improves the error message** within the **`prog` module's target resolution logic**. Previously, users encountering an "unknown target" error, often due to ungenerated system descriptions, received a vague message from the `GetTarget` function. Now, the error message in `prog/target.go` explicitly suggests running `make generate`, providing a clear path to resolve the issue. This **usability enhancement** acts as a **maintenance fix** for a common diagnostic problem, significantly **improving developer experience** by guiding users to quickly diagnose and fix configuration problems.

This commit **fixes a build error** within the **`syzbot` Docker environment** specifically impacting `android-6.12` kernel builds. It introduces an `update-alternatives` command in the `tools/docker/syzbot/Dockerfile` to create an alias, ensuring that `llvm-link` correctly points to `llvm-link-21`. This **maintenance update** prevents build failures caused by the `llvm-link` executable not being found, thereby restoring the integrity of the `android-6.12` testing pipeline.

This commit introduces a **new capability** to the **`syz-cluster`** component by adding a `BaseCommitHint` field to the `Series` object. This field will store a hint about the base commit associated with a particular series, enhancing the metadata available for series tracking. The change involves **extending the `Series` API definition**, **modifying the database schema** with new migration files, and updating the **`syz-cluster` service layer** (`UploadSeries`, `getSeries`) to persist and retrieve this data. The `series-tracker` component is also updated to populate this `BaseCommitHint` from `lore.Series` when creating API objects, ensuring the new field is correctly utilized across the system.

This commit **adds new test cases** to `pkg/email/parser_test.go` to **verify the correct extraction of base-commit hints from email bodies**. These tests enhance the **testing coverage** for the `pkg/email` module's parsing logic, specifically addressing scenarios with malformed or missing hashes. This **maintenance** work improves the robustness and reliability of a critical component for processing incoming email patches, ensuring accurate data extraction.

This commit introduces a **new capability** to the **email parsing subsystem** by enabling the extraction of `base-commit` hashes from incoming emails. It modifies `pkg/email/parser.go` to add a `BaseCommitHint` field to the `Email` struct and includes a new function, `extractBaseCommitHint`, to parse this information from the email body during the `Parse` operation. Additionally, `pkg/email/lore/parse.go` is updated to store this extracted `BaseCommitHint` within the `Series` struct. This enhancement allows the system to track the intended base for patch series, improving the understanding of patch dependencies and streamlining patch series management.

This commit **adds unit tests** to the `syz-cluster` component, specifically targeting the **series and patch name filtering functionality** within the `pkg/db` package. A new test function, `TestSeriesRepositorySearch`, has been introduced in `syz-cluster/pkg/db/series_repo_test.go` to verify these search capabilities. This **enhances the robustness and reliability** of the database repository's ability to filter series and patches, ensuring correct behavior for users. This **maintenance** work improves the overall quality and stability of the `syz-cluster`'s data management.