Pieter De Baets

This commit delivers a **bug fix** addressing a **crash** within the **Android Fabric mounting layer** that occurred during concurrent render cancellations or React Transitions. Previously, the C++ `allocatedViewRegistry` was not properly updated when a `ShadowNode` was destroyed via `destroyUnmountedShadowNode`, leaving stale entries. This desynchronization caused `Create` mutations to be incorrectly skipped for recycled view tags, leading to `RetryableMountingLayerException` when subsequent mount operations attempted to reference the already destroyed Java view. The fix ensures `allocatedViewRegistry` is correctly cleared by removing the view tag in `destroyUnmountedShadowNode`, thereby synchronizing C++ and Java view state and preventing these inconsistencies. New tests have been added to validate the corrected view lifecycle behavior, enhancing the **stability of view management** in **Fabric**.

This commit **fixes a critical bug** in the **image loading subsystem** by ensuring `RCTImageLoader` always calls its completion handler, even when the `RCTNetworking` module is unavailable or cannot handle a request. Previously, `RCTImageLoader._loadURLRequest:` would return `NULL` without notifying callers, causing `RCTSyncImageManager` to block for up to 20 seconds per image. The fix now correctly propagates an error via the completion handler, preventing these long delays and UI freezes. Additionally, **`RCT_DEBUG` guards have been removed** from these checks in `RCTImageLoader.mm`, making this robust error handling active in all builds. This significantly **improves the reliability and responsiveness of image loading** in React Native applications under adverse network conditions.

This commit **fixes a critical bug** in **iOS Fabric's `RCTViewComponentView`** where dynamically toggling off the `removeClippedSubviews` prop would leave previously clipped children invisible and the internal `_reactSubviews` state stale, potentially causing crashes. It introduces a new helper `_updateRemoveClippedSubviewsState` to correctly re-mount all children in the proper order and clear internal tracking when `removeClippedSubviews` is disabled. This **bug fix** significantly improves the resilience and correctness of the `removeClippedSubviews` optimization within the **iOS mounting layer**, ensuring consistent rendering behavior. The unmount path is also made more robust, and comprehensive **unit tests** have been added to cover toggle-off, ordering, cleanup, and unmount-after-toggle scenarios.

This commit provides a **bug fix** for a crash occurring in the **React Native Android** module's **Fabric mounting layer**. It specifically addresses a `RetryableMountingLayerException` within the `SurfaceMountingManager.kt` component. The fix involves adding **null checks** and **soft exception logging** to the `updateLayout` method. This prevents application crashes when the view state or the view itself is unexpectedly missing, significantly improving the **stability** of UI rendering on Android.

This commit performs a **cleanup and refactoring** within the **Android `Image` component** and its supporting infrastructure. It **removes the `fixImageSrcDimensionPropagation` feature flag** definition from `ReactNativeFeatureFlags.js` and eliminates its conditional usage from `Image.android.js` and associated integration tests, as the feature has been successfully rolled out. Furthermore, this change addresses a **code redundancy** by removing a duplicate assignment of the `src` prop, thereby simplifying the codebase and improving maintainability without altering functionality.

This commit introduces a **performance improvement** to the **React Native Differentiator** by implementing a Longest Increasing Subsequence (LIS) algorithm for reconciling reordered children. This **new capability** replaces the previous greedy two-pointer approach, drastically reducing the number of `REMOVE+INSERT` mutations required for UI updates involving child reordering, such as moving elements in a list. The change primarily affects the **mounting layer** (`Differentiator.cpp`) and is controlled by a new `useLISAlgorithmInDifferentiator` **feature flag** across Android, C++, and JavaScript, ensuring a controlled rollout and allowing for A/B testing of this more efficient diffing strategy. New benchmarks and tests have been added to validate the improved reordering logic, enhancing the overall efficiency of UI updates.

This commit **refactors** the **React Native C++ platform runtime** by renaming the `TurboModuleManager` class and its associated files to `ReactCxxTurboModuleProvider`. This change clarifies the component's specific role in **C++ TurboModule provisioning** and prevents potential naming collisions with platform-specific `TurboModuleManager` classes on Android and iOS. The `ReactHost.cpp` file was updated to reflect this new name and include path. This is a **purely internal renaming** that enhances code clarity and maintainability without introducing any functional changes or affecting external behavior.

This commit **re-introduces** the `receiveTouches` method to the **`RCTEventEmitter` interface** within the **React Native Android module**. This is a **backward compatibility fix** to prevent compilation failures for existing **ecosystem libraries** that implement `RCTEventEmitter` or `RCTModernEventEmitter` and override this method. By providing a default no-op implementation, it ensures that these libraries continue to compile without requiring immediate updates. This change addresses a breaking change introduced by a previous commit that entirely removed `receiveTouches`, thus maintaining stability for the broader React Native ecosystem.

This commit undertakes a substantial **refactoring and cleanup** of the **Android event dispatching system** by **removing legacy Paper-specific event emitters** and deprecated methods. It eliminates the `receiveTouches` method and the old `dispatch` method from `TouchEvent`, streamlining event handling within `InteropEventEmitter` and `UIManagerModule` by removing `EventDispatcherImpl` and `EventEmitterImpl` indirection. This work is crucial for the ongoing migration to the **Fabric architecture**, simplifying the codebase and ensuring that only modern event handling paths are utilized. The change updates the event dispatching API, removing deprecated entry points and improving maintainability.

This commit **refactors** the internal representation of **LinearGradient** directions within **React Native's Fabric renderer**, simplifying its angle handling. It replaces a separate enum and struct with a direct `std::variant` alias for `GradientDirection` in `LinearGradient.h`, deprecating the old `GradientDirectionType`. This **internal maintenance** streamlines gradient point calculation in `RCTLinearGradient.mm` and updates background image parsing functions in `BackgroundImagePropsConversions.cpp` to directly utilize the new `std::variant` structure. The change also refactors gradient serialization in `LinearGradient.cpp`, resulting in a cleaner and more maintainable codebase for gradient functionality.

This commit **refactors** the **Android UIManagerHelper** by **deprecating** the `getEventDispatcherForReactTag` and `getEventDispatcher(ReactContext, UIManagerType Int)` methods. It introduces a **simplified** `getEventDispatcher` method, which is now used consistently across various **React Native view managers** and components for event dispatching. This **cleanup** effort leverages the project's full transition to the new architecture, streamlining the event handling mechanism within the **Android UIManager**. The change is classified as a **breaking change** for Android, as external modules relying on the deprecated variants will need to update. This significantly simplifies event dispatching logic across the **React Native Android codebase**.

This commit performs a **maintenance cleanup** by **removing unreferenced `ReactNativeViewAttributes`** from the codebase. This action targets the **internal view attribute management system** within React Native, eliminating dead code that was no longer utilized. The change **improves code hygiene and reduces unnecessary definitions**, ensuring the codebase remains lean and maintainable **without introducing any functional changes or impacting external consumers** of the framework.

This commit **fixes a bug** in the **React Native Android Fabric renderer** where `FabricUIManager.resolveView` could throw an `IllegalViewOperationException` when attempting to resolve a view belonging to a stopped surface. Previously, `getView` would fail because `tagToViewState` was cleared for stopped surfaces, leading to an exception. The **fix** introduces an `isStopped()` check within `resolveView` to return `null` gracefully if the surface manager is stopped, preventing these crashes. This change improves the **stability** of the Fabric UI manager by handling views on terminated surfaces more robustly, aligning with existing behavior in `measure()` and `measureText()`.

This commit performs a **refactoring** of the **Fabric mounting system** within `SurfaceMountingManager.kt` to enhance code quality and error reporting. It **improves error messages**, replaces unsafe null assertions with explicit checks for increased robustness, and inlines the `addRootView` function. These **maintenance** changes provide **more signal for reported issues** and ensure a more stable and maintainable implementation of the core view management logic, particularly impacting how views are attached and managed.

This commit primarily **refactors** the **Fabric UI Manager's mounting infrastructure** by **migrating the `SurfaceMountingManager` class from Java to Kotlin**. This extensive language migration modernizes a core component responsible for managing UI surfaces and their lifecycle within React Native Android. The change also includes necessary adjustments to nullability annotations across several related mounting classes like `MountingManager.kt` and `FabricUIManager.java`, and updates the `ReactAndroid` API definition to reflect the new Kotlin implementation. This internal modernization effort improves code maintainability and leverages Kotlin's features for a critical part of the rendering pipeline.

This commit provides a **bug fix** to prevent **SIGILL/SIGTRAP crashes** in the **React Native renderer core** by replacing assertions with robust bounds checks. Specifically, the `RawPropsKeyMap::at()` function now gracefully handles invalid prop name lengths by returning `kRawPropsValueIndexEmpty`, rather than trapping. Concurrently, `RawPropsKey::render()` and its `operator std::string` now clamp overlong prop names to `kPropNameLengthHardCap - 1`, preventing assertions. This change significantly enhances the **stability** of the renderer by preventing crashes caused by out-of-bounds or excessively long property names.

This commit performs an **internal refactoring** by **relocating** the `RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION` macro definition. It moves the macro from the shared header `RCTDefines.h` to its sole consumer, `RCTDevSettings.mm` within the **CoreModules** subsystem. This change **removes an unnecessary `__has_include` dependency** from `RCTDefines.h`, thereby making `RCTDefines.h` a more **lightweight and standalone header** that no longer implicitly pulls in `RCTPackagerConnection.h`. This improves **code organization** and reduces compilation dependencies for modules that only need `RCTDefines.h`.

This commit **enables** the `fixImageSrcDimensionPropagation` feature flag by updating its default value from `false` to `true` within both the native and JavaScript **React Native feature flag configurations**. This **configuration update** is a **maintenance** task that effectively rolls out a **bug fix** related to how image dimensions are propagated. By activating this flag by default, the underlying fix for **image source dimension propagation** will now be applied to all React Native applications, improving image rendering consistency and reliability.

This commit **fixes a critical bug** in the **`Image` component** where explicitly provided `width` and `height` properties were not correctly applied to the image's style when a `uri` was used as the source. The **bug fix** ensures that images now correctly respect their specified dimensions, preventing unexpected rendering sizes. This involves **refactoring** the `getImageSourcesFromImageProps` utility to properly include dimension data and is gated by a new **feature flag**, `fixImageSrcDimensionPropagation`, for controlled deployment. Integration tests were also added to verify the correct propagation of these dimensions, **restoring expected image rendering behavior** for `Image` components.

This commit performs a **cleanup and refactoring** by **removing an obsolete reference** to the `integration/runner` directory. Specifically, it modifies the **Babel registration configuration** in `scripts/shared/babelRegister.js` to eliminate the `RN_INTEGRATION_TESTS_RUNNER_DIR` constant from the list of directories processed by `metro-babel-register`. This **maintenance task** streamlines the project's build setup by removing a "fantom location" that was no longer in use. The change ensures that the Babel transpilation process remains efficient and free of unnecessary paths, with no functional impact on current integration tests or runtime behavior as the referenced directory was already deprecated.