Siva Muthusamy

This commit **fixes build failures** for **FBOSS binaries** by updating the build configuration. It modifies the `BUCK` file within the `fboss/agent/test/prod_invariant_tests` module to include `15.0_ea_odp` in the list of supported SAI versions. This **maintenance change** ensures that the project can successfully compile and run tests when integrating with **brcm-sai 15.x EA** versions.

This commit **fixes build failures** encountered when compiling **FBOSS agent binaries** with the **brcm-sai 14.2 GA** version. It updates the `BUCK` build rules within `fboss/agent/test/prod_invariant_tests` to correctly include specific linker flags required for the `14.2.0.0_odp` SAI version. This **maintenance change** ensures that the **production invariant tests** can successfully build and run, preventing build breaks for developers integrating with the updated Broadcom SAI library.

This commit **enables support for firmware (FW) fabric auto link disable** within the **FBOSS agent's SAI implementation for Broadcom NPUs**. It **extends preprocessor directives** in `fboss/agent/hw/sai/api/bcm/SwitchApi.cpp` and `fboss/agent/hw/sai/switch/npu/bcm/SaiSwitch.cpp` to include `SAI_VERSION_14_2_0_0_DNX_ODP`. This **feature enablement** allows the agent to correctly register for and handle fabric auto link disable events and associated errors. The change ensures proper system response to hardware-initiated link state changes for the **14.2 GA SAI version**.

This commit implements a **temporary workaround** to address a **buffer overflow crash** occurring during **SDK initialization** on **BRCM DNX cModels**. The issue, specific to simulators, stemmed from the Thrift server's concurrent socket creation exceeding the `FD_SETSIZE` limit, causing instability. To resolve this, the **Thrift server event loop start** in `fboss/agent/SwAgentInitializer.cpp` is now **delayed** until after hardware switch and SDK initialization are complete. This **bug fix** ensures successful SDK setup, unblocking simulator testing, and will be reverted once a proper SDK fix is available.

This commit provides a **bug fix** addressing **ASIC source port ACL entry creation failures**, particularly on hardware like **Q4D**. The problem occurred because certain ASICs require `EtherType` to be explicitly passed for ACL entries, a condition not met for source port ACLs. To resolve this, the system now correctly sets a `NON_IP` type for these ACLs when the ASIC supports `EtherType`, ensuring **proper ACL programming** in the hardware. This change enhances the robustness of **ACL configuration** within the `fboss/agent` component by generalizing the condition for this setting based on `EtherType` support.

This commit **introduces a new hardware test configuration file** for the **Blackwolf800banw platform**. Specifically, it adds `fboss/oss/hw_test_configs/blackwolf800banw.agent.materialized_JSON`, providing the necessary setup for agent-based hardware tests. This is a **new capability** that expands the project's **hardware testing infrastructure** to support the `Blackwolf800banw` platform. The addition enables comprehensive testing and validation for this specific hardware, ensuring proper agent functionality.

This commit **fixes a failing test** within the **`AgentVoqSwitchIsolationFirmwareTest`** suite, specifically addressing the `forceLinkAdminDisable` test's incompatibility with **SDK 14.x**. The **test fix** modifies `fboss/agent/test/agent_hw_tests/AgentVoqSwitchFirmwareTests.cpp` to ensure that fabric ports are explicitly checked for an `ACTIVE` state before any force isolation or link disable operations are attempted. This **maintenance** update prevents test failures caused by operations on inactive ports, thereby improving the **robustness and accuracy of firmware tests** for VOQ switches.

This commit **introduces support for a new Broadcom SAI API version**, `SAI_VERSION_14_2_0_0_DNX_ODP`, within the FBOSS agent's hardware abstraction layer. It **adds this specific SAI version** to the conditional compilation directives in `fboss/agent/hw/sai/api/SaiVersion.h`, thereby updating the **SAI API versioning mechanism**. This **feature enhancement** is crucial for enabling the FBOSS agent to build and interact with systems running the Broadcom SAI 14.2 GA release, specifically the DNX_ODP variant. This foundational change paves the way for future hardware compatibility and broader platform support.

This commit **enables support for Broadcom SAI 14.2 GA** within the **FBOSS agent's SAI hardware abstraction layer**. It introduces the `SAI_VERSION_14_2_0_0_ODP` identifier by updating various conditional compilation macros in `fboss/agent/hw/sai/api/SaiVersion.h`. This **new capability** allows the agent to compile and operate against the specified SAI version, leveraging its latest features and improvements. The change is crucial for maintaining compatibility and accessing advancements in the underlying **SAI API**.

This commit introduces **support for a new SAI version**, specifically `SAI_VERSION_15_0_EA_ODP`, which corresponds to **Broadcom (BRCM) SAI 15.0 Early Access (EA)**. It **adds a new feature** by defining this version identifier within `fboss/agent/hw/sai/api/SaiVersion.h` and updates the associated conditional compilation macros. This change allows the `fboss` agent's **SAI API layer** to recognize and adapt its behavior for hardware platforms running this specific **SAI 15.0 EA ODP** implementation. The primary impact is enabling future development and ensuring compatibility with newer Broadcom SAI releases by providing the necessary versioning infrastructure.

This commit **disables several Qumran4D ASIC features** within the **FBOSS agent's hardware abstraction layer**. It updates the `isSupported` method in `fboss/agent/hw/switch_asics/Qumran4DAsic.cpp` to explicitly mark capabilities that are not currently supported by the underlying SDK. This **maintenance change** prevents the system from attempting to configure or utilize non-functional features, thereby improving the **stability and correctness** of **Qumran4D-based deployments**. It ensures the software accurately reflects the current capabilities provided by the hardware vendor's SDK.

This commit **fixes** the **QoS (Quality of Service) traffic class to queue map programming** for **QUMRAN4D (Q4DL) ASICs**, ensuring that CPU-bound traffic is correctly mapped to egress queues. Specifically, it corrects the `getTrafficClassToCpuEgressQueueId` logic in `QueueTestUtils.cpp` to properly handle Q4DL's queue IDs and extends `getCoppMidPriQueueId` for the same ASIC type. Additionally, a new helper function, `needsSeparateCpuQosPolicy`, is introduced and utilized across various **test utilities** like `NetworkAITestUtils.cpp` and `OlympicTestUtils.cpp` to centralize the determination of when a separate CPU QoS policy is required. This **bug fix** and **refactoring** improves the accuracy and maintainability of **CPU QoS policy configuration and verification** within the test suite for `QUMRAN4D` devices.

This commit **adds comprehensive support for the Arista Blackwolf 800banw platform** to the FBOSS agent by introducing previously missing platform-specific files. It provides the necessary header and implementation for the `SaiBcmBlackwolf800banwPlatform` and `SaiBcmBlackwolf800banwPlatformPort` classes. This **new capability** integrates the logic for **ASIC setup, internal system port configuration, and port state management** within the **SAI (Switch Abstraction Interface) platform abstraction layer**. The addition ensures the FBOSS agent can properly initialize and operate on this specific Broadcom-based hardware.

This commit **disables FDR (Fault Detection and Recovery) enable programming** for **Broadcom DNX platforms utilizing SDK version 15.x and above**. It introduces a **conditional compilation change** within `fboss/agent/hw/sai/api/bcm/PortApi.cpp`, specifically skipping the setting of the `SAI_PORT_ATTR_FDR_ENABLE` attribute. This **maintenance fix** addresses a compatibility gap where the 15.x DNX SDK lacks support for the Q4DL feature, preventing potential errors during port initialization. The change ensures stable operation by avoiding unsupported SDK calls on these specific hardware and software configurations.

This commit **adds initial port support** for the **Q4DL Blackwolf800BANW platform**, a **new feature** enabling hardware-specific network interface configuration. It modifies the `fboss/agent/platforms/sai/SaiPlatform.cpp` file to include the platform's dedicated port header and initialize its specific `SaiPlatformPort` type. This integration within the `initPorts` function is essential for the `fboss/agent` to correctly manage and operate on the new Blackwolf800BANW hardware, extending the **SAI platform integration** capabilities.

This commit **disables AM_IDLES programming** for **Broadcom DNX platforms running SDK version 15.x and above**. This is a **maintenance fix** addressing the lack of Q4DL support in these specific **DNX 15.x SDK versions**, which is a prerequisite for `AM_IDLES` functionality. The change is implemented by **modifying conditional compilation** within the **SAI Port API's Broadcom implementation** in `fboss/agent/hw/sai/api/bcm/PortApi.cpp`. Specifically, it excludes `SAI_PORT_ATTR_EXTENSION_AM_IDLES` when `BRCM_SAI_SDK_DNX_GTE_15_0` is defined, preventing attempts to program unsupported features and ensuring stability on affected hardware.

This commit introduces **new platform support** for the **Blackwolf800BANW hardware platform** within the SAI agent. It updates the `cmake/AgentPlatformsSai.cmake` build configuration to include necessary source files and link libraries for this new platform. Additionally, the `fboss/agent/platforms/sai/SaiPlatformInit.cpp` file is modified to extend the `chooseSaiPlatform` function, allowing the system to correctly identify and initialize the `SaiBcmBlackwolf800banwPlatform` specific to Blackwolf800BANW. This **feature addition** enables the FBOSS agent to operate on the new hardware by providing its dedicated **SAI platform initialization**.

This commit **disables specific hardware features** within the **Qumran4D ASIC** implementation. It prevents the `fboss` agent from attempting to utilize `VENDOR_SWITCH_NOTIFICATION` and `VENDOR_SWITCH_CONGESTION_MANAGEMENT_ERRORS` capabilities on Qumran4D devices. This is a **precautionary maintenance change** to ensure stability, as the necessary SDK support for these interrupt event features is not yet available. The modification, primarily in `Qumran4DAsic.cpp`, temporarily deactivates unsupported functionality via the `isSupported` method, preventing potential issues until full SDK integration.

This commit **disables switch pipeline statistics collection** for systems utilizing **DNX SDK version 15.x** within the **SAI hardware abstraction layer**. It addresses a **compatibility issue** by updating conditional compilation directives in `fboss/agent/hw/sai/switch/SaiSwitchManager.cpp`, specifically impacting the `getHwSwitchPipelineStats` function. This **maintenance fix** prevents attempts to gather unsupported statistics, ensuring **stability and correct operation** of the agent on hardware running the specified SDK version due to the **lack of SDK support**.

This commit **updates the SAI versioning definitions** within the `fboss` agent to support a new hardware abstraction layer. It introduces the new `SAI_VERSION_15_0_EA_DNX_ODP` macro in `fboss/agent/hw/sai/api/SaiVersion.h`, along with other related Broadcom SAI SDK version macros. This **maintenance update** enables the `fboss` agent to recognize and integrate with the **Broadcom SAI 15.0 Early Access (EA) SDK**, specifically for DNX ODP platforms. This change is essential for supporting newer hardware capabilities and features provided by this specific SAI SDK release.