SiaoJie Cai

This commit **updates test cases** within the **`SnapshotsActionMetadataTest`** class, located in the `prelude/toolchains/android` module, to utilize **content-based path formats** for snapshot files. This **test maintenance** effort ensures that the tests accurately reflect the actual Buck2 path structure, moving away from simple filenames. By aligning the test data with real-world Buck2 behavior, it improves the robustness and relevance of the **Kotlin JVM snapshot metadata tests**.

This commit delivers a **bug fix** to the **Kotlin incremental compilation (KSIC)** logic within **Buck's Android toolchain**. It addresses an issue where changes in content-based path hashes were incorrectly interpreted as **classpath removals**, leading to unnecessary full recompilations. The fix modifies the `hasClasspathRemoval` detection in `SnapshotsActionMetadata.kt` to **normalize paths by stripping content-based hash segments** before comparison, ensuring that only actual structural classpath changes trigger a full build. This refinement **improves incremental build performance** and reliability for Kotlin projects by preventing spurious full recompilations.

This commit **adds a new test case** to `prelude/toolchains/android/test/com/facebook/buck/jvm/kotlin/SnapshotsActionMetadataTest.java` to **showcase a bug** within the **Kotlin Incremental Compilation (KSIC)** logic. The test specifically demonstrates that the `hasClasspathRemoval` method incorrectly identifies a classpath removal when only a content-based path's hash changes, rather than an actual path removal. This **test case addition** is crucial for reproducing and subsequently fixing an issue that could lead to unnecessary full compilations, thereby impacting build performance.

This commit delivers a **bug fix** for the **Kosabi compiler plugin**, resolving an issue where it failed to strip top-level property delegations during its processing. Specifically, the `SourceModifierExtension.kt` file within the **Kotlin JVM stub generation** component was updated. The change **adjusts the property identification logic** in methods like `getRangesToRemove` and `isTypedProperty` to correctly include and remove delegates from top-level properties. This ensures the **Kosabi plugin** accurately processes all Kotlin property types, maintaining the integrity of generated stubs or modified source.

This commit **fixes inconsistent Kotlin build failures** by **forcing non-incremental compilation** specifically when dependencies are removed from `BUCK` files. The **Kotlin incremental compiler** previously struggled to reliably detect references to classes from removed dependencies, leading to incorrect successful builds. To address this, a new `ClasspathChanges.HasRemovals` type and a `hasClasspathRemoval()` method in `SnapshotsActionMetadata` were introduced to explicitly identify such removals. This ensures that the `JvmCompilationConfigurationFactory` triggers a full recompile only when necessary, **enhancing build correctness** for Kotlin projects within the `buck` system while preserving incremental compilation for additions and modifications.

This commit **improves the error message** displayed when **duplicate classes** are detected during the **Android build process**. Specifically, it enhances the output of the `duplicate_class_checker.py` tool by adding actionable instructions for debugging. The updated message now suggests running `buck cquery allpaths(<apk_target>, <library_target>)` or `arc deppy explain-dep <apk_target> <library_target>` to help **developers and sheriffs** identify the dependency paths causing the conflict. This **developer experience enhancement** aims to streamline the **triaging and resolution of duplicate class issues**, making the build debugging process more efficient.

This commit delivers a **bug fix** for the **Kotlin incremental compilation (KSIC)** system, addressing an issue where changes to `extra_kotlinc_arguments` were not being correctly recognized. The fix modifies `prelude/kotlin/kotlincd_jar_creator.bzl` to **update the incremental configuration version** and explicitly **include `extra_kotlinc_arguments` in the metadata struct** generated by `_create_incremental_config`. This ensures the **Kotlin build system** properly invalidates and recompiles when these critical compiler parameters are altered, preventing stale builds and improving overall build correctness.

This commit **increases the maximum wait time** for the **Android installer service** from 6 minutes to 10 minutes. This **maintenance adjustment** in `InstallerService.java` prevents premature timeouts during installation processes, particularly for larger or more complex applications. The change ensures that the installer has sufficient time to complete its operations, thereby improving the overall reliability and stability of the **Android toolchain** within the build system.

This commit introduces a **usability improvement** by updating the error reporting within the **Buck Android toolchain's `zipalign` component**. It modifies the `prelude/toolchains/android/src/com/facebook/buck/android/zipalign/ZipAlign.java` file to provide **mitigation guidance** when the `zipalign` operation fails due to exceeding the 2^16 entries limit. This **maintenance enhancement** ensures that developers encountering this specific `zipalign` error receive direct, actionable advice within the build output. The change aims to **streamline debugging** and improve the clarity of build failures for Android application development.

This commit **refactors** the **Kotlin compilation process** within Buck's Android toolchain by **removing custom `JavaKStub` translation logic**. Instead, it now **leverages `Javac`** to generate the Application Binary Interface (ABI) for **KSP (Kotlin Symbol Processing) outputs**. This change, implemented in `prelude/toolchains/android/src/com/facebook/buck/jvm/kotlin/DaemonKotlincToJarStepFactory.java` within the `createCompileToJarStepImpl` method, streamlines the **source-only ABI path** for Kotlin projects. By relying on the standard Java compiler, this improves consistency and potentially efficiency in ABI generation for KSP-generated code.

This commit introduces a **new capability** for the **Java compilation system** within Buck, allowing `Jsr199Javac` to output **stub JAR class files directly to a specified directory** instead of always packaging them into a `.jar` archive. This **feature** is enabled by a new `isMixedModule` flag, which is propagated through various **Java compilation steps** and their factories, including `JavacStep`. The **ABI generation logic** in `Jsr199JavacInvocation` and `StubGenerator` is updated to leverage a new `StubClassFileWriter` for this direct output. Additionally, a `DowngradeMissingAnnotationErrorMessager` is introduced to **downgrade missing annotation errors to warnings**, supporting more lenient compilation in mixed module environments. This **enhances the flexibility of ABI generation** for **mixed compilation** scenarios, providing more granular control over build artifacts.

This commit implements a **temporary workaround** within the **Kotlin compilation process** by conditionally **disabling dependency file generation**. It modifies the `_define_kotlincd_action` function in `prelude/kotlin/kotlincd_jar_creator.bzl` to prevent the creation of dependency files when the `should_kosabi_jvm_abi_gen_use_k2` flag is set to true. This **maintenance change** addresses the current state where the K2-based classes plugin for **Kosabi JVM ABI generation** is not yet fully ready. The scope of this change is to prevent potential build issues or incorrect dependency tracking for builds attempting to leverage K2 for Kosabi ABI generation until full K2 support is implemented.

This commit **enables `DEP_FILE` generation for Kosabi targets**, specifically for `source_only_abi` builds, extending an optimization previously limited to Library builds. By modifying the `_define_kotlincd_action` in the **`prelude/kotlin/kotlincd_jar_creator.bzl` Buck rule**, this **new capability** allows for more precise dependency tracking. This change introduces a **significant build efficiency improvement** for Kosabi projects. It will lead to **faster build times** by leveraging `LOCAL_DEP_FILE` hits, preventing unnecessary rebuilds when changes occur in unused classes within `source_only_abi_deps`.

This commit **enhances the Kotlin compilation process** within **Buck2's Android toolchain** by **enabling the generation of class usage files (`DEP_FILE`) for Kosabi builds**. Previously restricted to standard library builds, this **new capability** updates the conditional logic in `KotlincStep.java` to output these files for Kosabi targets. This change allows for more precise dependency tracking, significantly **reducing unnecessary rebuilds** of Kosabi targets when changes occur in unused classes of their `source_only_abi_deps`. Ultimately, this **improves overall build performance** through increased `LOCAL_DEP_FILE` cache hits.

This commit introduces a **performance optimization** for **Kosabi targets** within the **Kotlin build system** by enabling the `DEP_FILE` mechanism. It modifies the `Ksp1Step` and `KspStepsBuilder` to accept and pass a `shouldTrackClassUsage` flag, which activates class usage tracking during KSP1 compilation. This allows for more granular dependency analysis, preventing unnecessary rebuilds of `source_only_abi` targets when changes occur in unused classes of their `source_only_abi_deps`. The primary impact is **reduced build times** due to increased `LOCAL_DEP_FILE` hit rates for Kosabi targets.

This commit **increases the maximum timeout** for **Android application installations** performed by the **Buck build system**. Specifically, the wait time within the `InstallerService.java` component has been extended from 4 minutes to 6 minutes. This **maintenance adjustment** aims to prevent premature timeouts during the installation process, thereby improving the reliability of Android builds, especially for larger applications or slower environments.

This commit **refactors** the **Kotlin compilation process** within the `buck` build system by **disabling** the `usedclass` plugin during the **Kosabi stub generation step**. It modifies the `KosabiStubgenStep` constructor in `KosabiStubgenStep.java` to explicitly set the `trackClassUsage` parameter to `false`. This ensures the `usedclass` plugin, which is intended for the main Kotlin compilation, does not run unnecessarily during stub generation, thereby **optimizing build performance** and preventing unintended side effects in the stubbing phase.

This commit performs **maintenance cleanup** by **removing unused dependencies** from the **analysis API** module. Following the deletion of their usage in a previous change (D82131951), these dependencies are no longer required. This **dependency cleanup** helps to streamline the project's dependency graph, potentially reducing build times and binary size for components relying on the analysis API.

This commit performs a **refactoring** and **maintenance** cleanup within the **Kotlin stub generation process** of the `buck` build system. It **removes** the `kosabi_stubs_gen_extra_kotlin_home_library` parameter and its associated logic from `prelude/toolchains/android/src/com/facebook/buck/jvm/kotlin/KosabiStubgenStepsBuilder.java`, specifically within the `buildSteps` method. This parameter, originally introduced to facilitate the use of the **Kotlin Analysis API for stub generation**, is now obsolete. The change simplifies the configuration and improves the clarity of the **Android toolchain**'s Kotlin build logic by eliminating unnecessary code.

This commit **refactors** the **Kotlin stub generation process** within the `kosabi` plugin by **removing its dependency on the Analysis API**. Specifically, the `StubsCodegenK2FirAnalysisHandlerExtension.kt` now retrieves Kotlin files directly from `KotlinCoreEnvironment` instead of performing a full analysis session. This change is a **performance optimization** aimed at reducing build overhead, as the Analysis API was found to introduce significant latency (e.g., 250 ms for certain targets) when only `KTFiles` were required. Consequently, this should lead to **faster build times** for projects utilizing this stub generation mechanism.