SteVen Batten

This commit **resolves a bug where the 'Memory' tool was duplicated** in the Copilot tool picker, improving the user experience. It addresses this by **reassigning the 'Memory' tool's category** from 'Core' to 'VSCodeInteraction' within the `toolCategories` constant in `extensions/copilot/src/extension/tools/common/toolNames.ts`. This **maintenance fix** ensures that the tool is correctly categorized and appears only once, streamlining the selection process for **Copilot's memory features**.

This commit provides a **bug fix** for the **workbench title bar's menubar control**, specifically addressing an issue with **action runner event listener registration**. Previously, the event listener in `src/vs/workbench/browser/parts/titlebar/menubarControl.ts` was not being properly disposed of, potentially leading to resource leaks or unexpected behavior. By wrapping the listener registration with `this._register()`, this **maintenance fix** ensures correct lifecycle management and proper cleanup. This improves the overall stability and efficiency of the **workbench UI**'s command handling, preventing "waste" by ensuring event listeners are correctly de-registered.

This commit introduces a **logic correction** within the **Copilot extension's file creation tools**. Specifically, it **removes a redundant content exclusion check** from the `CreateFileTool`'s `run` method in `extensions/copilot/src/extension/tools/node/createFileTool.tsx`. This change is implemented because the content processed by this tool originates directly from the model, making the additional exclusion check unnecessary and streamlining the process for model-generated file content. The update ensures more efficient and accurate handling of file creation requests within the Copilot feature.

This commit introduces a **new capability** by implementing a comprehensive **chat tips service** to enhance user guidance within the **Chat feature**. It provides contextual tips directly in the chat interface, managed by frequency logic and new context keys like `chatModeName` for dynamic display. The work involves new core service logic in `chatTipService.ts`, dedicated UI components for rendering tips in `chatTipContentPart.ts` with associated styling, and integration into the `chatListRenderer.ts` for display. This significantly improves the user experience by offering timely and relevant suggestions, aiding in feature discovery and efficient chat usage.

This commit introduces a **new capability** to the **Chat feature**, enabling users to **switch the chat's operational mode by name**. The `src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts` file was updated to implement this functionality, specifically within the **Chat workbench contribution's action handling**. This enhancement provides a more direct and flexible way to control chat behavior, improving user interaction and potential for automation within the **VS Code Chat experience**.

This introduces a new capability to the chat feature, allowing its tools to read files outside the current workspace. This significantly expands the chat's data access scope, likely requiring user confirmation for security and privacy.

This commit introduces a **new capability** to the **telemetry system** by implementing a buffering mechanism for events. It ensures that telemetry events are not logged until the experiment configuration is fully loaded and set, preventing premature event submission and guaranteeing data accuracy. The core `TelemetryService` in `src/vs/platform/telemetry/common/telemetryService.ts` now buffers events and flushes them once experiment properties are established via `setExperimentProperty`. This enhancement, facilitated by a new `experimentsEnabled` utility, impacts the **Workbench telemetry services** across browser and Electron environments, as well as the **assignment service**, to provide more reliable data collection for experiments.

This commit **adds a new telemetry event** to track when the **chat view** is opened within the application. Specifically, it integrates a telemetry service into the `ChatViewPane` in `src/vs/workbench/contrib/chat/browser/chatViewPane.ts` to log a `ChatViewPaneOpenedClassification` event, likely within the `renderBody` method. This **new capability** enhances usage analytics for the **Chat UI**, providing valuable data for understanding user engagement and informing future development efforts.

This commit performs a **refactoring** by **upgrading the `tas-client` library to version 0.3.1** and eliminating the use of its "umd" variant. This update primarily impacts the **assignment and experimentation services**, necessitating adjustments to import paths within files such as `src/vs/platform/assignment/common/assignment.ts` and `src/vs/workbench/services/assignment/common/assignmentService.ts`. Specifically, the instantiation parameters for `ExperimentationService` were updated to align with the new library API. This ensures continued compatibility and leverages the latest features of the `tas-client` dependency.

This commit **refactors** the **language model (LLM) selection mechanism** within the **terminal output monitoring** feature. A new private method, `_getLanguageModel`, is introduced in `src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/monitoring/outputMonitor.ts` to centralize LLM instantiation, including a **fallback mechanism** for improved robustness. Existing methods such as `_assessOutputForErrors` and `_getSuggestedFix` are updated to utilize this new, more reliable selection logic. This **maintenance** effort enhances the consistency and maintainability of LLM interactions for analyzing terminal output.

This commit introduces a **new capability** to filter experimental traffic based on a developer device ID. It **enhances the assignment system** by adding a `DeveloperDeviceId` filter to the `AssignmentFilterProvider` in `src/vs/platform/assignment/common/assignment.ts`. Concurrently, the `WorkbenchAssignmentService` in `src/vs/workbench/services/assignment/common/assignmentService.ts` is updated to supply this developer device ID to the filter provider. This allows for more granular control over experiment participation, enabling targeted testing and debugging of experimental features on specific development devices.

This commit **enhances the user interface and accessibility** of the workbench views by preventing redundant information in ARIA labels. It modifies the `getAriaLabel` method within the `src/vs/workbench/browser/parts/views/viewPane.ts` module. Specifically, this **UI refinement** ensures that the view container title is not displayed in the ARIA label if it is identical to the view pane title. This change provides a cleaner and more concise experience for users, particularly those relying on screen readers, by improving the clarity and focus of accessibility information within the **view panes**.

This commit **enhances the Copilot entitlement system** by incorporating additional internal organization identifiers. It updates the `chatEntitlementService.ts` to include `MicrosoftCopilot` in its internal organization checks, ensuring proper recognition for chat-related entitlements. Furthermore, the `assignmentFilters.ts` module is modified to correctly identify both `ms-copilot` and `MicrosoftCopilot` as Microsoft internal organizations during the `updateCopilotEntitlementInfo` process. This **new capability** ensures accurate and consistent entitlement provisioning for internal users across various **Copilot-related features**.

This commit **removes an obsolete click protection mechanism** from the **dropdown UI component** within the `vs/base/browser/ui/dropdown` module. Specifically, it eliminates the `e.detail > 1` condition from the mouse event listener in the `dropdown.ts` constructor. This **maintenance refactoring** addresses an issue where the original problem (#41363) that necessitated this protection no longer reproduces, making the code redundant. The change **simplifies the dropdown's event handling logic**, ensuring it operates efficiently without unnecessary checks and potentially resolving subtle interaction issues related to multiple clicks.

This commit **refactors** the **About dialog** implementation to ensure comprehensive product details are always displayed, regardless of whether native or custom dialogs are in use. It introduces new utility functions, `createBrowserAboutDialogDetails` and `createNativeAboutDialogDetails`, to centralize the generation of environment-specific information like product versions, commit IDs, and OS details. The core **dialog handlers** (`BrowserDialogHandler`, `NativeDialogHandler`) and the `IDialogHandler` interface are updated to accept these pre-computed details, effectively decoupling the data generation from the dialog's display logic. This **enhancement** improves the **consistency and robustness** of the "About" dialog across all platforms, addressing cases where custom dialogs might previously lack full details.

bump @vscode/copilot-api to 0.1.1

This commit **enhances the Copilot prompt logging mechanism** by **removing the internal user check** from the `requestLoggerImpl.ts` module. Specifically, the `requestLoggerImpl` class, including methods like `logToolCall` and `logChatRequest`, will now **unconditionally log all prompt requests**. This **feature enhancement** ensures **comprehensive observability** of Copilot prompt interactions, providing a complete and unfiltered record for analysis and debugging purposes across all user types.

This commit **fixes the default visibility** of the **Copilot chat debug view** within the **Copilot extension**. It introduces new logic in `extensions/copilot/src/extension/contextKeys/vscode-node/contextKeys.contribution.ts` to conditionally control when the debug view is shown by default, likely based on internal status or environment. Additionally, a new "Show Chat Debug View" command is added, allowing users to explicitly open the view, with its localized string included in `extensions/copilot/package.nls.json`. This work is a **bug fix** that improves the initial state of the debug view and provides better control over its display for developers and advanced users.

This commit **reverts** the recently introduced **model categories** feature within the **chat model picker**. It specifically undoes the categorization logic in the `showAt` method of `ModelPickerWidget` and removes the dependency on `IChatModelCategoryService`, thereby disabling the ability to group chat models. A related change in `src/vs/platform/actionWidget/browser/actionList.ts` concerning header text rendering is also reverted. The primary impact is that users will no longer see chat models organized into categories when selecting a model.

This commit **improves the default language model selection logic** within the **Chat input part** by addressing an issue where outdated default models could be restored. It introduces new logic in `src/vs/workbench/contrib/chat/browser/chatInputPart.ts` to store and check if a selected language model was the default when persisted, utilizing symbols like `getSelectedModelIsDefaultStorageKey`. This **enhancement** prevents the system from restoring old default models if a new one has since been established, ensuring users consistently see the most current default language model in the chat interface.