Santhosh Nagaraj

This commit performs a **refactoring** within the **SwitchState** module by **removing deprecated code** related to interface neighbor tables. Specifically, it deletes the `migrateNeighborTables` function and its invocation from `uniquePtrFromThrift` in `fboss/agent/state/SwitchState.cpp`. This cleanup improves code maintainability by eliminating unused migration logic and also updates the description for the `intf_nbr_tables` flag. The change streamlines state management by removing a no-longer-needed component, without impacting current runtime behavior.

This commit performs **code cleanup** and **simplification** within the **IPv4 test suite** by modifying `fboss/agent/test/IPv4Test.cpp`. It **removes unused includes** and streamlines the `setupTestHandle` function. Specifically, the **ARP response table setup logic** is simplified by eliminating an unnecessary conditional flag check, improving the maintainability of the **test infrastructure** without affecting production code.

This commit **refactors** the **NDP test suite** in `fboss/agent/test/NDPTest.cpp` by converting most tests from `TYPED_TEST_SUITE` and `TYPED_TEST` macros to the `TEST_F` fixture-based approach. This **simplifies** the **NDP testing logic** by eliminating `isIntfNbrTable()` conditional branches and standardizing on an **interface-based approach** for NDP entry handling, updating constructors like `WaitForNdpEntry*` to use `InterfaceID` instead of `VlanID`. This **test infrastructure improvement** streamlines future test development and readability for the affected NDP tests, excluding five specific tests slated for later migration.

This commit performs **maintenance** by **refactoring** comments within the **FBOSS CLI's clear commands utility**. Specifically, it **cleans up and simplifies explanations** regarding the behavior of the `interfaceID` parameter in the `flushNeighborEntries` function, located in `fboss/cli/fboss2/commands/clear/CmdClearUtils.h`. This change improves **code readability** and maintainability for developers working on the `clear` command functionality, with no impact on runtime behavior or user-facing features.

This commit **simplifies the `AgentEcmpNeighborTest`** by **removing conditional logic and flags** associated with `intf_nbr_tables` from `fboss/agent/test/agent_hw_tests/AgentEcmpTests.cpp`. This **test maintenance** effort streamlines the test's setup and its `getNdpTable` method, making the test suite cleaner and potentially more robust. The change specifically targets the **ECMP test suite**, improving its clarity and reducing unnecessary complexity.

This commit **refactors** the **`ResolvedNexthopMonitor`** by **removing its internal interface neighbor table** from `ResolvedNexthopMonitor.cpp`. This change simplifies the monitor's data management responsibilities, as it no longer needs to maintain this specific network state directly. The removal streamlines the monitor's internal logic and reduces its dependencies, likely delegating this data management to another component or indicating it's no longer required for its core function. This is an internal **architectural improvement** that simplifies the `ResolvedNexthopMonitor` subsystem.

This commit **refactors** the **hardware route testing suite** by modifying `fboss/agent/hw/test/HwRouteTests.cpp`. Specifically, it targets the `HwRouteNeighborTest` by **removing the `intf_nbr_table` flag** and **simplifying the underlying neighbor table retrieval logic**. This **test maintenance** effort improves the clarity and efficiency of the existing tests. The change enhances the maintainability and readability of the **hardware route tests** without altering any production functionality or behavior.

This commit **refactors** the **`TeFlowTest` suite** by removing the templated `intf_nbr_table` configuration from `fboss/agent/state/tests/TeFlowTests.cpp`. This **maintenance** effort simplifies the test setup for TE Flow functionality. Specifically, it converts existing `TYPED_TESTs` to `TEST_Fs`, streamlining the test structure and making it easier to understand and maintain. The change improves the overall **test infrastructure** for TE Flow without altering any production code.

This commit **migrates** the `PendingNdp` test within `NDPTest.cpp` to utilize **interface-based neighbor tables** with **port-RIF configuration**, resolving a previously skipped test case. The **test update** adapts the verification logic to account for how pending NDP entries for the CPU port are handled differently in the new configuration, where they reside only in the internal neighbor cache and not `SwitchState`. It now specifically validates that upon receiving a Neighbor Advertisement, the entry correctly transitions to a **REACHABLE** state, which is then programmed to `SwitchState` and can be verified, ensuring comprehensive testing of **NDP behavior** with the updated architecture.

This commit **refactors** the **`StaticL2ForNeighborObserverTests.cpp`** test file by removing conditional logic associated with `intf_nbr_table` and `FLAGS_intf_nbr_tables`. This **simplifies** the test's `SetUp`, `resolveNeighbor`, and `unresolveNeighbor` methods, streamlining how neighbor resolution and unresolution are verified. The change improves the clarity and maintainability of the **`fboss/agent/test`** module by eliminating outdated conditional paths. This is a **test improvement** that makes the neighbor observer tests more focused and easier to understand.

This commit **migrates** the `PendingNdpCleanup` test in `NDPTest.cpp` to support **interface-based neighbor tables** using **port-RIF configuration**. Previously skipped for this configuration, the test's logic is **adapted** to verify the cleanup of pending **Neighbor Discovery Protocol (NDP)** entries. Instead of relying on `SwitchState` visibility, which doesn't show CPU port pending entries in the new setup, the test now indirectly validates cleanup by observing internal cache expiration and re-solicitation behavior. This **test adaptation** ensures proper validation of NDP cleanup functionality within the updated network stack architecture, resolving a previously disabled test case.

This commit **refactors** the **DHCPv4 handler test suite** by eliminating the `isIntfNbrTable` parameter from various test setup functions, such as `setupTestHandle` and `setupTestHandleNAT`. This **maintenance** effort also converts existing typed tests within `DHCPv4HandlerTest.cpp` to utilize standard test fixtures, streamlining the test infrastructure. The change simplifies the test code, making the **DHCPv4 handler tests** more maintainable and easier to comprehend. This refactoring improves the clarity and structure of the test module without altering the functional behavior of the DHCPv4 handler.

This commit **removes the `intf_nbr_table` variable** from the `PortUpdateHandlerNDPTest.cpp` file. This is a **test cleanup** and **refactoring** effort within the **Neighbor Discovery Protocol (NDP) testing suite**. The variable was found to be unused in the `PortUpdateHandlerNDPTest` class, and its removal **streamlines the test code**. This change improves the maintainability of the test infrastructure without impacting any production code or the functional behavior of NDP.

This commit performs **test cleanup** by **removing the `intf_nbr_table`** from the `AgentRouteTests.cpp` file. This change specifically affects the **agent route testing suite**, streamlining the test setup by eliminating an unnecessary or deprecated data structure. The removal helps to maintain the **test code's relevance and efficiency**, ensuring that future tests are not burdened by obsolete components.

This commit provides a **bug fix** to resolve a **port-flap bug** within the **NeighborCache** implementation. It corrects the logic in `getUpdateFnToProgramPendingEntry` by ensuring the incoming port parameter is used when setting the `portId` for `PENDING` neighbor entries, rather than a stale `fields.port` value. Additionally, it removes erroneous `encapIndex` allocation logic that incorrectly relied on the stale port for scope resolution. This change prevents incorrect port assignments and `encapIndex` allocations, thereby enhancing the stability and correctness of neighbor entry management in the `fboss/agent`.

This commit performs **code cleanup** by removing outdated comments from the `fboss/agent/test/TamManagerTest.cpp` file. Specifically, it targets comments related to **interface neighbor tables** within the test setup and helper functions of the **`TamManagerTest`**. This **maintenance** task improves the readability and accuracy of the test suite's documentation, ensuring that comments reflect the current state of the code without altering any functional behavior. The change is limited to the test infrastructure and has no impact on the runtime behavior of the `fboss` agent.

This commit **refactors** the **NeighborUpdaterImpl** component by **removing the `FLAGS_intf_nbr_tables` feature flag** and its associated conditional logic from `NeighborUpdaterImpl.cpp`. This change **simplifies the neighbor update mechanism** by making the use of interface neighbor tables the **default and sole behavior**, eliminating a configuration option that is no longer necessary. The update streamlines the internal logic for managing ARP and NDP caches, affecting functions like `getArpCacheData` and `getNdpCacheData`. This ensures consistent handling of neighbor table entries, including during port state changes (`portDown`, `portFlushEntries`) and timeout events (`timeoutsChanged`).

This commit **refactors** the **`SwSwitchTest.cpp`** file by removing the `intf_nbr_table` templated test setup. Specifically, it simplifies the `SwSwitchTestNbrs` test suite by eliminating the associated conditional logic for neighbor table access and update calls. This **test simplification** improves the clarity and maintainability of the test code, particularly within the `SetUp` and `TestStateNonCoalescing` methods.

This commit performs a **code simplification and refactoring** by removing the redundant `use_intf_nbr_tables` boolean parameter from the `getNeighborEntryForIP()` and `getNeighborTableForVlan()` functions within the **FBOSS agent's utility module**. Since the `FLAGS_intf_nbr_tables` feature flag now defaults to true, this parameter is no longer necessary, allowing for a cleaner API and implementation in `Utils.h` and `Utils.cpp`. The change impacts various core components, including **IPv6 handling**, **route updating logic**, **MAC table management**, and **switch core operations**, which now call these functions with fewer arguments. This streamlines the codebase by eliminating an obsolete conditional path and improving maintainability across the affected modules.

This commit **refactors** the **ECMP setup helper functions** within `fboss/agent/test/EcmpSetupHelper.cpp` by **removing the `intf_nbr_tables` flag and its associated conditional logic**. This **maintenance refactoring** simplifies the internal implementation of neighbor table retrieval, specifically impacting functions like `resolveVlanRifNextHop` and `unresolveVlanRifNextHop`. The change improves the clarity and reduces complexity of the ECMP test utilities, making the code easier to understand and maintain without altering external behavior.