Scott Smith

This commit **improves the quality and accuracy of the BSP API specification documentation** by addressing several **documentation maintenance** tasks. Specifically, it updates the `docs/docs/platform/bsp_api_specification.md` file to fix typos, correct formatting, update an outdated kernel documentation link, and refine example commands. This ensures that developers and users referencing the **platform's BSP API** documentation will encounter clearer, more precise, and up-to-date information, enhancing their understanding of the system's interfaces.

This commit performs a **documentation update** to the **BSP API specification**, specifically correcting an example LED color. It **updates the example text** within the `docs/docs/platform/bsp_api_specification.md` file, changing the specified LED color from 'red' to 'amber'. This **maintenance** ensures the documentation accurately reflects the intended or current color usage for LEDs, improving clarity and correctness for developers referencing the platform's Board Support Package API.

This commit **updates the platform documentation** to standardize and simplify **LED naming conventions** for Board Support Packages (BSPs). It **clarifies the specification** within `bsp_api_specification.md` and `bsp_development_requirements.md` by removing a conditional rule for port LED naming. Consequently, **port LEDs** must now consistently include both port and LED numbers, irrespective of the total number of LEDs per port, which simplifies the overall naming scheme. This **documentation update** aligns the specification with current reality, providing clearer and more consistent guidelines for BSP developers.

This commit **updates and clarifies documentation** within the **platform BSP API specification** and **BSP development requirements**. It resolves conflicting information between `docs/docs/platform/bsp_api_specification.md` and `docs/docs/platform/bsp_development_requirements.md` by providing consistent and accurate descriptions for **FPGA-related sysfs files**. Specifically, it adds read/write status and detailed explanations for `fw_ver`, `fpga_ver`, and `fpga_sub_ver`, ensuring developers have clear guidance. This **documentation maintenance** improves the accuracy and consistency of information regarding FPGA versioning.

This commit introduces a **new test case** within the **BSP platform watchdog tests** (`WatchdogTests.cpp`) to validate a critical error handling scenario. It specifically verifies that attempting to **open an already active watchdog device** correctly fails with an `EBUSY` error, aligning with BSP specifications. This **enhances test coverage** for the **watchdog subsystem**, ensuring the platform's device management adheres to expected error handling behavior and improves the overall robustness of the BSP.

This commit introduces a **new capability** by adding a 'BSP Release' skill for Large Language Models (LLMs), documented in `fboss/.llms/skills/bsp-release.md`. This skill teaches the AI the **end-to-end process for releasing a new FBOSS BSP version**, encompassing all steps from pulling source code using `bspctl` to bumping the BSP version in the platform manager. This enhancement aims to **automate and streamline the complex workflow** involved in BSP releases, significantly impacting the **management and deployment of FBOSS BSP versions**.

This commit performs a **maintenance update** by bumping the `bspKmodsRpmVersion` for **Arista Board Support Package (BSP) kernel modules** to `0.7.21-1`. It specifically updates the `platform_manager.json` configurations across several Arista platforms, including `icecube800banw`, `meru800bia`, `blackwolf800banw`, `meru800bfa`, `darwin48v`, and `darwin_netos`. This ensures these platforms utilize the latest kernel module version, while the `darwin` platform is intentionally excluded and remains on an older version. The change primarily affects the **platform configuration management** for these Arista devices, ensuring they are provisioned with the specified kernel module version.

This commit delivers a **robustness improvement** and **bug fix** for the **`fw_util` utility**, specifically addressing its firmware version listing functionality. Previously, the utility would crash and cease listing versions if it encountered any unreadable firmware entries. A `try-catch` block has been implemented within the `printAllVersions` function in `fboss/platform/fw_util/FwUtilVersionHandler.cpp` to gracefully handle these exceptions. This ensures that `fw_util` will now log errors for unreadable versions but continue to list all other accessible firmware versions, preventing crashes and providing more complete diagnostic information to users.

This commit performs a **platform configuration update** for the **ladakh800bcls** platform, specifically replacing the `anacapa_rtmcpld` kernel driver with a more generic `fbg_rtmcpld` driver for the **RTM_L_CPLD** and **RTM_R_CPLD** units. The change involves updating the kernel device name in `platform_manager.json` and adding detailed `cpldSysfsAttrs` to ensure proper interaction with these CPLDs. This **driver replacement** streamlines CPLD management by leveraging a generalized driver, improving maintainability and consistency across different CPLD instances on the platform.

This commit **updates the platform configuration** for the **`tahan800bc`** and `janga800bic` platforms by **replacing the platform-specific `mtia_pwrcpld` kernel driver with a generic `fbg_pwrcpld` driver** for the **`PWR_CPLD`** component. Specifically, the `fboss/platform/configs/tahan800bc/platform_manager.json` file is modified to reflect this change, updating the kernel device name and adding detailed CPLD system file attributes. This **maintenance and feature update** standardizes the CPLD driver implementation, potentially simplifying future support and consistency across different hardware platforms.

This commit performs a **driver migration** for the **MCB_CPLD** on **Wedge800bact** and **Wedge800cact** platforms, replacing the platform-specific `w800_mcbcpld` kernel driver with a more **generic CPLD driver**. This **refactoring** effort enhances modularity and maintainability by standardizing CPLD interactions. The **platform configuration** files, specifically `fboss/platform/configs/wedge800bact/platform_manager.json` and `fboss/platform/configs/wedge800cact/platform_manager.json`, are updated to reflect the new kernel device name for `MCB_CPLD`. Furthermore, these configurations now include a comprehensive list of CPLD system file attributes, detailing their register addresses and descriptions, which is essential for the generic driver's operation and consistent CPLD management across supported Wedge800 variants.

This commit **updates the platform configuration** for **Minipack3n** to integrate a **generic CPLD driver**, replacing the previously platform-specific `mp3n_mcbcpld` kernel driver. Specifically, the `fboss/platform/configs/minipack3n/platform_manager.json` file is modified to update kernel device names for `MCB_CPLD` and `SMB_CPLD`. This **platform update** also introduces detailed `sysfs` attribute configurations for these CPLDs, streamlining their management and enabling a more standardized approach to CPLD interaction on the Minipack3n platform.

This commit **updates the IceTea platform configuration** to transition from the platform-specific `icetea_mcbcpld` kernel driver to a more **generic CPLD driver**. It modifies `fboss/platform/configs/icetea/platform_manager.json` to reflect new kernel device names and introduces detailed CPLD sysfs attributes for both the **MCB_CPLD** and **PIC_CPLD** components. This **platform configuration update** is a **maintenance effort** that streamlines CPLD management by leveraging a standardized driver, improving consistency and maintainability across the **IceTea hardware platform**.

This commit **replaces the specific `pwr_cpld` driver with a more generic driver** for the **Janga800BIC platform**. As part of this **configuration update**, the `platform_manager.json` file is modified to reflect the new kernel device name for the PWR_CPLD. Additionally, it **adds new sysfs attributes** for CPLD version, board ID, and slot ID, enhancing the platform's ability to expose detailed hardware information. This **feature enhancement** improves driver reusability and provides richer CPLD telemetry for the Janga800BIC.

This commit introduces a **new feature** enabling the **`sensor_service`** to read sensor data from devices mapped under `/run/devmap/cplds/`. This **enhancement** expands the service's monitoring capabilities beyond `/run/devmap/sensors/` to include critical CPLD-specific alerts, such as PSU pins. It updates the **platform configuration validation** by modifying `kRuntimePathRegex` to recognize these new runtime paths and adjusts `isValidPmSensors` to accept them. This ensures that configurations referencing CPLD devices are properly validated and integrated into the system's comprehensive hardware monitoring.

This commit introduces a **configuration update** to the **Montblanc platform's Platform Manager**, specifically modifying how **PSU status sysfs files** are interpreted. By adding a `decimal` flag to several power supply unit status entries within `fboss/platform/configs/montblanc/platform_manager.json`, the system is now instructed to display these values as decimal rather than hexadecimal. This **enhancement** is critical for enabling correct data interpretation and integration with the `sensor_service`, ensuring accurate monitoring of PSU status. The change improves the reliability and consistency of sensor data reported across the platform.

This commit **implements a significant update to the CPLD management** for the **`tahansb800bc` platform**. It **replaces the platform-specific `tahansb_mcbcpld` kernel driver with a generic CPLD driver**, standardizing the approach to CPLD interaction. This **refactoring** involves updating the `fboss/platform/configs/tahansb800bc/platform_manager.json` configuration to reflect the new kernel device name and integrate new CPLD system file attributes. The change ensures the `tahansb800bc` platform leverages a more generic and potentially more robust CPLD driver, improving maintainability and consistency across platforms.

This commit **enhances hardware monitoring capabilities** for the **Montblanc platform** by **adding new configuration entries** for additional Power Supply Unit (PSU) status registers. It updates `fboss/platform/configs/montblanc/platform_manager.json` to include previously missing register definitions. This **new capability** allows for more comprehensive monitoring of PSU health, providing detailed metrics like thermal sensor readings, input power, and output power status for both left and right PSUs. The change significantly improves system diagnostics and operational visibility for the **Montblanc platform's power management subsystem**.

This commit **updates the `fboss_bsp_kmods` RPM version** to 4.2.0 across numerous **platform configurations**, including Icecube, Icetea, and Minipack3, by modifying their respective `platform_manager.json` files. This **dependency update** is a crucial **enabling change** for future platform enhancements. It incorporates a **new generic CPLD driver** within the updated kernel modules. This driver will allow for the future migration of register map sysfs definitions directly into the platform configurations, providing greater flexibility in hardware management. While this specific commit introduces no immediate functional changes, it prepares the system for these upcoming improvements.

This commit **implements the first generic CPLD driver** for the **Montblanc platform**, specifically the `MCB_CPLD`. It introduces a **new capability** by adding CPLD sysfs attributes configuration to `fboss/platform/configs/montblanc/platform_manager.json` and updates the associated kernel device name. This change enables proper management and interaction with the CPLD on Montblanc systems, affecting the **Montblanc platform manager** and its hardware abstraction.