Noelle Scobie

This commit **enhances debugging capabilities** within the **Graphite Vulkan backend** by including `VulkanYcbcrConversionInfo` details in the string representation generated by `VulkanTextureInfo::toBackendString()`. This **new capability** provides more comprehensive information about **Vulkan textures** in debug dumps, particularly regarding their YCbCr conversion parameters. To achieve this, a new static utility method `VulkanYcbcrConversion::InfoToString` was introduced to format the conversion data, and `VulkanCaps::toString` was **refactored** to delegate YCbCr conversion string generation to this new utility. This change significantly improves the ability to understand and diagnose texture-related issues in the GPU context.

This commit introduces a **bug fix** to the **Android port** of Skia, specifically within the `src/ports/SkLog_android.cpp` file. It addresses an issue where `error` and `fatal` log priorities were incorrectly downgraded to warnings in the **RenderEngine** context. The change ensures that only `info` and `debug` logs have their priorities adjusted, preserving the original severity of critical messages. This prevents important system failures from being overlooked due to miscategorized log levels, improving the reliability and accuracy of logging for the **RenderEngine**. The fix primarily affects the `SkLogVAList` function's priority handling.

This commit **reverts** a previous **refactoring** that aimed to move mipmap storage out of `SkBitmap` into `SkImage_Raster` and introduced a Ganesh-specific `GrMippedBitmap` class. The change **restores mipmap data directly within `SkBitmap`** and removes the `GrMippedBitmap` wrapper, simplifying mipmap handling across the codebase by re-integrating mipmap management into `SkBitmap`. This rollback affects core **Skia rendering components** like `SkDraw`, `SkBitmapDevice`, and `SkImage_Raster`, as well as numerous **Ganesh GPU backend** modules and **image factory functions**. This is a **temporary measure** to create a canary for investigating potential bugs (b/480815083 and b/479634079) related to the original mipmap refactoring.

This commit **reverts** the recent **generalization of texture capability checks** within the **Graphite** rendering backend, specifically undoing the introduction of a unified `TextureUsage` bit mask system. This **bug fix** addresses a regression (bug `b/486019769`) by restoring the previous, more specific `isFoo` functions and backend-specific implementations across **Dawn**, **Metal**, and **Vulkan** `Caps` classes. The revert also undoes adjustments made to `AHB` (Android Hardware Buffer) copy-src requirements and `DawnCaps` `is_valid_view` logic, which were part of the problematic generalization. By rolling back this complex refactoring, the commit ensures that texture support and usage validation in **Graphite** revert to their prior, stable behavior, preventing further issues. This impacts the core **Graphite** `Caps` system and its backend implementations.

This commit **refactors** the **Vulkan utility macros** used by both the **GPU Ganesh** and **Graphite** backends. The primary goal of this rework is to introduce support for **optional debug logging and tracing** of every Vulkan API call. This new **debugging capability** is activated via conditional compilation, offering a robust mechanism for detailed analysis and troubleshooting of Vulkan interactions within the graphics pipeline.

This commit performs a significant **refactoring** by **unifying disparate ad hoc stringification macros** across the codebase into a single, centralized utility. It introduces `SK_MACRO_STRINGIFY` and `SK_MACRO_STRINGIFY_IMPL_PRIV` within `include/private/base/SkMacros.h`, which are then adopted by various modules. Specifically, custom stringify macros in **`SkPDFDocument`**, **`GrGLUtil`**, **`CommandLineFlags`**, and **`VkTestUtils`** are replaced with the new `SK_MACRO_STRINGIFY`. This change improves code consistency and maintainability by centralizing a common utility, reducing duplication and the potential for divergent implementations across different subsystems.

This commit **refactors** the **Skia logging system** to modify the severity of `SkDebugf` messages. Specifically, it configures `SkDebugf` calls to log at **Android's WARN level** when the Skia library is compiled for use within the **Android RenderEngine**. This **configuration adjustment** ensures that debug output from Skia components within the RenderEngine is more prominent in system logs, aiding in identifying potential issues. For all other build configurations, the `SkDebugf` calls will continue to log at their default `DEBUG` level, maintaining existing behavior outside of the RenderEngine context. This is a **maintenance** update to improve debugging visibility in a critical Android component.

This commit **reverts** the previous addition of `skhdr::Metadata` structures, specifically `skhdr::ContentLightLevelInformation` (CLLI) and `skhdr::MasteringDisplayColorVolume` (MDCV), which introduced new HDR metadata parsing capabilities within the `skhdr` namespace. This **maintenance revert** addresses a **critical build breakage in a downstream Android project**. As a result, the newly introduced HDR metadata handling and the initial steps towards replacing `gfx::HDRMetadata` with `skhdr::Metadata` are temporarily removed from the codebase.

This commit **reverts** a previous change that introduced `operator==` and `operator!=` to the `SkColorSpacePrimaries` class within the **Skia graphics library**. This **revert** is a **critical maintenance action** taken because the original addition was **breaking a downstream Android build**. By undoing the change, the commit resolves the immediate **build-breaking issue**, ensuring the stability of dependent projects. Consequently, the new comparison operators for `SkColorSpacePrimaries` are temporarily removed from the codebase.

This **maintenance** commit adds a **warning** to the `transform` methods within **`src/core/SkRRect.cpp`** to highlight a critical dependency. The `SK_SUPPORT_LEGACY_RRECT_TRANSFORM` flag is noted as "load bearing" because its removal significantly alters shader compilation patterns in **Android RenderEngine's** draw-based prewarming. Specifically, removing this legacy behavior leads to fewer shaders compiled at boot but more during subsequent interactions, necessitating this **documentation update** to prevent unintended regressions.

This commit **reverts** a previous change that removed a one-off CICP (Color Information Colour Primaries) implementation from `SkAndroidCodec` and pointed it to `SkColorSpace`'s new parsing. This **maintenance revert** was necessary to unblock an Android roll, effectively restoring the dedicated CICP logic within `SkAndroidCodec` and undoing modifications to `SkColorSpace`'s `TableEntry` struct. As a result, the prior behavior for **HLG color spaces** is reinstated, and test failures related to `toXYZD50` matrix computations are resolved by bringing back the expected color space handling.

This commit performs a **maintenance revert** of the recent **Fontations** library roll, which had updated `skrifa` and `read-fonts` dependencies. It **restores** the previous dependency versions in `MODULE.bazel` and undoes a refactoring in `src/ports/fontations/src/base.rs` that had changed how `table_directory` was accessed within the `table_tags` function. This **revert** is critical to resolve **build failures** observed in the **Skia->Android autoroller**, ensuring the stability of the Skia build process for downstream projects. By rolling back these changes, the commit prevents further disruptions and temporarily defers the `Fontations` update.

This commit performs a **maintenance update** to the **Android build system's ownership configuration**. It **replaces an outdated owner email** (`scroggo@google.com` with `egdaniel@google.com`) within the `OWNERS_build_files.android` file. This change is specifically intended to **resolve a validation check failure** that occurred when this ownership file was included elsewhere in the Android build process. The update ensures the correct processing and integration of Android build file ownership information, preventing build system errors related to owner validation.

This commit **enhances failure logging** within **Ganesh's Android surface creation** by adding detailed `SkDebugf` messages to `SkSurfaces::WrapAndroidHardwareBuffer` for improved diagnostics. It also **improves the `RENDERENGINE_ABORTF` macro** to log critical messages on Android, providing better observability for important errors across the rendering engine. Concurrently, extraneous GL-specific logging is **refactored out** of `SkSurface_Ganesh.cpp`, streamlining the codebase and replacing it with generic `RENDERENGINE_ABORTF` calls for backend texture validation. This work primarily **improves error reporting and debugging capabilities** for the **Ganesh GPU backend** on Android.

This commit performs a **refactoring** within the **SkGainmapShader** module, specifically relocating the definition of an overloaded `Make` factory method. The implementation of `SkGainmapShader::Make` has been moved from its header file, `include/private/SkGainmapShader.h`, to its corresponding source file, `src/shaders/SkGainmapShader.cpp`. This change is a **build fix** designed to resolve an `error: member access into incomplete type 'SkShader'` that was occurring during Android builds. By separating the declaration from the definition, it addresses a compilation issue related to incomplete type dependencies, ensuring the `SkGainmapShader` component builds correctly.

This commit **refactors** the **`SkEmbossMaskFilter`** component by **renaming** the `SkEmbossMaskFilter::EmbossLight` struct back to `SkEmbossMaskFilter::Light`. This **reverts a previous rename** to resolve a **build issue** affecting the Android roll. The change propagates across the `SkEmbossMaskFilter` and `SkEmbossMask` implementations and headers, updating type references in function signatures, constructors, and variable declarations. Additionally, related **graphics module (gm)** and **test files** (`gm/emboss.cpp`, `tests/BlurTest.cpp`) are updated, and a namespace qualification is adjusted in `SkLightingImageFilter.cpp` to maintain consistency.

This commit **reverts** a previous change that aimed to apply IWYU (Include What You Use) principles to the **tracing system** by modifying `SkTraceEventCommon.h`. The original modification inadvertently caused a **build failure on Android** due to an unexpected interdependence between `SkTraceEventCommon.h` and `SkTraceEvent.h` when `SK_ANDROID_FRAMEWORK_USE_PERFETTO` was defined. This **maintenance revert** is a **critical bug fix** to unblock Android builds, with an alternative solution proposed to address the include issue more robustly.

This commit performs **maintenance** by adjusting header includes to establish `SkTraceEvent.h` as the canonical entry point for the **Skia tracing system**. It adds an `IWYU pragma: export` directive to `SkTraceEvent.h` for `SkTraceEventCommon.h` to guide include-what-you-use tools. Concurrently, the **GPU Ganesh module's** `GrProxyProvider.cpp` is **refactored** to directly include `SkTraceEvent.h`, removing its dependency on `SkTraceEventCommon.h`. This change resolves a dependency inversion, primarily to **unblock an Android roll** by standardizing tracing header usage across the codebase.

This commit **updates the C++ standard configuration** for **Skia's Android builds**, reverting a temporary override that previously pinned it to `gnu++17`. It now allows Skia to use Android's global default C++ standard, which has been upgraded to `gnu++20`. This **maintenance update** resolves prior build failures that prevented the use of the newer standard, effectively **unblocking further C++20 adoption** within Skia.

This **maintenance** commit updates the **Skia Quality Program (SkQP) test suite** to align with the upcoming **Android 16 (202504) vendor API bump**. It introduces a new API level constant `kApiLevel_202504` in `tests/CtsEnforcement.h` and adjusts the enforcement levels for numerous tests across **Graphite** and **Ganesh** backends, including `F16DrawTest`, `BackendTextureTest`, and `VkProtectedContextTest`. Additionally, it fixes a formatting issue in `SkSLTest.cpp` that arose from previous API level changes. This **API level update** ensures the test suite correctly enforces API requirements for future Android releases, preventing test failures or incorrect behavior.