Developer
Nivin Lawrence
nivinl@meta.com
Performance
YoY:+335%Key patterns and highlights from this developer's activity.
Breakdown of growth, maintenance, and fixes effort over time.
Bugs introduced vs. fixed over time.
Reclassifies engineering effort based on bug attribution. Commits that introduced bugs are retrospectively counted as poor investments.
Investment Quality reclassifies engineering effort based on bug attribution data. Commits identified as buggy origins (those that introduced bugs later fixed by someone) have their grow and maintenance time moved into the Wasted Time category. Their waste (fix commits) remains counted as productive. All other commits retain their standard classification: grow is productive, maintenance is maintenance, and waste (fixes) is productive.
The standard model classifies commits as Growth, Maintenance, or Fixes. Investment Quality adds a quality lens: a commit that introduced a bug is retrospectively counted as a poor investment — the engineering time spent on it was wasted because it ultimately required additional fix work. Fix commits (Fixes in the standard model) are reframed as productive, because fixing bugs is valuable work.
Currently computed client-side from commit and bug attribution data. Ideal server-side endpoint:
POST /v1/organizations/{orgId}/investment-quality
Content-Type: application/json
Request:
{
"startTime": "2025-01-01T00:00:00Z",
"endTime": "2025-12-31T23:59:59Z",
"bucketSize": "BUCKET_SIZE_MONTH",
"groupBy": ["repository_id" | "deliverer_email"]
}
Response:
{
"productivePct": 74,
"maintenancePct": 18,
"wastedPct": 8,
"buckets": [
{
"bucketStart": "2025-01-01T00:00:00Z",
"productive": 4.2,
"maintenance": 1.8,
"wasted": 0.6
}
]
}Latest analyzed commits from this developer.
| Hash | Message | Date | Files |
|---|
Commit activity distribution by hour and day of week. Shows when this developer is most active.
Developers who frequently work on the same files and symbols. Higher score means stronger code collaboration.
| Effort |
|---|
| 473fa3df | This commit introduces a **new capability** to the **`SaiBufferManager`** by adding methods to retrieve the **configured headroom and shared buffer pool sizes**. Specifically, `getConfiguredHeadroomPoolSizeBytes()` and `getConfiguredSharedPoolSizeBytes()` are implemented to query these values from the SAI buffer pool handle, alongside a new helper `getIngressPoolDivisor()` for accurate size calculation. This **feature addition** is critical for **monitoring** and **resource tuning**, as it enables tracking fleet-wide peak buffer usage, allowing for more precise adjustments to the shared-pool and headroom allocation. | Mar 28 | 2 | grow |
| b3ce5fe4 | This commit introduces a **new capability** to track and publish the **all-time maximum global shared and headroom buffer watermarks**, crucial for **capacity planning** and resource tuning. It implements `updateGlobalWatermarkMax()` within the **telemetry system** (`HwSwitchFb303Stats`) to record these peaks, with call sites wired in both `BcmBstStatsMgr` and `SaiBufferManager` to feed samples. To circumvent ODS rollup averaging issues that dilute peak values, these maximums are published as **ephemeral TLCounters** every ~65 minutes, which are cleared after a short visibility window. This **telemetry enhancement** provides accurate long-term peak usage data, enabling more precise tuning of buffer allocations and potential reallocation of headroom to the shared pool. | Mar 28 | 3 | grow |
| 5af93aee | This commit **introduces new APIs** within the **`BcmBstStatsMgr`** to retrieve the **configured sizes of the BCM headroom and shared buffer pools**. Specifically, it adds `getConfiguredHeadroomPoolSizeBytes()` and `getConfiguredSharedPoolSizeBytes()` methods that iterate through interface ports to accurately query these settings. This **new capability** is a foundational step for **network telemetry and capacity planning**, enabling the system to track peak buffer utilization and make informed decisions to optimize the allocation between shared buffers and headroom, thereby improving network performance and resource efficiency. | Mar 28 | 2 | grow |
| b9afa0a1 | This commit introduces **new telemetry** to monitor the **peak utilization percentages** of the **headroom and shared buffer pools** within the **buffer management** subsystem. It adds **ephemeral `TLCounters`** like `buffer_watermark_global_headroom_hourly_max_pct` in `HwSwitchFb303Stats.cpp` that capture hourly peak usage and are cleared quickly to prevent corruption by **ODS rollup averaging**. This **new capability** provides crucial data for more precise **buffer pool tuning** and **resource allocation optimization**, allowing for potential reallocation of capacity from headroom to the shared pool based on observed peak usage patterns. The `SaiBufferManager` is updated to provide the necessary pool size configurations for these calculations. | Mar 28 | 3 | grow |
| 3fac13b5 | This commit **enables the PTP TC provisioning test** for **Tomahawk4 (TH4) ASICs** by configuring **PHY loopback** instead of MAC loopback for TH4 ports within the `initialConfig()` function. This crucial adjustment in `AgentHwPtpTcProvisionTests.cpp` ensures **correct PTP timestamping** on TH4, allowing the **PTP hardware test suite** to function properly on this specific ASIC type. Additionally, the commit performs **code cleanup** by removing unused variables from `sendPtpPkts()` and enhances test robustness by adding a pre-condition check for at least two available ports. This work is a **maintenance and feature enablement** effort, specifically targeting the **FBOSS agent's hardware PTP testing capabilities** on newer ASIC platforms. | Mar 20 | 1 | maint |
| 02364309 | This commit **enhances** the **fabric link monitoring test** (`AgentVoqSwitchFabricLinkMonitoringTests.cpp`) to correctly support **dual-stage VoQ switches** in **DSF cluster configurations**. Previously designed only for single-stage setups, the test now incorporates dual-stage specific system port offsets, configures appropriate fabric levels, and includes L2 fabric switches in the test setup. This **extends test coverage** for complex topologies like RDSW/EDSW, ensuring accurate validation of fabric links in these environments. The change allows the test to run successfully with dual-stage base configurations, improving the robustness of hardware testing for **DSF clusters**. | Mar 12 | 1 | maint |
| f95907da | This commit **enhances the documentation** for the **FBOSS project**, specifically providing a high-level overview of the **FBOSS agent software architecture**. It details the agent's core components, internal layering, and how it communicates via the CLI, all within the `docs/docs/FBOSS.md` file. This **documentation update** is crucial for **Open Source Software (OSS)**, offering essential architectural context to external users and contributors. The work improves the overall understanding and onboarding experience for anyone engaging with the FBOSS agent's design. | Mar 9 | 1 | maint |
| cb87b35a | This commit **introduces comprehensive documentation** for the **FBOSS2 CLI** to the project's GitHub documentation site, marking the first part of this effort. It provides an **overview of the CLI's capabilities** for monitoring, troubleshooting, and configuration, along with a command overview table and syntax patterns. This **documentation enhancement** specifically details numerous `show` subcommands, such as `acl`, `agent`, `arp`, `interface`, and `lldp`, complete with usage examples and sample outputs in `docs/docs/debugging/fboss_cli.md`. This significantly improves the **usability and understanding** of the `fboss2` command-line interface for users performing operational tasks. | Mar 5 | 1 | maint |
| 8d23f0b7 | This commit **enhances the documentation for the `fboss2 CLI`**, specifically expanding the `show` subcommands section. It adds new entries to the `show` subcommands table for `mac`, `mirror`, `ndp`, `port`, `rif`, `route`, `transceiver`, `config`, `fsdb`, and `version`. Detailed usage and sample outputs are now included for `lldp`, `mirror`, `ndp`, and `port` commands within the **`docs/docs/debugging/fboss_cli.md` file**. This **documentation update** improves the clarity and completeness of the CLI guide, aiding users in understanding and utilizing various `fboss2` operational and debugging commands. | Mar 5 | 1 | maint |
| 4756260e | This commit **completes the documentation** for the `fboss2` **CLI tool** by adding comprehensive details for a wide range of commands. It covers `clear` (including `arp`, `interface`, `ndp`, `mirror`), `set` (including `interface`, `port`, `debug`, `fanhold`), `get` (`pcap`), `config`, and operational commands like `create`, `delete`, `bounce`, `reload`, `debug`, `start`, `stop`, `stream`, and `help`. This **documentation update** in `docs/docs/debugging/fboss_cli.md` significantly enhances the usability and understanding of the FBOSS2 command-line interface for users. | Mar 5 | 1 | maint |
| 7b9532c0 | This commit **introduces support for probabilistic ECN marking**, allowing non-100% ECN mark probabilities for ASICs that are validated to support this feature. It **enhances the ECN validation logic** within the `fboss/agent` module, specifically in `ValidateStateUpdate.cpp`, to conditionally apply validation rules based on ASIC capabilities. The `hasValidPortQueues` function was refactored and updated to take an `isEcnProbabilisticMarkingSupported` parameter, ensuring consistent validation across both MONO and MULTI_SWITCH configurations. This **new capability** provides more flexible ECN control for compatible hardware while maintaining strict 100% probability for others. | Mar 2 | 4 | grow |
| 76ef0bd0 | This commit introduces a **new test case** to validate the behavior of **ECN probabilistic marking** within the `fboss/agent`'s **Active Queue Management (AQM)** system. A new test class, `AgentAqmEcnProbabilisticMarkingTest`, and a test method, `verifyEcnProbabilisticMarking`, are added to `fboss/agent/test/agent_hw_tests/AgentAqmTests.cpp`. This **new capability test** specifically ensures that ECN marking occurs correctly when configured with a probability less than 100% and a high maximum limit, enhancing the **reliability of congestion control**. A minor **refactoring** is also included, making `configureQueue2WithAqmThreshold` virtual to support this new test. | Mar 2 | 1 | maint |
| 04a22025 | This commit **enhances the test suite** by adding comprehensive unit test coverage for the **ECN probabilistic marking validation** logic. New test cases are introduced in `fboss/agent/test/SwSwitchTest.cpp` to verify boundary conditions for ECN probability (0%, 100%, and 101%) and to ensure correct behavior when the `ECN_PROBABILISTIC_MARKING` feature is **not supported** by the ASIC. This **testing enhancement** improves the robustness of ECN configuration handling, ensuring proper validation across various scenarios and hardware capabilities. | Mar 2 | 1 | maint |
| 8908ebf1 | This commit introduces **new test utilities** and **refactors existing ones** to enable comprehensive testing of **ECN probabilistic marking** within the FBOSS agent. It adds new functions like `addVoqEcnProbabilisticMarkingConfig` in `NetworkAITestUtils` and `addQueueEcnProbabilisticMarkingConfig` in `OlympicTestUtils` to configure probabilistic ECN. Existing utilities such as `addQueueEcnConfig` and `GetEcnConfig` are also updated to accept a probability parameter, allowing for flexible ECN configuration. These enhancements to the **test infrastructure** are crucial for validating the correct behavior of **Explicit Congestion Notification** and **Virtual Output Queue (VoQ) ECN** with probabilistic marking, as demonstrated by updates to `AgentAqmTests.cpp` and `AgentPortBandWidthTests.cpp`. | Mar 2 | 8 | maint |
| 2b474591 | This commit introduces a **new capability** to enable **ECN probabilistic marking** within the **SAI WRED (Weighted Random Early Detection) profiles**. It extends the **SAI WRED API** (`WredApi.h`), its fake implementation, and the `SaiWredManager.cpp` to support the new `EcnGreenMarkProbability` attribute, allowing configuration of ECN marking probability for green packets. Special handling is included for **Broadcom platforms** and **TAJO** to manage default values and ensure smooth upgrades. Furthermore, the commit addresses **warm boot compatibility** by preventing unclaimed WRED handles and correctly serializing/deserializing the new attribute in `SaiObject.cpp` during state transitions. This enhancement provides more granular control over ECN marking behavior across various platforms. | Mar 2 | 9 | grow |
| a917d22b | This commit **fixes several bugs** in the **`FabricLinkMonitoring` test** within `fboss/agent/test/agent_hw_tests/AgentVoqSwitchFabricLinkMonitoringTests.cpp`. Specifically, it **corrects the test setup** by ensuring the fabric device peer is configured with the right ASIC and platform types, and the local switch's `switchType` is explicitly set to `VoqSwitch`. Furthermore, it prevents the test from incorrectly populating self-neighbors, focusing the validation on actual fabric neighbors. This **test improvement** enhances the accuracy and reliability of **hardware tests** for **fabric link monitoring**, ensuring proper validation of fabric connectivity logic. | Feb 9 | 1 | maint |
| 6f63e887 | This commit introduces a **new hardware test** within `AgentSflowMirrorTest.cpp` to validate **sFlow mirroring** functionality. Specifically, it verifies that sFlow mirrored packets are correctly forwarded to a **remote system port** through the **VOQ infrastructure**. The test, `AgentSflowMirrorRemoteSystemPortTest`, also includes updates to helper functions for collecting **VOQ queue statistics**, ensuring robust validation of this critical data plane behavior. This enhancement improves the reliability and correctness of sFlow deployments in systems utilizing VOQ. | Feb 7 | 1 | maint |
| ca3017e2 | This commit introduces a **new test class**, `AgentSflowMirrorRemoteSystemPortTest`, within the `fboss/agent/test/agent_hw_tests` module. This **enhances test coverage** for **sFlow mirror functionality** by specifically verifying scenarios where the mirror destination is a **remote system port** reached via a Virtual Output Queue (VOQ). The new class, along with several helper functions, ensures the correct operation of sFlow mirroring in complex, distributed network environments. This **new testing capability** improves the overall reliability and robustness of the `fboss` agent's sFlow implementation. | Feb 7 | 1 | maint |
| 4a6fe033 | This commit introduces **new utility APIs** to the `VoqTestUtils` module, specifically `addRemoteSysPortAndInterface` and `resolveRouteToRemoteSysPort`. These functions are designed to streamline and encapsulate common patterns for **testing traffic forwarding** to **remote VOQ switches** within a multi-node environment utilizing the **DSF infrastructure**. By providing these helpers, the commit significantly enhances the **test infrastructure** by simplifying the setup of remote system ports, interfaces, and route resolution. This **new capability** directly benefits the development and validation of multi-node network configurations by improving the efficiency and reliability of related tests. | Feb 6 | 2 | maint |
| afe37586 | This commit **refactors** the `getRemoteVoqSwitchId` method, moving it from the `AgentVoqSwitchWithMultipleDsfNodesTest` class into a new, reusable utility function within `VoqTestUtils`. This **improves code organization and reusability** for **VOQ testing utilities** by centralizing a common API for retrieving remote VOQ switch IDs from DSF node configurations. The change also includes a minor const correctness adjustment in `assertVoqTailDrops`. This **maintenance** effort provides a shared helper, enabling cleaner and more consistent usage in subsequent development. | Feb 6 | 3 | maint |
This commit introduces a **new capability** to the **`SaiBufferManager`** by adding methods to retrieve the **configured headroom and shared buffer pool sizes**. Specifically, `getConfiguredHeadroomPoolSizeBytes()` and `getConfiguredSharedPoolSizeBytes()` are implemented to query these values from the SAI buffer pool handle, alongside a new helper `getIngressPoolDivisor()` for accurate size calculation. This **feature addition** is critical for **monitoring** and **resource tuning**, as it enables tracking fleet-wide peak buffer usage, allowing for more precise adjustments to the shared-pool and headroom allocation.
This commit introduces a **new capability** to track and publish the **all-time maximum global shared and headroom buffer watermarks**, crucial for **capacity planning** and resource tuning. It implements `updateGlobalWatermarkMax()` within the **telemetry system** (`HwSwitchFb303Stats`) to record these peaks, with call sites wired in both `BcmBstStatsMgr` and `SaiBufferManager` to feed samples. To circumvent ODS rollup averaging issues that dilute peak values, these maximums are published as **ephemeral TLCounters** every ~65 minutes, which are cleared after a short visibility window. This **telemetry enhancement** provides accurate long-term peak usage data, enabling more precise tuning of buffer allocations and potential reallocation of headroom to the shared pool.
This commit **introduces new APIs** within the **`BcmBstStatsMgr`** to retrieve the **configured sizes of the BCM headroom and shared buffer pools**. Specifically, it adds `getConfiguredHeadroomPoolSizeBytes()` and `getConfiguredSharedPoolSizeBytes()` methods that iterate through interface ports to accurately query these settings. This **new capability** is a foundational step for **network telemetry and capacity planning**, enabling the system to track peak buffer utilization and make informed decisions to optimize the allocation between shared buffers and headroom, thereby improving network performance and resource efficiency.
This commit introduces **new telemetry** to monitor the **peak utilization percentages** of the **headroom and shared buffer pools** within the **buffer management** subsystem. It adds **ephemeral `TLCounters`** like `buffer_watermark_global_headroom_hourly_max_pct` in `HwSwitchFb303Stats.cpp` that capture hourly peak usage and are cleared quickly to prevent corruption by **ODS rollup averaging**. This **new capability** provides crucial data for more precise **buffer pool tuning** and **resource allocation optimization**, allowing for potential reallocation of capacity from headroom to the shared pool based on observed peak usage patterns. The `SaiBufferManager` is updated to provide the necessary pool size configurations for these calculations.
This commit **enables the PTP TC provisioning test** for **Tomahawk4 (TH4) ASICs** by configuring **PHY loopback** instead of MAC loopback for TH4 ports within the `initialConfig()` function. This crucial adjustment in `AgentHwPtpTcProvisionTests.cpp` ensures **correct PTP timestamping** on TH4, allowing the **PTP hardware test suite** to function properly on this specific ASIC type. Additionally, the commit performs **code cleanup** by removing unused variables from `sendPtpPkts()` and enhances test robustness by adding a pre-condition check for at least two available ports. This work is a **maintenance and feature enablement** effort, specifically targeting the **FBOSS agent's hardware PTP testing capabilities** on newer ASIC platforms.
This commit **enhances** the **fabric link monitoring test** (`AgentVoqSwitchFabricLinkMonitoringTests.cpp`) to correctly support **dual-stage VoQ switches** in **DSF cluster configurations**. Previously designed only for single-stage setups, the test now incorporates dual-stage specific system port offsets, configures appropriate fabric levels, and includes L2 fabric switches in the test setup. This **extends test coverage** for complex topologies like RDSW/EDSW, ensuring accurate validation of fabric links in these environments. The change allows the test to run successfully with dual-stage base configurations, improving the robustness of hardware testing for **DSF clusters**.
This commit **enhances the documentation** for the **FBOSS project**, specifically providing a high-level overview of the **FBOSS agent software architecture**. It details the agent's core components, internal layering, and how it communicates via the CLI, all within the `docs/docs/FBOSS.md` file. This **documentation update** is crucial for **Open Source Software (OSS)**, offering essential architectural context to external users and contributors. The work improves the overall understanding and onboarding experience for anyone engaging with the FBOSS agent's design.
This commit **introduces comprehensive documentation** for the **FBOSS2 CLI** to the project's GitHub documentation site, marking the first part of this effort. It provides an **overview of the CLI's capabilities** for monitoring, troubleshooting, and configuration, along with a command overview table and syntax patterns. This **documentation enhancement** specifically details numerous `show` subcommands, such as `acl`, `agent`, `arp`, `interface`, and `lldp`, complete with usage examples and sample outputs in `docs/docs/debugging/fboss_cli.md`. This significantly improves the **usability and understanding** of the `fboss2` command-line interface for users performing operational tasks.
This commit **enhances the documentation for the `fboss2 CLI`**, specifically expanding the `show` subcommands section. It adds new entries to the `show` subcommands table for `mac`, `mirror`, `ndp`, `port`, `rif`, `route`, `transceiver`, `config`, `fsdb`, and `version`. Detailed usage and sample outputs are now included for `lldp`, `mirror`, `ndp`, and `port` commands within the **`docs/docs/debugging/fboss_cli.md` file**. This **documentation update** improves the clarity and completeness of the CLI guide, aiding users in understanding and utilizing various `fboss2` operational and debugging commands.
This commit **completes the documentation** for the `fboss2` **CLI tool** by adding comprehensive details for a wide range of commands. It covers `clear` (including `arp`, `interface`, `ndp`, `mirror`), `set` (including `interface`, `port`, `debug`, `fanhold`), `get` (`pcap`), `config`, and operational commands like `create`, `delete`, `bounce`, `reload`, `debug`, `start`, `stop`, `stream`, and `help`. This **documentation update** in `docs/docs/debugging/fboss_cli.md` significantly enhances the usability and understanding of the FBOSS2 command-line interface for users.
This commit **introduces support for probabilistic ECN marking**, allowing non-100% ECN mark probabilities for ASICs that are validated to support this feature. It **enhances the ECN validation logic** within the `fboss/agent` module, specifically in `ValidateStateUpdate.cpp`, to conditionally apply validation rules based on ASIC capabilities. The `hasValidPortQueues` function was refactored and updated to take an `isEcnProbabilisticMarkingSupported` parameter, ensuring consistent validation across both MONO and MULTI_SWITCH configurations. This **new capability** provides more flexible ECN control for compatible hardware while maintaining strict 100% probability for others.
This commit introduces a **new test case** to validate the behavior of **ECN probabilistic marking** within the `fboss/agent`'s **Active Queue Management (AQM)** system. A new test class, `AgentAqmEcnProbabilisticMarkingTest`, and a test method, `verifyEcnProbabilisticMarking`, are added to `fboss/agent/test/agent_hw_tests/AgentAqmTests.cpp`. This **new capability test** specifically ensures that ECN marking occurs correctly when configured with a probability less than 100% and a high maximum limit, enhancing the **reliability of congestion control**. A minor **refactoring** is also included, making `configureQueue2WithAqmThreshold` virtual to support this new test.
This commit **enhances the test suite** by adding comprehensive unit test coverage for the **ECN probabilistic marking validation** logic. New test cases are introduced in `fboss/agent/test/SwSwitchTest.cpp` to verify boundary conditions for ECN probability (0%, 100%, and 101%) and to ensure correct behavior when the `ECN_PROBABILISTIC_MARKING` feature is **not supported** by the ASIC. This **testing enhancement** improves the robustness of ECN configuration handling, ensuring proper validation across various scenarios and hardware capabilities.
This commit introduces **new test utilities** and **refactors existing ones** to enable comprehensive testing of **ECN probabilistic marking** within the FBOSS agent. It adds new functions like `addVoqEcnProbabilisticMarkingConfig` in `NetworkAITestUtils` and `addQueueEcnProbabilisticMarkingConfig` in `OlympicTestUtils` to configure probabilistic ECN. Existing utilities such as `addQueueEcnConfig` and `GetEcnConfig` are also updated to accept a probability parameter, allowing for flexible ECN configuration. These enhancements to the **test infrastructure** are crucial for validating the correct behavior of **Explicit Congestion Notification** and **Virtual Output Queue (VoQ) ECN** with probabilistic marking, as demonstrated by updates to `AgentAqmTests.cpp` and `AgentPortBandWidthTests.cpp`.
This commit introduces a **new capability** to enable **ECN probabilistic marking** within the **SAI WRED (Weighted Random Early Detection) profiles**. It extends the **SAI WRED API** (`WredApi.h`), its fake implementation, and the `SaiWredManager.cpp` to support the new `EcnGreenMarkProbability` attribute, allowing configuration of ECN marking probability for green packets. Special handling is included for **Broadcom platforms** and **TAJO** to manage default values and ensure smooth upgrades. Furthermore, the commit addresses **warm boot compatibility** by preventing unclaimed WRED handles and correctly serializing/deserializing the new attribute in `SaiObject.cpp` during state transitions. This enhancement provides more granular control over ECN marking behavior across various platforms.
This commit **fixes several bugs** in the **`FabricLinkMonitoring` test** within `fboss/agent/test/agent_hw_tests/AgentVoqSwitchFabricLinkMonitoringTests.cpp`. Specifically, it **corrects the test setup** by ensuring the fabric device peer is configured with the right ASIC and platform types, and the local switch's `switchType` is explicitly set to `VoqSwitch`. Furthermore, it prevents the test from incorrectly populating self-neighbors, focusing the validation on actual fabric neighbors. This **test improvement** enhances the accuracy and reliability of **hardware tests** for **fabric link monitoring**, ensuring proper validation of fabric connectivity logic.
This commit introduces a **new hardware test** within `AgentSflowMirrorTest.cpp` to validate **sFlow mirroring** functionality. Specifically, it verifies that sFlow mirrored packets are correctly forwarded to a **remote system port** through the **VOQ infrastructure**. The test, `AgentSflowMirrorRemoteSystemPortTest`, also includes updates to helper functions for collecting **VOQ queue statistics**, ensuring robust validation of this critical data plane behavior. This enhancement improves the reliability and correctness of sFlow deployments in systems utilizing VOQ.
This commit introduces a **new test class**, `AgentSflowMirrorRemoteSystemPortTest`, within the `fboss/agent/test/agent_hw_tests` module. This **enhances test coverage** for **sFlow mirror functionality** by specifically verifying scenarios where the mirror destination is a **remote system port** reached via a Virtual Output Queue (VOQ). The new class, along with several helper functions, ensures the correct operation of sFlow mirroring in complex, distributed network environments. This **new testing capability** improves the overall reliability and robustness of the `fboss` agent's sFlow implementation.
This commit introduces **new utility APIs** to the `VoqTestUtils` module, specifically `addRemoteSysPortAndInterface` and `resolveRouteToRemoteSysPort`. These functions are designed to streamline and encapsulate common patterns for **testing traffic forwarding** to **remote VOQ switches** within a multi-node environment utilizing the **DSF infrastructure**. By providing these helpers, the commit significantly enhances the **test infrastructure** by simplifying the setup of remote system ports, interfaces, and route resolution. This **new capability** directly benefits the development and validation of multi-node network configurations by improving the efficiency and reliability of related tests.
This commit **refactors** the `getRemoteVoqSwitchId` method, moving it from the `AgentVoqSwitchWithMultipleDsfNodesTest` class into a new, reusable utility function within `VoqTestUtils`. This **improves code organization and reusability** for **VOQ testing utilities** by centralizing a common API for retrieving remote VOQ switch IDs from DSF node configurations. The change also includes a minor const correctness adjustment in `assertVoqTailDrops`. This **maintenance** effort provides a shared helper, enabling cleaner and more consistent usage in subsequent development.