Nicola Corti

This commit **refactors** the **React Native Android development support networking** by modifying `DevSupportHttpClient` to obtain its `OkHttpClient` instance from `OkHttpClientProvider.getOkHttpClient()`. This change moves away from creating an independent HTTP client, ensuring that **all development support connections** now share the **same connection pool and dispatcher** with the rest of React Native's networking. The primary impact is improved resource efficiency and consistency in network operations for development tools.

This commit **refactors** the **DevSupportHttpClient** within `ReactAndroid` by **removing its custom header management capabilities**. Specifically, the `addRequestHeader` and `removeRequestHeader` methods, along with the internal custom header interceptor and map, have been eliminated from `DevSupportHttpClient.kt`. This change simplifies the `DevSupportHttpClient` by delegating the responsibility for adding custom request headers to the more general `setOkHttpClientFactory` mechanism. Developers should now use `setOkHttpClientFactory` to provide a customized `OkHttpClient` instance if specific headers are required for development support network requests.

This commit performs a **refactoring** within the **React Native Android dev support inspector** by changing the `DevSupportHttpClient` class and its members from `public` to `internal` visibility. This change improves encapsulation by restricting access to `DevSupportHttpClient` and its methods like `addRequestHeader` and `removeRequestHeader` to only within the `ReactAndroid` module. As all existing callers are already internal to `ReactAndroid`, this is a **maintenance** task that reduces the public API surface without affecting external consumers. The `@JvmStatic` annotations were also removed from its functions as part of this internal adjustment.

This commit **refactors** the **WebSocketModule** within **React Native's Android implementation** to optimize network resource management. Instead of creating a new `OkHttpClient` instance for each WebSocket connection, the module now derives its client from `OkHttpClientProvider.getOkHttpClient()`, ensuring all connections share a **global `OkHttpClient` instance**. This change leads to **improved efficiency** by utilizing a **shared connection pool and dispatcher** for all WebSocket operations. Additionally, a dispatcher shutdown call was removed to prevent prematurely terminating the shared network resources, which could impact other ongoing connections.

Add react_renderer_viewtransition to prefab preprocessing entries (#55896)

This commit **fixes a critical bug** within the **Android UIManager module** by modifying the deprecated `UIManagerModule.getUIImplementation()` method. Previously, this method would return `null`, leading to `NullPointerExceptions` for any legacy callers still depending on it. The change ensures it now consistently returns a new `UIImplementation` instance, thereby **unblocking the Android CI** and enhancing the stability of the React Native Android platform.

This commit introduces a **bug fix** to enable proper secure connections for **React Native Android's development support traffic**. Previously, dev-support URLs for features like the inspector, debugger, and bundle loading were hardcoded to `http://` and `ws://`, leading to connection failures when routed through a proxy on port 443. New `httpScheme()` and `wsScheme()` helper functions are added to `DevSupportHttpClient` to dynamically determine if `https://` or `wss://` should be used when the host port is 443. This change updates URL constructions in **`DevServerHelper`**, **`JSPackagerClient`**, and **`PackagerStatusCheck`**, significantly improving **developer experience** by ensuring reliable connectivity for development tools in secure environments.

This commit **exposes** the `DevSupportHttpClient` as a **public API** within the **Android DevSupport module**, providing a **new capability** for external consumers. It **restores** the `addRequestHeader` and `removeRequestHeader` methods, enabling direct management of custom HTTP headers for development support requests. This **API change** allows consumers like **Expo Dev Launcher** to register custom headers without an intermediary, streamlining **custom dev-support HTTP header registration** for development tools.

This commit introduces a **new public API**, `DevSupportRequestHeaders`, within the **Android dev-support system** to manage custom HTTP headers. It **refactors** the `DevSupportHttpClient` by extracting its internal header management, allowing external consumers (e.g., Expo Dev Launcher) to register custom HTTP headers that will be applied to all React Native dev-support network traffic. This **enhancement** provides a standardized and public way to inject headers, improving the extensibility and maintainability of the **dev-support module**. A new Buck target was also added to resolve a dependency cycle, ensuring proper module isolation.

This commit **refactors** the **React Native Android** codebase by **migrating** the `LayoutShadowNode` class from Java to Kotlin. This change is part of the ongoing effort to transition the Android module entirely to Kotlin, specifically affecting the **UI manager's Legacy Architecture**. The migration involved translating all methods and properties of this deprecated class, which handles various layout properties like `setFlex`, `setWidth`, and `setMargin`. Consequently, the `ReactAndroid.api` definition was updated to reflect the new Kotlin structure, and the `ReactNoNewJavaDetector` lint allowlist was adjusted. This is a **maintenance** task that ensures continued progress towards a fully Kotlin-based Android implementation.

This commit **enhances** the **React Native Inspector's** WebSocket adapter by enabling the injection of custom HTTP headers during the initial connection handshake. Specifically, the `RCTCxxInspectorWebSocketAdapter` within the **React Native** framework now utilizes `initWithURLRequest:` instead of `initWithURL:` to facilitate setting these headers for the **CDP (Chrome DevTools Protocol) WebSocket connection**. This **feature addition** allows for more robust and configurable **devsupport connections**, providing greater flexibility for internal tooling or authentication mechanisms. The change primarily affects the **inspector's communication layer**, ensuring custom headers are applied during the HTTP upgrade process.

This commit introduces a **new capability** to the **React Native Inspector's network debugging** by enabling the application of custom development support HTTP headers. It modifies the `RCTInspectorNetworkHelper.mm` module within the **DevSupport** component to **inject registered custom headers** into all inspector resource loading requests. This **enhancement** ensures that network fetches performed by the inspector accurately reflect the development environment's configuration, providing a more complete and reliable debugging experience for developers.

This commit introduces a **new capability** to the **`RCTReconnectingWebSocket`** module, allowing the injection of **custom development support headers** into the **Hot Module Replacement (HMR) WebSocket connection**. It modifies the `reconnect` logic in `RCTReconnectingWebSocket.m` by switching from `initWithURL:` to `initWithURLRequest:`, which enables headers to be set during the HTTP upgrade handshake. This **feature enhancement** provides greater control and flexibility for development environments, particularly for configuring the HMR connection. The change primarily impacts the WebSocket connection establishment and reconnection process, ensuring custom headers are applied consistently.

This commit introduces a **new capability** to the **React Native development server communication**, enabling the application of **custom HTTP headers** to packager status check requests. It modifies the `RCTBundleURLProvider` in `packages/react-native/React/Base/RCTBundleURLProvider.mm` to utilize `NSMutableURLRequest` instead of `NSURLRequest`. This **feature enhancement** allows `RCTDevSupportHttpHeaders` to be injected into the requests made by `RCTPackagerIsRunning`. The change primarily impacts **devsupport tooling**, providing greater flexibility for developers to configure network interactions with the packager, such as for authentication or proxying in development environments.

This commit **enhances the React Native DevSupport system** by **injecting custom development support headers** into the POST request used to open the debugger. Specifically, the `openDebugger` function within `RCTInspectorDevServerHelper.mm` is modified to include these headers. This ensures that all registered custom headers are properly sent during the debugger launch, improving the **configurability and reliability of the debugging connection** for developers. This is a **feature enhancement** that provides greater flexibility for debugging setups requiring specific request headers.

This commit introduces a **new capability** by adding `RCTDevSupportHttpHeaders`, a **thread-safe singleton** to the **iOS devsupport subsystem**. This singleton manages and applies **custom HTTP headers** to all network requests made within the iOS development support environment, mirroring existing functionality on Android. It utilizes a GCD concurrent queue with barrier writes to ensure robust reader-writer synchronization for methods like `addRequestHeader` and `applyHeadersToRequest`. This enhancement provides a consistent and reliable mechanism for injecting custom headers, crucial for debugging and development workflows across platforms.

This commit introduces a **new capability** to the **development support system**, enabling the application of **custom HTTP headers** to **multipart bundle download requests**. It modifies `RCTMultipartDataTask.m` to inject headers registered via `RCTDevSupportHttpHeaders` into these network requests. This ensures that all multipart bundle fetches correctly include developer-defined headers, enhancing the **flexibility and debugging capabilities** of the **development workflow** for bundle loading. The change primarily impacts the **networking and development tooling subsystems** within React Native.

This commit **adds a new capability** to the **React Native DevSupport inspector** by introducing **custom HTTP request header support** to the `DevSupportHttpClient`. It provides `addRequestHeader` and `removeRequestHeader` methods, enabling callers to register and unregister headers that will be included in all requests made by both the `httpClient` and `websocketClient`. This enhancement improves the flexibility of development tools by allowing dynamic, thread-safe management of request headers for debugging and inspection purposes. The implementation uses a shared OkHttp Interceptor and `ConcurrentHashMap` to ensure headers can be safely managed from any thread.

This commit **refactors** the **React Native Android devsupport module** by migrating `DevServerHelper` to use a **shared `OkHttpClient` instance**. It replaces an inline `OkHttpClient.Builder()` with `DevSupportHttpClient.httpClient`, which allows for the reuse of the connection and thread pools across all development support HTTP consumers. This **maintenance** task improves resource efficiency and cleans up the codebase by removing unused constants like `HTTP_CONNECT_TIMEOUT_MS` and related `TimeUnit` imports from `DevServerHelper.kt`. The change ensures consistent and optimized HTTP client behavior for development-related network requests.

This commit introduces a **bug fix** and **performance optimization** within **React Native's Android development support**. It addresses an inefficient resource allocation pattern in the `RedBoxContentView`, where the `OpenStackFrameTask` was creating a new `OkHttpClient` instance, along with its associated connection and thread pools, every time a user tapped a stack frame. The change replaces this wasteful per-tap allocation with the shared `DevSupportHttpClient.httpClient` singleton, **reducing resource consumption** and **improving the efficiency** of network operations within the **RedBox debug overlay**. This ensures a more stable and performant debugging experience by preventing unnecessary object creation.