generatedunixname1030151775592158

This commit **updates test cases** within the `fboss/thrift_cow/nodes` module to align with a revised API for accessing **Thrift union and struct fields**. Specifically, it modifies `ThriftStructNodeTests.cpp` and `ThriftUnionNodeTests.cpp` to utilize direct field access methods such as `inlineString()`, `inlineStruct()`, and `inlineBool()` instead of their `_ref()` suffixed counterparts. This **refactoring** effort ensures that the test suite reflects the current, simplified `thrift_cow` API, promoting cleaner and more consistent field access. The change is a **maintenance** task focused on improving code readability and consistency within the test infrastructure.

This commit **refactors** the **`fboss/fsdb/client`** module to modernize Thrift exception field access. It updates `FsdbPublisher.cpp`, specifically within the `createGenerator` function, to directly access `FsdbException` fields like `errorCode` and `message` instead of using the older `_ref()` suffix. This **maintenance** change improves code consistency and readability for **Thrift exception handling** within the FSDB client, without altering any external functionality or behavior.

This commit performs **maintenance** on the **Thrift C++2 dynamic type system** by updating test cases in `thrift/lib/cpp2/dynamic/test/TypeSystemDigestTest.cpp`. It adapts the tests to an **API change** where `SerializableTypeDefinition` members are now accessed directly, rather than through the `_ref()` suffix. This ensures the test suite remains compatible and accurate with the latest interface of the **Thrift C++2 dynamic library**. The change reflects a broader shift in how members of `SerializableTypeDefinition` are exposed, impacting code that interacts with this part of the Thrift API.

This commit **updates test data generation** within the `fboss/thrift_cow/storage` module by modifying `TestDataFactory.cpp`. Specifically, it removes the `_ref()` suffix from the assignment of `two_byte_asn` within the `BgpRibMapDataGenerator`. This is a **maintenance update** to align the test data setup with current API usage or naming conventions. The change primarily affects **test correctness and clarity** for `BgpRibMapDataGenerator` within the `thrift_cow` storage tests.

This commit **refactors** the **Thrift C++2 library's metadata testing infrastructure** by updating include directives within `struct_metadata_test.cpp`. Specifically, it transitions to using `module_metadata_h.h` for metadata definitions and `_types.h` for struct definitions. This change standardizes header inclusion practices within the test suite, aligning with broader internal header organization improvements for generated Thrift code. As this modification is confined to a test file, its primary impact is on the maintainability and consistency of the **Thrift** codebase.

This commit performs a **maintenance update** within the **Thrift C++2 metadata test suite**. Specifically, it **refactors include directives** in `thrift/lib/cpp2/test/metadata/annotations_test.cpp` by replacing the deprecated `annotations_metadata.h` with the more granular `module_metadata_h.h` and `annotations_types.h`. This change ensures the test file uses the updated header structure for **Thrift annotations and module metadata**, aligning it with recent internal library organization improvements. The scope is limited to the **test infrastructure**, with no direct impact on runtime behavior or public APIs.

This commit performs a **maintenance update** to the include paths for **generated Thrift metadata headers** within the `thrift/lib/cpp2/test/metadata` subsystem. Specifically, it modifies `schema_comparison_test.cpp` to replace direct includes of specific metadata headers with more general types headers and introduces a new module-specific metadata header. This change **refactors header dependencies** to align with updated Thrift metadata generation conventions, ensuring tests correctly reference the new header structure. The update primarily impacts the **build system and header organization** for Thrift metadata, improving consistency and maintainability.

This commit **refactors** the include statements within the **Thrift C++2 example metadata** file `thrift/example/cpp2/metadata/MetadataExample.cpp`. It updates the header dependencies by replacing the older `MetadataExample_metadata.h` with `MetadataExample_types.h` and adding `module_metadata_h.h`. This **maintenance** change aligns the example code with updated **Thrift header generation practices**, ensuring consistency in how metadata types are included. The scope is limited to this example file, demonstrating the new, standardized header structure for **Thrift metadata definitions**.

This commit performs a **code refactoring** within the **`fboss/qsfp_service/module/cmis` subsystem**. It **removes redundant `_ref()` suffixes** from Thrift field access calls for `appSelCode` and `txPower0P01Dbm` within `CmisModule.cpp`. Specifically, the `customizeTransceiverLocked` and `programTunableModule` functions are updated to reflect this change. This internal cleanup improves code readability and aligns with modern Thrift usage, with no functional impact on the QSFP service.

This commit performs a **maintenance update** to the **Thrift C++2 protocol testing infrastructure**, specifically within `PaddedBinaryAdapterBackwardsCompatibilityTest.cpp`. It **removes the `_ref` suffix** from member access for `data` and `checksum` within existing test cases. This change **aligns the test suite** with a recent **API modification** in the `thrift/lib/cpp2` library, ensuring the tests correctly validate the `PaddedBinaryAdapter`'s backward compatibility. The update prevents test failures caused by outdated member access patterns, maintaining the integrity of the **protocol tests**.

This commit performs a **refactoring** within the **Thrift C++2 dynamic type system**, specifically affecting `thrift/lib/cpp2/dynamic/TypeSystemTraits.cpp`. It updates the internal type access patterns within the `ResolveType` struct's `operator()`, changing from `_ref().value()` to a more direct `().value()`. This change simplifies the code by removing the redundant `_ref` suffix, improving readability and consistency for internal type resolution mechanisms. The modification is an internal cleanup and does not alter the public API or behavior of the Thrift library.

This commit performs a **refactoring** within the **`fboss/qsfp_service`** module, specifically in `PortManager.cpp`. It **removes the `_ref()` suffix** from **Thrift object mappings** when accessing port names, standardizing the access pattern. This change improves code clarity and consistency for **Thrift-generated objects** without introducing any functional modifications or downstream impact.

This commit introduces a **refactoring** to the **FBOSS CLI**'s **route details command**, specifically within `fboss/cli/fboss2/commands/show/route/CmdShowRouteDetails.h`. It updates how **Thrift struct members** are accessed, transitioning from older `get_` methods, such as `getVlanPortMap()`, to direct member access or the use of `.value()` for optional fields. This change modernizes the codebase, improving readability and consistency in functions like `printOutput` and `createModel` by aligning with current Thrift best practices. The scope is localized to the internal handling and display logic of route information within this particular CLI command.

This commit performs a **maintenance update** to the **Thrift C++2 schema testing infrastructure**. It updates `thrift/lib/cpp2/schema/test/SyntaxGraphTest.cpp` to use `structDef()` instead of `structDef_ref()` for accessing struct definitions. This change reflects an underlying simplification in the **Thrift C++2 library's schema API**, where the `_ref` suffix is no longer necessary for obtaining references. The update ensures the test suite remains consistent with the current API, improving code clarity and reducing potential confusion.

This commit performs a **refactoring** within the **`fboss/fsdb/oper`** subsystem's test suite. It updates the `HybridSubscribableStorageTests.cpp` file to remove the `_ref()` suffix from patch value and struct node access methods, transitioning to direct access. This change aligns with a broader effort to modernize Thrift-generated code usage. The scope is limited to **test infrastructure**, improving code consistency and readability within tests without impacting production functionality.

This commit **refactors** the **FBOSS agent test suite** by updating the access pattern for the `timestamp` field within the `HwPortStats` Thrift struct. Specifically, it modifies `fboss/agent/test/AgentEnsemble.cpp` to use the direct accessor `timestamp_()` instead of the deprecated `timestamp__ref()`. This **maintenance task** ensures the test code aligns with modern Thrift generation practices, preventing potential build failures or runtime issues in the **`AgentEnsemble` tests** due to API changes in generated Thrift code. The change is localized to the test infrastructure and does not alter core agent functionality.

This commit performs a **refactoring** within the **`fboss/agent`** module, specifically in `ThriftHandler.cpp`. It updates the Thrift field accessors by **removing the `_ref` suffix** from method calls, aligning the codebase with modern Thrift accessor patterns. This change affects several key functions, including `getPortInfoHelper`, `getAclTableGroup`, and `setInterfacePrbs`. The primary goal of this **maintenance** work is to improve code readability and maintainability without altering any existing functionality.

This commit performs a **refactoring** of internal Thrift API usage within the `cpp2` library, specifically updating how optional fields are accessed. It transitions from using the `_ref()` suffix to direct `()` access for optional fields across several core components. This change impacts the **RocketClientChannel** for client-side asynchronous communication, the **GeneratedAsyncProcessorBase** for server-side request processing, and the **TypeSystemBuilder** for dynamic type system construction. The work ensures consistency with the updated Thrift API for optional field handling, affecting both client and server asynchronous logic. Associated **tests** for async sink services were also updated to reflect this API change, maintaining code hygiene and compatibility within the Thrift framework.

This commit **updates the Thrift lazy deserialization test suite** to reflect changes in field access conventions. It **removes the `_ref` suffix** from field access methods within `thrift/test/lazy_deserialization/random_test.cpp`, specifically changing calls from `field4_ref()` to `field4()` in a `decltype` expression. This is a **maintenance update** to align the test with recent **Thrift code generation** changes, where the `_ref` suffix is being deprecated or removed from generated field accessors. The change ensures the test remains compatible and correctly validates lazy deserialization behavior under the updated Thrift API.

This commit performs a **refactoring** across the **FBOSS agent test suite** to update how Thrift fields are accessed. It systematically removes the `_ref()` suffix from various field access calls, transitioning from methods like `timestamp__ref()` to direct accessors such as `timestamp_()` or `logicalID()`. This change impacts numerous test helpers and utility functions related to **port statistics**, **mirror configurations**, **AQM/queue settings**, **ACL counters**, and other test-specific data structures. The work ensures compatibility with updated Thrift access patterns and modernizes the test codebase, primarily affecting the **test infrastructure** without altering production logic.