generatedunixname893464919433493

This commit **migrates** the `containers_benchmark_lib` from `thrift-py-deprecated` to `thrift-python`, completing the removal of the deprecated flavor from the benchmark tool. It **refactors** `thrift/lib/python/benchmark/containers.py` by eliminating the `PY_DEPRECATED` enum value, its associated `ttypes` import mapping, and all `py-deprecated` serialization code paths. This **maintenance** task simplifies the codebase by removing legacy dependencies and logic. Additionally, it enhances robustness by introducing a `ValueError` for unknown serialization flavors within the `import_serializer_statement` function.

This commit performs **code cleanup** within the **image processing test suite** by removing several **unused private methods** from the `AnimatedRepeatedPostprocessorProducerTest` class. This **maintenance** task improves the readability and maintainability of the test code by eliminating dead code. The change specifically affects the **testing infrastructure** for animated image post-processing producers. There is no impact on the runtime behavior or functionality of the application, only on the internal structure of its tests.

This commit introduces a **new capability** for the **Buck2 Android installer**, enabling users to configure the installation timeout via a new `--install-timeout <seconds>` CLI option. It **refactors** the internal timeout management by centralizing the default 600-second value within `AndroidCommandLineOptions.java` and simplifying the `InstallerService` constructor to directly accept this value, removing hardcoded constants. This change provides greater flexibility for `buck2 install` operations, allowing users to override the default timeout to suit specific environment needs.

This commit provides a **bug fix** within the **`folly::fibers`** library, addressing an **incorrect memory alignment** for the `userBuffer_` member in the `Fiber` class. It removes a spurious `cacheline_align_v` argument from the `folly::aligned_storage_t` declaration for `userBuffer_` in `folly/fibers/Fiber.h`. This change restores the intended default alignment, which was inadvertently set to 64-byte cacheline alignment during a previous migration from `std::aligned_storage` to `folly::aligned_storage_t`. The fix ensures that fiber-local storage maintains its original alignment characteristics, preventing potential performance regressions or undefined behavior.

This commit performs a **build speed optimization** by **refactoring** the include structure within the **Thrift C++2 server library's** `LazyDynamicArguments` component. It forward declares `apache::thrift::syntax_graph::FunctionNode` in `LazyDynamicArguments.h` and moves the `#include <SyntaxGraph.h>` directive from the header to `LazyDynamicArguments.cpp`. This change significantly reduces include bloat by approximately 902KB per compilation unit that includes `LazyDynamicArguments.h`, leading to **faster compilation times**. The associated BUCK files were also updated to correctly manage the `syntax_graph` dependency.

This commit performs a **refactoring** within the **`thrift/lib/cpp2/async`** module to **improve build speed**. Specifically, it replaces the direct include of `thrift/lib/cpp2/server/StreamInterceptorContext.h` with a forward declaration in `ServerGeneratorStreamBridge.h`. This **maintenance optimization** significantly **reduces compilation dependencies** and include bloat by 4.2MB, as the `StreamInterceptorContext` class is only used through `std::shared_ptr` and does not require its full definition. The change aims to **reduce overall compilation time** for components depending on `ServerGeneratorStreamBridge.h`.

This commit **fixes a heap-use-after-free vulnerability** in the **Thrift C++2 runtime** by preventing the misuse of `IntWrapper` with reference types, which previously led to dangling references. It introduces a **compile-time static assertion** in `IntWrapper` within `thrift/lib/cpp2/detail/Isset.h` to explicitly disallow reference types, thereby safeguarding against this dangerous pattern. Additionally, the **`BitRef` component** is **refactored** to store raw pointers instead of `BitSet` wrappers and its copy constructor is fixed to properly dereference these pointers, ensuring correct bit manipulation. This **critical bug fix** enhances the **type safety** and **memory correctness** of core Thrift data structures, with corresponding **test updates** in `BitTest.cpp`.

This commit performs a **refactoring** to improve the robustness and safety of regex capture handling within the codebase. It replaces direct calls to `regex::Captures::get(0).unwrap()` with the more idiomatic and safer `get_match()` method, which directly returns the full matched string. This change primarily affects the **Buck2 legacy configuration parser** in `app/buck2_common/src/legacy_configs/parser/resolver.rs` and the **Starlark Language Server Protocol (LSP)** definition lookup logic in `starlark-rust/starlark_lsp/src/definition.rs`. By eliminating `unwrap()`, the update prevents potential panics if the primary capture group were ever unexpectedly missing, enhancing the overall stability of these components.

This commit introduces a **new capability** to the **Buck Android installer**, enabling automatic activation of Android app links immediately after an APK is successfully installed. It adds an `enableAppLinks` method to the `AndroidDevice` interface and its implementations, which executes the `adb shell pm set-app-links` command. Developers can explicitly control this behavior using a new `--enable-app-links` command-line option in `AndroidCommandLineOptions.java`, or it will default to enabling app links only for **allowlisted packages** such as `com.facebook.wakizashi`. This enhancement streamlines the development workflow by automating a common post-installation setup step, improving efficiency for specific applications.

This commit **migrates** the **Thrift Python benchmark tool** (`thrift/lib/python/benchmark/converter.py`) from the deprecated `thrift-py-deprecated` library to `thrift-python`. This **refactoring** effort updates the `converter-library` by removing old `thrift-py-deprecated` imports and references, updating supported languages, and cleaning up global configurations. As part of a larger **unification** project, the benchmark now exclusively tests conversion performance between `thrift-python` and `py3`, no longer including the legacy `py-legacy` implementation. This change streamlines the benchmark's focus and aligns it with the current Thrift Python standard.

This commit introduces a **refactoring** to optimize type collection operations within the **Kosabi compiler plugin**. It replaces the less efficient pattern of `collectDescendantsOfType().filter()` with a direct `collectDescendantsOfType { predicate }` call, leveraging a predicate directly within the collection method. This change impacts the **stubs generation** logic in `GenerationContext.kt` for collecting used user types and the **source modification** process in `SourceModifierExtension.kt` when calculating ranges to strip. The update improves code readability and potentially performance by reducing intermediate collection allocations within these core **Kosabi** components.

This commit **fixes a shadow variable warning** within the `CmdShowInterfaceCountersMKA` command's implementation in `fboss/cli/fboss2`. It **refactors** the `CmdShowInterfaceCountersMKA.h` file by renaming a local `table` variable to `aclTable` inside the `printAclStats` lambda. This change resolves the issue where the inner `table` was shadowing an outer variable, thereby enhancing **code clarity** and preventing potential confusion in the **MKA interface counters** display logic. This **bug fix** improves the overall code quality and maintainability of the CLI tool.