generatedunixname89002005287564

This commit performs a **maintenance update** to the **agent ensemble's known bad tests list**. It **adds new test configurations specifically for Meru800bia platforms**, ensuring that tests known to fail on this hardware are properly identified and managed. Additionally, it **updates SDK versions for existing configurations** within the `agent_ensemble_link_known_bad_tests.materialized_JSON` file, keeping the test suite's understanding of known failures current. This work helps maintain the accuracy and efficiency of the **agent ensemble testing framework** by preventing unnecessary runs of tests that are expected to fail under specific conditions.

This commit performs **build system maintenance and refactoring** within the **FBOSS agent's Broadcom (BCM) hardware abstraction layer**. It **removes unused build dependencies** such as `agent_features` and `sw_switch_warmboot_helper` from the `fboss/agent/hw/bcm/BUCK` file, addressing CQS signals related to unused includes. Concurrently, it **adds necessary thrift annotation dependencies** for `bcm_config.thrift` and `packettrace.thrift` to ensure proper compilation of these thrift definitions. This cleanup **improves build graph accuracy and efficiency** for the `fboss/agent` component by ensuring only required dependencies are declared.

This commit **resolves a `facebook-unused-include-check` CQS signal** specifically within the **FBOSS agent** codebase. It performs **build system maintenance** by adjusting `glog` dependencies within `cpp_library` rules in the `fboss/agent/state/BUCK` file. This **maintenance fix** improves build hygiene and resolves static analysis warnings, ensuring the **FBOSS agent's build system** is clean without affecting its runtime behavior.

This commit **modernizes C++ type trait usage** within the **Thrift conformance suite**, specifically addressing a CQS signal. It updates the `registerTest` function in `thrift/conformance/Utils.h` by replacing the older `std::remove_pointer<T>::type` with the more modern and idiomatic `std::remove_pointer_t<T>` alias template. This is a **style and maintenance improvement** that enhances code readability and adherence to contemporary C++ practices. The change is localized to the conformance utilities and does not alter any functional behavior of Thrift itself.

This commit introduces a **configuration update** to the **Fboss link test topology** for the `Icetea800bc` platform. It specifically modifies the `icetea800bc.materialized_JSON` file to update profile IDs and add new port configurations for various Ethernet interfaces. This **maintenance** ensures that the Fboss link tests accurately reflect current hardware specifications and testing requirements. The changes are confined to the test topology definition, directly impacting the setup and execution of Fboss link tests on `Icetea800bc` devices.

This commit performs a **configuration update** to the **FBOSS link test topology** for the `Icecube800BC` platform. It specifically modifies the `icecube800bc.materialized_JSON` file to update `profile IDs` and introduce the `hasTransceiver` property for multiple Ethernet interfaces. This **maintenance chore** ensures that the test environment accurately reflects the hardware capabilities and configurations of the `Icecube800BC` platform. The change improves the fidelity of **FBOSS link test simulations** by providing correct interface definitions, which is essential for reliable testing of network functionalities.

This commit **fixes** an issue with the `facebook-unused-include-check` CQS signal specifically within the **`fbcode/thrift/lib`** module. This **maintenance** work addresses an inaccuracy or bug in how the signal identifies unused includes, ensuring it functions as intended. By correcting the behavior of this code quality check, the commit improves the reliability of static analysis for the Thrift library, leading to more accurate feedback and reducing potential false positives or negatives.

This commit **resolves a CQS signal** from the `facebook-unused-include-check` static analysis tool. Specifically, it addresses an unused include within the **Thrift testing infrastructure** located in `fbcode/thrift/test`. This is a **maintenance cleanup** that improves code hygiene by removing unnecessary dependencies, thereby reducing noise from static analysis and making the test suite easier to understand and maintain.

This commit performs a **refactoring** within the **Fresco image pipeline's disk caching mechanism** to enhance **null safety**. It specifically removes redundant non-null assertion operators (`!!`) from the `EntryImpl` constructor in `DefaultDiskStorage.kt` and the `maybeUpdateResources` function in `DiskStorageCache.kt`. This **improves code quality** by making the disk cache implementation more robust and less prone to potential null pointer exceptions, aligning better with Kotlin's type safety principles. The change is internal to the caching layer, providing increased stability without altering external behavior or functionality.

This commit **modernizes C++ type trait usage** across various **Thrift C++ core libraries** by performing a widespread **refactoring**. It replaces verbose `std::enable_if::type` with `std::enable_if_t`, `std::is_xxx::value` with `std::is_xxx_v`, and similar constructs with their C++14/17 alias templates. This change primarily affects modules such as **Frozen serialization**, **protocol implementations** (`TDebugProtocol`), **transport layers** (`THeader`, `H2Channel`), **boxed values**, and various **utility components** within `thrift/lib/cpp` and `thrift/lib/cpp2`. The update, which also includes numerous test files, improves the **readability and conciseness** of template metaprogramming, leveraging modern C++ idioms for better maintainability.

This commit **refactors** the **Thrift Python protocol** implementation to enhance **C++17 compatibility** within `thrift/lib/py/protocol/fastproto.cpp`. It specifically updates the `decode_val` function to use `std::is_same_v` instead of `std::is_same` for type trait checks. This change modernizes the codebase by adopting contemporary C++ idioms, ensuring better alignment with current language standards without altering the existing runtime behavior of the fast protocol decoding.

This commit addresses a **CQS signal** by **modernizing namespace declarations** within the **Thrift test suite**. It updates `thrift/test/StructsExtra.h` and `thrift/test/reflection/fatal_merge_types.h` to utilize **C++17 inline namespace syntax**, specifically targeting the `modernize-concat-nested-namespaces` recommendation. This is a **style fix** and **code modernization effort** that improves consistency and adherence to modern C++ standards in the test infrastructure. The change is confined to **test code** and has no impact on the runtime behavior or functionality of the core Thrift library.

This commit performs a **maintenance update** to the **FBOSS agent ensemble's test configuration**, specifically within `agent_ensemble_link_known_bad_tests`. It **adds** the regex `roundtrip.*asicLinkFlap$` to the list of known bad test patterns in the `agent_ensemble_link_known_bad_tests.materialized_JSON` configuration file. This action effectively **disables** or marks as ignored a specific `roundtrip` test that is currently unstable or failing, preventing it from blocking continuous integration pipelines. The change ensures smoother **test suite execution** by managing known problematic tests.

This commit implements a **topology synchronization mechanism** specifically designed for **Fboss network link testing**. It ensures that the **testing infrastructure** accurately reflects the current network topology, providing up-to-date information for link validation. This **enhancement** improves the reliability and relevance of **Fboss link tests** by preventing tests from running against stale or incorrect network configurations. The work primarily affects the **Fboss testing framework** and its interaction with network topology services.

This commit introduces a **refactoring** to the **Thrift compiler's Python CAPI generator** to enhance code efficiency and adhere to CQS guidelines. It updates `thrift/compiler/generate/t_mstch_python_capi_generator.cc` by replacing `push_back` with `emplace_back` when adding elements to an `mstch::array` within the `python_capi_mstch_program` class. This change leverages `emplace_back` for **improved performance** by constructing elements in-place, reducing unnecessary copies or moves. The modification is an internal **optimization** that does not alter the functional output of the Thrift compiler but contributes to more efficient code generation.

This commit implements a **synchronization process** within the **Agent Ensemble** to accurately link and update its internal state regarding **known bad tests**. This **maintenance enhancement** ensures that all agents consistently recognize and account for tests that have been identified as problematic. The change improves the overall reliability and accuracy of test execution and reporting by providing agents with the most current information on test stability.

This commit introduces a mechanism to **synchronize** the list of **known bad tests** across an **agent ensemble link**. It ensures that all agents within the distributed testing infrastructure maintain a consistent and up-to-date understanding of tests identified as unreliable. This is a **maintenance and data consistency improvement** that enhances the efficiency of test execution. By consistently linking and updating the status of problematic tests, the change helps to **streamline test cycles** and improve the overall **reliability of test reporting**.

This commit focuses on **synchronizing the network topology** within the **FBOSS link testing framework**. It introduces or updates mechanisms to ensure that the test environment accurately reflects the intended network topology, which is crucial for reliable and consistent test execution. This is a **maintenance improvement** that enhances the accuracy and stability of **FBOSS link tests**, preventing discrepancies between the test setup and the expected network configuration. The change primarily affects the **FBOSS test infrastructure**, ensuring more robust and accurate validation of network link behavior.

This commit **synchronizes the topology** specifically for **FBOSS link tests**, ensuring that the test environment accurately reflects the intended network configuration. This **maintenance** task is crucial for reliable and consistent network validation within the **FBOSS testing infrastructure**. By aligning the test topology, it prevents tests from running against outdated or incorrect network states, thereby improving the accuracy and trustworthiness of **FBOSS network link validation**.

This commit performs a **maintenance update** to the **`agent_ensemble`** testing infrastructure by **removing several optics-related test names** from the `fboss/oss/link_known_bad_tests/agent_ensemble_link_known_bad_tests.materialized_JSON` file. This file specifically tracks tests that are known to be failing or problematic. By delisting these tests, they will now be **executed and reported normally** within the `agent_ensemble` test runs. This change improves the accuracy of the known bad tests list and potentially re-enables critical test coverage for **optics functionality**.