Michael Jolley

This commit introduces a significant **refactoring** to the **CmdPal** module by making its **settings and application state immutable**, directly addressing concurrency issues (bug #46437) caused by mutable shared state. Core data models such as `SettingsModel`, `AppStateModel`, and `DockSettings` are now immutable records, utilizing init-only properties and immutable collections. All state modifications are now performed through atomic `ISettingsService.UpdateSettings` and `IAppStateService.UpdateState` operations, employing copy-on-write (`with`) patterns across various `CmdPal.UI.ViewModels` and services. This architectural change enhances the **stability and reliability** of the command palette by eliminating in-place mutation and preventing race conditions during state persistence.

This commit performs a significant **refactoring** within the **CmdPal** module by extracting persistence logic from `SettingsModel` and `AppStateModel` into dedicated service classes. It introduces `IPersistenceService`, `ISettingsService`, and `IAppStateService` to manage loading, saving, and migration of application settings and state, transforming the original models into pure data containers. This change improves **separation of concerns** and **testability** for **settings and application state management**, impacting numerous consumer files across the `Microsoft.CmdPal.UI` and `Microsoft.CmdPal.UI.ViewModels` projects. Consumers now interact with these new service interfaces via **Dependency Injection**, abstracting away file I/O and migration details, and new unit tests have been added for the services.

This commit delivers a **bug fix** for the **CmdPal** module, resolving an issue where resizing windows opened from the dock (e.g., Performance Monitor) would incorrectly save and apply those dimensions to subsequent normal hotkey opens. The changes in `src/modules/cmdpal/Microsoft.CmdPal.UI/MainWindow.xaml.cs` introduce logic to prevent dock-initiated window size changes from persisting. Now, the window's size is reverted when opened via **CmdPal**, and persistence only occurs upon a normal window close, ensuring correct and consistent window position and size restoration for users.

This commit provides a **bug fix** for the **CmdPal Performance Monitor** extension, addressing a concurrency issue reported in Teams. It introduces **thread-safe mechanisms** to correctly manage the `_loadCount` variable, which tracks page loads. Specifically, a **lock** is added around `_loadCount` updates within the `ItemsChanged` event in `OnLoadStaticPage.cs`, and `Interlocked.Increment`/`Decrement` are now used in `PerformanceWidgetsPage.cs` for atomic operations. This ensures accurate performance metric collection by preventing race conditions during concurrent access, thereby improving the **reliability** of the **CmdPal** performance monitoring.

This commit introduces a **new capability** to the **Command Palette**, allowing users to **persist their search query** across invocations. A new "Keep previous query" setting has been added to the `CmdPal` general settings page, which, when enabled, prevents the search bar from clearing its text after a command is executed and the palette dismisses. This **enhancement** improves user workflow by reducing repetitive typing for iterative searches or re-running commands, affecting the `SettingsModel`, `SettingsViewModel`, `GeneralPage.xaml` UI, and the `SearchBar.xaml.cs` logic for handling `GoHomeMessage`.

This commit delivers a **bug fix** for the **CmdPal RDP extension** that resolves an issue preventing connections to `host:port` addresses. Previously, the `Uri.CheckHostName` validation incorrectly rejected RDP connection strings containing a port, such as `localhost:3389`, leading to an "invalid hostname" error. The fix modifies `OpenRemoteDesktopCommand.cs` and `FallbackRemoteDesktopItem.cs` to **strip the port suffix** before hostname validation, ensuring the full `host:port` is still passed to the RDP client. This enables users to successfully connect to **RDP sessions via forwarded ports** and ensures the fallback item correctly recognizes and displays these connections, with new unit tests added for verification.

This commit **fixes** a **bug** in the **CmdPal apps extension** that caused it to ignore the user's configured search result limit for fallback results. Previously, the `MainListPage` hardcoded the app result limit, preventing user customization of the number of displayed apps. The `AppResultLimit` property now correctly delegates to `AllAppsCommandProvider.TopLevelResultLimit`, ensuring the user's `SearchResultLimit` setting is respected. This **bug fix** improves the user experience by allowing proper control over **CmdPal**'s app result display, and **new regression tests** have been added to `MainListPageResultFactoryTests.cs` to validate this behavior, including edge cases.

This commit **fixes a bug** in the **CmdPal** module, preventing the details pane from displaying stale information or failing to hide when an item's initialization encounters an error. The `ListViewModel.cs` now explicitly calls `HideDetailsMessage` if `SafeSlowInit()` fails, ensuring previous details are cleared. Furthermore, `InstallPackageListItem.cs` introduces **exception handling for WinRT marshaling errors** when retrieving package metadata like `Documentations` and `Tags`. This ensures **graceful degradation**, allowing the details pane to display available information even if certain metadata collections fail to load, thereby improving the overall stability and user experience of the **CmdPal** interface.

This commit **enhances the command palette's global sort functionality** by **adjusting the ranking algorithm** to prioritize direct matches. It introduces a **50% penalty to fallback item scores** within the `CalculateScore` method in `src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Commands/MainListPage.cs`. This **bug fix** ensures that **direct matches are consistently ranked higher** than less relevant fallback results, significantly improving the accuracy and user experience of search outcomes.

This commit introduces significant **new capabilities** for **Command Palette's fallback command management**, allowing users to customize the display order of unranked fallbacks and designate specific ones as "global" to be ranked alongside top-level commands. This involves extensive **refactoring** within the `CmdPal` module, updating core logic in `MainListPage` for scoring and introducing new `FallbackSettings` and UI controls for configuration. A critical **breaking change** for extension developers requires adding a `string Id` property to `FallbackCommandItem` to ensure fallbacks are discoverable and rankable. This **enhancement** provides users with greater control over their search experience, addressing previous limitations where fallbacks were largely unranked.

This commit introduces a **new built-in Remote Desktop extension** to the **CmdPal** module, significantly enhancing its functionality. This **feature** allows users to seamlessly view and manage past RDP connections, save and connect to predefined connections, or initiate new Remote Desktop sessions directly from the command palette. It integrates a `RemoteDesktopCommandProvider` and `RDPConnectionsManager` to handle connection logic and persistence, providing a powerful new tool for system administrators and users who frequently interact with remote machines. The scope includes new UI components, command providers, and robust unit tests to ensure reliability.

This commit introduces an **enhancement to CmdPal's telemetry system** by adding a unique page identifier to the `OpenPage` event. The `PageViewModel` in `Microsoft.CmdPal.Core.ViewModels` now includes an `Id` property, which is then incorporated into the `OpenPage` event's data structure within `Microsoft.CmdPal.UI/Events`. Consequently, when a user navigates to a page within the **CmdPal UI**, the `OnNavigatedTo` method in `ShellPage.xaml.cs` will now log the specific page `Id` as part of the `OpenPage` telemetry event. This **new capability** provides more granular data for analyzing **user navigation patterns** and page usage within the **CmdPal** module.

This commit **refines the user interface** of the **CmdPal** feature by **removing the redundant "App" tag** from application entries. This **UI improvement** addresses visual clutter, making the application list within CmdPal cleaner and easier to read for users. The change streamlines the display of available applications, enhancing the overall user experience by reducing unnecessary visual noise.

This commit introduces a **new capability** to the **CmdPal Indexer**'s file search, allowing users to apply filters for 'all files & folders', 'folders only', or 'files only'. It establishes a new `SearchFilters` class to manage these options and integrates the filtering mechanism into the `IndexerPage`. This integration modifies core search methods like `PerformSearch` and `UpdateSearchText` to dynamically apply the chosen filter, enhancing the precision of search results. New icons and localized string resources are also added to support this improved user experience, providing users with more granular control over their search results within the CmdPal.

This commit delivers a crucial **bug fix** for the **CmdPal** module, resolving issues with search result accuracy and completeness. It addresses the problem of **duplicate pinned applications** appearing in search results and ensures that **Run and Calculator commands** are correctly displayed. The fix involves refactoring the search result filtering logic within `MainListPage.cs` to prevent duplicates and improve item display, making `AppListItem.cs` public to support new filtering requirements, and simplifying query update mechanisms in `FallbackExecuteItem.cs` for enhanced robustness. This significantly improves the reliability and user experience of the CmdPal search functionality.

This commit **resolves a UI rendering issue** within the **CmdPal module**, specifically addressing how links are displayed in the details section. Previously, `HyperlinkButton` content would not wrap, leading to truncated or overflowing text. By wrapping the `HyperlinkButton` content in a `TextBlock` within `src/modules/cmdpal/Microsoft.CmdPal.UI/Pages/ShellPage.xaml`, this **UI enhancement** ensures that long links now **wrap correctly**, significantly improving readability and user experience within CmdPal's detail views.

This commit introduces a **new capability** within the **CmdPal** (Command Palette) to enhance how users access item-specific information. It adds a "Show Details" context menu command to list items that possess associated details, even when the main list view is configured not to display them by default. This allows users to view details on demand, improving the **user experience** and information discoverability within the **CmdPal UI**. The change involves updates to the **list item view models** and the introduction of a new `ShowDetailsCommand`, alongside **refactoring** for command organization and a **bug fix** in `ShellPage.xaml.cs` to improve the stability of detail updates.

This commit introduces a **UI/UX improvement** to the **CmdPal** module by **limiting the display length of command text** to prevent overflow and enhance readability. It applies `MaxWidth`, `MaxLines`, `TextTrimming`, and `TextWrapping` properties to `TextBlock` elements within `CommandBar.xaml` to truncate primary, secondary, and 'More' commands with an ellipsis. Additionally, titles within `ContextMenu.xaml` are now restricted to a single line for a cleaner presentation. A new test case was added to `EvilSamplesPage.cs` to validate this text truncation behavior.

This commit initiates a significant **refactoring** effort within the **CmdPal All Apps extension** by systematically **removing `System.Linq` usage**. It replaces LINQ expressions with explicit loops, collection manipulations, and direct array indexing across various components, including app discovery, caching, and program management methods like `FindBestAppMatch` and `GetApps`. This **performance and readability improvement** aims to provide better control and potentially faster execution for the `All Apps` functionality. This work represents the first phase of a broader `System.Linq` clean-up within the `CmdPal` module.

This commit **improves the stability** of **Command Palette UI's search results** by **materializing search result collections into Lists** within the `src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Commands/MainListPage.cs` component. Specifically, methods such as `GetItems`, `UpdateFilteredItems`, and `UpdateFilteredApps` are updated to prevent re-enumeration of search items. This **bug fix** ensures consistent scoring behavior, preventing items from being unexpectedly re-ordered or re-scored. Consequently, users will experience more predictable and stable search outcomes within the **Command Palette**.