Milen Dzhumerov

This commit enhances the **Bundle Telemetry** system by ensuring it logs the *actual processed entitlements* used during Apple app signing, rather than potentially inaccurate unprocessed versions. This **feature enhancement** modifies the **Apple bundling tools**, specifically `prelude/apple/tools/bundling/main.py`, to introduce a temporary directory for storing these processed entitlements. It also updates the `codesign_bundle` function in `prelude/apple/tools/code_signing/codesign_bundle.py` to accept a path for saving these prepared entitlements. This guarantees that **telemetry loggers receive the precise entitlements** applied to signed bundles, improving the accuracy of build process insights.

This commit introduces an **optional bundle telemetry logger** for **Apple bundle assembly**, enabling the collection of build-time metrics. It integrates a new Python-based logger, defined in `prelude/apple/tools/bundling/main.py`, into the bundle assembly command via a new `bundle_telemetry_logger` attribute on the `apple_tools` rule. This **new capability** enhances the **Apple toolchain** by providing a mechanism for optional telemetry data collection during the bundle creation process. The change is a **feature addition** that allows for deeper insights into build performance and characteristics without impacting existing build flows unless explicitly configured.

This commit introduces a **new capability** to filter specific keys from entitlements during the Apple code signing process. A new `entitlements_removed_keys` attribute is added to the **`apple_bundle()` rule**, allowing users to specify which entitlement keys should be excluded from the final signed bundle. This enhancement affects the **Apple bundling and code signing infrastructure**, from rule definition in `apple_common.bzl` to the core logic in `prepare_code_signing_entitlements.py`. It provides greater control over the entitlements used for signing, ensuring only necessary keys are present in the final application.

This commit introduces a **new capability** to the **Apple bundling and code signing process** by adding an `entitlements_suffixed_key_map` attribute to the `apple_bundle()` rule. This feature allows specifying a map of entitlement keys whose values should be automatically suffixed during signing, affecting both explicitly provided and auto-generated entitlements. The core logic for applying these suffixes is implemented in `prepare_code_signing_entitlements.py`, which now processes the new `--entitlements-suffixed-key-map` argument passed through the bundling and signing tools. This enhancement provides greater flexibility in managing entitlements, such as **keychain access groups**, by enabling dynamic modification of their values based on build configurations.

This commit introduces a **new capability** to the **Apple build system** by adding a `[swift-sources]` subtarget to the `apple_library()` rule. This subtarget, defined within `prelude/apple/apple_library.bzl`, generates a text file that lists all Swift source files associated with the library. This enhancement provides a standardized mechanism for **source code statistics analysis** and other tooling that requires an explicit enumeration of Swift source files within `apple_library()` targets.

This commit performs a **refactoring** within the **Apple code signing tools** by renaming an internal helper function. Specifically, the function `_select_provisioning_profile()` in `prelude/apple/tools/code_signing/codesign_bundle.py` has been renamed to `_select_best_provisioning_profile()`. This change improves **naming consistency** with the related `select_best_provisioning_profile_core()` function, enhancing code readability and maintainability. The update affects the internal logic for provisioning profile selection, but introduces no functional changes or external impact on the code signing process.

This commit performs a **refactoring** within the **Apple code signing utilities** by **renaming** the `select_best_provisioning_profile` function to `select_best_provisioning_profile_core`. This change clarifies that the function operates purely on data types without performing any I/O or process invocation, enhancing code readability and maintainability. All internal call sites in modules like `codesign_bundle.py` and associated unit tests in `provisioning_profile_selection_test.py` have been updated to reflect the new name. The scope of this change is limited to improving the semantic clarity of the **provisioning profile selection logic** without altering its functional behavior.

This commit performs **maintenance** and **code cleanup** by **removing all handling** for the `propagated_target_sdk_version` mechanism from the codebase. This **refactoring** eliminates obsolete logic and associated code paths, as `propagated_target_sdk_version` is no longer utilized anywhere within the system. The change **simplifies the build system infrastructure** by reducing complexity and removing dead code, with no functional impact on existing features or build processes.

This commit **disallows the usage of `propagated_target_sdk_version`** within the **Apple build system's macro layer**, marking a significant **refactoring and deprecation** effort. Specifically, it modifies the `_transform_propagated_target_sdk_version_to_minimum_os_version` function in `prelude/apple/apple_macro_layer.bzl` to prevent any further use of this attribute, and removes the now-obsolete `_move_attribute_value` helper. This change is a crucial **preparatory step** to enable the complete and safe removal of `propagated_target_sdk_version` from all call sites across the codebase. By enforcing this disallowance, the commit ensures that any existing or future usage of the deprecated attribute will fail, streamlining the build configuration and paving the way for cleaner code.

This commit **fixes a compatibility bug** within the **`buck2_event_observer`** module, specifically impacting the `whatran` feature's command generation. It updates the `command_to_string` function in `app/buck2_event_observer/src/what_ran.rs` to replace `env --chdir` with `env -C`. This **bug fix** addresses an issue where the `--chdir` flag is not supported by `env` on macOS, causing generated reproduction commands to fail. As a result, **`whatran` repro commands will now execute successfully on both Linux and macOS**, significantly **improving cross-platform reliability** for command reproduction.

This commit introduces a **feature enhancement** to the **Apple code signing tooling** by incorporating **provisioning profile creation dates** into diagnostic logs. It updates the `ProvisioningProfileMetadata` dataclass in `prelude/apple/tools/code_signing/provisioning_profile_metadata.py` to parse and store the `creation_date` via the `from_file_path` method. Consequently, the `_make_multiple_matching_profiles_message` function in `prelude/apple/tools/code_signing/provisioning_profile_selection.py` is modified to include this `creation_date` in log messages. This change significantly improves **debugging capabilities** when multiple matching provisioning profiles are found, providing crucial context for resolving profile conflicts.

This commit **improves the error reporting logic** for **Apple provisioning profile mismatches** within the **code signing tooling**. Specifically, it **reorders mismatch checks** in `prelude/apple/tools/code_signing/provisioning_profile_selection.py` to prioritize reporting **bundle ID mismatches** before team ID mismatches. This **bug fix** ensures that developers receive more semantically accurate and helpful diagnostic messages, preventing situations where a less relevant team ID mismatch is reported when a more fundamental bundle ID discrepancy exists. The change impacts the `select_best_provisioning_profile` function, leading to clearer feedback during the provisioning profile selection process.

This commit **enhances the code signing diagnostics** for **Apple platforms** by ensuring that **non-bundle ID provisioning profile mismatches** are logged directly to the console output. Previously, these critical debugging details might only be written to a log file, making them inaccessible in environments like CI. This **feature improvement** significantly **aids debugging** by providing immediate visibility into common profile issues, even when full log file access is restricted. The change specifically impacts the `interpret_provisioning_profile_diagnostics` function within `prelude/apple/tools/code_signing/provisioning_profile_diagnostics.py`.

This commit **fixes a typing inconsistency** within the **Apple build rules** by correcting the `destination` attribute of the `apple_resource` rule in `prelude/apple/apple_rules_decls.bzl`. Previously, the attribute was declared to accept `AppleResourceBundleDestination` values, but the underlying implementation expected `AppleResourceDestination`. This **bug fix** ensures that the declared type now correctly matches the expected runtime type, preventing potential analysis-time failures and improving the robustness of **Apple resource handling**. The change safely removes a misleading type declaration, as the `systemextensions` element from the incorrect type could not have been used at runtime.

This commit **enhances the Swift compilation logic** by providing an explicit mechanism to **prevent diagnostic serialization** when generating `.swiftinterface` files. Previously, diagnostics were incorrectly serialized without the necessary `emit-module-diagnostics` output map entry, particularly outside of incremental builds. The change introduces a `supports_serialized_errors` parameter to the `_compile_with_argsfile` function in `prelude/apple/swift/swift_compilation.bzl`, allowing **fine-grained control** over this behavior. This **resolves potential compilation issues** and **improves the robustness** of Swift module interface generation.

This commit introduces a **new capability** to explicitly generate and expose a `swiftinterface` subtarget for **Swift modules** built using the `apple_library()` rule. It adds a `swiftinterface_subtarget_enabled` attribute to `apple_library` in `prelude/apple/apple_rules_decls.bzl`, allowing users to opt-in to `swiftinterface` artifact generation. The **Swift compilation logic** in `prelude/apple/swift/swift_compilation.bzl` is updated to implement this compilation and expose the artifact via `SwiftCompileResult`. This feature, which is disabled by default via a new `apple.swiftinterface_subtarget_enabled` buckconfig, provides granular control over `swiftinterface` generation, preventing unnecessary CPU and memory costs when not required.

This commit **refactors** the **Swift compilation logic** by changing the `compile_swift` function in `swift_compilation.bzl` to return a structured `SwiftCompileResult` record instead of an unnamed tuple. This improves the API clarity and extensibility of the Swift compilation output. Consequently, the **Apple build rules** for `apple_binary` and `apple_library` are updated to correctly consume the new record. Consumers like `apple_binary_impl` and `apple_library_rule_constructor_params_and_swift_providers` now access specific fields such as `swift_compilation` and `objc_swift_interface` from the returned record. This **maintenance refactoring** lays the groundwork for future enhancements to the information provided by the Swift compilation process.

This commit **removes unused functionality** related to generating `.swiftmodule` files from `.swiftinterface` definitions, which is no longer required. It **refactors** the **Apple build rules** by eliminating dead code, including specific logic, functions like `_should_compile_with_swift_interface` and `_compile_swiftmodule`, and arguments within `get_swift_dependency_info` calls. This cleanup primarily impacts the **Swift compilation logic** defined in `prelude/apple/swift/swift_compilation.bzl`, with minor adjustments in `apple_binary.bzl` and `apple_library.bzl`. The change **simplifies the Swift compilation process** by removing obsolete code paths, improving maintainability and reducing complexity within the build system.

This commit introduces a **bug fix** to prevent **debug information de-duplication issues** within the **Swift build system**. Previously, each **Swift SDK PCM** redundantly added SDK paths and resource directories to its debug info tset, leading to inefficient and duplicated entries. The **fix** centralizes the creation of this `sdk_debug_info` tset within the **`swift_toolchain()`** definition in `swift_toolchain.bzl`, ensuring it is generated only once. This pre-aggregated debug info is then correctly integrated into the merged clang debug infos via `extract_and_merge_clang_debug_infos()` in `swift_debug_info_utils.bzl`, streamlining **Swift SDK PCM compilation** and improving the accuracy of debug information.

This commit performs a **refactoring** to improve the **clarity and accuracy of naming conventions** within the build system's **Apple library rules** and **Swift compilation logic**. It renames the `[swift-interface]` subtarget to `[objc-swift-interface]` in `prelude/apple/apple_library.bzl` and updates associated internal functions like `_create_swift_interface` to `_create_objc_swift_interface` in `prelude/apple/swift/swift_compilation.bzl`. This change clarifies that the subtarget represents the Swift representation of an Objective-C module's public interface, distinguishing it from `.swiftinterface` files. The **renaming prevents ambiguity** and **prepares the system for the future introduction** of a distinct `[swiftinterface]` subtarget, enhancing overall build system maintainability.