Matt Mastracci

This commit introduces a **refactoring** of **Rust build task** input fingerprinting within the **`next-swc` package** by adding a new `rust-fingerprint` TurboRepo task. This task centralizes the computation of a `TURBO_HASH` stamp file, which existing Rust build and check tasks now depend on, eliminating duplicated input globs and **simplifying configurations**. Additionally, it updates the **global TurboRepo configuration** to pass through `SCCACHE_*` and `RUSTC_WRAPPER` environment variables, ensuring proper functionality of `sccache` for faster builds. This **maintenance** change improves build system maintainability and reliability by streamlining input definitions and environment variable propagation.

This commit **refactors the Turbopack Docker image build and caching mechanism** to resolve issues with Turborepo's cache corrupting or truncating Docker files. It introduces a **new module** (`scripts/turbo-cache.mjs`) for direct interaction with the Turbo remote cache API, enabling robust artifact management including zstd compression. The **CI workflow** (`.github/workflows/build_and_deploy.yml`) and the **Docker image caching script** (`scripts/docker-image-cache.js`) are updated to leverage this direct API interaction, completely bypassing Turborepo tasks for caching. This change **improves the reliability and efficiency** of Docker image builds by preventing cache corruption and streamlining the caching process.

This commit **refactors and enhances the Turbopack native binary build system** by replacing multiple opaque `napi-rs` Docker images with a single, custom `next-swc-builder` Dockerfile. This new setup enables **efficient cross-compilation for all four Linux targets** (x86_64/aarch64 × gnu/musl) with baked-in toolchains, significantly reducing build times by eliminating runtime downloads and leveraging **Turbo remote caching** for the Docker image. The **CI/CD workflows** are updated, and new Node.js and shell scripts (`scripts/docker-native-build.js`, `scripts/docker-native-build.sh`) orchestrate the build process, including **smoke tests** and enabling `--icf=all` for a 1-2% binary size reduction. This comprehensive **maintenance and feature enhancement** improves build reliability, customizability, and ensures broader glibc compatibility for the native binaries.

This commit primarily **improves build speed** for **cross-compiled MUSL targets** within the **Turbopack** project, addressing a performance regression introduced by LTO. It achieves this through **optimizations** in `Cargo.toml` release profiles, such as enabling thin LTO and adjusting `codegen-units`, and by streamlining linker usage for MUSL builds. Concurrently, the **CI/CD workflow** in `.github/workflows/build_and_deploy.yml` undergoes significant **refactoring** for enhanced maintainability, consolidating build logic and documenting configurations. Additionally, Rust compiler settings in `.cargo/config.toml` are simplified, and a new `print-rustflags` subcommand is introduced to `turbopack/xtask`, collectively improving the build system's efficiency and clarity.

This commit introduces a significant **refactoring** of the **Turbopack task registration system**, transitioning much of the `Value`, `Trait`, and `Function` registration code to be `const`-evaluated at compile time. It establishes a **unified `const` registry** and `RegistryType` to centralize metadata and enables **compile-time vtable construction** for trait methods using the `phf` crate, replacing previous runtime `Lazy` and `inventory_submit!` mechanisms. This fundamental change aims to **reduce Turbopack's startup time and memory allocations**, leading to a measurable **1-3% compilation speedup** in benchmark applications by minimizing runtime overhead and atomic checks. The work lays the groundwork for further performance optimizations and improved LTO capabilities within the `turbo-tasks` core.

This commit **enables Thin Link-Time Optimization (LTO)** for all **release builds** across the workspace by adding `lto = "thin"` to the root `Cargo.toml`'s `[profile.release]` section. This **performance optimization** aims to **improve runtime performance** of final artifacts, including the `next-napi-bindings` native module and `turbopack-cli` binary, through cross-crate optimizations without the full build time cost of fat LTO. Additionally, the `'rlib'` crate type is removed from `crates/next-napi-bindings/Cargo.toml`, likely to facilitate this change. This **build configuration change** will also benefit `release-with-assertions` and `release-with-debug` profiles, ensuring broader performance gains.

This commit introduces a **new `ast-grep` rule**, `no-err-anyhow`, which enforces the use of the more compact `bail!` macro over `Err(anyhow!())` for returning errors. This **refactoring** effort standardizes error handling across numerous **`turbopack` crates**, including `turbo-tasks-backend`, `turbo-tasks-fs`, and `turbopack-core`, by updating various functions like `realpath` and `content` to utilize `bail!`. The change improves **code consistency and readability** by promoting a more concise error return pattern, facilitating broader adoption of `turbofmt/turbobail` conventions. Accompanying this, **new test cases** for `no-err-anyhow` and **snapshot updates** for `ast-grep` rules are included to validate the new pattern and maintain rule integrity.

This commit introduces the `turbofmt!` and `turbobail!` procedural macros to the **Turbopack** ecosystem, providing a streamlined way to perform **async string formatting** and error handling with `Vc<T>` and `ResolvedVc<T>` values. This **new capability** significantly **refactors** approximately 30 call sites across modules like `next-core`, `turbo-tasks-fs`, `turbopack-core`, and `turbopack-ecmascript`, replacing verbose manual formatting and `bail!` calls. By leveraging an auto-deref pattern and borrow-based capture, these macros reduce boilerplate and offer potential optimizations by minimizing intermediate tasks. The change also introduces the `ValueToStringRef` trait and updates the `ValueToString` derive macro, standardizing async display logic and improving overall code clarity and performance within the project. A new `FORMATTING.md` document is added to guide developers on their usage.

This commit **refactors** the **Turbopack task function registration** to be entirely `const`-evaluated at compile time, eliminating thousands of runtime allocations and `Lazy` initializations. It modifies the `#[turbo_tasks::function]` macro and related `value_impl`/`value_trait` macros in `turbo-tasks-macros` to generate `static` items initialized with `const fn` constructors, producing `&'static dyn TaskFn` trait objects directly. This significant **performance optimization** for the **`turbo-tasks` core library** reduces startup time by computing global names and function metadata at compile time using new `const` helper macros like `const_type_name` and `const_concat!`. The `NativeFunction` and `ArgMeta` structures, along with `into_task_fn` helpers, are now `const`-constructible, paving the way for further **startup optimizations** within the `turbopack` system.

This commit performs a significant **refactoring of Turbopack's module splitting and re-export handling** to prepare for an upcoming name mangling feature. It introduces a new `EsmExports::reexport_including_default` helper to consolidate re-export facade creation and adds `get_locals_if_split` and `get_facade_if_split` methods to `EcmascriptModuleAsset` for encapsulating module split logic. This **refactoring** simplifies the `apply_module_type` function in `turbopack/src/lib.rs` and reduces duplicated boilerplate across `NextDynamicEntryModule`, `NextServerComponentModule`, and `NextServerUtilityModule`. These changes are crucial for enabling virtual facade modules to function correctly with mangled names and centralize logic for Next.js module wrappers that require unmangled export names.

This commit performs **refactoring and maintenance** across several Turbopack crates, addressing review feedback from a previous change related to `#[derive(ValueToString)]`. It **improves the `ValueToString` macro** in `turbopack-tasks-macros` by removing `is_pure_constant` and directly unescaping `{{`/`}}` in format strings during macro expansion, ensuring `rcstr!` works reliably for all constant strings without runtime formatting. Additionally, it **refactors `turbopack-ecmascript`** by replacing an inline `if` with a `Display` implementation for `RequireContextAssetReference` and making `WebpackChunkAssetReference::chunk_id()` internal. These changes enhance code clarity, encapsulation, and the robustness of string formatting logic within Turbopack.

This commit introduces a **new `#[derive(ValueToString)]` procedural macro** in the `turbo-tasks-macros` crate to automate the generation of `ValueToString` implementations. This **refactoring** effort converts approximately 45 manual implementations across various **Turbopack** and `next-core` crates, eliminating 660 lines of boilerplate code. The macro supports flexible formatting options, including field interpolation and expression delegation, leveraging a new `ValueToStringify` trait for async `Vc` resolution. This significantly improves code readability and maintainability by standardizing string conversion logic throughout the `turbo_tasks` system.

This commit introduces a significant **refactoring** to the **Turbopack chunking architecture**, specifically simplifying how JavaScript `ChunkItem`s are handled. It consolidates the vast majority of module-specific `ChunkItem` implementations into a single, generic `EcmascriptModuleChunkItem`. This is achieved by extending the `EcmascriptChunkPlaceable` trait with new methods like `chunk_item_content()`, `chunk_item_content_ident()`, and `chunk_item_output_assets()`, which various modules across `next-core` and `turbopack-ecmascript` now implement directly. This **internal cleanup** removes redundant wrapper structs, streamlining the codebase and improving maintainability for future feature development within the **Turbopack JavaScript bundling pipeline**.

This commit introduces a significant **refactoring** to **Turbopack's worker creation mechanism**, unifying how **Web Workers and Node.js Worker Threads** are initialized. It transitions from URL-based worker instantiation to a factory function pattern, ensuring that **runtime globals** like `NEXT_DEPLOYMENT_ID` are consistently forwarded to worker contexts. This **enhancement** resolves issues with workers dynamically importing assets and accessing deployment-specific configuration, leading to more **robust and consistent behavior** across different worker environments. The change affects **Turbopack's client, edge, and server chunking contexts** and its **ECMAScript runtime**, with new E2E tests verifying correct asset loading and global forwarding in both browser and Node.js workers.

This commit introduces a **new capability** in **Turbopack** to make global variables passed to web workers configurable via the `BrowserChunkingContext`. It **refactors** the worker entrypoint generation and the `ChunkingContext` trait to support dynamically forwarding specified globals, moving away from hardcoded framework knowledge. This allows **Next.js** to pass critical information like `NEXT_DEPLOYMENT_ID` to all workers, improving deployment context awareness. The mechanism involves embedding `WORKER_FORWARDED_GLOBALS` into the browser runtime and transmitting them via `params=` in the worker URL, ensuring workers receive necessary environment data.

This commit addresses minor **Rust check warnings** across the **Turbopack** codebase to reduce build log noise. It includes a **documentation update** in the `crates/napi/src/next_api/turbopack_ctx.rs` file, correcting markdown syntax within a comment. Additionally, an unused `process::Command` import is removed from the `turbopack/crates/turbopack-cli/benches/small_apps.rs` benchmark file. This **maintenance chore** improves code hygiene and developer experience by eliminating unnecessary warnings without introducing any functional changes.

This commit **refactors** the `test_mixed_cpu_bound_and_waiting_tasks` within the **Turbopack priority runner** to ensure deterministic execution. The previous implementation was **flaky** due to its reliance on timing-based synchronization and unpredictable thread scheduling, leading to inconsistent test results. By replacing `sleep()` calls with `std::sync::Barrier` pairs, the test now explicitly controls task progression, guaranteeing that priority-based task completion is reliably asserted. This **maintenance fix** significantly improves the **reliability** of the `priority_runner` test suite, preventing future false positives or negatives related to scheduling variations.

This commit **fixes a critical bug** in **Turbopack**'s worker bundling by replacing blob URLs with real entrypoint files for `Worker` and **introduces full support for `SharedWorker`** instances. This change **resolves issues with relative URL resolution** inside workers, enabling correct loading of assets like WASM modules via `import.meta.url`, which previously failed due to blob URLs. The **Turbopack** build system now emits a dedicated, content-hashed entrypoint file that parses bootstrap configuration from URL hash parameters and loads chunks via `importScripts`. This enhancement significantly improves the robustness and correctness of worker asset generation and loading within **Turbopack** applications.

This commit provides a **bug fix** for the **Turbo-tasks manager** within `turbopack/crates/turbo-tasks`. It **resolves a compile failure** that occurred when `tokio_tracing` was enabled. Specifically, the change adjusts the tracing description formatting in `src/manager.rs` to correctly handle an optional `parent_task_id`. This ensures that the system compiles successfully and tracing functions as expected, preventing disruptions in development environments utilizing `tokio_tracing`.