Andreas Löscher

This commit **reverts** a prior change, ensuring the **Erlang common test runner** correctly reports internal crashes as 'failed' instead of 'skipped'. The **`test_runner.erl`** module, specifically within the `collect_results_broken_run` function, is updated to restore this behavior. This **fix** improves the accuracy of test reporting by preventing critical internal failures from being masked as non-critical skips. Consequently, test suite health is more transparently reflected, aiding in quicker identification of underlying issues.

This commit **corrects the test reporting logic** within the **Erlang common test runner**. Previously, internal crashes, which are infrastructure issues rather than test failures, would incorrectly mark test results as **failed**. The change modifies the `collect_results_broken_run` function in `prelude/erlang/common_test/test_binary/src/test_runner.erl` to now classify these incidents as **skipped**. This **bug fix** ensures a more accurate representation of test suite outcomes, preventing infrastructure problems from obscuring actual test failures.

This commit introduces a **custom boot script mechanism** for Erlang releases, significantly enhancing flexibility in the build process. It adds new attributes, `bootscript_builders` and `generate_default_bootscript`, to `prelude/decls/erlang_rules.bzl` to control default generation and enable custom script provision. The core implementation in `prelude/erlang/erlang_release.bzl` modifies the `_build_release` function and introduces new functions like `_build_custom_boot_scripts` to orchestrate this new logic. This **new capability** allows developers to disable default boot script generation and provide their own custom scripts, offering granular control over Erlang application startup.

This commit introduces a **bug fix** to the **`test_exec` module** within the `prelude/erlang/common_test` component. It addresses an issue where a stub process, created during the `start` function in `test_exec.erl`, was prematurely exiting. By modifying the process creation logic, this **maintenance** change ensures the PID remains active, preventing unexpected application termination and guaranteeing the stability and correct operation of the `test_exec` framework.

This commit introduces a **new capability** to the **Erlang toolchain** by exposing Erlang OTP headers for NIF builds. It adds a new Starlark rule `erlang_headers` and a corresponding BUCK target `prelude//erlang/toolchain:erlang_headers` to extract and make these essential headers available. This allows `cxx_*` targets to correctly include the necessary Erlang headers, resolving issues for native implemented functions. Additionally, a **bug fix** was applied to the `copy_dir` function within `extract_from_otp.erl` to ensure robust handling of target paths during the header extraction process.

This commit **removes all direct usages** of the `waaat:log` logging utility across the codebase. This is a **maintenance and cleanup** effort, likely part of a broader **refactoring** initiative to standardize or update the project's logging infrastructure. The change affects various modules that previously relied on this specific logging mechanism, ensuring a more consistent approach to logging. By eliminating `waaat:log`, the codebase is streamlined, preventing its future use and simplifying the overall logging architecture.

This commit introduces a **bug fix** to the **Erlang toolchain integration** by correcting how the `erl` executable path is resolved. Previously, commands found in the system's `PATH` were incorrectly made absolute relative to the repository root, leading to issues with local toolchains. A new function, `normalize_erl_cmd` in `prelude/erlang/common_test/test_binary/src/test_info.erl`, now properly uses `os:find_executable` for commands in `PATH` and falls back to `make_path_absolute` otherwise. This ensures reliable execution of Erlang processes, particularly within the `common_test` framework, when using **local Erlang toolchains**.

This commit delivers a **bug fix** to the **Erlang shell execution** logic, specifically within the `prelude/erlang/erlang_shell.bzl` module. It adjusts the `erl` command formatting in the `_do_build_run_info` function to correctly resolve its path. Previously, shells would fail if the `erl` toolchain was sourced from the system's `PATH` rather than directly from the repository. Now, the system intelligently determines the `erl` source based on input presence, ensuring **Erlang shell commands** execute successfully regardless of whether `erl` is provided by the repository or found in the environment.

This commit introduces **structured error reporting** for Erlang compilation within Buck2, marking the first version of this **new capability**. It significantly enhances the **Erlang build system** by integrating a new `erlang_erlc_action_error_handler` into the `ErlangToolchainInfo` provider, as seen in `prelude/erlang/erlang_toolchain.bzl` and `prelude/erlang/erlang_info.bzl`. This ensures that **Erlang compiler errors** are captured and presented in a standardized format, improving the diagnostic experience. Consequently, `buck2` will now print detailed error information to stdout, and all captured errors will be included in the build report.

This commit introduces a **new watchdog mechanism** to the **Erlang common test execution framework** to prevent lingering test nodes and improve resource management. A new module, **`ct_executor_watchdog`**, establishes a TCP connection between the test node and the test binary. If the test binary terminates unexpectedly (e.g., due to a crash or timeout), the watchdog detects the closed connection and gracefully shuts down the Erlang VM. This **new capability** ensures that test nodes do not consume resources indefinitely, thereby preventing system poisoning and improving the overall stability of the test environment.

This commit provides a **bug fix** for the **Erlang shell integration** with `buck2`. It resolves an issue where the `--source` CLI argument was inadvertently lost during `buck2` command invocations, specifically within `bxl` script execution. The `get_additional_paths` function in `prelude/erlang/shell/src/shell_buck2_utils.erl` has been updated to correctly include this argument. This ensures proper **module loading and build functionality** by guaranteeing that `buck2` commands are invoked with all necessary parameters within the Erlang shell environment.

This commit **removes the integration of `ct_property_test`** from the **Erlang build rules** defined in `prelude/erlang/erlang_tests.bzl`. Specifically, the `property_tests` parameter and its associated logic are removed from the `erlang_tests_macro`, `_build_erlang_test`, and `link_output` functions. This **maintenance** and **refactoring** change addresses flakiness and incompatibility issues with Buck2's build model, improving the **robustness and speed of Erlang test compilation**. Going forward, Erlang tests will leverage the `srcs` attribute for native Buck2 compilation, ensuring more reliable builds.

This commit **enhances the CI/CD infrastructure** by integrating Erlang into the build environment. It modifies the `.github/actions/setup_linux_env/action.yml` workflow to ensure the `erlang` package is installed via `apt-get` during Linux environment setup. This **maintenance** update is crucial for enabling the continuous integration and testing of Erlang-based projects. Consequently, both internal and external OSS **CI pipelines** are now equipped to support new Erlang sample applications and escripts, facilitating broader language support within the project's development lifecycle.

This commit introduces **initial support for Erlang** by defining a new **Erlang toolchain** within the `prelude/toolchains` module. It adds `system_erlang_toolchain` and an associated rule (`_system_erlang_binary_impl`) to leverage system-installed Erlang binaries. This **new capability** integrates Erlang into the `system_demo_toolchains` in `prelude/toolchains/demo.bzl`, enabling Erlang projects to build out-of-the-box in an open-source environment. This significantly simplifies the setup for users by providing a default, readily available Erlang toolchain.

This commit **fixes a critical bug** in the **Erlang release build system** that caused applications to start in the incorrect order during release boot. Previously, the `.rel` file content, which dictates the boot script sequence, was constructed in reverse. The `_build_boot_script` function in `prelude/erlang/erlang_release.bzl` and `build_start_boot` in `prelude/erlang/toolchain/boot_script_builder.erl` are modified to correct this sequencing. This **bug fix** ensures that all applications, including root and release applications, are started in the **correct and expected order**, preventing potential issues related to improper dependency initialization.

This commit introduces a **performance optimization** to the **Erlang project loading** mechanism, specifically within the `_elp_config` function in `prelude/erlang/elp.bxl`. It refactors the target discovery logic to first retrieve unconfigured targets, then filter them by kind *before* full configuration. This change **reduces target fanout** during the initial project discovery stage by **avoiding unnecessary loading of BUCK files** for dependencies of non-Erlang targets, leading to more efficient and faster project loading.

This commit **refactors** the internal mechanism for handling **Erlang OTP binaries** within the build system to improve flexibility. It updates attribute definitions in `erlang_rules.bzl` to use `attrs.arg` instead of `attrs.source` and changes the type of binary fields in `ErlangOTPBinariesInfo` within `erlang_info.bzl` from `Artifact` to `Tool`. Additionally, the `erlang_toolchain.bzl` module is modified to remove the `configured_otp_binaries` rule and adjust `erlang_otp_binaries_impl` to use `cmd_args`. This **maintenance** work streamlines how Erlang binaries are provided to the toolchain, allowing for more adaptable configurations of Erlang environments.

This commit implements a **maintenance change** to the **Erlang build system** by introducing a fake `0.0` ERTS version into paths where it is expected by `erl/dyn_erl` trampolines. The `_build_erts` function in `prelude/erlang/erlang_release.bzl` is updated to include this version in the ERTS path and dictionary key, while `_erlang_toolchain_impl` in `prelude/erlang/erlang_toolchain.bzl` declares the ERTS output with this placeholder. This **refactoring** ensures that the build environment consistently provides an ERTS version in the path, satisfying toolchain expectations and preventing potential resolution issues.

This commit **re-introduces foundational support for "trampolines"** within the **Erlang Common Test (CT) framework** and its **Buck build rules**. It **adds `_inner_trampolines` and `_trampolines` attributes** to the `erlang_test` rule definition and integrates a new `trampolines` field into the `buck_ct_test_info` and `buck_ct_test_run_info` records. This involves **refactoring** numerous functions across `test_logger.erl`, `test_info.erl`, `test_runner.erl`, and `ct_runner.erl` to properly initialize, load, write, and pass this new trampoline data. While the actual trampoline setup is not yet fully active, this work **lays the essential groundwork** for future trampoline-based test execution within the Erlang ecosystem.

This commit introduces a **new capability** to configure an **inner trampoline** for **Erlang test nodes** within the build system. It **enhances the Erlang Common Test (CT) framework** by adding a `_inner_trampolines` attribute to the `erlang_test` rule in `prelude/decls/erlang_rules.bzl`, allowing users to specify additional execution layers. The change propagates this configuration through the `buck_ct_test_info` records and updates the test execution logic in `prelude/erlang/common_test/test_runner/src/test_runner.erl` and `prelude/erlang/common_test/test_exec/src/ct_runner.erl` to properly start test nodes with these new trampolines. This provides greater flexibility in controlling the environment and execution context of Erlang tests.