Alexander Oprisnik

This commit performs a **code quality improvement** by adding the `@Nullsafe` annotation to **27 test files** within the `imagepipeline` module. This change specifically targets test classes across various `imagepipeline` components, including `core` functionality, `memory` management, and numerous `producers`. By enabling null-safety checks in these tests, the commit helps to proactively identify and prevent potential `NullPointerException`s. This **maintenance** effort enhances the robustness and reliability of the test suite, contributing to the overall stability of the `imagepipeline` codebase.

This commit **enhances null-safety enforcement** within the **ImagePipeline test infrastructure** by **applying the `@Nullsafe(Nullsafe.Mode.LOCAL)` annotation**. Specifically, this **refactoring** targets the `PoolStats` class in `imagepipeline-test` and the `CloseableReferences` utility in `imagepipeline`'s test suite. This improves the **robustness and type-safety** of these test helpers, enabling stricter nullability checks during compilation.

This commit **refactors** the **Volley backend classes** within the `imagepipeline-backends` module by adding the `@Nullsafe` annotation to `RawRequest.java`, `VolleyImagePipelineConfigFactory.java`, and `VolleyNetworkFetcher.java`. This **maintenance** change significantly enhances **type safety** and code quality by enabling compile-time nullability checks for the **Volley integration** of the image pipeline. By doing so, it helps prevent potential `NullPointerException`s, making the code more robust and reliable for consumers of the image pipeline's Volley backend.

This commit addresses and **fixes null safety issues** throughout the **Fresco Showcase sample application**, preventing potential `NullPointerException`s. It introduces comprehensive null safety annotations and checks within key UI components like `ImageFormatGifFragment`, `ResizableFrameLayout`, `SettingsFragment`, and `VitoRoundedCornersFragment` to ensure stable operation during user interactions and data handling. The `BaseShowcaseFragment` also receives a null safety annotation as part of this **refactoring** and **maintenance** effort, which also includes updating deprecated API usage in `SettingsFragment`. This **bug fix** significantly enhances the **stability and robustness** of the sample app, providing a more reliable demonstration of Fresco's features.

This commit **reverts** a previous migration, restoring the use of **Stetho's native `DumpappServer` initialization** within the **Fresco open-source samples**. Specifically, the `ComparisonApp` and `ShowcaseApplication` samples now initialize `DumpappServer` using standard Stetho APIs in their `onCreate` methods. Additionally, the `BaseFrescoStethoPlugin` is updated to import **Stetho's native dumpapp classes**, moving away from internal Meta implementations. This **refactoring** and **maintenance** task ensures proper and standard integration of Stetho in the open-source Fresco ecosystem, improving compatibility and reducing reliance on internal tooling.

This commit **adds the `@Nullsafe` annotation** to the `IntPair` class, located within the **ImagePipeline memory module**. This is a **maintenance** and **style** change aimed at improving code quality and reliability. By marking `IntPair` as `@Nullsafe`, it ensures that all its fields and methods adhere to null-safety contracts, preventing potential `NullPointerExceptions` and enhancing the robustness of code interacting with `IntPair` instances.

This commit **refactors** the **Image Pipeline**'s **Ashmem memory management** test suite by converting the `AshmemMemoryChunkPoolTest` from Java to Kotlin. The conversion of `memory-types/ashmem/src/test/java/com/facebook/imagepipeline/memory/AshmemMemoryChunkPoolTest.kt` maintains all existing test logic and assertions, ensuring no change in test coverage or behavior. This **maintenance** task aligns the test with modern development practices and improves codebase consistency without impacting the runtime functionality of the memory pool.

This commit introduces a **new lightweight debug overlay** for **Vito2**, specifically enhancing the `FrescoDrawable2` component. It adds a `LightweightDebugOverlayDrawable` to display a color-coded bar and configurable debug text, such as image dimensions, origin, and URI, at the bottom of rendered images. New debug data providers in `FrescoDrawable2DebugDataProviders.kt` facilitate the extraction of this critical image information, which is then managed and rendered by a `LightweightDebugOverlayFactory2`. This **new capability** provides developers with an **on-device visual debugging tool** to quickly understand and diagnose image loading characteristics within the Vito2 rendering pipeline.

This commit performs a significant **refactoring** within the **Fresco Vito core implementation** by simplifying the logic in `KFrescoController.kt`. It streamlines several methods, including `bind` and `setActualImage`, by extracting common drawable validation and improving parameter naming for enhanced readability. This effort reduces the internal complexity of the image loading and management controller, making the code more maintainable. The changes primarily affect the internal workings of how images are bound and released within the Vito framework, with no direct impact on external API behavior.

This commit **refactors** the `KFrescoVitoDrawable` class within the **Fresco Vito core implementation** to simplify its internal logic. It streamlines several functions and property getters, including `getIntrinsicWidth` and `setOverlayDrawable`, by adopting more concise Kotlin syntax like `?.let` and single-expression bodies. This **maintenance** effort enhances code readability and maintainability for the drawable's internal operations, ensuring no changes to its external behavior or API.

This commit **enhances the Vito debug overlay** by introducing **new debug data providers** and utility functions. It adds capabilities to display more detailed information about **image origin, format, and URI** within the overlay. Existing debug data providers in `vito/core-common-impl` and `vito/core-impl` are updated to accept an `Extras` parameter, allowing for richer and more comprehensive debugging data to be presented. This work significantly improves the diagnostic capabilities for **Vito image loading and display**.

This commit **refactors** the **Vito debug overlay system** by **relocating generic debug data provider definitions** and utility functions, such as `formatDimensions`, from the `vito/core-impl` module to a new `vito/core-common-impl` module. This **module restructuring** centralizes common debug utilities, improving code organization and reusability across the Vito project. As a result, files within `vito/core-impl` and `vito/tools/liveeditor` were updated to reference these providers, including `StringDebugDataProvider`, from their new common location. The change ensures that shared debug components are accessible to various modules without code duplication. This is a **maintenance refactoring** that has no functional impact but streamlines the codebase for future development.

This commit introduces a **new feature** to the **Image Pipeline** library, enabling developers to specify a custom cache key for image requests. It **enhances the `ImageRequest` and `ImageRequestBuilder`** by adding a `mCustomCacheKey` field and corresponding `setCustomCacheKey` method, allowing users to define their own unique identifier. The **caching mechanism** is updated, with `DefaultCacheKeyFactory` now prioritizing this custom key for both bitmap and encoded image caching. This provides **greater control over image caching behavior**, facilitating more flexible cache management for diverse image loading scenarios where the default key generation is insufficient.

This commit performs a **maintenance cleanup** by **removing an obsolete TODO comment** pertaining to the **Vito Kotlin layer opacity** functionality. This action targets the **Vito Kotlin** module, aiming to improve code clarity and maintainability by eliminating outdated directives. As a **refactoring** and **cleanup** task, this change has no functional impact on the application, only addressing a comment that is no longer relevant.

This commit introduces a **new capability** to the **Fresco Vito image loading library** by adding support for `ColorImageSource`. It defines a new data class, `ColorImageSource`, allowing developers to specify an image source as a single solid color. The **core rendering controllers**, `KFrescoController` and `FrescoController2Impl`, have been updated to recognize this new source type and render a `ColorDrawable` accordingly when `setActualImage` is called. This enhancement simplifies displaying solid color placeholders or backgrounds within the Fresco Vito framework, providing a more integrated and efficient way to handle such UI elements.

This commit introduces an **API change** within the **Fresco Vito image loading library**, specifically affecting the `DrawableResImageSource` component. It **refactors** the `DrawableResImageSource` data class by changing the visibility of its `resId` property from private to public. This modification allows external consumers of `DrawableResImageSource` to directly access the underlying Android drawable resource ID. The change enhances the flexibility and introspection capabilities for modules interacting with image sources defined by resource identifiers.

This commit introduces a **performance optimization** for **Fresco Vito's image rendering** by preventing redundant alpha updates. Specifically, it modifies the **Vito renderer** and **data layer** to only update the alpha value if it differs from the current paint alpha, avoiding unnecessary operations. This **enhancement** is controlled by a new `experimentalOptimizeAlphaHandling` configuration flag, which is integrated across `FrescoVitoConfig`, `KFrescoVitoDrawable`, `ImageLayerDataModel`, and `ImageRenderer`. The change aims to improve rendering efficiency by reducing redundant alpha setting calls within the **Vito core implementation**.

This commit introduces a **new feature** to the **Vito core-impl** module, enhancing the usability of the debug overlay. A **convenience method** is added to the `DebugOverlayHandler` by providing a new constructor. This constructor allows developers to directly set the debug overlay's enabled state using a simple boolean, eliminating the need for a `Supplier` when dynamic state provision is not required. This change simplifies the setup and configuration of the debug overlay, streamlining debugging workflows within the **Vito** framework.

This commit introduces a **new debugging feature** to the **Vito image loading library**, specifically within its `core-impl` module. It **adds the capability to display HDR gainmap presence** (true/false) directly in the **Vito debug overlay**. This enhancement provides developers with immediate visual feedback on whether an image being rendered includes an HDR gainmap, significantly aiding in the **diagnostics and testing of HDR image support**. The change involves adding an `hdrGainmapProvider` in `DebugDataProvider.kt` and integrating it into the `DebugOverlayHandler.kt` to render this information.

This commit introduces a **new capability** to detect the presence of a **gainmap** within a drawable's underlying bitmap, which is essential for **HDR image support**. It adds the `hasBitmapWithGainmap` method across the **Vito core interfaces** (`FrescoDrawableInterface.kt`), **implementations** (`KFrescoVitoDrawable.kt`, `FrescoDrawable2Impl.kt`), and **data models** (`ImageLayerDataModel.kt`, `ImageDataModel.kt`). This allows the **Fresco Vito rendering pipeline** to query if an image contains HDR metadata, enabling proper handling and display of **HDR content** by checking for gainmaps with appropriate Android version checks.