Oleksandr Redko

This commit significantly **improves the clarity and accuracy of comments** across various **example `main.go` files** within the `/examples` directory. It involves **documentation updates** such as correcting grammar, spelling, and terminology in `codespaces` and `newreposecretwithxcrypto` examples, clarifying usage for `ratelimit` and `verifyartifact`, and updating descriptions for `otel` and `listenvironments`. These **maintenance** changes enhance the understandability of the example code, making it easier for users to grasp the functionality and intended use of different features.

This commit performs a **tooling update** by migrating the **CI/CD linting workflow** to use `golangci-lint-action` within GitHub Actions. This **maintenance chore** enhances code quality enforcement by adding checks for generated code and OpenAPI validation to the automated pipeline. Concurrently, the `example/newreposecretwithlibsodium` directory is no longer excluded from linting, ensuring broader code coverage for quality checks. This change improves the overall **developer experience** and **code consistency** across the project by leveraging a more robust linting solution.

This commit **optimizes CI performance** by implementing **caching for custom `golangci-lint` binaries** within the **GitHub Actions linter workflow**. It refactors `script/setup-custom-gcl.sh` to dynamically read the linter version from the configuration file and updates the binary installation path. This `chore` also includes a correction to a plugin path in `.custom-gcl.yml`, collectively reducing redundant downloads and installations to make linting runs faster and more efficient.

This commit **updates the Dependabot configuration** in `.github/dependabot.yml` to expand its dependency scanning capabilities. It now includes **subdirectories within the `tools` directory** for **Go module dependency scanning**, specifically for **linter dependencies**. This **maintenance chore** ensures that all relevant tooling dependencies are automatically monitored and kept up-to-date, significantly improving **project maintainability** and **security** by automating dependency updates for critical tooling.

This commit **refactors** the internal **`check-structfield-settings` tool** by updating its `golangciConfig` struct. It now utilizes an **inline `structfield.Settings`** to manage tag configurations, standardizing how these settings are defined within `tools/check-structfield-settings/main.go`. This **maintenance refactoring** improves the internal consistency and maintainability of the `check-structfield-settings` utility, without introducing any direct user-facing changes.

This commit performs a **maintenance chore** by significantly updating the project's **Go linting configuration** in `.golangci.yml`. It enables a stricter `default: none` policy for linters, ensuring only explicitly configured checks are run. Specifically, it activates crucial linters like `errcheck`, `ineffassign`, and `unused` to improve code quality by catching potential errors, inefficient assignments, and dead code, while disabling `copyloopvar` and `intrange` for better focus. This change will lead to **stricter and more effective code analysis** across the entire Go codebase, enhancing overall code health.

This commit performs a **code cleanup** by **removing duplicated formatter implementations** from the codebase. It targets the utility or presentation layer responsible for data formatting, ensuring that only a single, canonical version of each formatter exists. This **refactoring** effort improves code maintainability, reduces redundancy, and streamlines future development. The change is purely internal and does not introduce any functional modifications or user-facing impact.

This commit introduces a **chore** and **refactoring** effort to **significantly speed up the project's linting process**. It **refactors the main linting script** (`script/lint.sh`) to execute module lint jobs **concurrently**, leveraging `wait_pids` for improved performance. Additionally, the `golangci-lint` installation method in `script/setup-custom-gcl.sh` has been updated to use the official install script and adjust version checks, ensuring a more robust tooling setup. This change directly **enhances developer productivity** by reducing wait times during code quality checks across the codebase.

This commit **refactors** the **`CopilotService` tests** within `github/copilot_test.go` to enhance their readability and conciseness. It **simplifies test setup** by inlining timestamp creation directly into test struct literals, eliminating intermediate variable assignments. This **test code maintenance** effort makes the existing `CopilotService` tests easier to understand and maintain, without altering any production functionality or behavior.

This commit **fixes a flaky test**, `TestDo_rateLimit_abuseRateLimitError_xRateLimitReset`, specifically targeting the **GitHub API client's rate limit abuse error handling**. It **refactors** the test in `github/github_test.go` by wrapping it with `synctest.Test`, adjusting time calculations to **UTC**, and refining assertions. This **test maintenance** work ensures more reliable and consistent test results for the **GitHub client's rate limiting logic**, preventing false negatives and improving overall **test stability**.

This commit introduces a **breaking change** to the **`ActivityService`**, specifically modifying the `MarkThreadDone` method. The `id` parameter for `MarkThreadDone` has been **refactored** from an `int64` to a `string` type in `github/activity_notifications.go`. This change corrects the parameter type, ensuring consistency and potentially resolving underlying issues with activity notification identification. Consumers of this **activity notification functionality** must update their calls to `MarkThreadDone` to pass a `string` `id`, as reflected in the updated test suite.

This commit represents a **significant refactoring** of the test infrastructure, specifically aimed at simplifying and standardizing form value assertions. It **refactors** the existing `testFormValues` utility and introduces a **new** `testFormValuesList` utility within `github/github_test.go` to provide more robust and concise assertion logic, particularly for handling multiple values per key. This **maintenance** effort standardizes form value assertions across **various test suites** in the `github` package, including those for organizations, personal access tokens, repository contents, releases, and security advisories. The change ultimately makes **test code more readable and maintainable** by reducing boilerplate and improving assertion clarity.

This commit performs a **documentation and tooling consistency** update through **spelling corrections**. It standardizes the term `whitespace` to `white space` within the **contributing guidelines** (`CONTRIBUTING.md`) and the help messages of the **metadata generation tool** (`tools/metadata/main.go`). Furthermore, the `tools/metadata/main.go` utility now consistently uses `SHA` instead of `sha` in its output. A minor **maintenance** update also corrects a URL in the `.golangci.yml` configuration, collectively enhancing the clarity and accuracy of project-wide text without introducing any functional changes.

This commit performs a significant **maintenance update** to the **JSON marshalling tests** across nearly all `github/` sub-packages. The central `testJSONMarshal` utility in `github/github_test.go` has been **refactored** into separate marshal/unmarshal functions and enhanced with new JSON comparison options. Consequently, expected JSON outputs for a vast number of **GitHub API client models** have been updated, and `cmpJSONRawMessageComparator` options were added to several tests to improve comparison robustness. This ensures the **serialization logic** for data structures like `ActionsCacheList`, `RunnerGroup`, `Secret`, `Event`, and various `Repository` and `Organization` related models remains accurate and thoroughly tested. This **chore** improves the **reliability of the test suite** by reflecting current marshalling behavior and enhancing test utility.

This commit **fixes the `TestNewFormRequest` function** within the **GitHub API client test suite** by adding robust error handling. It also **improves error message formatting** within this test, making failures more informative. This **test fix** enhances the reliability and clarity of the test suite, aiding future debugging and development efforts for the `github` package.

This commit **fixes outdated documentation links** within the **GitHub API client documentation**. Specifically, it updates a link related to conditional requests in `github/doc.go` and corrects several authentication documentation links found in the example functions within `github/examples_test.go`. This **documentation maintenance** ensures users are directed to the correct and most current resources when learning about the GitHub API client's usage, improving the overall accuracy and usability of the project's documentation.

This commit performs a **refactoring** of the **GitHub API client library** by updating several deprecated pointer helper functions. Specifically, the `Bool`, `Int`, `Int64`, and `String` helper functions in `github/github.go` are modified to internally call a more generic `Ptr` function, streamlining their implementation. Additionally, various **test files** across `enterprise_apps`, `orgs_custom_repository_roles`, `scim`, and `sub_issue` modules are updated to directly use the generic `Ptr` helper, ensuring consistency with the new internal approach. This **maintenance** task improves code clarity and reduces redundancy within the pointer utility functions.

This commit primarily performs **maintenance** by **updating the `golangci-lint` version** and its configuration. It **enables several new `revive` rules** in `.golangci.yml` to enforce stricter code quality standards. Concurrently, various **refactorings** were applied across the **`github` API client** and **internal `tools`** modules, simplifying code structures like `switch` statements and type assertions. This work improves overall code readability and maintainability, aligning the codebase with enhanced linting practices without altering functional behavior.

This commit introduces a **breaking change** by **refactoring** the **`IssuesService`** and **`SubIssueService`** APIs to clarify and correctly handle options for listing issues and sub-issues. The previous `IssuesService.List` method has been split into `IssuesService.ListAllIssues` and `IssuesService.ListUserIssues`, each accepting distinct option types. Furthermore, `IssuesService.ListByOrg` now uses `IssueListByOrgOptions`, and `SubIssueService.ListByIssue` has been updated to accept `ListOptions`. This significant **API modification** impacts consumers of these **GitHub API client methods**, requiring updates to their code due to altered method signatures and option parameters.

This commit undertakes a significant **refactoring** effort to modernize sorting operations across the codebase, transitioning from the legacy `sort` package to the more efficient and idiomatic `slices` package, often in conjunction with `maps` and `cmp`. Specifically, it updates sorting logic within the **GitHub integration module** (`github/messages.go`) and various **internal tooling components** such as `tools/check-structfield-settings` and the `tools/metadata` package responsible for OpenAPI generation. This **code modernization** improves readability and leverages standard library enhancements, with a new `gocritic` linter rule added to `.golangci.yml` to guide future development towards `slices` usage. The change primarily impacts internal code quality and maintainability without altering any external functionality.