Joshua Selbo

This commit introduces a **bug fix** within the **Android APK packaging** process to prevent `DuplicateFileException` errors during build. It modifies the `ApkBuilder`'s `shouldInclude` method in `prelude/toolchains/android/src/com/facebook/buck/android/apk/sdk/ApkBuilder.java` to **filter out `LICENSE` and `NOTICE` files**. This change resolves build failures that occur when multiple JAR dependencies contain these common metadata files, ensuring smoother assembly of Android applications by avoiding duplicate entries.

This commit implements a **feature enhancement** for the **`android_library` rule**, enabling it to emit sub-targets, such as `dummy_r_dot_java`, even when no source files are provided. This change removes an unnecessary restriction, allowing for more flexible use cases where these sub-targets are required independently of source code. Specifically, the `get_default_info` function in `prelude/java/utils/java_utils.bzl` was modified to ensure sub-targets are always included during `DefaultInfo` initialization. This broadens the utility of `android_library` definitions by decoupling sub-target generation from the presence of source files.

This commit performs a **codemod** to **refactor** the project's test infrastructure. It **updates test code** across the **Drawee**, **FBCore**, and **ImagePipeline** modules, specifically changing import statements in various test files to utilize the modern `org.junit.Assert` class. This change replaces the deprecated `junit.framework.Assert` with its updated counterpart, which helps **modernize the test infrastructure** and ensures better compatibility with current JUnit versions. The modification is purely internal to the testing suite, **improving maintainability** without affecting any production code or application functionality.

This commit performs a **codemod** operation to **modernize test code** within the **Android internationalization test suite** for the `Hermes` project. It **refactors** import statements in files like `HermesInstrumentationTest.java` and `HermesIntlAndroidTest.java`, replacing the deprecated `Java6Assertions` with the standard `Assertions` from the AssertJ library. This **maintenance** task removes reliance on an outdated compatibility layer that is no longer necessary for Android support, aligning the codebase with current best practices and resolving a lint warning. The change is confined to test files and has no impact on runtime behavior or production code.

This commit performs a **refactoring** within the **`fresco/vito/core/impl` test suite**, specifically updating `ImagePipelineUtilsImplTest.kt`. It replaces outdated `Java6Assertions` imports and method calls with the more modern `Assertions` API. This **maintenance** task standardizes the assertion library used in tests, improving code consistency and maintainability. The change is confined to **test code** and has no impact on the runtime behavior or functionality of the `Fresco Vito` library.

This commit introduces a **bug fix** within the **Buck build system** to enhance the robustness of **Kotlin Symbol Processing (KSP)** compilation. It modifies the `ZipIsolatedStep` in `prelude/toolchains/android/src/com/facebook/buck/step/isolatedsteps/common/ZipIsolatedStep.kt` to **delete existing zip files** before attempting to write new ones. This change prevents a **rare `RuntimeException`** that could occur when a build is interrupted and then restarted, specifically an "Attempting to overwrite an existing zip" error. By gracefully handling pre-existing output files, this **maintenance** improves the reliability of the build process and developer experience, particularly for KSP-generated sources.

This commit performs **test suite maintenance** by **removing several tests that were previously marked with `@Ignore`**. These tests were not actively being executed, so their removal helps to **clean up the codebase**. This action streamlines the **test infrastructure** by eliminating dead test code, ensuring that the test suite remains focused and efficient.

This commit **refactors** several **test suites** by **removing JUnit `assume` statements**, which were previously used for conditional test execution. The logic now replaces these with direct conditional returns or stronger `assertTrue` and `assertThat` assertions, ensuring tests either run fully or explicitly pass/fail. This change primarily impacts tests within the **Java ABI generation** (`StubJarTest`, `FrontendOnlyJavacTaskTest`), **test runner timeouts** (`TimeoutTest`), and **class loader caching** (`ClassLoaderCacheTest`) components under `prelude/toolchains/android`. This **maintenance** effort improves **test reliability and consistency** by making test outcomes more explicit and less dependent on implicit environment assumptions.

This commit performs **maintenance** by **removing unused PowerMock dependencies** from the project's **Gradle build configuration files**. This **cleanup** streamlines the dependency graph, reducing build overhead and improving the overall maintainability of the **testing infrastructure**. The change specifically targets obsolete PowerMock-related entries, ensuring the build system only includes necessary components.

This commit performs **test cleanup** by **removing Java 8 specific conditional logic and imports** from the **Java ABI generation test suite** within the `buck` build tool. It updates `prelude/toolchains/android/test/com/facebook/buck/jvm/java/abi/source/FrontendOnlyJavacTaskTest.java` and `prelude/toolchains/android/test/com/facebook/buck/jvm/java/abi/source/InterfaceScannerTest.java` to remove outdated assertions and event expectations. This **maintenance task** addresses tests that were failing or incompatible with Java 8, ensuring the test suite remains stable and relevant for current Java versions. The change **improves the maintainability and reliability of the ABI generation tests** by eliminating legacy code.

This commit **removes** the `ExternalJavac` component, effectively **deprecating and eliminating** the use of an external Java compiler integration within the system. This **maintenance** effort simplifies the **Java build pipeline** by consolidating compilation logic or removing an outdated dependency. The change streamlines the overall build infrastructure, reducing complexity related to external tool management for Java projects.

This commit performs a **maintenance update** by adjusting the default targeted Java version constant within the **Buck build system's Android toolchain**. It modifies `prelude/toolchains/android/src/com/facebook/buck/jvm/java/JavacLanguageLevelOptions.kt` to update the default `target` value from Java 7 to Java 8. This **chore** primarily affects **internal tests** that rely on this default setting, ensuring they reflect the current standard Java language level. The change aligns the codebase with the reality of Java 8 being the de-facto default, with no significant impact on production builds.

This commit performs a significant **refactoring** by **removing the `ProcessExecutor`** and its related dependencies from the **compiler daemon (`javacd`/`kotlincd`) infrastructure**. This cleanup is enabled by the deprecation of external `javac` support within these workers, allowing for a simpler implementation of the `CompilerDaemonRunner`. The change also involves updating **Java compilation test utilities** such as `FakeJavac` and `TestExecutionContext` to remove their reliance on process execution abstractions, resulting in a leaner and more focused codebase for Java and Kotlin compilation.

This commit performs a **maintenance refactoring** within the **Buck Android toolchain testing infrastructure**. Specifically, the `newInstance` method in `prelude/toolchains/android/test/com/facebook/buck/step/TestExecutionContext.java` has been updated to **no longer pass environment variables** when creating an `IsolatedExecutionContext`. This change simplifies the test setup by preventing environment variables from being propagated to isolated test contexts, ensuring more predictable and isolated test execution without affecting Buck's core runtime behavior.

This commit performs a **cleanup** of the **Java ABI testing infrastructure** by removing Java 8-specific test runner annotations. It updates numerous test files within `prelude/toolchains/android/test/com/facebook/buck/jvm/java/abi/` to use the standard `Parameterized` runner instead of `CompilerTreeApiParameterized`. This **refactoring** removes legacy "hacks" and imports that were necessary for Java 8 compatibility, streamlining the test setup. The change signifies that these tests no longer require special handling for older Java versions, simplifying the test codebase without altering test functionality.

This commit **refactors** the **Buck build system's Android toolchain** by **removing obsolete Java 8 compatibility logic**. Specifically, it simplifies the `getPackageElementEvenIfEmpty` method within `prelude/toolchains/android/src/com/facebook/buck/jvm/java/lang/model/MoreElements.java`, which previously used reflection for Java 8, to now directly leverage Java 9+ APIs. This **maintenance work** is safe because the `javacd` toolchain, used by **CD workers**, no longer needs to support Java 8 runtimes. The change streamlines the codebase, improving clarity and reducing complexity within the **JVM Java language model** by eliminating unnecessary backward compatibility.

This commit **refactors Java testing infrastructure** by **removing deprecated Java 8-specific code** from `AnnotationProcessorFactoryTest.java` and `PluginFactoryTest.java` within the `prelude/toolchains/android` module. It replaces calls to the removed `SynchronizedToolProvider.getSystemToolClassLoader()` with the standard `ClassLoader.getPlatformClassLoader()`. This **maintenance task** ensures that these **tests are compatible with newer Java versions** and no longer rely on an outdated internal API. The change improves the long-term stability and forward compatibility of the build system's Java tooling tests.

This commit performs a **refactoring** by **removing** the `ResolvedJavac.Source` component from the codebase. This change streamlines the **Java compilation and analysis subsystem**, eliminating an obsolete or redundant abstraction. The removal simplifies the internal architecture and reduces maintenance overhead within the `Javac` integration. This is an internal cleanup with no direct impact on external functionality or user-facing features.

This commit **removes deprecated Java 8 specific logic** from the **`javacd` toolchain**, as remaining Java 8 runtimes no longer utilize this component. Specifically, it **cleans up** the `prelude/toolchains/android/src/com/facebook/buck/jvm/java/plugin/adapter/PostEnterTaskListener.java` file by eliminating Java 8 specific conditional logic and imports within the `onEvent` method. This **maintenance task** simplifies the **Java plugin adapter's** annotation processing event handling. The change ensures **no functional impact** on current builds while streamlining the codebase by removing obsolete support.

This commit **refactors the Kotlin toolchain definition** to explicitly distinguish between the standard `kotlinc` compiler and its `kotlincd` variant. It introduces a new `kotlincd` field within the `KotlinToolchainInfo` provider in `prelude/kotlin/kotlin_toolchain.bzl`, allowing for separate path definitions in `prelude/toolchains/kotlin.bzl` via the `kotlincd_toolchain` function. Consequently, the `_define_kotlincd_action` in `prelude/kotlin/kotlincd_jar_creator.bzl` now directly references the dedicated `kotlincd` compiler from the toolchain. This **enhancement** improves the **Kotlin build system's configuration flexibility** by providing distinct compiler paths. It is a preparatory step for future logic that might leverage `kotlinc` even when `kotlincd` is the preferred protocol.