Jitendra Verma

This commit **enhances the reliability of hardware tests** by addressing a race condition in the IPv6 address change test. It modifies `fboss/agent/test/agent_hw_tests/AgentTunnelMgrTests.cpp` to incorporate a `WITH_RETRIES` pattern using `checkKernelEntriesExistBool()`. This **test enhancement** ensures the test reliably waits for the asynchronous processing of the **`TunManager`** to complete, preventing flaky failures caused by assertions running before kernel entries are fully updated. The change improves the robustness of validating IPv6 address modifications within the **`AgentTunnelMgrTests`** suite.

This commit **enhances the stability** of the **`AgentTunnelMgrTests`** by addressing a **race condition** in the `checkKernelIPv4EntriesPortsDown` test. Previously, asynchronous processing by the **`TunManager`** could cause test assertions to fail prematurely. A **retry mechanism** using the `WITH_RETRIES` pattern and `checkKernelEntriesExistBool()` has been added to `fboss/agent/test/agent_hw_tests/AgentTunnelMgrTests.cpp`, allowing the test to wait for `TunManager` operations to complete. This **test enhancement** ensures more reliable and accurate validation of **IPv4 kernel entries and port status**, preventing flaky failures in the **hardware agent tunnel manager test suite**.

This commit **enhances the stability of hardware agent tests** by introducing a retry mechanism to mitigate a race condition. Specifically, it addresses a **test reliability issue** in the `changeIPv4Address` test within `fboss/agent/test/agent_hw_tests/AgentTunnelMgrTests.cpp`. The change implements a `WITH_RETRIES` pattern using `checkKernelEntriesExistBool()` to ensure the test waits for **`TunManager`** asynchronous processing to complete before asserting. This **test enhancement** prevents flaky failures caused by timing issues between test assertions and `TunManager`'s kernel entry updates, leading to more robust and dependable test results.

This commit **enhances the reliability of hardware tests** for the **`TunManager`** by addressing a **race condition** in the `checkDuplicateEntries` test. It updates the `fboss/agent/test/agent_hw_tests/AgentTunnelMgrTests.cpp` file to incorporate a **retry pattern** using `EXPECT_EVENTUALLY_TRUE` and `checkKernelEntriesExistBool()`. This **test enhancement** ensures that test assertions wait for the `TunManager`'s asynchronous processing to complete, preventing intermittent test failures and improving the overall stability of the **tunnel management test suite**.

This commit **enhances the `AgentTunnelMgrTests`** by introducing a retry mechanism to the `checkKernelIPv6EntriesPortsDownUp` test case. It **fixes a race condition** where test assertions could execute prematurely before the `TunManager`'s asynchronous processing completed, leading to intermittent test failures. By utilizing the `WITH_RETRIES` pattern with `checkKernelEntriesExistBool()`, the test now robustly waits for kernel entries to be properly updated. This **test enhancement** significantly improves the **reliability and stability of the FBOSS agent hardware tests** related to tunnel management.

This commit **enhances the reliability of the `checkProbedDataCleanupInterfaceDown` test** within the **`AgentTunnelMgrTests`** suite. It **resolves a race condition** that occurred between test assertions and the asynchronous processing of the **`TunManager`**. By integrating a **`WITH_RETRIES` pattern** using `checkKernelEntriesExistBool()`, the test now waits for `TunManager` to complete its operations, ensuring accurate and consistent test results. This **test fix** prevents intermittent failures and improves the overall stability of the **tunnel manager's hardware tests**.

This commit **enhances the reliability of hardware tests** by addressing a **race condition** within the `AgentTunnelMgrTests` suite. Specifically, it modifies the `checkKernelIPv4EntriesPortsDownUp` function in `fboss/agent/test/agent_hw_tests/AgentTunnelMgrTests.cpp` to incorporate a `WITH_RETRIES` pattern. This **test enhancement** ensures that assertions wait for the asynchronous processing of the `TunManager` to complete, preventing flaky test failures caused by timing discrepancies. The change improves the stability and accuracy of **tunnel manager hardware tests** by making them more robust against timing variations.

This commit **fixes a race condition** within the **`AgentTunnelMgrTests.cpp`** test suite, specifically enhancing the `checkKernelIPv4Entries` test. It introduces a **retry mechanism** using the `WITH_RETRIES` pattern and `checkKernelEntriesExistBool()` to ensure test assertions correctly wait for asynchronous processing by the **`TunManager`**. This **test maintenance** improves the **reliability and stability of hardware agent tests** by preventing intermittent failures caused by timing issues between test assertions and `TunManager`'s kernel entry updates.

This commit **improves test stability** by addressing a **race condition** within the `AgentTunnelMgrTests.cpp` suite. It enhances the `checkKernelIPv6Entries` function, which is part of the **TunManager** testing, by integrating a retry mechanism. This change ensures that test assertions correctly wait for the asynchronous `TunManager` processing to complete, preventing intermittent failures caused by timing issues. The fix utilizes the `WITH_RETRIES` pattern with `checkKernelEntriesExistBool()` to make the tests more robust and reliable.

This commit **resolves a race condition** in the `checkProbedDataCleanup` test within the **`AgentTunnelMgrTests.cpp`** suite. The test previously suffered from flakiness due to a timing conflict between its assertions and the asynchronous processing of the **`TunManager`**. To address this, a **retry mechanism** using `checkKernelEntriesExistBool()` is now employed, allowing the test to wait for `TunManager` operations to complete. This **test stability improvement** ensures more reliable execution of **hardware agent tunnel tests** by preventing premature assertions.

This commit **resolves a race condition** in the **`AgentTunnelMgrTests`** where test assertions for IPv4/IPv6 address changes would prematurely check kernel entries before `TunManager`'s asynchronous updates were complete. It introduces a new utility function, `checkKernelEntriesExistBool`, in `TunnelMgrTestUtils` that provides a boolean check, enabling tests to **poll and wait** for the kernel state to reflect the desired IP addresses. This **test infrastructure improvement** ensures the reliability of agent hardware tests verifying `TunManager`'s IP address management by properly synchronizing test assertions with the system's actual state.

This commit performs a significant **cleanup** within the **AgentTunnelMgrTests.cpp** file by removing numerous **unused local API definitions**. Functions like `clearKernelEntries` and `checkKernelIpEntriesExist` were made redundant after all tests were successfully migrated to utilize shared utility APIs from `TunnelMgrTestUtils.h`. This **refactoring** effort improves the **maintainability** and reduces **technical debt** within the **Tunnel Manager test suite**, ensuring a more streamlined and consistent approach to testing kernel interactions. Additionally, unused includes like `<sstream>` and `ConfigFactory.h` were removed, further tidying the codebase.

This commit **refactors** the `checkProbedDataCleanupInterfaceDown` test within **`fboss/agent/test/agent_hw_tests/AgentTunnelMgrTests.cpp`**. It updates this specific test case to leverage the shared `utility::checkKernelEntriesExist` API, migrating it from a potentially duplicated or less standardized implementation. This **test maintenance** effort promotes code reuse and consistency across the **Tunnel Manager test suite**, improving the overall maintainability and reliability of the test infrastructure.

This commit **refactors** the `SetUp` method within `fboss/agent/test/agent_hw_tests/AgentTunnelMgrTests.cpp` to utilize a new, standardized utility API. Specifically, it updates the test setup to invoke `utility::clearAllKernelEntries` from the `TunnelMgrTestUtils.cpp` module. This change improves code consistency and maintainability by centralizing common test operations into a dedicated `utility::` namespace. The scope is limited to the **test infrastructure** for the **Tunnel Manager** component, ensuring cleaner and more reusable test code.

This commit **refactors** the **`AgentTunnelMgrTests`** by migrating several wrapper methods to utilize standardized utility APIs from the `TunnelMgrTestUtils` namespace. Specifically, methods like `clearKernelEntries` and `checkKernelIpEntriesExist` now delegate to their `utility::` counterparts. This **improves test code consistency and reusability**, centralizing common test logic for **tunnel management kernel entry checks** within the FBOSS agent's hardware tests. The change streamlines the test infrastructure, making it more maintainable by leveraging shared utility functions.

This commit **refactors** the **`AgentTunnelMgrTests`** suite by migrating the `checkProbedDataCleanup` test to leverage shared utility APIs. Specifically, the test now utilizes the `utility::checkKernelEntriesExist` function, centralizing common test logic. This **test maintenance** effort improves **code consistency and maintainability** within `fboss/agent/test/agent_hw_tests/AgentTunnelMgrTests.cpp`. By adopting the `TunnelMgrTestUtils` API, the change streamlines test implementation and reduces potential code duplication for kernel entry checks.

This commit **refactors** the `checkKernelIPv4EntriesPortsDownUp` test within the **Tunnel Manager hardware test suite** (`AgentTunnelMgrTests.cpp`). It updates the test to leverage common utility APIs from `TunnelMgrTestUtils.cpp` for kernel entry operations. Specifically, calls to check, clear, and verify removal of kernel entries now use `utility::checkKernelEntriesExist`, `utility::clearKernelEntries`, `utility::checkKernelEntriesRemoved`, and `utility::clearAllKernelEntries`. This **maintenance** change improves the **maintainability and consistency** of the test suite by centralizing common test infrastructure logic.

This commit **refactors** the `checkKernelIPv4EntriesPortsDown` test within the **`AgentTunnelMgrTests`** suite to enhance code reusability and consistency. The test now utilizes a set of shared utility APIs from `TunnelMgrTestUtils.cpp`, specifically `utility::checkKernelEntriesExist`, `utility::clearKernelEntries`, `utility::checkKernelEntriesRemoved`, and `utility::clearAllKernelEntries`, for managing kernel entries. This **maintenance** effort centralizes common test logic, improving the readability and maintainability of the test suite without altering the functional behavior of the test itself.

This commit **refactors** the `changeIpv4AddressPortDownUp` test located in `fboss/agent/test/agent_hw_tests/AgentTunnelMgrTests.cpp`. The test now leverages common **utility APIs** from `TunnelMgrTestUtils.cpp`, specifically `utility::getInterfaceIpAddress` and `utility::clearAllKernelEntries`. This **maintenance** effort improves the consistency and maintainability of the **Tunnel Manager** test suite by centralizing common test operations.

This commit **refactors** the **`AgentTunnelMgrTests`** suite by updating the `changeIpv6AddressPortDownUp` test case. It migrates the test to utilize common **utility APIs** from `TunnelMgrTestUtils.cpp`, specifically `utility::getInterfaceIpAddress` and `utility::clearAllKernelEntries`. This **maintenance** effort improves the consistency and maintainability of the **FBOSS agent's hardware tests** by centralizing common test operations. The change ensures that test setup and teardown logic within this specific test leverages standardized helper functions, reducing code duplication and potential errors in the **test infrastructure**.