Jagadeesh Babu Challagundla

This commit delivers a **bug fix** for the **FBOSS agent's SAI platform initialization**, ensuring that **management ports are correctly ignored** when the `--hide-management-port` flag is enabled. Previously, these ports were erroneously configured despite the flag's presence. The fix modifies the `SaiPlatform` constructor in `fboss/agent/platforms/sai/SaiPlatform.cpp` to prevent management ports from being added to the logical port list. Additionally, the `genPortVlanCfg` utility in `fboss/agent/test/utils/ConfigUtils.cpp` is updated to exclude management ports from generated test configurations, maintaining consistency. This change improves the accuracy of port configuration and enhances security by preventing unintended exposure of management interfaces.

This commit introduces **new platform support** for the **Yangra2 platform** and its associated **Chenab2 ASIC**. It primarily involves **extending the CMake build system** to integrate the `Chenab2Asic` source, define `yangra2_platform_mapping` libraries, and link them into the `platform_mapping_utils` and `sai_platform` components. Additionally, this **new capability** includes **hardware test configurations** for both single and multi-switch Yangra2 setups, along with production feature configurations for the Chenab2 ASIC, enabling the software to run and be tested on this new hardware.

This commit introduces **support for the new Yangra2 platform and Chenab2 ASIC**, significantly extending FBOSS's hardware compatibility. It involves adding the `Chenab2Asic` implementation to define its specific hardware properties and integrating `PLATFORM_YANGRA2` and `ASIC_TYPE_CHENAB2` across various **FBOSS agent modules**, including configuration, ASIC utilities, and SAI platform management. A substantial **refactoring** effort was undertaken to generalize ASIC type checks, moving from specific `ASIC_TYPE_CHENAB` checks to using `getAsicVendor` for better maintainability. This **new capability** ensures FBOSS can correctly initialize, configure, and manage network devices built on the **Yangra2/Chenab2 hardware**, with comprehensive updates to existing tests to cover the new platform.

This commit **resolves a compilation failure** for the **`fboss/agent/test/prod_invariant_tests`** module by updating its build configuration. Previously, `fbpkg` for these tests failed on `conveyor` due to incorrect dependency resolution for the `tp2` project. The **maintenance** change modifies the `cxx_test` rules in `fboss/agent/test/prod_invariant_tests/BUCK` to leverage the `to_versions()` helper function, ensuring proper compile dependency resolution. This guarantees the invariant tests can build successfully, improving overall test reliability.

This commit **fixes build issues** within the **`fboss/agent/test/agent_hw_tests`** module by updating its `BUCK` file. It refactors the way **SAI SDK versions** are specified for `cxx_test` rules, transitioning from a direct dictionary literal to using the `to_versions()` function. This **maintenance** change resolves problems where preprocessor flags were not being exported correctly, ensuring proper dependency management and preventing unintended `sai_sdk` additions for agent tests. The update ensures that `agent_test` builds correctly resolve `fbpkg` issues related to exported flags.

This commit **enhances the test framework** by initializing the `agent_graceful_exit_timeout_ms` command line argument. Specifically, it configures this parameter within the `SetUp` method of `fboss/agent/test/AgentWrapperTest.cpp`. This **test framework enhancement** ensures that tests can properly control and observe the agent's graceful exit behavior, making the **test suite more robust** and configurable for scenarios involving agent shutdown.

This commit **disables L2 learning mode** for the **Chenab ASIC** within the **FBOSS agent system scale test configurations**. This **bug fix** addresses recurring **FDB errors**, specifically "fdb metadata read errors," that were observed in these tests after the enablement of `BRIDGE_PORT_8021Q` in a previous change. By modifying the `getSystemScaleTestSwitchConfiguration` function in `fboss/agent/test/utils/SystemScaleTestUtils.cpp`, the system scale tests no longer attempt unnecessary L2 learning for Chenab, which was causing instability. This **maintenance** change ensures the **reliability of the FBOSS testing infrastructure** by preventing test failures related to incorrect FDB state.

This commit introduces **support for NVIDIA Spectrum4 ASICs** within the `sdkcastle` utility. It **adds `SPECTRUM4` to the `AsicType` enumeration** in `fboss/util/sdkcastle/enums.py` and includes a new `nvda_basic_regressions.JSON` template to facilitate testing for this hardware. Furthermore, the `NetcastleTestRunner`'s SDK version parsing logic in `fboss/util/sdkcastle/test_runner.py` is enhanced to correctly identify 'chenab' and 'nvda' as **NVIDIA vendors**, ensuring proper vendor recognition and error handling for unknown types. This **new capability** allows the system to recognize and test against the specified NVIDIA ASIC.

This commit **refactors** the **FBOSS agent build system** to introduce more granular **test artifact packages**. Previously split by `test_type`, these artifacts are now further segmented by the specific `asic` or `product` type, such as `nvda` or `brcm`. The `fboss/agent/fbpkg/BUCK` configuration was updated to leverage a new macro, enabling the generation of distinct targets like `neteng.fboss.wedge_agent.test_artifacts.hw_test.nvda.opt-asan`. This enhancement provides **all test teams** with more precisely targeted test artifacts, streamlining the testing process for hardware-specific scenarios.

This commit **introduces new build configurations** within the `fboss/agent/fbpkg/BUCK` file to enable the generation of specific test artifact packages. It adds the necessary rules to create both **BCM and native BCM test artifacts**, which are crucial for hardware-specific testing. This **new capability** enhances the build system's ability to produce and distribute essential components for Broadcom-related development and testing. The change directly impacts the **FBOSS agent's build process** by providing a structured way to package these critical test assets.

This commit **enhances** the **FBOSS agent fbpkg build system** by modifying the `build_test_artifacts_fbpkg()` function and its dependent calls to accept a list of product lines. Previously, this function only supported a single product line, limiting its flexibility. This change now allows for **building fbpkgs for multiple product lines concurrently** that correspond to the same product name, significantly streamlining the build process for test artifacts. The update primarily affects the `fboss/agent/fbpkg/BUCK` file, where calls to the function are adjusted to leverage this new capability.

This commit introduces a **new feature** by adding build configuration to **generate test artifacts** for the **LEABA product line**. It updates the `fboss/agent/fbpkg/BUCK` file to include the necessary rules for packaging these artifacts. This enhancement directly supports the testing infrastructure for LEABA hardware, enabling the creation of dedicated test packages for quality assurance. The change primarily impacts the **FBOSS agent's build system** and the overall testing workflow for LEABA devices.

This commit **re-lands** a previously reverted change, **re-enabling Link group evictions for FBOSS test artifacts** within the **FBOSS agent hardware and production invariant tests**. It **updates the build configuration** by adding the `--rpath='$ORIGIN'` linker flag to `cxx_test` definitions in `fboss/agent/test/agent_hw_tests/BUCK` and `fboss/agent/test/prod_invariant_tests/BUCK`. This **maintenance update** resolves prior bus errors on the `wedge-agent conveyor` by ensuring shared libraries are correctly located at runtime. By properly configuring the runtime path for test binaries, this change improves the reliability and efficiency of the **FBOSS test infrastructure**.

This commit **re-lands** the functionality to **package eviction link group files into `test_artifacts` fbpkgs**, a change previously reverted due to bus errors on the `wedge-agent conveyor`. The re-landing is now safe as **`netcastle` has been updated with `sha256sum` checks and cleanup** to prevent issues with `.so` files not being copied correctly to test boxes. Specifically, the `fboss/agent/fbpkg/BUCK` file is **refactored** to configure `split-dwarf` and `use_link_groups` for `fboss_fbpkg_builder` targets, addressing underlying relocation overflow problems. This **maintenance and feature re-enablement** significantly **enhances the robustness of the testing infrastructure** and ensures proper deployment of `fboss/agent` components.

This commit **re-introduces** a critical **fix** by backing out a previous revert, enabling the use of `link_groups` for building `test_artifacts` within `fbpkg`. Specifically, it adds `split-dwarf` and `use_link_groups` configurations to the `fboss/agent/fbpkg/BUCK` file, resolving relocation overflow issues during the build process. This **maintenance** update ensures the correct compilation of `test_artifacts` for the `fboss` and `netcastle` modules.

This commit **re-applies a build system optimization** for **FBOSS agent tests**, which was previously reverted due to test failures. It introduces the `--rpath=$ORIGIN` linker flag to `cxx_binary` definitions within the `fboss/agent/test/agent_hw_tests/BUCK` and `fboss/agent/test/prod_invariant_tests/BUCK` build configurations. The primary goal of this **maintenance** change is to **save binary space** by enabling the eviction of specific `fbcode` directories during test compilation. This re-application ensures the **build efficiency** improvement can now be safely integrated, as the underlying issue causing `agent invariant config tests` to fail has been addressed.

This commit **updates the build configuration** for **FBOSS test artifacts** by incorporating `split-dwarf` and `use_link_groups` into multiple `fboss_fbpkg_builder` targets within `fboss/agent/fbpkg/BUCK`. This **maintenance change** is specifically designed to **fix relocation overflow issues** that were occurring during the build process for these packages. By implementing these configurations, the commit ensures the **stability and correctness of the build system** for FBOSS test artifacts, preventing build failures related to memory addressing.

This commit performs **maintenance** and **optimization** for **FBOSS agent tests**, primarily by using `link_groups` to evict unnecessary `fbcode` directories during compilation, thereby **reducing binary size**. It also **enhances test execution reliability** for **NetCastle tests** by ensuring generated shared libraries (`.so` files) are correctly copied to test boxes. This involves adding `--rpath=$ORIGIN` to linker flags in `fboss/agent/test/agent_hw_tests/BUCK` and `fboss/agent/test/prod_invariant_tests/BUCK` to ensure proper runtime loading of these shared libraries.

This commit **refactors** the build system by **decoupling** the **NVDA** (NVIDIA_SAI_SDK) component from the general `test_artifacts` package. It introduces a **dedicated `nvda` specific `test_artifact` package** to house all related test artifacts, improving modularity and build organization. The change involves modifying `fboss/agent/fbpkg/BUCK` to add a new build rule that specifically loads and calls `build_test_artifacts_fbpkg` for NVDA. This **maintenance** effort streamlines the management of test dependencies for the NVIDIA SAI SDK, preventing unnecessary linkages with other test artifact sets.

This commit **adds new documentation** detailing the **routing dataplane requirements** for the **protocol stack**. It introduces a new file, `fboss/agent/wiki/static_docs/docs/Features/routing-dataplane-requirement.mdx`, which comprehensively covers aspects such as **packet IO**, **unicast/MPLS route programming**, and **UCMP**. This **documentation update** enhances clarity and provides essential reference material for understanding the system's routing capabilities and implementation specifics.