Jason Hartman

This commit **fixes incremental TypeScript builds** within the **`build-tools` package** by ensuring that `allowJs` and `checkJs` options are correctly recognized in `tscUtils.ts`. Previously, these options were stripped from the configuration side, leading to a permanent mismatch with `.tsbuildinfo` and forcing full rebuilds. This **bug fix** significantly **improves build performance** by enabling proper incremental compilation for projects utilizing JavaScript. Additionally, it addresses two deficiencies by removing a doubly defined `useDefineForClassFields` and an incorrectly cased `skipdefaultlibcheck` from the incremental options list, further refining the build configuration.

This commit introduces a significant **refactoring** of the **build system** across several `@fluidframework` and `@fluid-private` packages, including `file-driver`, `debugger`, and `driver-definitions`. It **separates the compilation of test code from production library code** by creating dedicated `tsconfig.json` files for tests (`src/test/tsconfig.json` and `src/test/tsconfig.cjs.json`) and updating main `tsconfig.json` files to exclude test sources. This **build system enhancement** resolves persistent incremental build errors where `tsc` struggled with shared output files, ensuring a cleaner and more reliable build process. The change improves **developer experience** by providing distinct build targets for tests and production code, leading to more stable and efficient builds.

build(client): remove unused type test deps and settings (#26792)

This commit **upgrades the project's build system** to the **`build-tools` 0.64 release**, updating `pnpm` dependencies and adjusting `package.json` configurations. It modifies **`flub generate entrypoints`** calls to correctly use `require` for CommonJS and `import` for ESM, ensuring proper module resolution. Additionally, **type test generation** is refined to leverage selected package exports, improving accuracy, and a `legacy.d.ts` workaround is removed from the **`packages/dds/tree`** module. This comprehensive **maintenance update** enhances the build infrastructure, ensuring compatibility and leveraging new `build-tools` capabilities across the codebase.

build(build-tools): bump version to 0.65.0 (#26724)

This commit introduces a **fix** and **enhancement** to the **build-tools**' `generate entrypoints` command, primarily addressing issues with **module resolution** for `type: "module"` packages. It adds a new `resolutionConditions` argument, allowing users to explicitly specify `customConditions` for `ts-morph` to correctly infer "import" or "require" resolution, preventing silent failures when generating entrypoints for modern module types. Additionally, this change improves **error handling** by making `generate entrypoints` throw an error when an export lacks a source, while the `modify fluid-imports` command now issues a warning via the updated `getApiExports` utility, providing clearer feedback during the build process. This ensures more robust and accurate entrypoint generation across different module systems.

This commit provides **documentation updates** within the **`client-test-utils`** package, specifically clarifying the behavior of its exports. It details the **side-effects of runtime exports** in `packages/test/test-utils/src/index.ts` that import `timeoutUtils.ts`. The update explains their interaction with **Mocha's timeout handling**, providing crucial context for developers. This **maintenance work** improves the clarity and maintainability of the test utilities by distinguishing between runtime-affecting exports and non-contributing type exports.

This commit **restores the TypeScript version to 5.4.5** for the **`client-import-testing` build**, addressing an issue where aliased package installations were causing `tsc` and `tsserver` to default to an unexpected 5.9 version. It achieves this by **relocating TypeScript version management** to a new `typescript-versions-host` package. This **maintenance fix** ensures consistent dependency resolution within the testing infrastructure, preventing build inconsistencies and standardizing the TypeScript version used for import tests. The `syncpack.config.cjs` configuration was updated to reflect this package name change.

This commit **refactors** the **`@fluid-internal/test-utils` package** to enhance modularity and clarify dependencies. It **isolates event and error logging utilities** into a new `eventAndErrorLogger.ts` file, moving them away from `testObjectProvider.ts` to better manage modules with side-effects. Additionally, Mocha is now explicitly set as a `devDependency` for `test-utils`, and documentation is updated in `README.md` and `timeoutUtils.ts` to explain the package's conditional side-effect on Mocha's test timeout when loaded. This **refactoring** improves the package's structure, reduces unintended side-effects, and clarifies its dependency on Mocha.

This commit **updates the `.gitignore` configuration** to prevent temporary and personal files generated by **Claude** from being committed to the repository. It adds new ignore patterns for Claude's local settings, task tracking, and worktree directories, ensuring these are excluded even when Claude is invoked in narrow scopes. This is a **maintenance chore** that improves repository hygiene by keeping development artifacts out of version control. The change applies broadly to all subdirectories, preventing accidental inclusion of these files.

This commit **adds documentation** for a new **repository policy checking skill** within the **Claude AI tool**. It introduces the `SKILL.md` file in the `.claude/skills/policy-check/` directory, which outlines the skill's description and usage instructions. This **enhancement** provides users with the necessary information to leverage Claude's new capability, ensuring that work adheres to established project policies and preventing incorrect execution.

This commit performs a **maintenance chore** by updating the `.gitignore` file to **exclude local Claude configuration settings**. Specifically, it adds `.claude/settings.local.json` to prevent sensitive, user-specific configurations from being committed to the repository. This change is **preparatory work** for enabling **repository-common Claude configurations and skills**, ensuring that only non-sensitive, shareable configuration files are tracked by version control. It directly impacts **version control hygiene** for the **Claude tool integration** by preventing accidental exposure of personal settings.

This commit introduces **consumable type aliases** for the return types of **client-presence state factories** within the `@fluidframework/presence` package. It provides new `*Configuration` aliases (e.g., `LatestConfiguration`, `NotificationsConfiguration`) to enable consumers to define and split schema definitions more robustly, addressing limitations with `ReturnType<>` and discouraging direct use of internal types. Additionally, this work includes a **fix and refactoring** to enhance **type safety** by adding generic `Key` parameters to `StatesWorkspaceSchema` and `NotificationsWorkspaceSchema`, allowing for more narrowly defined `RegistrationKey` types. These generics are propagated through `getWorkspace` methods across the **presence management system**, significantly **improving developer experience** and flexibility for defining presence schemas.

This commit **refactors** the **API Extractor configuration system** by setting the base `api-extractor-base.json` to be inert by default, requiring all derived configurations to explicitly define their `mainEntryPointFilePath` and enabled actions. This **maintenance** change prevents unintended API Extractor operations when new configurations are introduced, affecting various packages like `common/lib/common-utils` and `server/routerlicious`. Consequently, several `api-extractor-lint.json` files were updated to explicitly define their entry points. Additionally, the **build pipeline** for benchmarks is improved to trigger builds upon changes in `common/build/build-common`, and the `.gitignore` file is updated for `tsdoc-metadata.json`.

This commit undertakes a significant **API surface cleanup and refactoring** within the **`core-interfaces`** and **`presence`** packages. Its primary goal is to **rename internal utility type namespaces**, such as `InternalUtilityTypes` to `InternalCoreInterfacesUtilityTypes` and `Internal*` to `InternalPresence*` within `presence`, to prevent naming collisions and ensure uniqueness across Fluid Framework APIs. This **API governance improvement** also includes adding new `api-extractor` linting for internal/exposed utility types, removing an unused configuration, and promoting several utility types to `@beta` status. These changes enhance API consistency and maintainability, with downstream impact on dependent packages like `container-runtime-definitions` that consume these renamed types.

This commit **reverts** previous changes that refactored **type definitions** within the **`protocol-definitions`** package, specifically undoing modifications related to an attempted upgrade to ESLint 9 flat config. It restores the original type definitions for `blobs` and `trees` in interfaces like `ISnapshotTree`, `ISummaryTree`, and `ISnapshotTreeEx`, which were previously changed from `Record` to explicit indexed types. As a **maintenance** action, this commit instead introduces **ESLint suppressions** in `storage.ts` and `summary.ts` to address the linting issues that prompted the original type refactoring. This ensures stability in the **protocol layer's data structures** by rolling back potentially impactful type changes and managing linting concerns through suppression.

This commit primarily **fixes** the `generate node10Entrypoints` and `generate typetests` commands within the **`build-tools`** package to correctly support **nested package exports** like `legacy/alpha`. Previously, these commands would fail to resolve such paths, leading to incorrect entrypoint generation and type validation. As a significant **enhancement**, `generate typetests` now dynamically determines the package's entrypoint instead of hardcoding `../../index.js` and inspects `tsconfig` for custom export `conditions` (e.g., "allow-ff-test-exports"), enabling more robust type validation for diverse package structures and internal protocols. This **refactoring** also centralizes entrypoint generation logic, removes the deprecated `--level` option, and updates generated file headers to include command-line arguments, improving the overall flexibility and maintainability of the build process.

build: clean up rogue --local arg to API linting (#26482)

This commit **reverts** a previous change that removed the 'api' dependency from the 'compile' target within the **build configuration**. It specifically modifies `fluidBuild.config.cjs` to re-include 'api' as a necessary dependency for the compilation process. This **build maintenance** action also adds a comment explaining why 'api' must be part of 'compile', clarifying its role in the build system. The revert addresses issues or incorrect assumptions from a prior streamlining attempt, ensuring proper build dependency management and preventing potential build failures.

build: cleanup ci:build definitions (#26480)