Joseph Wu

This commit performs a significant **refactoring** of the **FBOSS CLI** by moving the implementations of seven `clear/` commands from their header files to dedicated `.cpp` source files. Specifically, methods like `queryClient()` and `printOutput()` for commands such as `CmdClearArp`, `CmdClearNdp`, and `CmdClearInterfaceCounters` are now in separate implementation files, improving **code organization**. This change enhances **build efficiency** by reducing header-only code and aligns the `clear/` command structure with established project patterns. Additionally, `CmdClearUtils.h` is made self-contained by adding a missing include for `CmdUtils.h`, ensuring proper dependency management.

This commit performs a significant **refactoring** within the `fboss/cli/fboss2` subsystem by decentralizing explicit template instantiations for command handler methods. Specifically, it moves `run()`, `getValidFilters()`, and `getValidAggs()` instantiations from the monolithic `fboss/cli/fboss2/CmdHandlerImpl.cpp` to their respective individual command implementation files. This change affects **51 existing OSS command `.cpp` files**, such as `CmdShowAcl.cpp` and `CmdShowInterface.cpp`, drastically reducing the size and complexity of `CmdHandlerImpl.cpp`. The primary goal is to improve **code organization and build efficiency** by distributing these instantiations, aligning with a new architectural pattern for the CLI. This is the first phase of a larger **refactoring effort**, with header-only commands to be addressed in subsequent changes.

This commit **open-sources the `delete config` CLI command**, making it available by introducing its definition and registering it within the **`config` command tree**. Concurrently, it **enhances the CLI's command tree merging logic** by modifying `CmdSubcommands::addCommandBranch()` to allow subcommands from different trees to be merged under a common parent, rather than throwing an error. This **new capability** and **infrastructure improvement** provides greater flexibility in defining CLI command structures. Specifically, it enables commands like `delete config` to exist in both internal and open-source contexts with their respective subcommands combined, while still rejecting exact duplicate leaf commands.

This commit introduces the **`help` special command** to **OSS CLI binaries** for `fboss2` and `fboss2 config`, significantly **enhancing user experience** by providing integrated command-line assistance. Concurrently, it performs a **refactoring** of the `CmdHelp` module, eliminating unnecessary vector copies in functions like `revHelpTree` and `printSubCommandTree` by utilizing `const` references, which **improves performance** and code efficiency. Additionally, the `helpArgTypeHandler()` is moved and inlined into `CmdHelp.h` to **reduce code duplication** across various `CmdListImpl.cpp` files, streamlining the codebase. This work ensures the **OSS CLI** offers a more robust and efficient command-line interface.

This commit performs a significant **refactoring** of the **CLI command tree definition** to eliminate One Definition Rule (ODR) violations that arose from multiple definitions of `kAdditionalCommandTree()` and `kSpecialCommands()`. It introduces a two-layered approach where `kBaseAdditionalCommandTree()` defines shared base commands once, and each binary's dedicated `CmdListImpl.cpp` then defines its specific `kAdditionalCommandTree()` and `kSpecialCommands()`, either returning the base tree or merging it with config commands. This change primarily affects the **`fboss2` and `fboss2-dev` executables** and their associated **build system configurations (Buck and CMake)**. The **refactoring** ensures correct and consistent **CLI command registration** across different `fboss2` binaries, improving **code correctness and maintainability**.

This commit **refactors the build system configuration** to resolve an ambiguity in SAI source file inclusion for NPU and PHY builds. Previously, NPU-specific files like `SaiAclTableManager.cpp`, `SaiPortManager.cpp`, and `SaiSwitch.cpp` were part of a common `SAI_SWITCH_SRC` variable, which was also used by PHY builds, leading to potential conflicts. The change **moves these NPU implementation files out of the common source list** and into a conditional inclusion block within `cmake/AgentHwSaiSwitch.cmake`. This **build system fix** ensures that only the correct NPU-specific SAI implementation files are used for NPU builds, preventing runtime issues and guaranteeing proper module selection for different hardware targets.

This commit **refactors** the **fboss2 CLI application's initialization logic** by introducing a new `CmdInitUtils` library. It **consolidates** the previously inlined CLI setup from `Main.cpp` and scattered `postAppInit()` implementations into dedicated `CmdInitUtils.h` and `CmdInitUtils.cpp` files. This **enhancement** enables `Main.cpp` and future **integration tests** to share a common, consistent initialization path, improving **code reuse** and **maintainability**. The new library also addresses a **circular dependency** by deferring `kCommandTree()` symbol resolution, allowing different binaries to provide their own command trees.

This commit **fixes a Clang build error** in the **SAI PHY Manager** by explicitly deleting the move constructor and move assignment operator for the `PlatformInfo` class. Previously, these operations were implicitly deleted by the compiler due to non-movable members like `std::mutex` and `folly::Synchronized`, leading to `-Wdefaulted-function-deleted` errors with Clang. By marking them as `= delete` and moving them to the private section in `fboss/lib/phy/SaiPhyManager.h`, the code now compiles correctly without affecting runtime behavior, as `PlatformInfo` instances are managed via `std::unique_ptr`. This **maintenance** change ensures **compatibility with Clang builds** that enforce `-Werror`.

This commit **open-sources** the `AgentTunnelMgrTests.cpp` by integrating it into the project's **CMake build system**. As a **maintenance** task, it defines a new **`tunnel_mgr_test_utils` CMake library** within `cmake/AgentTestUtils.cmake` to house specific test utilities. The `AgentTunnelMgrTests.cpp` file is then added to the `agent_hw_test_src` library in `cmake/AgentTestAgentHwTests.cmake`, linking against this newly created utility library. This ensures that the **Agent Tunnel Manager tests** are properly built and available in open-source environments, enhancing the overall **test infrastructure** and **build configuration** for agent hardware tests.

Fix FBOSS OSS on-diff job fetching configerator/structs/neteng/fboss/thrift/common.thrift

Fix FBOSS OSS on-diff job fetching configerator/structs/neteng/fboss/thrift/common.thrift

Fix FBOSS OSS on-diff job fetching configerator/structs/neteng/fboss/thrift/common.thrift

This commit **fixes a build failure** for the `qsfp_hal_test` target within the **QSFP Service** by addressing missing Google Test symbols. The `qsfp_hal_test` target, which uses a custom `main()` function directly interacting with `testing::UnitTest`, was previously only linking `${GTEST}`. This **build system bug fix** adds `LIBGMOCK_LIBRARIES` to the target's linked libraries in `cmake/QsfpServiceTestHalTest.cmake`, resolving the undefined symbol errors. This ensures the **QSFP Service's hardware abstraction layer tests** can be successfully built and executed, particularly in **OSS environments**.

This commit **open-sources** the `configerator/structs/neteng/fboss/thrift/common.thrift` file, making its definitions publicly available. This **dependency management** step is crucial for external projects, specifically enabling the **FBOSS FSDB** to utilize these common thrift structures. The scope of this change is limited to only `common.thrift`, ensuring that other related thrift files within the same directory remain internal for now. This action facilitates broader integration and use of essential **FBOSS** data structures in open-source contexts.

Only opensource configerator/structs/neteng/fboss/thrift/common.thrift

This commit **open-sources** the `configerator/structs/neteng/fboss/thrift/common.thrift` file, making its definitions publicly available. This **dependency management** step is crucial for external projects, specifically enabling the **FBOSS FSDB** to utilize these common thrift structures. The scope of this change is limited to only `common.thrift`, ensuring that other related thrift files within the same directory remain internal for now. This action facilitates broader integration and use of essential **FBOSS** data structures in open-source contexts.

This commit **open-sources** the `fboss2 show config running agent` and `fboss2 show config history agent` commands, making crucial **agent configuration inspection capabilities** available to the public. It involves **refactoring** by moving the implementation of these commands, along with shared utilities and traits, from internal Facebook-specific paths to the open-source `fboss/cli/fboss2/commands/show/config/` directory. The **`fboss2` CLI**'s build system (BUCK and CMake) and command registration (`fboss/cli/fboss2/oss/CmdList.cpp`) are updated to incorporate these new components. This **maintenance** effort significantly enhances the diagnostic tools available to the open-source community, allowing users to query and print the agent's current and historical configurations.

This commit **refactors** the project's test infrastructure by **unifying** the Google Test `main` function implementation into a single shared source. It introduces `fboss/util/oss/TestMain.cpp` to consolidate the previously duplicated `main` functions used by various unit tests, such as those in `fboss/agent/test/oss/Main.cpp` and `fboss/cli/fboss2/test/TestMain.cpp`. This change primarily affects the **build system (CMake)**, updating configurations for numerous **FBOSS unit test executables** across modules like `fboss/agent`, `fboss/cli/fboss2`, `qsfp_service`, and `fsdb`. The **maintenance** effort aims to improve **code consistency** and **maintainability** of the project's testing framework by centralizing the test entry point.

This commit **refactors the Python formatting and linting infrastructure** for the **`fboss/` directory**, transitioning from Black to Ruff. It introduces a **universal `ruff.toml` configuration file** that aligns with Meta's internal standards, ensuring consistent code style across all `fboss` Python files. This **maintenance and tooling update** resolves previous formatting inconsistencies reported by internal signals, by configuring `ruff-check` to apply to all Python files within `fboss/` via `.pre-commit-config.yaml`. The change ensures that all Python code in `fboss/` adheres to a unified and enforced style.

This commit **enables the `-Werror=unused-function` compiler flag** across all **FBOSS code** within the internal Buck build system. This **build system improvement** ensures parity with external OSS builds, promoting stricter code hygiene by turning unused function warnings into compilation errors. As a direct consequence, the `unbindTamObjectFromSwitchAndPort` function in `fboss/agent/hw/sai/switch/npu/bcm/SaiTamManager.cpp` was refactored for conditional compilation to avoid new errors. This change requires developers to explicitly mark intentionally unused functions with `[[maybe_unused]]` or remove them, leading to cleaner and more maintainable code.