Joe Vilches

This commit **fixes a bug** preventing declarative `blur()` calls on component refs from functioning correctly within **React Native's Fabric renderer**. Previously, **View components** were not properly becoming the first responder when focused, which caused `resignFirstResponder` to fail and subsequently prevented `onBlur()` events from being generated. The fix involves adjusting the `didUpdateFocusInContext` method in `packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm` to ensure `becomeFirstResponder` is called when a view gains focus and `resignFirstResponder` when it loses focus. This change restores the expected behavior for **declarative blur functionality** across **React Native views**.

This commit performs **maintenance** by **removing outdated and unnecessary comments** from the `ReactScrollView` component within the **React Native Android scrolling implementation**. Specifically, it targets the `fling` and `onOverScrolled` methods in `packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java`. This **refactoring** improves code readability and maintainability by eliminating legacy, irrelevant comments, without introducing any functional changes or affecting downstream behavior.

This commit **refactors** the **`ScrollViewShadowNode`** component within the **React Native renderer's `scrollview` module**. Specifically, it updates the `getContentOriginOffset` function to use **designated initializer lists** for `Vector` and `Point` object initialization. This is a **code style improvement** and **maintenance** task, driven by linting suggestions, enhancing code readability and adherence to modern C++ practices. The change is internal to the `ScrollViewShadowNode.cpp` file and does not alter the component's runtime behavior or introduce any functional changes.

This commit **promotes the `enableAccessibilityOrder` feature flag to the experimental release channel** within **React Native**. It updates the **feature flag configuration** in `ReactNativeFeatureFlags.config.js` to mark this accessibility-related feature as experimental for Open Source Software (OSS) builds. Consequently, overrides are added in `ReactNativeFeatureFlagsOverrides_RNOSS_Experimental_Android.kt` and `ReactNativeFeatureFlagsOverridesOSSExperimental.h` to ensure the `enableAccessibilityOrder` flag is active for **experimental Android and C++ builds**, respectively. This **release management** change allows experimental users to test and provide feedback on the new accessibility ordering behavior, impacting the **accessibility subsystem** for those builds.

This commit **refactors** the **Android native module integration** by **decoupling** `ReactAndroidHWInputDeviceHelper` from `ReactRootView`. Previously, `ReactAndroidHWInputDeviceHelper` had a direct dependency on `ReactRootView`, but now it directly accepts `ReactContext` as a parameter for event dispatching. This **architectural improvement** enhances modularity and reduces tight coupling within the **input device handling** subsystem. Specifically, `ReactAndroidHWInputDeviceHelper.kt` is updated to use `ReactContext` directly, and `ReactRootView.java` is modified to pass the context to the helper's methods, improving the maintainability of the **Android native components**.

This commit **refactors the accessibility element management** within the **React Native Fabric architecture** for iOS `View` components. It addresses potential **hard-to-find iOS crashes** by switching to the standard setter for the `accessibilityElements` property in `RCTViewComponentView.mm`, rather than a custom implementation. This **bug fix and stability improvement** removes the custom `RCTViewAccessibilityElement` and ensures proper handling of accessibility elements. The change is expected to **reduce crashes** and enhance the overall robustness of the accessibility system on iOS.

This commit **reverts a previous implementation strategy** for `accessibilityOrder` that relied on building the accessibility tree through `addChildrenForAccessibility`. It **re-introduces the `experimental_accessibilityOrder` prop** for **ScrollView** and **TextInput** components, making it available again in the JavaScript layer. Concurrently, it **removes specific API definitions** like `setAccessibilityOrder` and `ReactAxOrderHelper` from the **React Native Android API**. However, this **re-architecture** also **adds or re-establishes prop handling** for `ACCESSIBILITY_ORDER` within the **Android native UI management system** (`BaseViewManager`, `BaseViewManagerDelegate`), including a new resource ID for tracking dirty state. This ensures the feature's continued functionality while addressing issues with the problematic prior implementation.

This commit **refactors** the **`ReactScrollView`** component within **`ReactAndroid`** by changing the access modifier of the `getOverScrollerFromParent` method from `private` to `protected`. This modification enhances the **extensibility** of `ReactScrollView`, allowing subclasses to directly access the underlying `Scroller` instance. The change enables developers to implement custom scrolling logic or interact with the scroller without resorting to reflection or duplicating existing code, thereby improving **subclassing capabilities** for Android scroll views. The **API definition** for `ReactAndroid` is also updated to reflect this change.

This commit delivers a **bug fix** addressing an issue where **keyboard navigation** failed in **React Native scroll views** on **Android** when `snapToAlignment` was set. The problem stemmed from the `FormsStackingContext` check in `FabricUIManagerBinding.cpp` preventing the discovery of focus candidates. The fix involves removing this check within the `getRelativeAncestorList` function, ensuring the entire ancestor list is returned to the native system. This change in the **Fabric UIManager binding** allows the native platform to correctly identify focusable elements, thereby restoring reliable **keyboard navigation** for users interacting with scrollable content that utilizes `snapToAlignment`.

This commit provides a **bug fix** for the **accessibility order example**, correcting issues introduced in a previous change. It addresses instances where incorrect text content was used or inappropriate props were applied within the example code. This ensures the example accurately demonstrates proper accessibility ordering, improving the clarity and correctness of the **documentation and sample code** for developers implementing accessibility features.

This commit **enhances** the **accessibility order example** within the **RNTester** application by **revamping** its content. The update introduces a more comprehensive set of **edge cases** to better demonstrate and test various accessibility ordering scenarios. This **maintenance** work improves the internal tooling for React Native developers, providing a robust example for validating and understanding accessibility behavior.

This commit introduces an **accessibility enhancement** to the **React Native Fabric rendering system** on iOS. It modifies the `RCTRecursiveAccessibilityLabel` function within `RCTViewComponentView.mm` to **comma-separate co-opted accessibility labels**. This change ensures that screen readers, particularly **VoiceOver**, pause appropriately between semantically distinct labels, providing a more natural and less jarring auditory experience for users. This aligns the iOS accessibility behavior with the default implementation on Android, significantly improving the **user experience for visually impaired users**.

This commit implements a **performance optimization** by introducing a caching mechanism for `accessibilityElements` within the **React Native Fabric rendering system**. Specifically, it modifies the `packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm` file to cache the result of `accessibilityElements` calls, which were previously causing performance stalls due to frequent re-computation. The `accessibilityElements` getter, `updateProps`, and `resetView` methods are updated to manage this new cache, ensuring that accessibility information is retrieved efficiently. This change directly addresses reported performance issues and improves the responsiveness of **accessibility features** for users.

This commit **refactors** the **Android text rendering subsystem** by updating `PreparedLayoutTextView` to directly use a `PreparedLayout` object instead of a raw `Layout`. This change involves modifying internal logic within `PreparedLayoutTextView.kt`, adjusting `updateExtraData` in `PreparedLayoutTextViewManager.kt`, and updating accessibility functions in `ReactTextViewAccessibilityDelegate.kt` to correctly interact with the new `preparedLayout` property. The primary purpose of this **enhancement** is to **support `textVerticalAlign`**, as the `PreparedLayout` object stores the necessary vertical offset information. This allows for more precise text positioning and rendering within React Native Android applications, ensuring that vertical alignment properties are correctly applied and interpreted.

This commit introduces a significant **refactoring** within React Native's **rendering engine**, specifically relocating the `textAlignVertical` property from `TextAttributes` to `ParagraphAttributes`. This change corrects the semantic representation of the property, as it inherently applies to entire paragraphs rather than individual text segments, improving the accuracy of text layout. The work involved updating the definitions, equality operators, and hashing functions for both `TextAttributes` and `ParagraphAttributes`, alongside modifying prop conversion logic and how `ParagraphProps` and `TextInputProps` process this style. This is a **breaking change** for Android, ensuring `textAlignVertical` is correctly managed at the paragraph level for enhanced consistency in text rendering.

This commit **implements the `textVerticalAlign` property** for React Native's Android platform, introducing a new mechanism to control vertical text alignment within text components. It involves **refactoring** the `FabricUIManager` to utilize an updated `TextLayoutManager` for layout preparation, which now calculates and applies a `verticalOffset` to text content. This **new capability** enhances the **Android text rendering pipeline** by allowing precise vertical positioning of text and addressing existing issues with inline Views. The change specifically impacts the `TextLayoutManager`, `PreparedLayout` data structures, and `PreparedLayoutTextView`'s `onDraw` method to correctly apply the vertical offset. This work lays the groundwork for future distinct `verticalAlign` behavior while ensuring current `textVerticalAlign` functionality is robust.

This commit **fixes the focusability logic** for `PreparedLayoutTextView`s within **React Native Android**, specifically addressing issues with links and screen readers. It **removes the problematic link detection** that could cause TalkBack to individually focus linked text within accessible views, leading to a poor user experience. To ensure proper accessibility, the `onInitializeAccessibilityNodeInfo` method in `ReactTextViewAccessibilityDelegate.kt` is now overridden to **explicitly set the text content** for `AccessibilityNodeInfo`, allowing TalkBack to correctly announce the view's content. This **accessibility improvement** prevents unwanted auto-focusing on links when a screen reader is active, enhancing the user experience for visually impaired users.

This commit **fixes a crash** occurring in **React Native's Android text accessibility** component. The issue stemmed from an incorrect character bounding box calculation within `ReactTextViewAccessibilityDelegate.kt`, specifically in the `getCharacterBoundingBox` function, which would fail when a link's `endOffset` extended beyond the line's `endOffset`. This **bug fix** prevents application instability and improves the robustness of text rendering and accessibility features for users interacting with links on the Android platform.

This commit **reverts** a previous change, effectively **re-introducing** the `useEditTextStockAndroidFocusBehavior` feature flag and all its associated implementation details across the **React Native Android platform**. This **maintenance** work restores the full **feature flag system** for this specific behavior, including its definitions in Kotlin, C++, JNI bindings, JavaScript configuration, and the `requestFocus` method within the `ReactEditText` component. The primary goal is to ensure **backward compatibility** for older versions, such as 0.80, allowing users to continue enabling or disabling the stock Android focus behavior for `EditText` components and preventing potential regressions. This provides crucial **configuration flexibility** for text input focus management on Android.

This commit **reverts** a previous change that aimed to **fix text input blurring** on **Android versions 8.1 and older**. Specifically, it undoes the override of the `requestFocus` method within `packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.kt`. This **maintenance** action is performed to allow a different, more comprehensive fix to be integrated into **React Native 0.80**, preventing a critical regression for older Android devices in that upcoming release. While temporarily reintroducing the original blurring issue, this step ensures a path to a stable solution across all Android versions for the `TextInput` component.