ilkos

This commit **introduces new fields** to the `HeapGraphObject` protobuf message within the **Perfetto tracing system**. Specifically, it adds capabilities to capture **Bitmap-specific tracing information** during heap dumps by modifying `perfetto_trace.proto` and `heap_graph.proto`. This **new capability** enhances the detail available in heap profiles, enabling more granular analysis of memory usage related to Bitmaps. The change improves the ability to debug and optimize memory-intensive applications by providing richer data in trace outputs.

This commit delivers a **bug fix** to the **`trace_processor`**'s **`perfetto_sql` stdlib** to ensure accurate Android package resolution. It introduces a new SQL function, `_app_id_to_base_package`, within `src/trace_processor/perfetto_sql/stdlib/android/process_metadata.sql` that correctly maps Android app IDs to their base package IDs. This specifically accounts for and resolves issues related to processes running within **SDK sandbox** and **PCC UID ranges**. The change improves the reliability of **Android process metadata** by providing a robust mechanism for identifying the true originating package for processes in these specialized environments.

This commit significantly **enhances the Heap Profile UI** by rendering continuous heap profile snapshots as **distinct time slices with duration**, rather than single, long events. This **feature improvement** allows for better visual correlation of allocations with other trace events and introduces **area selection** for multi-selecting these slices on the timeline. It also **fixes a bug** related to state management that caused crashes when reusing flame graph configurations across different profile types, and refines the allocation data by excluding negative values. The changes primarily affect the **`dev.perfetto.HeapProfile` plugin**, specifically its **track rendering**, **details panel logic**, and **internal state management**. This provides a more accurate and interactive way to analyze heap allocations over time.

This commit **refactors** the **HeapProfile plugin** in the UI to **separate different memory profile types into distinct tracks**, addressing the previous issue of multiplexed and confusing visualizations. It introduces new `ProfileType` and `ProfileDescriptor` definitions in `common.ts` to categorize profiles, which are then used to create individual tracks and generate corresponding SQL views in `index.ts`. The `heap_profile_details_panel.ts` and `heap_profile_track.ts` are updated to leverage these new types for displaying and identifying profiles. This **enhances the clarity and usability** of memory profiling by allowing users to easily distinguish and analyze native, ART, and Java heap profiles independently.

This commit introduces a **new capability** within the **Trace Processor's `stdlib`** by adding `symbolization_candidates.sql`, which defines a `_to_breakpad_module` function and `_stacks_symbolization_candidates` table. This new **`stacks.symbolization_candidates` module** is designed to identify unsymbolized frames and associate them with their respective processes, crucial for accurate symbolization. The existing **`unsymbolized_frames` metric** is **refactored** to utilize this new module, streamlining the calculation of `google_lookup_id`. This change **enhances the Trace Processor's ability** to prepare profiling data for symbolization, moving core logic into the standard library for improved reusability and maintainability, and is validated with new diff tests for heap and perf profiling scenarios.

This commit significantly **enhances Android memory analysis** within the **Perfetto Trace Processor** by introducing new SQL stdlib modules and updating existing metrics. It adds a new `heap_graph_stats` module to aggregate Java heap graph and process memory statistics, including **dmabuf RSS**, and a `dmabuf_spans` module for tracking dmabuf usage. The existing `java_heap_stats.sql` metric is **refactored** to leverage these new capabilities, providing more comprehensive and accurate Java heap statistics. This work also involves updating the `JavaHeapStats` proto definition to remove `HeapRoots` and incorporate the new `dmabuf_rss_size` field, ensuring that **Perfetto's Android memory metrics** are more robust and detailed.

This commit performs a **refactoring and cleanup** of the **Perfetto metrics protobuf definitions**. It **removes the `AndroidTaskNames` message definition** and **deprecates the `android_task_names` field** within `protos/perfetto/metrics/metrics.proto` and `protos/perfetto/metrics/perfetto_merged_metrics.proto`. This change addresses an obsolete mechanism, as the `android_task_names` field is no longer used, with process metadata now providing a superior alternative for tracking task information. The work **streamlines the metrics protobufs** by eliminating unused definitions, improving the clarity and maintainability of the schema.

This commit introduces a **new documentation page** specifically for diagnosing **Android OutOfMemoryError (OOME)**, providing users with a straightforward, dependency-free method to obtain heap dumps. This **maintenance** effort enhances the project's support capabilities by offering a dedicated guide within the `docs/case-studies` section. The existing `docs/case-studies/memory.md` is updated to cross-reference this new resource, and the `docs/toc.md` is adjusted to reflect its inclusion. This improvement empowers users to more easily self-diagnose OOME issues and gather crucial information for troubleshooting.

This commit introduces **new filtering capabilities for flame graphs** within the **Perfetto UI**, allowing users to filter by unaggregated properties like root type or heap type. This **new capability** is implemented by modifying filter generation and pivot logic in `ui/src/components/query_flamegraph.ts`, affecting functions like `computeFlamegraphTree` and `getPivotFilter`. Concurrently, a **refactoring** in `src/trace_processor/perfetto_sql/stdlib/android/memory/heap_graph/helpers.sql` standardizes `heap_type` values to `HEAP_TYPE_NATIVE` to ensure data consistency for the new filters. This enhancement significantly improves the analytical precision for **Android memory heap dumps**, enabling more granular investigations, such as filtering by `HEAP_TYPE_APP` to exclude boot/zygote classes.

This commit **introduces a new `android.memory.lmk` standard library module** within Perfetto SQL, providing a **new feature** for more robust handling of Android Low Memory Killer (LMK) events. The module includes functions to parse and categorize LMK data from various trace event sources, supporting newer instant events and paving the way to deprecate older trace processor handling. Existing **Android LMK metrics** like `android_lmk` and `android_lmk_reason` are **refactored** to utilize this new module, consolidating LMK event processing logic. This enhancement improves the accuracy and flexibility of LMK analysis, with new diff tests ensuring its correctness across different LMK event types.

This commit **fixes a bug** in the **Perfetto Trace Processor's SQL standard library** related to `dmabuf` slice tracking. It **corrects the SQL query** within `src/trace_processor/perfetto_sql/stdlib/android/memory/dmabuf.sql` by adjusting join conditions and aliases. Previously, the query incorrectly linked `dmabuf` slices to thread IDs due to an erroneous join between slice and track IDs. This ensures that `dmabuf` slices are now properly attributed to their respective threads, significantly improving the accuracy of **Android memory analysis** in Perfetto.

This commit **fixes a bug** in the **Perfetto trace processor's Android startup analysis** by ensuring that only fully completed startup slices are considered. Previously, ftrace buffer data loss could result in incomplete slices being incorrectly identified as finished, leading to skewed performance metrics. The change **modifies the SQL query** in `src/trace_processor/perfetto_sql/stdlib/android/startup/startups_minsdk33.sql` to filter for slices with `dur > 0` instead of `dur != 0`. This effectively **discards unfinished startup slices**, significantly improving the **accuracy of Android startup performance measurements** derived from Perfetto traces.

This commit **fixes** an issue within the **Perfetto UI's heap profiling configuration** by updating the shared memory buffer (SMB) selector values. It specifically revises the list of available SMB sizes and adjusts the default value presented to users for **heap profiling**. This **bug fix** ensures that users can correctly configure the shared memory buffer for `heapprofd` traces, improving the reliability and accuracy of profiling sessions. The changes are localized to the `ui/src/plugins/dev.perfetto.RecordTraceV2/pages/memory.ts` file, directly impacting the user experience when setting up memory traces.

This commit introduces `android_user_id` as a **first-class field** within **Perfetto's Android process metadata**, enhancing the granularity of process tracking. It involves a **schema evolution** by adding the `android_user_id` field to `AndroidProcessMetadata` protobufs and updating the internal `PROCESS_TABLE` definition. The **trace processor** is updated to populate this new field from the `uid` during data ingestion, making it accessible via the `process` SQL view and integrated into various **Android-specific metrics**. This **new capability** provides more precise context for process analysis, particularly in multi-user Android environments, by explicitly identifying the user associated with each process. Numerous `diff_tests` were updated to reflect the inclusion of this new field in metric outputs.

Merge "Add heap type to java flamegraphs" into main am: b7e350c659

This commit introduces a **new capability** by adding `heap_type` to **Java flamegraphs**, significantly enriching the data available for memory analysis. It updates the **heap graph calculations** within `src/trace_processor/perfetto_sql/stdlib/android/memory/heap_graph/helpers.sql` to include this new type. Concurrently, it provides a **bug fix** in the `ui/src/plugins/dev.perfetto.HeapProfile/heap_profile_details_panel.ts` file, correcting a typo in the `flamegraphMetrics` query that previously selected the incorrect table, changing from `_heap_graph_class_tree` to `_heap_graph_dominator_class_tree`. This ensures accurate data retrieval and display for **heap profile details** in the UI.

Merge "Ingest heap type in trace processor" into main am: 94761f1433

Merge "Ingest heap type in trace processor" into main

This commit introduces the **ingestion and storage of heap type information** for heap graph objects within the **trace processor's profiling subsystem**. It modifies `ParseHeapGraph` in `heap_graph_module.cc` to read this new data from protos and updates the `heap_graph_tracker` to store it in `Object` structs and `SequenceState`. A new `heap_type` column is added to the `HEAP_GRAPH_OBJECT_TABLE` schema, enabling persistence and querying of this attribute. This **new capability** provides richer context for memory analysis, allowing users to understand the specific type of heap an object resides on. Test cases are updated to reflect and verify the correct handling of this new data.