Simon Knott

This commit introduces a **bug fix** to the **HTML Reporter** to prevent the display of empty project labels. Specifically, the `ProjectAndTagLabelsView` component in `packages/html-reporter/src/labels.tsx` is modified to conditionally render the `ProjectLink` only when actual project names are available. This change improves the visual presentation and user experience of the **HTML Reporter** by ensuring that project labels are only shown when they contain meaningful information. An accompanying test in `tests/playwright-test/reporter-html.spec.ts` was updated to validate this new rendering logic.

This commit provides a **bug fix** for **light mode styles** within the **dashboard**, specifically addressing visual inconsistencies. It **corrects visual rendering** by reordering a CSS rule for **active tabs** and adding the `forwards` keyword to the `interactive track radial animation` in `packages/dashboard/src/dashboard.css`. This ensures that the **Dashboard UI** elements display correctly and animations behave as expected when the light theme is active, improving the overall user experience and visual consistency.

This commit **updates the documentation** for the **trace snapshot command** within `packages/playwright-core`. Specifically, it modifies the examples in `SKILL.md` to demonstrate redirecting output to a file using the new `--filename` flag. This **documentation update** ensures users are shown the correct and intended method for saving trace snapshots, replacing older examples that used shell redirection. The change improves the accuracy of the **trace tool's usage instructions**, reflecting the recent implementation of the dedicated output flag.

This commit **fixes** a bug in the **Playwright Trace Viewer** where the `traceRequest` command failed to display complete request and response bodies, especially when these bodies were stored as separate resources. It enhances the **trace request inspection functionality** within `playwright-core` by modifying `traceRequests.ts` to correctly retrieve and show this content. This **bug fix** significantly improves the diagnostic capabilities for users debugging network interactions, ensuring a more complete view of network traffic. New test cases in `tests/mcp/trace-cli.spec.ts` and `tests/mcp/trace-cli-fixtures.ts` were added to verify that the CLI command now correctly displays body content from associated resources.

This commit provides a **bug fix** for the **Playwright ESM loader**, preventing it from prematurely bailing out when encountering **preflight requests** for ESM modules. Specifically, the `load` function in `esmLoader.ts` is refined to correctly distinguish preflight URLs from original module URLs, ensuring proper module resolution. Additionally, `transform.ts` now includes **improved error handling** for preflight ESM imports, logging failures via `debugTest` for better diagnostics. New test cases in `loader.spec.ts` validate the robustness of the ESM loader's interaction with custom Node.js ESM loaders, ensuring reliable module loading within Playwright.

This commit significantly enhances the **DevTools application**, particularly its integration with the `cli show` command, and introduces **extensive new test coverage**. It includes **UI fixes** in `devtools.tsx` and `grid.tsx` to correctly disable elements based on connection status, and a **refactoring** in `index.tsx` to use `useLayoutEffect` for `popstate` event handling. A **new capability** is added to `openDevToolsApp` in `devtoolsApp.ts`, allowing it to return only a URL for testing without launching a browser page. This work is complemented by **extensive new tests** in `cli-show.spec.ts` that validate various UI interactions and functionalities of the DevTools application. These changes improve the stability, accessibility, and testability of the **DevTools UI** and its **CLI integration**.

This commit **enhances the Playwright CLI's `kill-all` command** to ensure comprehensive process termination. It **updates the `killAllDaemons` function** in `packages/playwright/src/cli/client/program.ts` to correctly identify and terminate `devtoolsApp.js` processes on both Windows and Unix-like systems. This **maintenance improvement** prevents orphaned **devtools** processes, leading to a cleaner and more reliable development environment for Playwright users. A new test case in `tests/mcp/cli-show.spec.ts` has been added to verify the successful closure of these devtools processes.

This commit **fixes** a diagnostic issue within the **Playwright core library** by introducing a **proper error message** when the `test_debug` functionality is invoked without a required default Playwright context or page fixture. Specifically, the `_setupContextOptions` function in `packages/playwright/src/index.ts` is updated to explicitly inform users of this dependency. A new test case has been added to `tests/mcp/test-debug.spec.ts` to ensure this improved error handling is correctly validated. This **enhances the developer experience** by providing clearer guidance and preventing silent failures or ambiguous errors during debugging sessions.

This commit **enhances Playwright's tracing capabilities** by ensuring that source files associated with `tracing.group()` calls, when a `location` is specified, are collected and included within the trace archive. It **modifies the tracing client** (`tracing.ts`) to gather these additional sources, updates the **protocol definition** (`protocol.yml`, `validator.ts`), and adjusts the **server-side trace zipping utility** (`localUtils.ts`) to handle their inclusion. This **new capability** significantly improves debugging by allowing developers to view the relevant source code directly in the trace viewer, providing richer context for trace events. A new test case (`trace-viewer.spec.ts`) has been added to verify this behavior.

This commit **enhances the Playwright CLI's `show` command** by implementing a mechanism to **block execution until the DevTools application is fully open and ready**. This **new capability** involves a significant refactor of the **DevTools daemon** (`devtoolsApp.ts`) to communicate its operational status and URL back to the client, which the `program.ts` then uses to ensure readiness. The change provides a more robust and predictable user experience, preventing race conditions or premature interactions with the DevTools. Comprehensive **new tests** were added to validate this improved daemon behavior and its singleton process management.

This **refactoring** of **GitHub Actions workflows** addresses an issue where `job.status` was not reliably available outside of composite actions, leading to incorrect triggering of test report uploads. Specifically, the conditions for uploading **blob reports** in `run-test/action.yml` and `tests_primary.yml` are now more precise, activating only on pull requests or job failures. Concurrently, the `upload-blob-report/action.yml` itself has been simplified to always execute unless cancelled, ensuring the artifact is captured when the report generation is triggered. A minor **maintenance improvement** also updates the GitHub status context in `create_test_report.yml` to include the workflow run name for better clarity. These changes enhance the **reliability and accuracy of CI/CD test reporting**.

This commit **enhances the reliability and stability of the CI/CD pipelines** by addressing several issues within the **GitHub Actions workflows**. It **fixes a bug** in the `download-artifact` action (`.github/actions/download-artifact/action.yml`) by adding a conditional check to prevent `unzip` errors when no zip artifacts are present. Additionally, it **refactors the blob report upload steps** in both the `run-test` action (`.github/actions/run-test/action.yml`) and the `tests_primary.yml` workflow (`.github/workflows/tests_primary.yml`) to include cancellation checks. This ensures blob reports are not skipped and only uploaded for successfully completed jobs, preventing unnecessary resource usage and leading to **more robust and efficient build processes**.

This commit delivers a comprehensive **UI overhaul** for the **DevTools**, introducing an **interactive mode** and extensive **styling updates** across the interface. Key changes include replacing manual inspector resizing with a `SplitView` component, integrating new icon components, and refining input handling within the main `DevTools` component. Furthermore, a new `hideToolbar` option is implemented in the **recorder** within `packages/injected` and `packages/playwright-core`, enabling conditional toolbar visibility for specific workflows like **locator picking**. This work significantly enhances the user experience, visual consistency, and interactivity of the DevTools.

This commit implements a **devops enhancement** to the **CI/CD pipeline**, ensuring that **merge reports** are consistently published for all commits. The `create_test_report.yml` workflow is now triggered on every push event, outputting the report URL and publishing it directly as a commit status. Crucially, the `upload-blob-report` action has been updated to expand its conditions, guaranteeing that these reports are uploaded even in the event of job failures, thereby significantly improving visibility into build outcomes and aiding in debugging.

This commit introduces **support for faking `AbortSignal.timeout`** within Playwright's clock mechanism, enabling more comprehensive and deterministic testing of web applications. It adds a new `fakeAbortSignal` function to `packages/injected/src/clock.ts` and integrates it into the `createClock` utility, allowing `AbortSignal.timeout` calls to be controlled by `page.clock.tick()`. The **injected utility scripts** are updated to recognize this new faked builtin, and the server-side clock passes browser context for improved error reporting. This **enhancement** significantly improves the **testability** of asynchronous operations that rely on `AbortSignal.timeout`, ensuring consistent behavior across test runs, and is verified with new test cases in `tests/library/page-clock.spec.ts`.

This commit performs a **maintenance update** for the **Playwright core library**, upgrading the `proxy-from-env` dependency from version 1.1.0 to 2.0.0. This **dependency upgrade** specifically addresses the removal of reliance on the deprecated `url.parse` method, enhancing the project's long-term stability and adherence to modern API standards. The change is formally reflected by updating the `ThirdPartyNotices.txt` file to document the new version of this third-party component.

This commit **fixes** a bug in the **Playwright test runner's reporting mechanism** where the command hash did not accurately reflect changes in the test list. It modifies the `computeCommandHash` function in `packages/playwright/src/runner/reporters.ts` to incorporate the SHA1 hash of the `cliTestList` and `cliTestListInvert` files. This ensures that the **reporting blob hash** correctly updates when the set of tests to be executed changes, preventing stale reports or incorrect caching. A new test case was added to `tests/playwright-test/reporter-blob.spec.ts` to verify this crucial update.

feat(devtools): chrome devtools + pick locator (#39256)

This commit **refactors** the **Playwright CLI and configuration system** by **renaming** the browser sandboxing option for improved clarity. The previous `--sandbox` and `--no-sandbox` command-line flags, along with their corresponding environment variable, have been updated to `--chromium-sandbox` and `--no-chromium-sandbox` respectively. This change, implemented across `packages/playwright/src/mcp/browser/config.ts` and `packages/playwright/src/mcp/program.ts`, clarifies that the option specifically controls the **Chromium browser sandbox**. The test suite in `tests/mcp/config.spec.ts` has also been updated to reflect this new naming. Users relying on the old option will need to update their commands and environment variables to use the more explicit `chromiumSandbox` identifier.

This commit **fixes a flaky codegen test** by preventing the Playwright recorder from tracking internal `x-pw-` actions during test execution. By adding `omitCallTracking: true` to the recorder options within `tests/library/inspector/inspectorTest.ts`, the test environment now ignores these specific Playwright-internal calls. This **improves the reliability of codegen tests** by ensuring that only user-intended actions are recorded, thus stabilizing test outcomes. The change specifically impacts the **test infrastructure** for the Playwright inspector and codegen features, making the test suite more robust.