Ruslan Lesiutin

This commit **refactors** the **frame timing instrumentation** within React Native's dev support and modern JS inspector tracing. It **removes the `commitTimestamp` field** from `FrameTimingSequence` and related data structures, along with the generation of the "Commit" trace event. This **maintenance** effort streamlines performance profiling by focusing on more relevant frame lifecycle events like `BeginFrame` and `DrawFrame`, aligning the tracing data with standard Chrome event structures and improving the clarity of performance timelines. The change impacts `FrameTimingsObserver`, `JReactHostInspectorTarget`, and various `jsinspector-modern` tracing components by simplifying their data models and event generation logic.

This commit **updates the `debugger-frontend` module** to a newer version, synchronizing it with the latest upstream changes from `react-native-devtools-frontend`. This **maintenance update** specifically incorporates a **bug fix** that prevents issues with the infobar custom element being registered multiple times. The change ensures the **React Native DevTools frontend** operates more robustly, avoiding potential errors related to custom element registration. This improves the stability and reliability of the debugging experience for React Native developers.

This commit **fixes a critical crash** in the **React Native Android JNI layer** that occurred when multiple `TracingStateListener` instances were registered, caused by incorrect static initialization of JNI methods. It **refactors** the `JReactHostInspectorTarget` and `JTracingStateListener` components to **cache the `onStateChanged` interface method** and directly invoke it on the listener object, resolving the static initialization conflict. This **bug fix** improves the robustness and stability of **React Native's tracing and inspection capabilities** on Android by ensuring `onStateChanged` is always called on the correct listener.

This commit introduces a **feature enhancement** to the **React Native DevSupport** system, specifically for **Android**. It now **completely hides the Performance Monitor overlay** from the UI when a trace is actively initiated through **React Native DevTools (RNDT)**. Previously, the monitor was merely disabled but remained visible, potentially interfering with tracing data or screenshots. This change, implemented in `PerfMonitorOverlayManager.kt` via the `updateTracingState` logic, ensures a cleaner developer experience and more accurate performance tracing by removing the monitor's visual presence during active CDP tracing sessions.

This commit **refactors** the **tracing state management** within the **React Native Android runtime** by eliminating the manual propagation of tracing state in `ReactHostInspectorTarget.kt`. Instead, the `PerfMonitor` now **subscribes directly to `InspectorTarget` tracing events**, establishing `jsinspector-modern` as the sole and centralized source of truth for tracing state. This **internal architectural improvement** simplifies the tracing mechanism, ensuring more consistent and reliable performance monitoring by centralizing control over recording state changes. The change specifically impacts methods like `addPerfMonitorListener`, `pauseAndAnalyzeBackgroundTrace`, `resumeBackgroundTrace`, and `stopBackgroundTrace` within `ReactHostInspectorTarget.kt`.

This commit implements a **performance optimization** within the **React Native Android dev support inspector** to drastically **reduce the size of captured screenshots**. It modifies the `takeScreenshot` method in `FrameTimingsObserver.kt` to use a **decreased scale factor** and **WEBP_LOSSY compression with zero quality**. This **maintenance** change shrinks screenshot sizes from approximately 100KB to about 6KB, which is crucial for **improving the efficiency of trace recordings** that involve numerous frames by preventing excessive data accumulation.

This commit **refactors** the **tracing mechanism** within `ReactCommon` by updating the category of the `SetLayerTreeId` trace event. Specifically, the event's category in `TraceEventGenerator.cpp` is changed from `Timeline` to `HiddenTimeline`. This **internal improvement** ensures that the `SetLayerTreeId` event is not displayed by default in Chrome's profiling timelines, aligning with Chrome's intended behavior for this specific event. The change **reduces visual clutter** in developer tools, making profiling data clearer and more focused.

This commit **enhances the JavaScript Inspector's modern tracing system** by **introducing a dedicated `Frame` category**, aligning with how Chrome DevTools categorizes frame-related events. This **new capability** involves adding the `Frame` category definition in `TracingCategory.h` and updating conversion functions. Subsequently, specific trace events like `BeginFrame`, `Commit`, and `DrawFrame` are **migrated from the general `Timeline` category to the new `Frame` category** within `TraceEventGenerator.cpp`. This refinement improves the **granularity and accuracy of performance tracing data** for rendering operations, aiding in more precise performance analysis within React Native's debugging tools.

This commit **corrects the timestamp source** for the `BeginDrawing` event within **Android frame timing metrics**. It changes the timestamp from `INTENDED_VSYNC_TIMESTAMP` to `VSYNC_TIMESTAMP` in the `FrameTimingsObserver.kt` file. This **bug fix** ensures that the `BeginDrawing` event accurately reflects the *actual* start of the frame sequence, rather than the *intended* start, aligning with how `BeginFrame` trace events are interpreted. The change significantly improves the **accuracy of performance data** reported to **Chrome DevTools** for **React Native Android applications**, providing more reliable insights into UI thread responsiveness.

This commit **updates the React Native debugger frontend** to its latest version, incorporating a **new feature** that significantly **enhances the Timeline** functionality. Specifically, this **dependency update** enables the debugger to display **newly supported options for the Timeline**, providing developers with more detailed insights during performance analysis. This **maintenance update** brings **new capabilities** to the **developer tools**, improving the overall debugging experience for React Native applications.

Remove stale references to removed jni target (#54746)

This commit performs a **cleanup** by **removing an unused JNI layer** specifically designed for **frame timings** within the **Android platform integration**. The `FrameTimings` JNI code was not yet rolled out to open-source, making its removal a safe **maintenance** task with no breaking changes. This action streamlines the codebase by eliminating dead code related to performance measurement, improving overall maintainability without impacting any existing features.

This commit introduces a significant **refactoring** to the **JavaScript Inspector's tracing subsystem** by clarifying the distinct roles of `HostTracingProfile` and `TraceRecordingState`. Previously, `TraceRecordingState` ambiguously served as both a global state and the container for collected tracing data; now, `HostTracingProfile` explicitly encapsulates the actual tracing profile data. This **architectural improvement** involves updating numerous methods across `HostAgent`, `HostTarget`, and `TracingAgent` to correctly pass and manage tracing data using the new `HostTracingProfile` struct. The change enhances the **maintainability and clarity** of the tracing mechanism within the **React Native runtime**, ensuring a more robust separation of concerns for tracing configuration and collected data.

This commit **refactors** the propagation of **Android frame timing data** within React Native, moving from direct JNI calls to a more integrated approach using the **inspector's `HostTarget` mechanism**. It introduces a new `FrameTimingSequence` data class and updates the `FrameTimingsObserver` to report sequences via a callback. The `ReactHostInspectorTarget` and its corresponding JNI implementation are extended with a `recordFrameTimings` method to facilitate this new data flow. This **internal architectural improvement** streamlines how performance tracing data is reported, enhancing consistency and maintainability for the **React Native Android runtime**.

This commit introduces a **new capability** to the **JS Inspector's `HostTarget`** by defining and implementing a `recordFrameTimings` endpoint. This new public API allows external systems to capture and report detailed frame timing data, which can be invoked during active tracing sessions to enhance **performance monitoring and debugging**. The change also includes **thread-safety improvements** for tracing operations by adding mutex guards to `startTracing` and `stopTracing` in `HostTargetTracing.cpp`, ensuring robust data collection. A new test case in `TracingTest.cpp` verifies the correct functionality of `recordFrameTimings`.

This commit **enhances the tracing mechanism** within the **`jsinspector-modern` subsystem** by introducing a consistent time window for trace recordings. It modifies `HostTargetTraceRecording` to accept and propagate a `windowSize` parameter, which is then stored in `TraceRecordingState`. This **new capability** ensures that all tracing agents, including `InstanceTracingAgent` for performance tracing, are aware of and utilize the same defined window size. The change removes redundant constants and establishes a unified approach, which is crucial for accurate performance data collection and will support future extensions like integrating frame tracing at the host layer.

This commit **introduces new serialization logic** to integrate frame timing data into the `HostTargetTracingProfile` within the `jsinspector-modern` subsystem. It **implements the `emitFrameTimings` method** in `HostTracingProfileSerializer.cpp` to convert frame timing sequences into trace events, which are then emitted as `Tracing.dataCollected` chunks. This **new capability** ensures that critical performance metrics related to frame timings are correctly captured and serialized, enhancing the comprehensiveness of performance tracing. A new test case in `TracingTest.cpp` was added to validate the correct emission of these frame timing sequences.

This commit **reverts** a previous change, effectively **removing** the recently added **CDP frame events** functionality from the **`jsinspector-modern/tracing`** module within `ReactCommon`. Specifically, it **removes** several `PerformanceTracer` event struct definitions and their inclusion in the `PerformanceTracerEvent` variant type alias from `PerformanceTracer.h`. This **backout** ensures that the `jsinspector-modern` component no longer supports tracing these specific frame-related events. The change is a **reversion** of a feature addition, impacting the available performance tracing capabilities.

This commit introduces a **new capability** by adding the `TimeWindowedBuffer` data structure to the **`jsinspector-modern/tracing`** subsystem. This buffer is designed to preserve entries that fall within a configurable time window, and can also function as a simple buffer when no time constraints are specified. It improves upon previous approaches, like that in `PerformanceTracer`, by avoiding pointers to prevent issues during copies or moves. This **internal utility** provides a robust way to manage time-sensitive data within the project, accompanied by comprehensive unit tests in `TimeWindowedBufferTest.cpp`.

This commit **reverts** a previous change that aimed to expose frame events on the `PerformanceTracer` within the **React Native performance tracing system**. This **corrective action** effectively removes the recently added capability to access detailed frame-related performance data. Consequently, the `PerformanceTracer` will no longer provide these specific frame events, impacting any tooling or features that might have relied on their availability.