krishnamd-jkp

This commit **enhances a conformance test** within the **storage** module by modifying the initialization of the `MultiRangeDownloader`. Specifically, it ensures that the test in `storage/retry_conformance_test.go` now configures the downloader to use a minimum of two connections. This change improves the **test coverage** for multi-stream download scenarios, validating the component's behavior when multiple concurrent streams are utilized. It helps ensure the robustness and correctness of the **multi-range download functionality**.

This commit performs **release preparation** for the **`storage` client library**, incrementing its version from `v1.61.2` to `v1.61.3`. It involves **maintenance updates** to various configuration and generated files, including `.librarian/state.yaml`, `internal/generated/snippets/storage/control/apiv2/snippet_metadata.google.storage.control.v2.json`, and `storage/internal/version.go`, to reflect the new version. This automated **version bump** is initiated by the Librarian CLI. Merging this pull request will **trigger the official `v1.61.3` release** of the `storage` module, which primarily incorporates a documentation fix.

This commit implements a **documentation fix** within the **`storage` package** to improve godoc formatting. Specifically, it standardizes placeholder syntax in comments from angle brackets to curly braces across `acl.go`, `post_policy_v4.go`, and `storage.go`. This **maintenance** change enhances the consistency and readability of documentation for critical components such as `ACLEntity`, `ObjectAttrs.Owner`, `PostPolicyV4Options.PrivateKey`, and `SignedURLOptions.PrivateKey`. The update ensures that the godoc comments adhere to a consistent style, making them clearer for developers interacting with the `storage` client library.

This commit **restores** the intended **version update** for the **Google Cloud Storage client library**, effectively reverting a previous rollback. It updates the internal version constant in `storage/internal/version.go` and various configuration files, including `.librarian/state.yaml` and `snippet_metadata.google.storage.control.v2.json`, from `1.61.0` to `1.61.1`. This **maintenance** change ensures the project correctly reflects the latest `1.61.1` release of the **`storage` module**, impacting dependency management and the client's reported version.

This commit prepares for the **release of the `storage` client library version `v1.61.0`**, updating internal versioning and generated metadata files. This **version update** incorporates several **new features** and **bug fixes** into the **`storage` module**. Key enhancements include adding APIs for **bucket encryption enforcement**, **multistream options** for Managed Replication Destinations (MRD), and a **DeleteFolderRecursive API**. Additionally, it resolves issues related to Transfer Manager download directories and MD5 checksum handling, optimizing gRPC writer performance.

This commit provides a **bug fix** for a **corner case** within the **`storage/transfermanager`** module's **downloader component**. It addresses an issue where the download file path could incorrectly resolve to the download directory itself, potentially leading to security vulnerabilities or incorrect file handling. The fix refines the `isSubPath` function in `downloader.go` to correctly validate relative paths by comparing the local directory with the parent folder of the final resolved file path. New test cases have been added to `downloader_test.go` to ensure comprehensive coverage of these specific scenarios, enhancing the **robustness and security** of the download functionality.

chore(storage): upgrade gRPC version to 1.79.2 (#14143)

This commit performs a **chore** to refine the **checksum calculation logic** within the **`storage`** module's `grpc_writer.go`. Specifically, it **adjusts the condition** in the `Write` function to correctly handle scenarios where an **MD5 checksum** is already provided for an object. This ensures accurate full object checksum accounting, improving **data integrity** and preventing potential mismatches during storage operations.

This commit introduces a **new feature** to the **`storage` module**, enabling the configuration and enforcement of bucket encryption policies. It adds comprehensive support for **Google Managed, Customer Managed, and Customer Supplied encryption enforcement configurations** to the `Bucket` model and its conversion logic within `storage/bucket.go`. The `UpdateBucket` gRPC client method in `storage/grpc_client.go` is also updated to include field masks for these new configurations. This enhancement allows users to specify and enforce encryption at the bucket level, significantly improving data security and compliance.

This commit **fixes a potential panic** within the **`storage` module's `grpc_writer` component** by introducing null checks for `params.objectAttrs` and `params.fullObjectChecksum` in the `getObjectChecksums` function. This **bug fix** prevents crashes when object attributes or full checksums are unexpectedly absent. Concurrently, the commit **enhances test coverage** for `TestGetObjectChecksums` in `grpc_writer_test.go`. New test cases now validate scenarios involving nil object attributes, explicit CRC32C, and the correct handling of **MD5 checksums**, significantly improving the reliability and robustness of checksum operations within the storage system.

This commit introduces a **fix and optimization** within the **`storage` module's gRPC writer** to improve checksum handling. It modifies the `Write` method and `getObjectChecksums` function in `storage/grpc_writer.go` to **omit redundant auto-checksum calculations** (MD5 or CRC32C) when a user has already provided one. This ensures that user-provided checksums are prioritized, preventing unnecessary processing during data uploads. The change improves the efficiency and correctness of **data uploads** to storage services when custom checksums are supplied. New **integration tests** have been added to `storage/integration_test.go` to validate this behavior, ensuring the correct checksums are used in final requests.

This commit performs a **maintenance chore** by **correcting an error checking condition** within the `TestIntegration_MRDStreamFailureSurvival` function in the **storage integration tests**. Specifically, it ensures that `EOF` errors are properly handled during stream failure simulations. This adjustment prevents potential false negatives or inaccurate test results, thereby improving the reliability and accuracy of the **storage stream failure survival test** suite. The change ensures the test correctly validates the system's behavior under specific error conditions without altering any production code.

This commit **improves the robustness of the storage subsystem's gRPC multi-range reader** by **fixing stream error handling**. It modifies the `grpc_reader_multi_range.go` component to **prevent premature stream cancellation** when an EOF (End-Of-File) condition is encountered, allowing the `receiveLoop` to continue processing data. Additionally, **resource deallocation calls** are now properly integrated within the receive loop for better stability. This **maintenance** ensures **complete and reliable data reception** for multi-range reads, preventing partial data streams.

This commit refines the **error checking logic** within the `TestIntegration_MRDStreamFailureSurvival` in the **storage integration tests**. It specifically modifies how the test handles failed ranges by now correctly accounting for `io.EOF` conditions. Furthermore, the commit updates critical error reporting from `t.Errorf` to `t.Fatalf` for certain scenarios, ensuring that significant test failures immediately halt execution. This **maintenance chore** improves the reliability and accuracy of the **storage stream failure survival test**, preventing potential false positives and providing clearer test outcomes.

This commit introduces a **fix** and **enhancement** to the **Multi-Range Downloader (MRD)** within the `storage` module, significantly improving its resilience to stream failures. It **refactors** the stream picking logic to a weighted strategy and enhances error handling to correctly propagate permanent errors and manage stream failures more robustly. This ensures that the downloader can better recover from or appropriately report issues with individual data streams. A new integration test, `TestIntegration_MRDStreamFailureSurvival`, has been added to verify the downloader's behavior under various stream failure scenarios, ensuring more reliable data retrieval.

This commit introduces **new configuration options** for the **`MultiRangeDownloader`** within the **`storage` module**, enhancing its flexibility and control over resource usage. It adds public options such as `WithMinConnections`, `WithMaxConnections`, `WithTargetPendingRanges`, and `WithTargetPendingBytes` to the `NewMultiRangeDownloader` function, allowing users to fine-tune concurrency and buffering behavior. This **new feature** provides more granular control over data retrieval operations, potentially improving performance or resource management. Integration tests in `storage/integration_test.go` have been updated to validate the proper functioning of these new settings.

This commit introduces **multistream support** to the **`MultiRangeDownloader`** within the **`storage` module**, enabling more efficient and concurrent data range downloads. It involves a significant **feature implementation** and **refactoring** of the `grpc_reader_multi_range.go` component, adding core logic for stream management, connection scaling, and an updated event loop. New public configuration options like `withMinConnections` and `withMaxConnections` are exposed in `storage/reader.go` to control this behavior. Comprehensive **integration tests** have been added and modified to verify connection scaling and range distribution, ensuring the robustness of this new capability. This enhancement allows the downloader to utilize multiple parallel streams for fetching data, potentially improving download performance and resilience.

This commit is a **release preparation** for the **`storage` client library**, bumping its version to **1.60.0**. It updates internal version constants, snippet metadata, and the Librarian state configuration to reflect this new release. The `storage` module receives **new features**, including support for `max-retry-duration` and checksum validation in resumable JSON uploads, alongside **critical bug fixes** addressing panics in transfer manager downloads and deadlocks. This **maintenance release** significantly enhances the functionality and stability of the Google Cloud Storage client for users.

This commit delivers a **bug fix** addressing a **panic error** within the **storage transfer manager** during download operations. The `gatherShards` function in `storage/transfermanager/downloader.go` was modified to **prevent panics** by ensuring checksums are only collected for shards after the first one and by skipping checksum collection entirely for any errored shards. This change significantly enhances the **robustness of multi-part downloads**, particularly when encountering partial failures or corrupted data. The accompanying `downloader_test.go` was also refactored to include new test cases specifically covering shard failures and checksum mismatches, validating the stability of the fix.

This commit **fixes a test case** within the **storage** module by updating an expected error message. Specifically, it modifies `storage/http_client_test.go` to align the expected error string for the `TestValidateChecksumFromServer` test when a wrong checksum is encountered. This **maintenance** change ensures the test accurately validates the HTTP client's checksum verification logic, preventing false negatives caused by an outdated expected message. The update is confined to the test suite and has no impact on the production behavior of the `storage` module.