Kaylee Lubick

This commit performs a **refactoring** within the **Skia graphics library's shader system**, specifically in `src/shaders/SkImageShader.cpp`. It removes extraneous and redundant `'true &&'` conditions from conditional checks inside the `appendStages` function. This **code cleanup** improves the readability and maintainability of the `SkImageShader` implementation. The change is internal to the shader module, ensuring no downstream impact on rendering output or external behavior.

This commit **reintroduces a new capability** to the **SkExif image codec** module, enabling explicit control over EXIF parsing. It adds a `ForceSkExif` method that allows developers to **force the use of the C++ EXIF parser** even when the `rust_exif` feature is enabled. This **feature addition** primarily affects the `src/codec/SkExif.cpp` implementation, modifying how `SkExif::Parse` selects its backend, and updates various build configurations. The change provides enhanced flexibility for debugging and compatibility, ensuring that the image metadata processing can be directed to the desired EXIF parsing implementation.

This commit **fixes a bug** in the **Skia pixel recording tests** (`PixelsRecTest.cpp`) that specifically affected 32-bit architectures. It **refactors the `hugeRowBytes` calculation** within the `ReadPixelsRec_trim` and `WritePixelsRec_trim` tests. The change ensures these tests explicitly trigger and verify `y_offset` overflow conditions, rather than implicitly relying on the size of `size_t`. This **improves the reliability and accuracy of Skia's testing suite** for pixel operations, ensuring proper behavior across various architectures, especially 32-bit environments.

This commit implements a **bug fix** and **refinement** to the **AVX512 CPU feature detection** within the **`SkCpu` module**. It now uses `cpuid` to intelligently enable AVX512 only on newer Intel chips (Ice Lake and later) and all AMD chips, while disabling it for older Intel generations (Skylake, Cascade Lake) that experienced performance regressions. This change in `src/core/SkCpu.cpp` prevents performance issues and, coupled with adjustments in `src/core/SkOpts.cpp` for conditional compilation, allows clients to safely enable AVX512 by default, improving performance where appropriate. The update also introduces a `SK_DISABLE_AVX512_OPTS` flag for finer control.

This commit performs a significant **refactoring** of **CPU optimization targeting** by renaming x86 optimization levels from Intel-specific codenames (Haswell, Skylake) to the more generic and industry-standard **x86-64 microarchitecture levels v3 (ml3) and v4 (ml4)**. It also renames `SK_CPU_SSE_LEVEL*` macros to `SK_CPU_X64_LEVEL*` to better reflect modern 64-bit feature sets and introduces `SkX64` and `SkLoongArch` structs for clearer CPU feature flag management within `SkCpu.h`. This **maintenance** change improves **code clarity and future-proofing** by decoupling optimization levels from specific vendors, as these features are supported by both Intel and AMD processors. The changes are largely mechanical, impacting **CPU feature detection logic**, **optimization dispatch functions**, and **build system configurations** across various `src/core` and `src/opts` modules.

This commit **renames** the `grshape` libfuzzer application target to `api_grshape` within the `BUILD.gn` configuration file. This **maintenance** change standardizes the naming convention for the **`grshape` fuzzer**, aligning it with other **API fuzzers** across the project. The primary impact is on the **build system** and **fuzzing infrastructure**, ensuring consistent identification and management of fuzzer targets.

This commit **fixes a bug** by **introducing robust size validation** within the **`SkTableMaskFilter`** and the **multi-picture document (MSKP) reading utility**. It adds width and image size checks in `SkTableMaskFilter::filterMask` to prevent overflows and handle invalid image dimensions. Concurrently, it defines a `kMaxDimension` and validates page counts and dimensions in `SkMultiPictureDocument::ReadPageCount` and `SkMultiPictureDocument::ReadPageSizes`. This ensures the **stability and security** of Skia by preventing crashes or incorrect rendering when processing excessively large or malformed image effects and document inputs.

This commit performs a **maintenance chore** by updating the `.gitignore` file to **ignore workspace-level metadata** generated by coding agents. Specifically, it adds the `.gemini` entry, preventing these temporary or local configuration files from being tracked by Git. This action improves **repository hygiene** by ensuring that developer-specific artifacts do not clutter the version control system. The change primarily affects **developer workflows** and **repository cleanliness**, avoiding unnecessary diffs and commits of non-essential files.

This commit provides **maintenance and a critical bug fix** for the **`SkReadPixelsRec` and `SkWritePixelsRec` core Skia components**. It **fixes a potential undefined behavior** in the `trim` methods of both `SkReadPixelsRec` and `SkWritePixelsRec` by adding checks to correctly handle `INT_MIN` values for `fX` or `fY` during negation. Additionally, **comprehensive documentation** is added to the constructors and `trim` methods of both classes, clarifying parameter behavior and modifications. New **unit tests** are introduced in `PixelsRecTest.cpp` to validate the `trim` logic, specifically covering negative coordinates and overflow conditions. This work **improves the robustness and reliability** of pixel manipulation operations within Skia.

This commit **relands** a previous change to **refactor** and **document** the **`SkCpu` module**, specifically improving its CPU feature detection logic. It introduces dedicated helper functions for CPUID calls and new constants within `src/core/SkCpu.cpp`, enhancing the structure and clarity of the detection process. Additionally, detailed documentation is added to explain the CPU feature identification, significantly improving the **readability** and **maintainability** of this core component.

This commit **refactors** the **`SkCpu` module's CPU feature detection logic** to significantly improve its **readability and maintainability**. It introduces new helper functions, such as `read_cpu_features`, and constants, along with detailed comments, to clarify how CPU capabilities like `cpu_features` and `cpu_flags` are identified using mechanisms like `xgetbv`. This work is a **code quality improvement** that enhances the internal structure of the CPU detection subsystem without altering its external behavior. A minor **style update** was also applied to the header guard in `SkCpu.h`.

This commit introduces a **build fix** for the **Dawn** library on **Linux** by explicitly adding the X11 build flag within the `third_party/dawn/build_dawn.py` script. Previously, the implicit definition of this flag led to inconsistent compilation, succeeding on some Linux machines but failing on others. By making the X11 dependency explicit, this change ensures **consistent and reliable compilation** of **Dawn** across all Linux environments. This **maintenance** update resolves a critical build issue, improving the stability of the **Dawn** integration.

This commit introduces a **new capability** by adding a **Graphite+Vulkan test job** to the Continuous Quality (CQ) system. It modifies `infra/bots/jobs.json` to define the new job's configuration and `infra/bots/tasks.json` to specify its associated task. This integration ensures that the **Graphite rendering backend** is automatically tested with the **Vulkan graphics API** as part of the pre-submit checks. This **feature addition** improves the stability and reliability of this specific rendering path by catching regressions early in the development cycle.

This commit performs a **maintenance upgrade** of the operating system for **MacBookPro11,5** build agents within the CI/CD infrastructure. Specifically, it updates the `defaultSwarmDimensions` in `infra/bots/gen_tasks_logic/gen_tasks_logic.go` to provision these machines with **macOS 12.7** instead of macOS 11.7. Correspondingly, job definitions in `infra/bots/jobs.json` are updated to reflect the `Mac12` OS version. This ensures that all jobs targeting these specific hardware configurations will now execute in a **macOS 12.7 environment**.

This commit **improves the clarity and structure of the installation instructions** for the **profiler and visualizer tools**. It specifically targets the `site/docs/dev/testing/profiling.md` file, **restructuring the content** to make the setup process more straightforward for developers. This **documentation update** enhances the user experience by providing clearer guidance, ultimately simplifying the initial configuration of these important **performance analysis tools**.

This commit **introduces a new capability** to the **CanvasKit** module by adding a conditional dependency for `pathops` within its `BUILD.gn` configuration. This change allows the `pathops` library, which provides advanced path operations, to be optionally included in CanvasKit builds when its feature is enabled. This **feature enhancement** provides greater flexibility for developers to leverage `pathops` functionality as needed. This update is part of the **CanvasKit v0.41.0 release**, signifying a significant update to the library's build options.

This commit **fixes** the **Skia viewer's** functionality with the **Dawn Graphite backend** on **Linux** by addressing critical build and configuration issues. It re-enables necessary X11 support for Dawn on Unix and introduces **new build configurations** in `third_party/dawn/BUILD.gn` that define `SK_DAWN_HAS_` macros, allowing the **viewer** (`tools/viewer/Viewer.cpp`) to precisely control and toggle available Dawn backends based on `dawn_enable_` GN arguments. Additionally, this **bug fix** includes **refactoring** to improve error reporting and logging within the **Graphite Dawn window contexts** (`tools/window/GraphiteDawnWindowContext.cpp`, `tools/window/unix/GraphiteDawnXlibWindowContext_unix.cpp`), enhancing the overall robustness of Dawn integration. These changes ensure the **viewer** provides a stable and configurable experience for Dawn development on Linux.

This commit introduces new **Bazel macros**, `skia_cc_library_with_testutil` and `skia_objc_library_with_testutil`, to streamline the creation of `cc_library` and `objc_library` targets that require a `GPU_TEST_UTIL` variant. This **new capability** for the **Bazel build system** automatically generates both production and test-utility versions of libraries and intelligently rewrites dependencies to ensure the correct variant is used, preventing mixed builds. Consequently, numerous **GPU-related modules** like `ganesh` and `graphite` undergo significant **refactoring** to adopt these macros, eliminating manual duplication of `TEST_UTIL` build definitions. This change simplifies build configurations, reduces redundancy, and improves maintainability and consistency across the project's GPU components.

This commit performs **maintenance** by addressing a `-Wdeprecated-copy-with-dtor` warning within the **Chromium ICC profile handling** module. It modifies `include/private/chromium/SkCodecsICCProfileChromium.h` to explicitly define a default constructor and delete the copy constructor and copy assignment operator for the `ICCProfileChromium` class. This **bug fix** prevents the compiler warning without altering the intended object lifecycle or behavior of the `ICCProfileChromium` class.

This commit **improves the usability** of the `viewer` tool through **documentation enhancements** and minor **refactoring**. It adds and clarifies keyboard command documentation in `site/docs/user/sample/viewer.md`, specifically detailing the 'h' key for help. Additionally, the description for the 'u' command within the `tools/viewer/Viewer.cpp` source code is refined from 'Zoom UI' to 'Zoom Stats UI', providing a more accurate explanation of its function. This work ensures users have clearer and more precise information when interacting with the **viewer application**.