Felix Hanau

03-30-26 Bazel cleanup (#6458)

This commit **updates the Bazel build configuration** by explicitly enabling the `incompatible_repo_env_ignores_action_env` flag, aligning with Bazel 9's default behavior. This **refactoring** separates environment variables, making `BAZEL_COMPILER`, `CC`, and similar variables exclusively `repo_env` while `ASAN_OPTIONS` and `UBSAN_OPTIONS` become exclusively `action_env`. The change impacts the **core build system**, **CI/CD workflows**, **Docker build processes**, and **developer documentation**, requiring updates to `.bazelrc`, GitHub Actions, Dockerfiles, and `README.md` files. This is a crucial **build system maintenance** step to prepare for future Bazel versions and improve build reproducibility by clarifying environment variable scope.

This commit **updates the build system** to **protobuf v34**, enabling the use of prebuilt `protoc` and significantly **restricting external autoloads** within the Bazel configuration. The `.bazelrc` file is modified to remove specific `cc_` rules, further tightening these autoload restrictions. Concurrently, the `MODULE.bazel` file **updates the `sqlite3` module** to a newer version and integrates `rules_go` and `rules_android` as new Bazel dependencies. This comprehensive **build system maintenance** effort streamlines dependencies and enhances overall build efficiency.

This commit provides a **build fix** for the **Windows release configuration** by modifying `.bazelrc`. It **disables inlining** for specific source files within the **Bazel build system** to prevent `clang-cl` crashes during compilation. This change directly addresses and resolves existing **CI test failures** on Windows, ensuring the stability and reliability of the **Windows release build pipeline**. Consequently, the **Windows test CI job** will now run successfully in release configuration, preventing future build failures.

Merge pull request #6059 from cloudflare/felix/experimental-tcp-ingress

Merge pull request #5370 from cloudflare/felix/102125-stw-cleanup

This commit performs a **maintenance update** across numerous **GitHub Actions workflows** to address **Node 20 deprecation warnings**. It modifies the configuration of nearly all **CI/CD pipelines**, including `_bazel.yml`, `_wpt.yml`, `lint.yml`, `test.yml`, and various release-related workflows located in the `.github/workflows/` directory. This proactive change ensures the continued stability and compatibility of the project's **automated testing and deployment infrastructure**, preventing potential disruptions or failures when Node 20 is fully deprecated on GitHub Actions runners. The updates mitigate future issues by aligning the workflows with upcoming platform changes, safeguarding the integrity of builds and releases.

Merge pull request #6302 from cloudflare/felix/031126-build-cleanup

This commit performs **build system and dependency refactoring** within the **`workerd`** project, primarily focusing on **build performance optimizations**. It **reduces compilation overhead** by removing the expensive `workerd-api.h` header include from `src/workerd/server/workerd.c++` where it was not semantically required. Concurrently, it **streamlines Bazel dependencies** by correcting the relationship between C++ and Rust JSG components, specifically removing an unnecessary dependency on `//src/rust/jsg` from `src/workerd/jsg/BUILD.bazel`. This cleanup aims to eliminate unnecessary linker inputs and improve overall build efficiency for the **`workerd`** server.

This commit **refactors the Bazel build configuration** for **Rust dependencies**, specifically improving how the `lol-html` C API header is imported. Changes across `deps/rust/BUILD.bazel`, `cargo.bzl`, and `extension.bzl` streamline the integration of the `lol_html_c_api` crate. This **build system improvement** significantly **reduces future maintenance effort** by automating the version management of the `c-api` crate, eliminating the need for manual updates. The scope is limited to the build process, ensuring more robust and less error-prone dependency handling for the `lol-html` C API.

This commit performs significant **build system maintenance** and **dependency management**, primarily affecting the **Bazel build system** and **CI configurations**. It **rolls Bazel from 9.0.0 to 9.0.1** and **removes the unused `aspect_rules_lint`** to reduce dependency bloat and resolve compatibility issues with Bazel 9. Further updates include upgrading `clang-tidy` to its latest patch release, addressing a bug fix, and refining **macOS CI configurations** to prevent duplicate flags and ensure benchmarks are properly disabled during builds. Additionally, the `zlib` dependency is updated, and the `README.md` is revised to reflect the latest Debian release, Trixie. These changes improve build stability, reduce complexity, and update development tooling.

This commit introduces **support for the new `connect` worker handler** within the **`Miniflare` runtime**. It implements this **new feature** by adding `'connect'` to the set of reserved keys for worker handlers in `packages/miniflare/src/shared/external-service.ts`. This change ensures that the **`Miniflare` external service integration** correctly recognizes and processes `connect` events, allowing developers to utilize this handler type in their Workers.

This commit **updates the `perfetto` module's build configuration** and **enables `proto` toolchain resolution** within the Bazel build system. This **build system improvement** allows the project to utilize pre-compiled `protoc` binaries, thereby avoiding the need for self-compilation when building components that depend on `perfetto`. Specifically, it modifies `.bazelrc` to enable `proto_toolchain_resolution` and applies patches to `perfetto`'s Bazel files. These patches **remove `rules_android` dependencies** and **disable verbose info-level logging** in `perfetto`, streamlining its **build process** and aligning with existing downstream configurations.

This commit updates the build system to `clang-tidy-22`, introducing a new static analysis check (`readability-redundant-typename`). This enhances code quality and consistency for all C++ code within `src/workerd` by enforcing new linting rules, with no direct impact on production runtime behavior.

This change significantly improves `workerd`'s performance by enabling hardware acceleration (ISA extensions) for SQL-related hashing and CRC32C computations, fixing a regression and a known performance issue.

This commit performs a significant **refactoring** of the **observability (o11y) tracing infrastructure** within `workerd`, transitioning from a `CompleteSpan` model to an **event-based observer API**. The `CompleteSpan` structure and its associated methods are entirely removed, and the `SpanObserver` interface is updated to use `onOpen`, `onClose`, and `onUpdateName` methods for reporting span lifecycle events. This change allows **spans to be reported as soon as they are available**, rather than waiting for full completion, which simplifies the tracing API and enhances real-time visibility. Consequently, various **API instrumentation tests** for D1, Images, Durable Objects, and R2 are updated to align with the new event-driven span reporting behavior.

Merge pull request #6012 from cloudflare/felix/020326-update-deps

This commit updates numerous Rust dependencies within the Bazel build system, potentially impacting the stability, performance, or functionality of all Rust-based services and applications that consume these updated crates. While primarily a build system change, it reflects underlying changes in third-party libraries.

This commit refactors core `workerd` components, including API, I/O, and server infrastructure, by removing unused code and standardizing internal wrapper usage. It is an isolated internal code quality improvement with no functional impact on users or external systems.

This change globally improves V8 performance by enabling higher optimization levels in the build process for all builds, and critically resolves a segfault issue specifically affecting macOS builds.