Fabrizio Cucci

This commit delivers a **critical bug fix** addressing **widespread Hermes crashes** in **iOS TurboModule** interactions. Previously, when an **async void TurboModule method** threw an `NSException`, the `performVoidMethodInvocation` function in `RCTTurboModule.mm` would attempt to convert it to a `JSError` on a non-JSI thread, causing `jsi::Runtime` thread-safety violations, heap corruption, and `EXC_BAD_ACCESS` crashes. The fix modifies `performVoidMethodInvocation` to **re-throw the `NSException` directly** instead of converting it, thereby preventing unsafe access to the JSI runtime. This resolves a significant source of memory corruption and crashes, particularly impacting users encountering specific JavaScript errors in void TurboModule methods.

This commit **fixes a build failure** in the **`build_debugger_shell` CI job** by correctly passing the `--prepack` flag to the `yarn build` command within the workflow. Previously, the `debugger-shell` package's `main` field was not being rewritten from `./src/index.js` to `./dist/index.js` because the `prepack.js` script was not executed, causing `build-binary.js` to fail. This **maintenance fix** ensures the `debugger-shell` binary builds successfully in CI, resolving an issue introduced by recent refactoring of the package's `package.json` and build scripts.

This commit **optimizes iOS simulator management** within the **release testing scripts** by preventing redundant simulator boots. It introduces a new `bootSimulatorIfNeeded` helper function in `scripts/release-testing/test-release-local.js` that checks for any already-booted simulator before attempting to launch a new one. This **refactoring** addresses an issue where `testRNTesterIOS` would unnecessarily spawn a new simulator, consuming resources and time. The change significantly **improves the efficiency and speed of local and CI test runs** by ensuring simulators are only booted when absolutely necessary.

This commit **enhances the iOS simulator booting logic** within the **release testing scripts**, specifically in `scripts/release-testing/test-release-local.js`. It **dynamically discovers and boots the latest available iOS simulator** using `xcrun simctl` instead of a hardcoded device like "iPhone 16 Pro". This **improves the robustness and flexibility of local release testing** by ensuring compatibility with the newest iOS runtimes. Furthermore, the `bootSimulatorIfNeeded` function call is now strategically placed before `xcodebuild` invocations to prevent unintended, duplicate simulator boots.

This commit **introduces a new automation script**, `release-hermes-for-branch-cut.js`, designed to **streamline the Hermes release workflow** during React Native branch cuts. This **new capability** automates the complex process of preparing Hermes releases, including cloning the Hermes repository, fetching versions, creating release branches, triggering GitHub Actions builds, and updating various **React Native configuration files** like `.hermesversion`, `package.json`, and `version.properties`. By providing an interactive and `--dry-run` enabled tool, this script significantly **enhances the release engineering process** for **Hermes dependency management** within React Native, reducing manual effort and potential errors.

This commit implements a **preventative measure** to ensure **React Native release branches** consistently utilize **stable Hermes** builds rather than nightly versions. A new utility function, `setStableHermesForReleaseBranch`, was introduced in `scripts/releases/utils/hermes-utils.js` to modify `gradle.properties` and enforce this stable Hermes usage. This function is then integrated into the `scripts/releases/create-release-commit.js` script, safeguarding the **release process** from potential instability. This change primarily impacts the **Android build configuration** for release branches, enhancing the reliability of new stable releases.

This commit **reverts** a previous change that aimed to utilize stable Hermes for **Android dry-run builds** on stable branches. It **removes conditional logic** from `.github/actions/build-android/action.yml` that previously selected the Hermes version, thereby **defaulting these builds back to using nightly Hermes**. This **maintenance** action was necessary as the prior change did not resolve the intended issue, ensuring the build process continues with the more current Hermes version for these specific checks.

This commit **fixes** a critical issue in the **Android build workflow** where dry-run builds on stable branches incorrectly attempted to fetch non-existent `SNAPSHOT` versions of **Hermes**, leading to build failures. The **bug fix** introduces conditional logic within `.github/actions/build-android/action.yml` to detect stable branches, whether from direct pushes or pull requests targeting them. For these identified stable branches, the workflow now correctly uses **stable Hermes releases** from Maven Central, omitting the `-SNAPSHOT` suffix. This ensures the **CI/CD pipeline** for **Android builds** functions reliably on stable releases by resolving Hermes dependencies correctly.

This commit **refactors** several **LogBox UI components** by migrating them from traditional function component syntax to the newer **Flow component syntax**. Specifically, the `CodeFrameDisplay`, `LogBoxInspectorCodeFrame`, and `AppInfo` components within `Libraries/LogBox/UI` are updated. This is a **maintenance** and **code modernization** effort, aligning these components with current best practices for type-safe React development. The change primarily affects the internal implementation details of the **LogBox inspector**, with no functional impact on its behavior or the end-user experience.

This commit **refactors** the **LogBox UI components** `TappableLinks` and `LogBoxMessage` by migrating them from traditional function component syntax to the newer **Flow component syntax**. This change primarily affects the **internal implementation** within `packages/react-native/Libraries/LogBox/UI/LogBoxMessage.js`, enhancing type safety and code consistency for these critical error logging display elements. The work is a **maintenance refactor** aimed at modernizing the codebase without altering user-facing functionality.

This commit **refactors** the **LogBox UI** components `LogBoxInspectorStackFrames`, `StackFrameList`, and `StackFrameFooter` by migrating them from traditional function component syntax to the newer **Flow component syntax**. This change primarily affects the internal implementation details of how stack frames are displayed within the LogBox inspector. The **refactoring** improves code consistency and leverages Flow's advanced type checking capabilities for enhanced maintainability and type safety. This update is an internal code quality improvement with no direct user-facing changes to the LogBox functionality.

This commit **refactors** the `LogBoxInspectorReactFrames` component by migrating it from a traditional function component to the **Flow component syntax**. This update primarily affects the **LogBox UI**, which is responsible for displaying error and warning messages within React Native applications. The change involves adjusting prop destructuring within the component's definition to align with the new syntax. This is an internal **maintenance** effort to modernize the codebase's type annotations and improve consistency.

This commit **refactors** the `LogBoxInspectorMessageHeader` component, located within the **React Native LogBox UI** module. The change involves migrating the component's definition from a standard function component to utilize **Flow component syntax**, which also necessitates updating how its props are defined and accessed internally. This is a **maintenance** and **code modernization** effort aimed at improving type safety and consistency within the `LogBox` subsystem. While it enhances the internal implementation of the **LogBox UI**, specifically the header displayed for inspector messages, there is no functional change or impact on the end-user experience.

This commit **refactors** the `LogBoxInspectorStackFrame` component within the **LogBox UI** module. It migrates the component's definition from a traditional function component to leverage **Flow component syntax**. This **internal maintenance** effort improves code consistency and enhances type-checking capabilities for better maintainability within the `LogBox` system. The change has no functional impact on the end-user experience of the LogBox inspector, primarily affecting the internal development and type safety of the component.

This commit **refactors** the `LogBoxInspectorSourceMapStatus` component within the **React Native LogBox UI** to adopt the **new Flow component syntax**. Specifically, it **migrates** the component defined in `packages/react-native/Libraries/LogBox/UI/LogBoxInspectorSourceMapStatus.js` from a functional component with props to this updated syntax. This **internal code modernization** enhances consistency and maintainability within the `LogBox` module, without introducing any changes to the component's runtime behavior or user-facing functionality.

This commit **refactors** the **LogBox UI** by migrating the `LogBoxButton` component from a standard function component to **Flow component syntax**. This internal **syntax migration** updates how props are destructured and used within the component, enhancing type safety and consistency for the `LogBoxButton.js` file. The change is a **maintenance** effort that affects only the implementation of `LogBoxButton` and has no impact on its external behavior or API.

This commit **refactors** the `LogBoxInspectorSection` component, an integral part of the **LogBox** UI system in React Native. It **migrates** the component's internal definition and prop handling from a standard function component to the more explicit **Flow component syntax**. This **internal maintenance** task enhances type safety and code consistency within the `packages/react-native/Libraries/LogBox/UI/LogBoxInspectorSection.js` file. The change primarily focuses on **code quality and maintainability** without introducing new features or altering user-facing behavior.

This commit **refactors** the `TextAdjustsDynamicLayoutExample.js` file, part of the **`rn-tester` Text examples**, by **migrating React components** within it. The change updates these components from their **legacy function syntax to the modern Flow component syntax**. This **internal maintenance** effort aligns the example code with the preferred pattern for writing Flow-typed React components at Meta. The update primarily improves **code consistency and maintainability** for the **`Text` component examples** within the test application.

This commit **refactors** the **`rn-tester` examples for `SectionList`** by migrating their React components from a legacy function syntax to the modern **Flow component syntax**. This **code modernization** effort updates files like `SectionList-inverted.js` and `SectionList-onEndReached.js` to align with Meta's preferred patterns for writing Flow-typed React components. The change improves code consistency and maintainability within the example suite, without altering the functional behavior of `SectionList` itself.

This commit **refactors** the **`rn-tester` examples** for the **`IntersectionObserver`** and **`MutationObserver`** APIs. It updates the React components within these examples from their legacy function syntax to the modern **Flow component syntax**, aligning with Meta's preferred coding standards for Flow-typed codebases. This **internal code style update** primarily affects the consistency and maintainability of the example code, ensuring developers have up-to-date patterns to follow. The change does not alter the functionality of the `IntersectionObserver` or `MutationObserver` APIs themselves, only how their demonstration components are written.