Developer
edward
edzhong@celestica.com
Performance
YoY:+600%Key patterns and highlights from this developer's activity.
Breakdown of growth, maintenance, and fixes effort over time.
Bugs introduced vs. fixed over time.
No bugs introduced or fixed in this period.
Latest analyzed commits from this developer.
| Hash | Message | Date | Files |
|---|
Commit activity distribution by hour and day of week. Shows when this developer is most active.
Developers who frequently work on the same files and symbols. Higher score means stronger code collaboration.
| Effort |
|---|
| 9a130813 | This commit performs a **configuration update** for the **Icecube platform** to enable support for **BSP version 4.1.0-1**. Specifically, it updates the `bspKmodsRpmVersion` to `4.1.0-1` within the `fboss/platform/configs/icecube/platform_manager.json` file. As part of this **maintenance** effort, the `kernelDeviceName` for `SMB_CPLD` is also adjusted from `icecube_smbcpld` to `th6_smbcpld`. This ensures the **Icecube platform** remains compatible with the latest BSP, allowing platform services like `platform_manager` and `sensor_service` to function correctly with the updated kernel modules and device naming conventions. | Mar 4 | 1 | maint |
| 1719cd7a | This commit introduces **configuration updates** for the **Icecube platform**, primarily to support a new **SMB hardware version (`v 2 3 10`)** for DVT. It adds four new SMB voltage sensors to the `sensor_service.json` under the `versionedSensors` for this specific version. Additionally, the `platform_manager.json` is updated to include the `fboss_iob_i2c` driver in `requiredKmodsToLoad`, which is a **maintenance fix** to prevent timing issues by ensuring the driver is preloaded. These changes collectively enhance **hardware support** and **system stability** for Icecube devices. | Jan 29 | 2 | grow |
| 94e345ff | This commit performs a **configuration update** for the **Icecube platform**, specifically within the `fboss/platform/configs/icecube/platform_manager.json` file. It **bumps the `bspKmodsRpmVersion` from `3.4.0-1` to `4.0.0-1`** to ensure **compatibility and support for the latest BSP (Board Support Package) version**. This **maintenance change** is crucial for the **Icecube platform** to function correctly with the updated BSP, impacting its core system dependencies and enabling it to leverage the new BSP features. | Jan 8 | 1 | maint |
| 53416789 | This commit updates the **Icecube sensor service configuration** (`sensor_service.json`) to support both `TH6 B0` and `TH6 B0+` sensor chips. It introduces **versioned sensor thresholds** and configurations, allowing the system to dynamically adjust based on the `Product Production State` read from the SMB EEPROM. This **configuration update** ensures correct sensor monitoring and prevents false positives or negatives across different hardware revisions (EVT and DVT phases) of the **Icecube platform**. Specifically, it modifies thresholds for several `SMB_XP0R8V_PT_VDDC` and `SMB_XP0R72V_PB_TRVDD` sensors to align with the `TH6 B0+` datasheet. This **enhancement** is crucial for maintaining accurate hardware health monitoring as the platform evolves. | Dec 18 | 1 | grow |
| 5cef8b2c | This commit **updates the BSP test configuration** for the **Icecube platform** by adding specific test definitions to `fboss/platform/configs/icecube/bsp_tests.json`. This **new configuration** is a **maintenance** task essential for fulfilling the comprehensive BSP test suite requirements for OSS platform onboarding. It specifically includes test objects for `ICECUBE_MCB.SCM_CPLD`, `ICECUBE_MCB.MCB_FAN_CPLD`, and `ICECUBE_MCB.48V_HSC_MONITOR`, ensuring these critical components are covered by the automated test framework. This **enhances the test coverage** and **platform validation** for Icecube devices, enabling their successful onboarding to the new OSS platform. | Dec 8 | 1 | grow |
| 45b0b12d | This commit **updates the Icecube platform configuration** to enhance thermal management and sensor monitoring. It **raises the TMP432 high limit thresholds** to 100°C in `platform_manager.json` to prevent premature thermal shutdowns on TH6. Additionally, the `sensor_service.json` file is updated to **add new fan RPM, power consumption, and ASIC temperature sensor configurations**, and to adjust thresholds for several existing temperature and ADC sensors, aligning with thermal design requirements. This **configuration update** improves the system's ability to operate within thermal specifications and provides more comprehensive hardware monitoring. | Nov 21 | 2 | waste |
| 4481ce15 | This commit **updates the Icecube platform configuration** to support new hardware and resolve a critical sensor issue. It **adds configuration for the COME sensor version 4.2.1** and renames the `MCB_PU1066_LTC4287_P48V_POUT` sensor to `MCB_PU1066_LTC4287_P48V_PIN` within `platform_manager.json` and `sensor_service.json`. Crucially, this **bug fix** introduces `initRegSettings` for power brick devices (`PMBUS_1`, `PMBUS_2`, `PMBUS_3`) to explicitly set the PMBus page to `0` during initialization, preventing PMBus driver failures observed on new hardware units. This ensures **reliable sensor data collection** and **platform stability** for Icecube devices utilizing these updated components. | Nov 10 | 2 | grow |
| 94f12085 | This commit **updates the sensor service configuration** for the **Tahan platform**, specifically for **SMB and COME boards**. It **adjusts sensor thresholds** in `sensor_service.json` to align with the latest hardware sensor table, which also **fixes a bug** where `SMB_XP3R3V_LEFT_VOUT` and `SMB_XP3R3V_RIGHT_VOUT` readings were incorrectly exceeding their configured limits. Additionally, the `bspKmodsRpmVersion` is **bumped to `3.3.0-1`** in `platform_manager.json`, and threshold fields are **reordered for consistency** to improve code readability. This **maintenance and bug fix** ensures more accurate and reliable hardware monitoring by preventing false alarms and aligning software configurations with physical hardware specifications. | Sep 9 | 2 | waste |
| 2b18aed4 | This commit performs a **maintenance update** and **bug fix** for the **Janga platform's sensor and platform manager configurations**. It **adjusts various sensor thresholds** in `sensor_service.json` for SMB and COME boards to align with the latest hardware specifications, while also **fixing incorrect min/max alarm values** for specific voltage sensors and **correcting sensor names and computation formulas**. Concurrently, the `bspKmodsRpmVersion` is **bumped** to `3.3.0-1` and the `ledtrig_timer` kernel module is added as a requirement in `platform_manager.json`, ensuring accurate hardware monitoring and proper system operation. | Sep 9 | 2 | waste |
| 14df5059 | This commit introduces **platform service configurations** to provide comprehensive support for the **Icecube EVT2 hardware phase**. It involves significant updates across multiple configuration files, including `platform_manager.json`, `sensor_service.json`, `fw_util.json`, `fan_service.json`, `led_manager.json`, and `weutil.json`. Key changes include adding **SMB board configurations** to various services, updating sensor definitions and thresholds for components like MCB, BMC, and COMESE units, and modifying unit naming conventions and XCVR-related settings. This work delivers the essential **new capability** for FBOSS to accurately manage and monitor the Icecube platform's EVT2 hardware. | Aug 1 | 8 | grow |
| 91dd383e | This commit introduces **comprehensive support for the new Icecube800bc platform**, enabling the FBOSS software to manage its hardware components. It primarily focuses on **QSFP transceiver management** and **LED control**, integrating a dedicated **Board Support Package (BSP)** for Icecube800bc into the `fboss/lib`, `qsfp_service`, and `led_service` modules. This **new platform support** involves extensive additions to platform mapping, build configurations, and initialization logic, allowing FBOSS to correctly identify and interact with Icecube800bc hardware. The changes include new `Icecube800bcLedManager` and `Icecube800bcBspPlatformMapping` implementations, along with updates to `cmake` and `BUCK` files to incorporate the new platform's build rules and dependencies. This work is a **new feature** that expands FBOSS's hardware compatibility. | Jul 24 | 21 | grow |
| 9f19e736 | This commit performs a **configuration update** for the **Janga platform service**. It modifies the `bspKmodsRpmVersion` in `fboss/platform/configs/janga800bic/platform_manager.json`, updating it from `3.1.0-1` to `3.2.0-1`. This **maintenance** change synchronizes the platform's configuration with the latest tag in the Board Support Package (BSP) repository. The update ensures that the **Janga platform** correctly references the most current BSP kernel modules RPM, preventing potential version discrepancies and ensuring compatibility. | Jun 6 | 1 | maint |
| c351f328 | This commit performs a **configuration update** for the **Tahan platform service**, specifically modifying the `bspKmodsRpmVersion` within the `fboss/platform/configs/tahan800bc/platform_manager.json` file. The version string has been updated from '3.1.0-1' to '3.2.0-1'. This **maintenance change** is crucial for synchronizing the platform's configuration with the latest tag in the BSP repository, ensuring the **Tahan platform service** correctly references the most current **BSP kernel modules RPM version**. This prevents potential version mismatches and ensures compatibility with updated BSP components. | Jun 6 | 1 | maint |
| bfa89b3c | This commit **updates the Tahan platform configuration** by modifying the `platform_manager.json` file. It **renames the kernel device identifier** for the `adm1272` component to `bp4f_adm1272`. This **maintenance adjustment** is crucial for aligning the platform's configuration with a **new BSP driver** that now uses the prefixed name. The change ensures the **Tahan platform** can correctly identify and interact with the `adm1272` device, preventing potential device recognition or interaction issues. | Apr 25 | 1 | maint |
| 5571a26f | This commit introduces **over-temperature protection** for the **TH5 ASIC** on the **Tahan platform**. It adds a new `TAHAN_SMB_TH5_TEMP` sensor definition to `sensor_service.json` and configures the `fan_service.json` to trigger a specific shutdown command for the ASIC if its temperature exceeds 110 degrees. This **new capability** ensures hardware safety by selectively powering down the TH5 ASIC without affecting the entire system, enhancing the platform's reliability. Additionally, the `platform_manager.json` was updated to correctly map the CPLD and its sysfs sensor for the new temperature monitoring. | Apr 25 | 3 | waste |
| 2e5ca6aa | This commit introduces **overtemperature protection** for the **Montblanc platform**, specifically targeting the **TH5 ASIC**. It **adds a new capability** to the **fan service configuration** (`fan_service.json`) to monitor the `SMB_TH5_TEMP` sensor and trigger a shutdown command for the ASIC if its temperature exceeds 110 degrees, preventing a full system shutdown. Concurrently, it **fixes an I2C address** for the `mp3_smbcpld` device within the **platform manager configuration** (`platform_manager.json`), correcting it from `0x3e` to `0x33`. This work enhances the platform's thermal management and overall reliability by providing granular protection for critical components. | Apr 25 | 2 | waste |
| 20df4c6b | This commit introduces the **initial `weutil` configuration** for the **Icecube800bc** platform, marking the **first pre-EVT version** of this essential hardware utility setup. This **new capability** provides the necessary definitions within `fboss/platform/configs/icecube800bc/weutil.json` for the `weutil` utility to correctly read and parse EEPROM data. Due to current hardware limitations, this configuration specifically includes definitions for 6 EEPROMs and omits an SMB card. This **maintenance** work enables crucial hardware validation and diagnostics for the **Icecube800bc** system, laying the groundwork for future development and hardware bring-up. | Apr 24 | 1 | grow |
| 5a273004 | This commit performs a **maintenance update** to the **Tahan800BC platform configuration**, specifically modifying the `fboss/platform/configs/tahan800bc/platform_manager.json` file. It **removes the `bp4f_` prefix from various kernel device names** (e.g., `bp4f_mp9941` becomes `mp9941`) to align with a **new BSP driver's naming convention**. This **configuration refactoring** ensures proper device identification and compatibility with the updated BSP. Additionally, the `bspKmodsRpmVersion` is incremented, reflecting this dependency update. | Apr 10 | 1 | maint |
| 2c295ed9 | This commit **updates the Janga800BIC platform configuration** to support new hardware revisions of **SMB and COME cards**. It **adds versioned PVT sensor configurations** to `sensor_service.json` for these cards, including their sysfs paths and thresholds, and **remaps existing SMB TMP422 sensors** in `platform_manager.json` to new bus names and paths. This **enhancement** ensures accurate sensor monitoring and management for specific production states and versions of the SMB ('3 5 20') and COME ('4 1 1', '4 1 2') cards. The changes are crucial for the **Janga platform's hardware compatibility and sensor data integrity**, allowing the system to correctly identify and read sensor data from these updated components. | Jan 7 | 2 | grow |
| 8c531543 | This commit provides a **configuration correction** for the **Tahan800BC platform's sensor service**, specifically addressing issues within the `fboss/platform/configs/tahan800bc/sensor_service.json` file. It **removes an erroneous `SMB_FRU "3 5 20"` sensor configuration block** that was inadvertently included in a previous update. Furthermore, this **bug fix** rectifies the **`NETLAKE "3 1 2"` configuration**, correcting its sensor names and threshold values. This ensures the **sensor monitoring system** operates with accurate and intended parameters for the **Tahan800BC hardware**. | Jan 6 | 1 | waste |
This commit performs a **configuration update** for the **Icecube platform** to enable support for **BSP version 4.1.0-1**. Specifically, it updates the `bspKmodsRpmVersion` to `4.1.0-1` within the `fboss/platform/configs/icecube/platform_manager.json` file. As part of this **maintenance** effort, the `kernelDeviceName` for `SMB_CPLD` is also adjusted from `icecube_smbcpld` to `th6_smbcpld`. This ensures the **Icecube platform** remains compatible with the latest BSP, allowing platform services like `platform_manager` and `sensor_service` to function correctly with the updated kernel modules and device naming conventions.
This commit introduces **configuration updates** for the **Icecube platform**, primarily to support a new **SMB hardware version (`v 2 3 10`)** for DVT. It adds four new SMB voltage sensors to the `sensor_service.json` under the `versionedSensors` for this specific version. Additionally, the `platform_manager.json` is updated to include the `fboss_iob_i2c` driver in `requiredKmodsToLoad`, which is a **maintenance fix** to prevent timing issues by ensuring the driver is preloaded. These changes collectively enhance **hardware support** and **system stability** for Icecube devices.
This commit performs a **configuration update** for the **Icecube platform**, specifically within the `fboss/platform/configs/icecube/platform_manager.json` file. It **bumps the `bspKmodsRpmVersion` from `3.4.0-1` to `4.0.0-1`** to ensure **compatibility and support for the latest BSP (Board Support Package) version**. This **maintenance change** is crucial for the **Icecube platform** to function correctly with the updated BSP, impacting its core system dependencies and enabling it to leverage the new BSP features.
This commit updates the **Icecube sensor service configuration** (`sensor_service.json`) to support both `TH6 B0` and `TH6 B0+` sensor chips. It introduces **versioned sensor thresholds** and configurations, allowing the system to dynamically adjust based on the `Product Production State` read from the SMB EEPROM. This **configuration update** ensures correct sensor monitoring and prevents false positives or negatives across different hardware revisions (EVT and DVT phases) of the **Icecube platform**. Specifically, it modifies thresholds for several `SMB_XP0R8V_PT_VDDC` and `SMB_XP0R72V_PB_TRVDD` sensors to align with the `TH6 B0+` datasheet. This **enhancement** is crucial for maintaining accurate hardware health monitoring as the platform evolves.
This commit **updates the BSP test configuration** for the **Icecube platform** by adding specific test definitions to `fboss/platform/configs/icecube/bsp_tests.json`. This **new configuration** is a **maintenance** task essential for fulfilling the comprehensive BSP test suite requirements for OSS platform onboarding. It specifically includes test objects for `ICECUBE_MCB.SCM_CPLD`, `ICECUBE_MCB.MCB_FAN_CPLD`, and `ICECUBE_MCB.48V_HSC_MONITOR`, ensuring these critical components are covered by the automated test framework. This **enhances the test coverage** and **platform validation** for Icecube devices, enabling their successful onboarding to the new OSS platform.
This commit **updates the Icecube platform configuration** to enhance thermal management and sensor monitoring. It **raises the TMP432 high limit thresholds** to 100°C in `platform_manager.json` to prevent premature thermal shutdowns on TH6. Additionally, the `sensor_service.json` file is updated to **add new fan RPM, power consumption, and ASIC temperature sensor configurations**, and to adjust thresholds for several existing temperature and ADC sensors, aligning with thermal design requirements. This **configuration update** improves the system's ability to operate within thermal specifications and provides more comprehensive hardware monitoring.
This commit **updates the Icecube platform configuration** to support new hardware and resolve a critical sensor issue. It **adds configuration for the COME sensor version 4.2.1** and renames the `MCB_PU1066_LTC4287_P48V_POUT` sensor to `MCB_PU1066_LTC4287_P48V_PIN` within `platform_manager.json` and `sensor_service.json`. Crucially, this **bug fix** introduces `initRegSettings` for power brick devices (`PMBUS_1`, `PMBUS_2`, `PMBUS_3`) to explicitly set the PMBus page to `0` during initialization, preventing PMBus driver failures observed on new hardware units. This ensures **reliable sensor data collection** and **platform stability** for Icecube devices utilizing these updated components.
This commit **updates the sensor service configuration** for the **Tahan platform**, specifically for **SMB and COME boards**. It **adjusts sensor thresholds** in `sensor_service.json` to align with the latest hardware sensor table, which also **fixes a bug** where `SMB_XP3R3V_LEFT_VOUT` and `SMB_XP3R3V_RIGHT_VOUT` readings were incorrectly exceeding their configured limits. Additionally, the `bspKmodsRpmVersion` is **bumped to `3.3.0-1`** in `platform_manager.json`, and threshold fields are **reordered for consistency** to improve code readability. This **maintenance and bug fix** ensures more accurate and reliable hardware monitoring by preventing false alarms and aligning software configurations with physical hardware specifications.
This commit performs a **maintenance update** and **bug fix** for the **Janga platform's sensor and platform manager configurations**. It **adjusts various sensor thresholds** in `sensor_service.json` for SMB and COME boards to align with the latest hardware specifications, while also **fixing incorrect min/max alarm values** for specific voltage sensors and **correcting sensor names and computation formulas**. Concurrently, the `bspKmodsRpmVersion` is **bumped** to `3.3.0-1` and the `ledtrig_timer` kernel module is added as a requirement in `platform_manager.json`, ensuring accurate hardware monitoring and proper system operation.
This commit introduces **platform service configurations** to provide comprehensive support for the **Icecube EVT2 hardware phase**. It involves significant updates across multiple configuration files, including `platform_manager.json`, `sensor_service.json`, `fw_util.json`, `fan_service.json`, `led_manager.json`, and `weutil.json`. Key changes include adding **SMB board configurations** to various services, updating sensor definitions and thresholds for components like MCB, BMC, and COMESE units, and modifying unit naming conventions and XCVR-related settings. This work delivers the essential **new capability** for FBOSS to accurately manage and monitor the Icecube platform's EVT2 hardware.
This commit introduces **comprehensive support for the new Icecube800bc platform**, enabling the FBOSS software to manage its hardware components. It primarily focuses on **QSFP transceiver management** and **LED control**, integrating a dedicated **Board Support Package (BSP)** for Icecube800bc into the `fboss/lib`, `qsfp_service`, and `led_service` modules. This **new platform support** involves extensive additions to platform mapping, build configurations, and initialization logic, allowing FBOSS to correctly identify and interact with Icecube800bc hardware. The changes include new `Icecube800bcLedManager` and `Icecube800bcBspPlatformMapping` implementations, along with updates to `cmake` and `BUCK` files to incorporate the new platform's build rules and dependencies. This work is a **new feature** that expands FBOSS's hardware compatibility.
This commit performs a **configuration update** for the **Janga platform service**. It modifies the `bspKmodsRpmVersion` in `fboss/platform/configs/janga800bic/platform_manager.json`, updating it from `3.1.0-1` to `3.2.0-1`. This **maintenance** change synchronizes the platform's configuration with the latest tag in the Board Support Package (BSP) repository. The update ensures that the **Janga platform** correctly references the most current BSP kernel modules RPM, preventing potential version discrepancies and ensuring compatibility.
This commit performs a **configuration update** for the **Tahan platform service**, specifically modifying the `bspKmodsRpmVersion` within the `fboss/platform/configs/tahan800bc/platform_manager.json` file. The version string has been updated from '3.1.0-1' to '3.2.0-1'. This **maintenance change** is crucial for synchronizing the platform's configuration with the latest tag in the BSP repository, ensuring the **Tahan platform service** correctly references the most current **BSP kernel modules RPM version**. This prevents potential version mismatches and ensures compatibility with updated BSP components.
This commit **updates the Tahan platform configuration** by modifying the `platform_manager.json` file. It **renames the kernel device identifier** for the `adm1272` component to `bp4f_adm1272`. This **maintenance adjustment** is crucial for aligning the platform's configuration with a **new BSP driver** that now uses the prefixed name. The change ensures the **Tahan platform** can correctly identify and interact with the `adm1272` device, preventing potential device recognition or interaction issues.
This commit introduces **over-temperature protection** for the **TH5 ASIC** on the **Tahan platform**. It adds a new `TAHAN_SMB_TH5_TEMP` sensor definition to `sensor_service.json` and configures the `fan_service.json` to trigger a specific shutdown command for the ASIC if its temperature exceeds 110 degrees. This **new capability** ensures hardware safety by selectively powering down the TH5 ASIC without affecting the entire system, enhancing the platform's reliability. Additionally, the `platform_manager.json` was updated to correctly map the CPLD and its sysfs sensor for the new temperature monitoring.
This commit introduces **overtemperature protection** for the **Montblanc platform**, specifically targeting the **TH5 ASIC**. It **adds a new capability** to the **fan service configuration** (`fan_service.json`) to monitor the `SMB_TH5_TEMP` sensor and trigger a shutdown command for the ASIC if its temperature exceeds 110 degrees, preventing a full system shutdown. Concurrently, it **fixes an I2C address** for the `mp3_smbcpld` device within the **platform manager configuration** (`platform_manager.json`), correcting it from `0x3e` to `0x33`. This work enhances the platform's thermal management and overall reliability by providing granular protection for critical components.
This commit introduces the **initial `weutil` configuration** for the **Icecube800bc** platform, marking the **first pre-EVT version** of this essential hardware utility setup. This **new capability** provides the necessary definitions within `fboss/platform/configs/icecube800bc/weutil.json` for the `weutil` utility to correctly read and parse EEPROM data. Due to current hardware limitations, this configuration specifically includes definitions for 6 EEPROMs and omits an SMB card. This **maintenance** work enables crucial hardware validation and diagnostics for the **Icecube800bc** system, laying the groundwork for future development and hardware bring-up.
This commit performs a **maintenance update** to the **Tahan800BC platform configuration**, specifically modifying the `fboss/platform/configs/tahan800bc/platform_manager.json` file. It **removes the `bp4f_` prefix from various kernel device names** (e.g., `bp4f_mp9941` becomes `mp9941`) to align with a **new BSP driver's naming convention**. This **configuration refactoring** ensures proper device identification and compatibility with the updated BSP. Additionally, the `bspKmodsRpmVersion` is incremented, reflecting this dependency update.
This commit **updates the Janga800BIC platform configuration** to support new hardware revisions of **SMB and COME cards**. It **adds versioned PVT sensor configurations** to `sensor_service.json` for these cards, including their sysfs paths and thresholds, and **remaps existing SMB TMP422 sensors** in `platform_manager.json` to new bus names and paths. This **enhancement** ensures accurate sensor monitoring and management for specific production states and versions of the SMB ('3 5 20') and COME ('4 1 1', '4 1 2') cards. The changes are crucial for the **Janga platform's hardware compatibility and sensor data integrity**, allowing the system to correctly identify and read sensor data from these updated components.
This commit provides a **configuration correction** for the **Tahan800BC platform's sensor service**, specifically addressing issues within the `fboss/platform/configs/tahan800bc/sensor_service.json` file. It **removes an erroneous `SMB_FRU "3 5 20"` sensor configuration block** that was inadvertently included in a previous update. Furthermore, this **bug fix** rectifies the **`NETLAKE "3 1 2"` configuration**, correcting its sensor names and threshold values. This ensures the **sensor monitoring system** operates with accurate and intended parameters for the **Tahan800BC hardware**.