Erik Corry

This commit **removes a specific patch** from the **V8** build process, which previously modified lookup paths for `fast_float` and `simdutf`. This **maintenance** adjustment ensures that the patched **V8** can continue to be compiled using the **GN** build system. By doing so, the scope of the original `simdutf` integration is now effectively restricted to only affect **Bazel** builds, preventing unintended compilation issues with other build configurations.

This commit **enforces a specific execution order** within the project's formatting pipeline, ensuring that all required formatting tools are downloaded and available *before* any parallel formatting tasks are initiated. It modifies the `main` function within the **cross-platform formatting utility** located at `tools/cross/format.py`. This is a **chore** aimed at improving the robustness and reliability of the development tooling. The change prevents potential failures or inconsistencies that could arise from formatting operations attempting to run before their necessary dependencies are fully prepared.

Feedback

This commit **refactors the Rust formatting workflow** to significantly improve developer experience by **speeding up `rustfmt` execution**. Instead of relying on Bazel to build `rustfmt`, the `just format` command now **directly fetches and runs `rustfmt`** binaries from `static.rust-lang.org`. This change updates the `justfile` to call `tools/cross/format.py` directly, modifies the `rustfmt` function within that script, and includes a new `MODULE.bazel` entry, **eliminating Bazel startup overhead** for formatting. This **tooling improvement** specifically benefits developers on Mac (ARM64) and Linux, ensuring a quicker and more efficient formatting process.

This commit introduces **parallel execution** for `clang-format` and `prettier` within the **tooling infrastructure** defined in `tools/cross/format.py`. This **performance improvement** significantly **reduces the runtime** of the code formatting process, cutting the `just format` command's execution time from 6.8s to 2.6s. Additionally, it refactors Bazel tool handling and adds support for `rustfmt`, further enhancing the **developer experience** and CI efficiency, particularly for **Workers** builds.

This commit **refactors** the `terminationRequested` member within `src/workerd/jsg/setup.h` to be an **atomic type**. This change ensures **thread-safe access** to the flag, which is crucial for reliably signaling and handling **Workerd's termination process** across different threads. By making it atomic, the system can safely check and update the termination status without race conditions, significantly improving the robustness of the **shutdown mechanism** in multi-threaded environments.

This commit implements a **critical bug fix** to prevent **memory exhaustion and crashes** in `workerd` when JavaScript iterates over C++ objects like SQL cursors. It introduces a new `isTerminationRequested()` flag on `IsolateBase` within the **JavaScript Gateway (JSG)** subsystem, allowing C++ iterators' `nextImpl()` to check for and respect **V8 isolate termination requests**. This ensures that C++ callbacks properly halt execution when termination is requested, preventing indefinite loops and improving the stability of resource management under memory pressure.

This is an isolated maintenance fix within the `workerd` V8 integration layer. It updates internal V8 API calls to address deprecation warnings, ensuring compatibility with recent V8 releases without affecting external behavior.

This commit fixes a robustness issue in the `getCallSites` utility function within the Workerd Node.js API, preventing errors or incorrect behavior when function names are missing from call sites. This is an isolated fix improving the reliability of stack trace generation.

This change improves the stability and robustness of the `workerd` runtime by setting a global V8 Out-Of-Memory handler. It affects how `workerd`'s JavaScript engine handles memory exhaustion, preventing crashes in such scenarios.

This is an isolated, cosmetic change to improve code readability within the `workerd` API sockets and server components; it has no impact on functionality or external behavior.

This commit primarily **fixes crashes** and performs **maintenance** within `workerd`'s **V8 integration** layer. It updates the `ResetRoot` function in `src/workerd/jsg/setup.c++` to use the `Get()` method instead of a deprecated arrow operator and introduces a `HandleScope` to prevent runtime crashes. A new V8 patch is also added to seal `HandleScope` during garbage collection, further enhancing stability. Additionally, an outdated patch that reverted a `TracedReference` dereference API removal is removed, aligning `workerd` with upstream V8 API changes. These changes collectively improve the **runtime stability** and **correctness** of the JavaScript environment.

This commit implements a significant **refactoring** within the **`jsg` subsystem** to improve performance and code clarity when interacting with the V8 JavaScript engine. It modifies numerous functions, particularly those involved in **wrapping and unwrapping** JavaScript values, promise handling, and module operations, to explicitly pass a `jsg::Lock` object. This change eliminates reliance on potentially slow `v8::Isolate::GetCurrent()` calls and `context->GetIsolate()`, ensuring that the V8 `Isolate` is always directly available where needed. The widespread modifications across files like `type-wrapper.h`, `value.h`, and `resource.h` streamline V8 isolate access, contributing to a more efficient and robust JavaScript runtime.

This commit performs a significant **refactoring** within the **JavaScript Glue (JSG) layer** and related **I/O components** to optimize V8 isolate access. Instead of relying on the potentially slow `v8::Isolate::GetCurrent()` via thread-local storage, numerous functions, particularly `wrap` and `tryUnwrap` methods, now explicitly receive a `jsg::Lock` object, which directly provides the necessary `v8::Isolate`. This change improves performance and clarifies the dependency on the V8 isolate across core JSG functionalities, including promise handling, module loading, resource management, and type conversions. The widespread modification ensures consistent and efficient V8 isolate management throughout the system, reducing implicit dependencies and potential overhead.

This commit performs a **maintenance refactoring** within the **`workerd` JavaScript bindings generation (JSG) subsystem**, specifically in `src/workerd/jsg/type-wrapper.h`. It **updates V8 API usage** by replacing the deprecated `context->GetIsolate()` call with `v8::Isolate::GetCurrent()` in functions such as `wrap`, `tryUnwrap`, and `unwrap`. This proactive change ensures **forward compatibility with future V8 engine versions** and clarifies the code's intent for retrieving the current V8 isolate.

This commit introduces **foundational support for V8 sandboxing** within the `workerd` runtime, primarily focusing on secure `ArrayBuffer` data management. It integrates new V8 sandbox APIs, such as `SandboxContains` and `GetSandboxAddressSpace`, via a dedicated patch. Within the `jsg` subsystem, methods like `BackingStore::from` and `ArrayBufferWrapper::wrap` are updated to conditionally copy `kj::Array<byte>` data into the V8 sandbox, ensuring all relevant data resides within the isolated memory region. Additionally, the `newIsolate` function is configured to use a group-specific array buffer allocator when `V8_COMPRESS_POINTERS_IN_MULTIPLE_CAGES` is enabled, further enhancing memory isolation. This work represents a **significant feature enhancement** that improves the security and stability of JavaScript execution by enforcing strict memory boundaries.

This commit **refactors** the **Workerd JavaScript runtime (JSG)** and **server components** to consistently utilize `v8::IsolateGroup` for V8 isolate management. It modifies constructors for core classes like `jsg::IsolateBase`, `jsg::Isolate`, and `WorkerdApi` to accept `v8::IsolateGroup` as a non-optional argument, ensuring all isolate creation and related operations are properly grouped. This **maintenance** effort standardizes V8 isolate handling across the system, improving consistency and laying a crucial foundation for future V8-related features, potentially enhancing resource isolation or sandboxing capabilities.

This commit performs **maintenance** on the **V8 Bazel build configuration** by removing the `-latomic` linker flag. This flag, previously applied through a patch (`patches/v8/0021-Remove-unneded-latomic-linker-flag.patch`), is now considered **unnecessary** for the V8 build process. The change streamlines the **build configuration** for the V8 dependency, ensuring it uses the minimal and correct set of linker flags and potentially resolving build environment-specific issues. This **chore** improves the robustness and simplicity of the V8 compilation within the project.

This commit performs a significant **dependency upgrade**, rolling the **V8 JavaScript engine to version 13.4.114.17**. This update involves extensive **integration adjustments** through a series of patches that enable **Windows builds** under Bazel, improve **V8 Bazel build speed**, and enhance **serialization and deserialization** capabilities. Furthermore, the patches introduce features like **Promise Context Tagging**, refine **V8 inspector** behavior, and adjust dependency lookup paths for `fast_float` and `simdutf`. The `WORKSPACE` file is also updated, notably removing `abseil` bindings, which collectively streamlines the build process and ensures the stability and performance of the updated JavaScript runtime.

This commit performs a **general code quality improvement** by **fixing numerous typos and grammatical errors** across various internal modules and documentation. The primary focus is correcting instances of "it's" to "its" in comments, but it also addresses other minor spelling mistakes such as "there" to "their", "whish" to "which", and "wildcart" to "wildcard", alongside a struct name correction in `src/workerd/api/worker-rpc.c++`. These **maintenance** changes span across **Node.js compatibility layers**, **Pyodide integrations**, and extensively within **Workerd's API components** like streams, RPC, JSG, and IO. The overall impact is an enhancement to the clarity and accuracy of the project's internal documentation and comments, with **no functional changes** to the software's runtime behavior.